[{"id":13126,"web_url":"https://patchwork.libcamera.org/comment/13126/","msgid":"<d4afb882-1f5a-fc28-8b7a-ff2608fd7c6c@ideasonboard.com>","date":"2020-10-09T12:26:00","subject":"Re: [libcamera-devel] [PATCH 03/10] libcamera: property_ids: Define\n\tdraft properties","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Jacopo,\n\nOn 09/10/2020 13:20, Jacopo Mondi wrote:\n> Libcamera is in the process of defining its own set of properties, to\n> advertise the camera capabilities.\n> \n> To temporary close the gap in the Android camera HAL and support all\n\ns/temporary/temporarily/\n\n> static metadata required in the LIMITED hw level, define a set of Draft\n> properties whose values are taken from their Android definition, in order\n> to allow pipeline handlers to support them.\n> \n> Signed-off-by: Jacopo Mondi <jacopo@jmondi.org>\n> ---\n>  src/libcamera/property_ids.yaml | 74 +++++++++++++++++++++++++++++++++\n>  1 file changed, 74 insertions(+)\n> \n> diff --git a/src/libcamera/property_ids.yaml b/src/libcamera/property_ids.yaml\n> index 7261263a9ba3..e524a0718dc3 100644\n> --- a/src/libcamera/property_ids.yaml\n> +++ b/src/libcamera/property_ids.yaml\n> @@ -663,4 +663,78 @@ controls:\n>          \\todo Rename this property to ActiveAreas once we will have property\n>                categories (i.e. Properties::PixelArray::ActiveAreas)\n>  \n> +  - AvailableNoiseReductionModes:\n> +      type: int32_t\n> +      draft: true\n> +      size: [n]\n> +      description: |\n> +        Draft property to report the list of supported noise reduction modes.\n> +        Currently identical to\n> +        ANDROID_NOISE_REDUCTION_AVAILABLE_NOISE_REDUCTION_MODES.\n\nI don't think it's necessary to say \"Draft property\" in the\ndescriptions, and that's defined by the draft flag.\n\nHowever - I interpret \"draft: true\", to be a statement that all/any of\nthe implementation of the control will/can be updated, and therefore\nthat includes the description - and thus ... you can put in anything you\nlike that you feel is appropriate to get started ;-)\n\nFor me - the parts I would check on draft controls are that the styles\nare consistent and no glaring errors to tackle - so that makes adding\ndraft controls easy.\n\n(And getting out of draft status is where the important stage is).\n\nSo -\n\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n\n> +      enum:\n> +        - name: NoiseReductionModeOff\n> +          value: 0\n> +          description: No noise reduction is applied\n> +        - name: NoiseReductionModeFast\n> +          value: 1\n> +          description: |\n> +            Noise reduction is applied without reducing the frame rate.\n> +        - name: NoiseReductionModeHighQuality\n> +          value: 2\n> +          description: |\n> +            High quality noise reduction at the expense of frame rate.\n> +        - name: NoiseReductionModeMinimal\n> +          value: 3\n> +          description: |\n> +            Minimal noise reduction is applied without reducing the frame rate.\n> +        - name: NoiseReductionModeZSL\n> +          value: 4\n> +          description: |\n> +            Noise reduction is applied at different levels to different streams.\n> +\n> +  - AvailableColorCorrectionAberrationModes:\n> +      type: int32_t\n> +      draft: true\n> +      size: [n]\n> +      description: |\n> +        Draft property to report the list of supported color correction\n> +        aberration modes. Currently identical to\n> +        ANDROID_COLOR_CORRECTION_AVAILABLE_ABERRATION_MODES.\n> +      enum:\n> +        - name: ColorCorrectionAberrationOff\n> +          value: 0\n> +          description: No aberration correction is applied.\n> +        - name: ColorCorrectionAberrationFast\n> +          value: 1\n> +          description: Aberration correction will not slow down the frame rate.\n> +        - name: ColorCorrectionAberrationHighQuality\n> +          value: 2\n> +          description: |\n> +            High quality aberration correction which might reduce the frame\n> +            rate.\n> +\n> +  - AvailableLensShadingMapModes:\n> +      type: int32_t\n> +      draft: true\n> +      size: [n]\n> +      description: |\n> +        Draft property to report the list of supported lens shading map modes.\n> +        Currently identical to\n> +        ANDROID_STATISTICS_INFO_AVAILABLE_LENS_SHADING_MAP_MODES.\n> +      enum:\n> +        - name: LensShadingMapModeOff\n> +          value: 0\n> +          description: No lens shading map mode is available.\n> +        - name: LensShadingMapModeOn\n> +          value: 1\n> +          description: The lens shading map mode is available.\n> +\n> +  - PipelineMaxDepth:\n> +      type: int32_t\n> +      draft: true\n> +      description: |\n> +        Draft control to report the maximum number of pipeline stages a frame\n> +        has to go through from when it is exposed to when it is available to\n> +        applications. Currently identical to ANDROID_REQUEST_PIPELINE_MAX_DEPTH.\n> +\n>  ...\n>","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 46910BEEE0\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri,  9 Oct 2020 12:26:06 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D3F4B60725;\n\tFri,  9 Oct 2020 14:26:05 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DAD3760358\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri,  9 Oct 2020 14:26:03 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 4B736539;\n\tFri,  9 Oct 2020 14:26:03 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"TovaHpUa\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1602246363;\n\tbh=9Ub+K9N0d2e8o3UL1vDlQo1N72Dpk8EhI3Vel8ywVIo=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=TovaHpUacSrSoP1uRKBoVpLwSN7C9aga2gaI5jBHUXzzr3APcHuSnaabq21W4z+dp\n\tiyqG5yg7XuTGC37VbTy3iFF6EO4UJl0wfZTzVbXuZtyNucTIyW5P8wSsvukcpCA+mj\n\tEgi/AdliCdFmwIkkvRVPFiHPzyobssg2CKlJeh2k=","To":"Jacopo Mondi <jacopo@jmondi.org>, libcamera-devel@lists.libcamera.org","References":"<20201009122101.73858-1-jacopo@jmondi.org>\n\t<20201009122101.73858-4-jacopo@jmondi.org>","From":"Kieran Bingham <kieran.bingham@ideasonboard.com>","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<d4afb882-1f5a-fc28-8b7a-ff2608fd7c6c@ideasonboard.com>","Date":"Fri, 9 Oct 2020 13:26:00 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"<20201009122101.73858-4-jacopo@jmondi.org>","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [PATCH 03/10] libcamera: property_ids: Define\n\tdraft properties","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Reply-To":"kieran.bingham@ideasonboard.com","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":13169,"web_url":"https://patchwork.libcamera.org/comment/13169/","msgid":"<20201012004024.GM3944@pendragon.ideasonboard.com>","date":"2020-10-12T00:40:24","subject":"Re: [libcamera-devel] [PATCH 03/10] libcamera: property_ids: Define\n\tdraft properties","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jacopo,\n\nThank you for the patch.\n\nOn Fri, Oct 09, 2020 at 01:26:00PM +0100, Kieran Bingham wrote:\n> On 09/10/2020 13:20, Jacopo Mondi wrote:\n> > Libcamera is in the process of defining its own set of properties, to\n\ns/Libcamera/libcamera/\n\n> > advertise the camera capabilities.\n> > \n> > To temporary close the gap in the Android camera HAL and support all\n> \n> s/temporary/temporarily/\n> \n> > static metadata required in the LIMITED hw level, define a set of Draft\n\ns/hw/hardware/ ?\n\n> > properties whose values are taken from their Android definition, in order\n> > to allow pipeline handlers to support them.\n> > \n> > Signed-off-by: Jacopo Mondi <jacopo@jmondi.org>\n> > ---\n> >  src/libcamera/property_ids.yaml | 74 +++++++++++++++++++++++++++++++++\n> >  1 file changed, 74 insertions(+)\n> > \n> > diff --git a/src/libcamera/property_ids.yaml b/src/libcamera/property_ids.yaml\n> > index 7261263a9ba3..e524a0718dc3 100644\n> > --- a/src/libcamera/property_ids.yaml\n> > +++ b/src/libcamera/property_ids.yaml\n> > @@ -663,4 +663,78 @@ controls:\n> >          \\todo Rename this property to ActiveAreas once we will have property\n> >                categories (i.e. Properties::PixelArray::ActiveAreas)\n> >  \n> > +  - AvailableNoiseReductionModes:\n> > +      type: int32_t\n> > +      draft: true\n> > +      size: [n]\n> > +      description: |\n> > +        Draft property to report the list of supported noise reduction modes.\n> > +        Currently identical to\n> > +        ANDROID_NOISE_REDUCTION_AVAILABLE_NOISE_REDUCTION_MODES.\n> \n> I don't think it's necessary to say \"Draft property\" in the\n> descriptions, and that's defined by the draft flag.\n> \n> However - I interpret \"draft: true\", to be a statement that all/any of\n> the implementation of the control will/can be updated, and therefore\n> that includes the description - and thus ... you can put in anything you\n> like that you feel is appropriate to get started ;-)\n> \n> For me - the parts I would check on draft controls are that the styles\n> are consistent and no glaring errors to tackle - so that makes adding\n> draft controls easy.\n> \n> (And getting out of draft status is where the important stage is).\n> \n> So -\n> \n> Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n\nI would also drop draft in the description, but both option are fine\nwith me.\n\n> > +      enum:\n> > +        - name: NoiseReductionModeOff\n> > +          value: 0\n> > +          description: No noise reduction is applied\n> > +        - name: NoiseReductionModeFast\n> > +          value: 1\n> > +          description: |\n> > +            Noise reduction is applied without reducing the frame rate.\n> > +        - name: NoiseReductionModeHighQuality\n> > +          value: 2\n> > +          description: |\n> > +            High quality noise reduction at the expense of frame rate.\n> > +        - name: NoiseReductionModeMinimal\n> > +          value: 3\n> > +          description: |\n> > +            Minimal noise reduction is applied without reducing the frame rate.\n> > +        - name: NoiseReductionModeZSL\n> > +          value: 4\n> > +          description: |\n> > +            Noise reduction is applied at different levels to different streams.\n\nThis one will likely be handled using per-stream controls, which will\nthen influence the other values.\n\n> > +\n> > +  - AvailableColorCorrectionAberrationModes:\n> > +      type: int32_t\n> > +      draft: true\n> > +      size: [n]\n> > +      description: |\n> > +        Draft property to report the list of supported color correction\n> > +        aberration modes. Currently identical to\n> > +        ANDROID_COLOR_CORRECTION_AVAILABLE_ABERRATION_MODES.\n> > +      enum:\n> > +        - name: ColorCorrectionAberrationOff\n> > +          value: 0\n> > +          description: No aberration correction is applied.\n> > +        - name: ColorCorrectionAberrationFast\n> > +          value: 1\n> > +          description: Aberration correction will not slow down the frame rate.\n> > +        - name: ColorCorrectionAberrationHighQuality\n> > +          value: 2\n> > +          description: |\n> > +            High quality aberration correction which might reduce the frame\n> > +            rate.\n> > +\n> > +  - AvailableLensShadingMapModes:\n> > +      type: int32_t\n> > +      draft: true\n> > +      size: [n]\n> > +      description: |\n> > +        Draft property to report the list of supported lens shading map modes.\n> > +        Currently identical to\n> > +        ANDROID_STATISTICS_INFO_AVAILABLE_LENS_SHADING_MAP_MODES.\n> > +      enum:\n> > +        - name: LensShadingMapModeOff\n> > +          value: 0\n> > +          description: No lens shading map mode is available.\n> > +        - name: LensShadingMapModeOn\n> > +          value: 1\n> > +          description: The lens shading map mode is available.\n\nNote that these three properties should be handled through ControlInfo\ninstead of being manually defined. For instance, the LensShadingMapMode\ncontrol will have a ControlInfo that should list the supported values.\nWe don't have this yet in ControlInfo for enum controls, so it's not a\ncandidate for this patch series, but let's keep the direction in mind.\n\nAcked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n\n> > +\n> > +  - PipelineMaxDepth:\n> > +      type: int32_t\n> > +      draft: true\n> > +      description: |\n> > +        Draft control to report the maximum number of pipeline stages a frame\n> > +        has to go through from when it is exposed to when it is available to\n> > +        applications. Currently identical to ANDROID_REQUEST_PIPELINE_MAX_DEPTH.\n> > +\n> >  ...\n> >","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7C082BEEE0\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 12 Oct 2020 00:41:12 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id F190A60D49;\n\tMon, 12 Oct 2020 02:41:11 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CB9F260CE0\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 12 Oct 2020 02:41:10 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 780A6308;\n\tMon, 12 Oct 2020 02:41:09 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"l7+tYYOz\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1602463269;\n\tbh=G7TFLikW5gp8LZNXB64EjoJygOEp+d3TOmRdeCoj6l8=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=l7+tYYOzmtuoF4aB3SpgZZWe7yGO+h/lMk49h7C3z0yvFUtogkpK4qkFsBfokeibN\n\tLPsrTz7asoI7up3vCSDljgRTBM6dq437yxgKECttXrw7sObAAyQrbUS6EFQzCTTWyB\n\tIMC3mZxdEm/yZH5rP3vkOrakhiBwxjhD5cBpT/3U=","Date":"Mon, 12 Oct 2020 03:40:24 +0300","From":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","To":"Jacopo Mondi <jacopo@jmondi.org>","Message-ID":"<20201012004024.GM3944@pendragon.ideasonboard.com>","References":"<20201009122101.73858-1-jacopo@jmondi.org>\n\t<20201009122101.73858-4-jacopo@jmondi.org>\n\t<d4afb882-1f5a-fc28-8b7a-ff2608fd7c6c@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<d4afb882-1f5a-fc28-8b7a-ff2608fd7c6c@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 03/10] libcamera: property_ids: Define\n\tdraft properties","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}}]