[{"id":13168,"web_url":"https://patchwork.libcamera.org/comment/13168/","msgid":"<20201012000204.GL3944@pendragon.ideasonboard.com>","date":"2020-10-12T00:02:04","subject":"Re: [libcamera-devel] [PATCH 02/10] libcamera: controls: Define\n\tAwbLocked control","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jacopo,\n\nThank you for the patch.\n\nOn Fri, Oct 09, 2020 at 02:20:53PM +0200, Jacopo Mondi wrote:\n> Define a control to report the AWB algorithm locking state.\n> The control definition is copied from the AeLocked one.\n> \n> Reviewed-by: Kieran Bingham \n> Reviewed-by: Niklas Söderlund \n> Signed-off-by: Jacopo Mondi \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/libcamera/control_ids.yaml | 11 +++++++++++\n> 1 file changed, 11 insertions(+)\n> \n> diff --git a/src/libcamera/control_ids.yaml b/src/libcamera/control_ids.yaml\n> index 3560d4a81882..4c415545dcae 100644\n> --- a/src/libcamera/control_ids.yaml\n> +++ b/src/libcamera/control_ids.yaml\n> @@ -208,6 +208,17 @@ controls:\n> value: 7\n> description: Maximum allowed value (place any new values above here).\n> \n> + - AwbLocked:\n> + type: bool\n> + description: |\n> + Report the lock status of a running AWB algorithm.\n> +\n> + If the AWB algorithm is locked the value shall be set to true, if it's\n> + converging it shall be set to false. If the AWB algorithm is not\n> + running the control shall not be present in the metadata control list.\n> +\n> + \\sa AwbEnable\n> +\n> - ColourGains:\n> type: float\n> description: |","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id EC93ABEEDF\n\tfor ;\n\tMon, 12 Oct 2020 00:02:50 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B95F560730;\n\tMon, 12 Oct 2020 02:02:50 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D37E860357\n\tfor ;\n\tMon, 12 Oct 2020 02:02:49 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 66133308;\n\tMon, 12 Oct 2020 02:02:49 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"ZUEyXNVT\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1602460969;\n\tbh=fhEch4BTJsSzNG7NhKMR94tjrlpiFab+Eg+ln3csFD8=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=ZUEyXNVTDvVA0yQ0Qjfrj1l9F4ldrixEFNcM50Qa9nLzf1+dxLBK+8YynQFzgtb53\n\tUglY3+jL6ZiqKdSUigKPn1ETyBnMZ22bKQTghmQ+P7Gy+U4FmW7czWT85gQnbJmMWk\n\thd0SftqikX6jXJfMrnJthy01brSLTdvD3vyeFkn8=","Date":"Mon, 12 Oct 2020 03:02:04 +0300","From":"Laurent Pinchart ","To":"Jacopo Mondi ","Message-ID":"<20201012000204.GL3944@pendragon.ideasonboard.com>","References":"<20201009122101.73858-1-jacopo@jmondi.org>\n\t<20201009122101.73858-3-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20201009122101.73858-3-jacopo@jmondi.org>","Subject":"Re: [libcamera-devel] [PATCH 02/10] libcamera: controls: Define\n\tAwbLocked control","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]