[{"id":13124,"web_url":"https://patchwork.libcamera.org/comment/13124/","msgid":"","date":"2020-10-09T11:51:13","subject":"Re: [libcamera-devel] [PATCH] android: jpeg: Use LGPL-2.1 license","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Umang,\n\nOn 09/10/2020 09:00, Umang Jain wrote:\n> The jpeg components should use LGPL-2.1-or-later license instead of\n> the GPL-2.0.\n\nIndeed, good spot.\n\nReviewed-by: Kieran Bingham \n\n\n> Signed-off-by: Umang Jain \n> ---\n> src/android/jpeg/encoder.h | 2 +-\n> src/android/jpeg/encoder_libjpeg.cpp | 2 +-\n> src/android/jpeg/encoder_libjpeg.h | 2 +-\n> src/android/jpeg/exif.cpp | 2 +-\n> src/android/jpeg/exif.h | 2 +-\n> 5 files changed, 5 insertions(+), 5 deletions(-)\n> \n> diff --git a/src/android/jpeg/encoder.h b/src/android/jpeg/encoder.h\n> index cf26d67..4483153 100644\n> --- a/src/android/jpeg/encoder.h\n> +++ b/src/android/jpeg/encoder.h\n> @@ -1,4 +1,4 @@\n> -/* SPDX-License-Identifier: GPL-2.0-or-later */\n> +/* SPDX-License-Identifier: LGPL-2.1-or-later */\n> /*\n> * Copyright (C) 2020, Google Inc.\n> *\n> diff --git a/src/android/jpeg/encoder_libjpeg.cpp b/src/android/jpeg/encoder_libjpeg.cpp\n> index 510613c..a77f5b2 100644\n> --- a/src/android/jpeg/encoder_libjpeg.cpp\n> +++ b/src/android/jpeg/encoder_libjpeg.cpp\n> @@ -1,4 +1,4 @@\n> -/* SPDX-License-Identifier: GPL-2.0-or-later */\n> +/* SPDX-License-Identifier: LGPL-2.1-or-later */\n> /*\n> * Copyright (C) 2020, Google Inc.\n> *\n> diff --git a/src/android/jpeg/encoder_libjpeg.h b/src/android/jpeg/encoder_libjpeg.h\n> index 1e8df05..934caef 100644\n> --- a/src/android/jpeg/encoder_libjpeg.h\n> +++ b/src/android/jpeg/encoder_libjpeg.h\n> @@ -1,4 +1,4 @@\n> -/* SPDX-License-Identifier: GPL-2.0-or-later */\n> +/* SPDX-License-Identifier: LGPL-2.1-or-later */\n> /*\n> * Copyright (C) 2020, Google Inc.\n> *\n> diff --git a/src/android/jpeg/exif.cpp b/src/android/jpeg/exif.cpp\n> index e4a116d..d21534a 100644\n> --- a/src/android/jpeg/exif.cpp\n> +++ b/src/android/jpeg/exif.cpp\n> @@ -1,4 +1,4 @@\n> -/* SPDX-License-Identifier: GPL-2.0-or-later */\n> +/* SPDX-License-Identifier: LGPL-2.1-or-later */\n> /*\n> * Copyright (C) 2020, Google Inc.\n> *\n> diff --git a/src/android/jpeg/exif.h b/src/android/jpeg/exif.h\n> index 77d1177..12c27b6 100644\n> --- a/src/android/jpeg/exif.h\n> +++ b/src/android/jpeg/exif.h\n> @@ -1,4 +1,4 @@\n> -/* SPDX-License-Identifier: GPL-2.0-or-later */\n> +/* SPDX-License-Identifier: LGPL-2.1-or-later */\n> /*\n> * Copyright (C) 2020, Google Inc.\n> *\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B6D74BEEDF\n\tfor ;\n\tFri, 9 Oct 2020 11:51:18 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1F35060725;\n\tFri, 9 Oct 2020 13:51:18 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6DBD060358\n\tfor ;\n\tFri, 9 Oct 2020 13:51:17 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id CB7C9539;\n\tFri, 9 Oct 2020 13:51:16 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"MmaRVk+4\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1602244277;\n\tbh=WEWSp2J79oqzqe3ZiwjwNUa4wNoFChTMMh79F7R5czY=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=MmaRVk+4BEMZ2Sz5VyWLRbkM9CGUU39xP+Mry7YDwkEdxR93VcpbxCteAXeDgqS3F\n\ttwE1qATEAQmAXN05+9G/+SnzGR2yw32BA2cjy1U1EjjxTE53sRAL36e2OwPlhx0R7Z\n\tbG4kfpIC9COhJBXpn5t5MqiFeIlB2B0DalG0wsrY=","To":"Umang Jain , libcamera-devel@lists.libcamera.org","References":"<20201009080026.31566-1-email@uajain.com>","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"","Date":"Fri, 9 Oct 2020 12:51:13 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"<20201009080026.31566-1-email@uajain.com>","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [PATCH] android: jpeg: Use LGPL-2.1 license","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"kieran.bingham@ideasonboard.com","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":13153,"web_url":"https://patchwork.libcamera.org/comment/13153/","msgid":"<20201009223712.GI25040@pendragon.ideasonboard.com>","date":"2020-10-09T22:37:12","subject":"Re: [libcamera-devel] [PATCH] android: jpeg: Use LGPL-2.1 license","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Umang,\n\nThank you for the patch.\n\nOn Fri, Oct 09, 2020 at 01:30:26PM +0530, Umang Jain wrote:\n> The jpeg components should use LGPL-2.1-or-later license instead of\n> the GPL-2.0.\n\nIt was indeed an oversight.\n\nI'll push the patch with the following update to the commit message to\nclarify that the GPL-2.0 has never been our intent.\n\n\"The jpeg components are licensed under GPL-2.0-or-later. This is an\noversight and unvoluntary. License them under the LGPL-2.1-or-later as\nthe rest of the camera HAL implementation.\"\n\nAcked-by: Laurent Pinchart \n\n> Signed-off-by: Umang Jain \n> ---\n> src/android/jpeg/encoder.h | 2 +-\n> src/android/jpeg/encoder_libjpeg.cpp | 2 +-\n> src/android/jpeg/encoder_libjpeg.h | 2 +-\n> src/android/jpeg/exif.cpp | 2 +-\n> src/android/jpeg/exif.h | 2 +-\n> 5 files changed, 5 insertions(+), 5 deletions(-)\n> \n> diff --git a/src/android/jpeg/encoder.h b/src/android/jpeg/encoder.h\n> index cf26d67..4483153 100644\n> --- a/src/android/jpeg/encoder.h\n> +++ b/src/android/jpeg/encoder.h\n> @@ -1,4 +1,4 @@\n> -/* SPDX-License-Identifier: GPL-2.0-or-later */\n> +/* SPDX-License-Identifier: LGPL-2.1-or-later */\n> /*\n> * Copyright (C) 2020, Google Inc.\n> *\n> diff --git a/src/android/jpeg/encoder_libjpeg.cpp b/src/android/jpeg/encoder_libjpeg.cpp\n> index 510613c..a77f5b2 100644\n> --- a/src/android/jpeg/encoder_libjpeg.cpp\n> +++ b/src/android/jpeg/encoder_libjpeg.cpp\n> @@ -1,4 +1,4 @@\n> -/* SPDX-License-Identifier: GPL-2.0-or-later */\n> +/* SPDX-License-Identifier: LGPL-2.1-or-later */\n> /*\n> * Copyright (C) 2020, Google Inc.\n> *\n> diff --git a/src/android/jpeg/encoder_libjpeg.h b/src/android/jpeg/encoder_libjpeg.h\n> index 1e8df05..934caef 100644\n> --- a/src/android/jpeg/encoder_libjpeg.h\n> +++ b/src/android/jpeg/encoder_libjpeg.h\n> @@ -1,4 +1,4 @@\n> -/* SPDX-License-Identifier: GPL-2.0-or-later */\n> +/* SPDX-License-Identifier: LGPL-2.1-or-later */\n> /*\n> * Copyright (C) 2020, Google Inc.\n> *\n> diff --git a/src/android/jpeg/exif.cpp b/src/android/jpeg/exif.cpp\n> index e4a116d..d21534a 100644\n> --- a/src/android/jpeg/exif.cpp\n> +++ b/src/android/jpeg/exif.cpp\n> @@ -1,4 +1,4 @@\n> -/* SPDX-License-Identifier: GPL-2.0-or-later */\n> +/* SPDX-License-Identifier: LGPL-2.1-or-later */\n> /*\n> * Copyright (C) 2020, Google Inc.\n> *\n> diff --git a/src/android/jpeg/exif.h b/src/android/jpeg/exif.h\n> index 77d1177..12c27b6 100644\n> --- a/src/android/jpeg/exif.h\n> +++ b/src/android/jpeg/exif.h\n> @@ -1,4 +1,4 @@\n> -/* SPDX-License-Identifier: GPL-2.0-or-later */\n> +/* SPDX-License-Identifier: LGPL-2.1-or-later */\n> /*\n> * Copyright (C) 2020, Google Inc.\n> *","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0A023BEEE0\n\tfor ;\n\tFri, 9 Oct 2020 22:37:58 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 90D8B60359;\n\tSat, 10 Oct 2020 00:37:57 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6091760359\n\tfor ;\n\tSat, 10 Oct 2020 00:37:56 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D4558528;\n\tSat, 10 Oct 2020 00:37:55 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Ynkw1Cf5\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1602283076;\n\tbh=nnZeO9nugzwbebLtWrJ6PhdPnZhjoJ9ozcr180b7Do8=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=Ynkw1Cf5TiqGv+f/0Ewacw4dESD7yOwvCe1/CYhldXAF9zMN5Upg/KuGEMrOa49YU\n\tPH15BK8Pp5y90sgb7UP2BE11IDTh4GrGcZti68qf0IwRMuAQ45U9w2JYuBkrj9v6Tg\n\tYSbEhbXcss0RNUFFmM8VMNKVUdcsLrYfXMkAsh8o=","Date":"Sat, 10 Oct 2020 01:37:12 +0300","From":"Laurent Pinchart ","To":"Umang Jain ","Message-ID":"<20201009223712.GI25040@pendragon.ideasonboard.com>","References":"<20201009080026.31566-1-email@uajain.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20201009080026.31566-1-email@uajain.com>","Subject":"Re: [libcamera-devel] [PATCH] android: jpeg: Use LGPL-2.1 license","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]