{"id":1002,"url":"https://patchwork.libcamera.org/api/patches/1002/?format=json","web_url":"https://patchwork.libcamera.org/patch/1002/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20190416134210.21097-2-jacopo@jmondi.org>","date":"2019-04-16T13:42:04","name":"[libcamera-devel,v6,1/7] libcamera: stream: Make Stream inheritable","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"fa34d1368a9c04cc43dad55009786e0b2cddd7af","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/?format=json","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/1002/mbox/","series":[{"id":252,"url":"https://patchwork.libcamera.org/api/series/252/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=252","date":"2019-04-16T13:42:03","name":"libcamera: Framework changes to prepare for multiple streams support","version":6,"mbox":"https://patchwork.libcamera.org/series/252/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/1002/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/1002/checks/","tags":{},"headers":{"Return-Path":"","Received":["from relay9-d.mail.gandi.net (relay9-d.mail.gandi.net\n\t[217.70.183.199])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2B71660DC1\n\tfor ;\n\tTue, 16 Apr 2019 15:41:26 +0200 (CEST)","from uno.lan (2-224-242-101.ip172.fastwebnet.it [2.224.242.101])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay9-d.mail.gandi.net (Postfix) with ESMTPSA id 6E0B9FF81F;\n\tTue, 16 Apr 2019 13:41:24 +0000 (UTC)"],"X-Originating-IP":"2.224.242.101","From":"Jacopo Mondi ","To":"libcamera-devel@lists.libcamera.org","Date":"Tue, 16 Apr 2019 15:42:04 +0200","Message-Id":"<20190416134210.21097-2-jacopo@jmondi.org>","X-Mailer":"git-send-email 2.21.0","In-Reply-To":"<20190416134210.21097-1-jacopo@jmondi.org>","References":"<20190416134210.21097-1-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v6 1/7] libcamera: stream: Make Stream\n\tinheritable","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Tue, 16 Apr 2019 13:41:26 -0000"},"content":"In preparation for multiple streams support prepare to allow sub-classing\nthe Stream class by removing the 'final' specifier from the class\ndefinition and make its private members protected.\n\nReviewed-by: Niklas Söderlund \nReviewed-by: Laurent Pinchart \nSigned-off-by: Jacopo Mondi \n---\n include/libcamera/stream.h | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)","diff":"diff --git a/include/libcamera/stream.h b/include/libcamera/stream.h\nindex d0f7b0e12485..8a47930f8614 100644\n--- a/include/libcamera/stream.h\n+++ b/include/libcamera/stream.h\n@@ -43,7 +43,7 @@ private:\n \tSize size_;\n };\n \n-class Stream final\n+class Stream\n {\n public:\n \tclass StillCapture : public StreamUsage\n@@ -68,7 +68,7 @@ public:\n \tBufferPool &bufferPool() { return bufferPool_; }\n \tconst StreamConfiguration &configuration() const { return configuration_; }\n \n-private:\n+protected:\n \tfriend class Camera;\n \n \tBufferPool bufferPool_;\n","prefixes":["libcamera-devel","v6","1/7"]}