{"id":10019,"url":"https://patchwork.libcamera.org/api/patches/10019/?format=json","web_url":"https://patchwork.libcamera.org/patch/10019/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20201007185719.3208272-3-kieran.bingham@ideasonboard.com>","date":"2020-10-07T18:57:19","name":"[libcamera-devel,2/2] DNI: How to use a draft control","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"e7189e00f71e5ff8327557246f18c4e1d6e5bdb9","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/?format=json","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"delegate":{"id":11,"url":"https://patchwork.libcamera.org/api/users/11/?format=json","username":"kbingham","first_name":"Kieran","last_name":"Bingham","email":"kieran.bingham@ideasonboard.com"},"mbox":"https://patchwork.libcamera.org/patch/10019/mbox/","series":[{"id":1365,"url":"https://patchwork.libcamera.org/api/series/1365/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1365","date":"2020-10-07T18:57:17","name":"draft controls and properties support","version":1,"mbox":"https://patchwork.libcamera.org/series/1365/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/10019/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/10019/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 30F2BBEEDF\n\tfor ;\n\tWed, 7 Oct 2020 18:57:29 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id F00B3605AF;\n\tWed, 7 Oct 2020 20:57:28 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 40E9A605A8\n\tfor ;\n\tWed, 7 Oct 2020 20:57:26 +0200 (CEST)","from Q.local (cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net\n\t[86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C506FA08;\n\tWed, 7 Oct 2020 20:57:25 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"XskCyXrR\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1602097046;\n\tbh=uaMmk/7AafdplmO8uRLp0DAPjFzTNL2BkU25iHwc/hA=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=XskCyXrR18pMGzRXOhniOa2ycE9i4grluNumQEIlyIN8KVx2L+hoEnwfKr2cUfdZI\n\tNRPginqtICWORBafZNNZ5STef9jR3tWyvgs2+6ZHiD8UGbFlsuDFYqlBDGMRDPevcw\n\toxVbo2drEaqYDswd7fG5f7eI0Do6Yz8HfZFZt/lY=","From":"Kieran Bingham ","To":"libcamera devel ","Date":"Wed, 7 Oct 2020 19:57:19 +0100","Message-Id":"<20201007185719.3208272-3-kieran.bingham@ideasonboard.com>","X-Mailer":"git-send-email 2.25.1","In-Reply-To":"<20201007185719.3208272-1-kieran.bingham@ideasonboard.com>","References":"<20200911162039.61933-1-jacopo@jmondi.org>\n\t<20201007185719.3208272-1-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH 2/2] DNI: How to use a draft control","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"This just shows how the draft state can be used on a control or\nproperty.\nExpressing a draft key on the property_ids or control_ids yaml\ndescriptions will automatically move the entrys to the draft namespace.\n\n\n---\n src/libcamera/camera_sensor.cpp | 2 +-\n src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 2 +-\n src/libcamera/property_ids.yaml | 1 +\n 3 files changed, 3 insertions(+), 2 deletions(-)","diff":"diff --git a/src/libcamera/camera_sensor.cpp b/src/libcamera/camera_sensor.cpp\nindex 78c7ceec7c44..4e899d180d95 100644\n--- a/src/libcamera/camera_sensor.cpp\n+++ b/src/libcamera/camera_sensor.cpp\n@@ -249,7 +249,7 @@ int CameraSensor::init()\n \t\tpropertyValue = rotationControl->second.def().get();\n \telse\n \t\tpropertyValue = 0;\n-\tproperties_.set(properties::Rotation, propertyValue);\n+\tproperties_.set(properties::draft::Rotation, propertyValue);\n \n \t/* Enumerate, sort and cache media bus codes and sizes. */\n \tformats_ = subdev_->formats(pad_);\ndiff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\nindex 26dbd2573e04..c1468178f163 100644\n--- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n+++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n@@ -270,7 +270,7 @@ CameraConfiguration::Status RPiCameraConfiguration::validate()\n \t * error means the platform can never run. Let's just print a warning\n \t * and continue regardless; the rotation is effectively set to zero.\n \t */\n-\tint32_t rotation = data_->sensor_->properties().get(properties::Rotation);\n+\tint32_t rotation = data_->sensor_->properties().get(properties::draft::Rotation);\n \tbool success;\n \tTransform rotationTransform = transformFromRotation(rotation, &success);\n \tif (!success)\ndiff --git a/src/libcamera/property_ids.yaml b/src/libcamera/property_ids.yaml\nindex 7261263a9ba3..e3400cc9d469 100644\n--- a/src/libcamera/property_ids.yaml\n+++ b/src/libcamera/property_ids.yaml\n@@ -28,6 +28,7 @@ controls:\n \n - Rotation:\n type: int32_t\n+ draft: true\n description: |\n The camera rotation is expressed as the angular difference in degrees\n between two reference systems, one relative to the camera module, and\n","prefixes":["libcamera-devel","2/2"]}