[{"id":13050,"web_url":"https://patchwork.libcamera.org/comment/13050/","msgid":"<77edf0db-b9bb-c618-8e20-38736cefa79c@ideasonboard.com>","date":"2020-10-07T12:47:20","subject":"Re: [libcamera-devel] [PATCH 4/4] ipa: raspberrypi: fix use of\n\tuninitialized fields","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Tomi,\n\nOn 07/10/2020 12:07, Tomi Valkeinen wrote:\n> These fields are not initialized, but are used. Set them to 0.\n> \n> Signed-off-by: Tomi Valkeinen \n> ---\n> src/ipa/raspberrypi/controller/rpi/agc.hpp | 6 +++---\n> 1 file changed, 3 insertions(+), 3 deletions(-)\n> \n> diff --git a/src/ipa/raspberrypi/controller/rpi/agc.hpp b/src/ipa/raspberrypi/controller/rpi/agc.hpp\n> index ba7ae09..23374d5 100644\n> --- a/src/ipa/raspberrypi/controller/rpi/agc.hpp\n> +++ b/src/ipa/raspberrypi/controller/rpi/agc.hpp\n> @@ -116,9 +116,9 @@ private:\n> \tstd::string exposure_mode_name_;\n> \tstd::string constraint_mode_name_;\n> \tdouble ev_;\n> -\tdouble flicker_period_;\n> -\tdouble fixed_shutter_;\n> -\tdouble fixed_analogue_gain_;\n> +\tdouble flicker_period_ = 0;\n\n = 0.0; ?\n\nAlso - this is setting the initialisation in the header definition,\nrather than the implementation where we would normally do the\ninitialisation. Any reason for that?\n\n> +\tdouble fixed_shutter_ = 0;\n> +\tdouble fixed_analogue_gain_ = 0;\n\nThese get initialised in Agc::Agc(Controller *controller) ...\n\nOh - wait, I see you've removed that in patch 2/4!\n\nSo technically this is a defect introduced by patch 2/4 - so perhaps it\nshould be squashed there in some form or another.\n\n\n> };\n> \n> } // namespace RPiController\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 93C00BEEE0\n\tfor ;\n\tWed, 7 Oct 2020 12:47:26 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D6F6D605A8;\n\tWed, 7 Oct 2020 14:47:25 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 605186055E\n\tfor ;\n\tWed, 7 Oct 2020 14:47:24 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B78FD9DA;\n\tWed, 7 Oct 2020 14:47:23 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"OUQaaeco\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1602074844;\n\tbh=DY8PfOqP9I7WiooZVan2XNzb6gA25PYV9I+0WwTnjso=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=OUQaaecoXtRAS0Arp7bx8u1LGdAxI/ojRhDecjsIQdItkRHjDfLrGyK9aifnuXrMu\n\t5X9c6AGGT/UJ3MM7eIWzcZglQwITDLGgbDix33OTL+/FY5CO3nbEdObao4Nze2AePI\n\t7h91t2gqLH2wBK/TuGq5Weulio2R3E+zas2CHsO8=","To":"Tomi Valkeinen ,\n\tlibcamera-devel@lists.libcamera.org,\n\tNaushir Patuck , \n\tDavid Plowman ","References":"<20201007110743.55561-1-tomi.valkeinen@iki.fi>\n\t<20201007110743.55561-5-tomi.valkeinen@iki.fi>","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<77edf0db-b9bb-c618-8e20-38736cefa79c@ideasonboard.com>","Date":"Wed, 7 Oct 2020 13:47:20 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"<20201007110743.55561-5-tomi.valkeinen@iki.fi>","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [PATCH 4/4] ipa: raspberrypi: fix use of\n\tuninitialized fields","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"kieran.bingham@ideasonboard.com","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":13053,"web_url":"https://patchwork.libcamera.org/comment/13053/","msgid":"","date":"2020-10-07T12:52:21","subject":"Re: [libcamera-devel] [PATCH 4/4] ipa: raspberrypi: fix use of\n\tuninitialized fields","submitter":{"id":70,"url":"https://patchwork.libcamera.org/api/people/70/","name":"Tomi Valkeinen","email":"tomi.valkeinen@iki.fi"},"content":"On 07/10/2020 15:47, Kieran Bingham wrote:\n> Hi Tomi,\n> \n> On 07/10/2020 12:07, Tomi Valkeinen wrote:\n>> These fields are not initialized, but are used. Set them to 0.\n>>\n>> Signed-off-by: Tomi Valkeinen \n>> ---\n>> src/ipa/raspberrypi/controller/rpi/agc.hpp | 6 +++---\n>> 1 file changed, 3 insertions(+), 3 deletions(-)\n>>\n>> diff --git a/src/ipa/raspberrypi/controller/rpi/agc.hpp b/src/ipa/raspberrypi/controller/rpi/agc.hpp\n>> index ba7ae09..23374d5 100644\n>> --- a/src/ipa/raspberrypi/controller/rpi/agc.hpp\n>> +++ b/src/ipa/raspberrypi/controller/rpi/agc.hpp\n>> @@ -116,9 +116,9 @@ private:\n>> \tstd::string exposure_mode_name_;\n>> \tstd::string constraint_mode_name_;\n>> \tdouble ev_;\n>> -\tdouble flicker_period_;\n>> -\tdouble fixed_shutter_;\n>> -\tdouble fixed_analogue_gain_;\n>> +\tdouble flicker_period_ = 0;\n> \n> = 0.0; ?\n> \n> Also - this is setting the initialisation in the header definition,\n> rather than the implementation where we would normally do the\n> initialisation. Any reason for that?\n\nAny reason not to initialize in the header? I think it's much nicer to initialize there when you are\nsetting to a simple literal. It's very easy to miss the init in the implementation file, especially\nif you have multiple constructors.\n\n Tomi","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E29EBBEEDF\n\tfor ;\n\tWed, 7 Oct 2020 12:52:25 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6B9BF60579;\n\tWed, 7 Oct 2020 14:52:25 +0200 (CEST)","from mail-lj1-x243.google.com (mail-lj1-x243.google.com\n\t[IPv6:2a00:1450:4864:20::243])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 670AA6055E\n\tfor ;\n\tWed, 7 Oct 2020 14:52:23 +0200 (CEST)","by mail-lj1-x243.google.com with SMTP id y16so697794ljk.1\n\tfor ;\n\tWed, 07 Oct 2020 05:52:23 -0700 (PDT)","from [192.168.1.111] (91-152-83-50.elisa-laajakaista.fi.\n\t[91.152.83.50]) by smtp.gmail.com with ESMTPSA id\n\to9sm320006lfi.235.2020.10.07.05.52.22\n\t(version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n\tWed, 07 Oct 2020 05:52:22 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"q5TqgX/7\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=sender:subject:to:references:from:message-id:date:user-agent\n\t:mime-version:in-reply-to:content-language:content-transfer-encoding; \n\tbh=swVoNCJ9YCwhGOb1RhV+LubQ6o1EDze+vvlRK+l2UQ4=;\n\tb=q5TqgX/7z1Jp4cD8GE/sUQxxzGzpCdbJpko3SXy+/dg/jYylCAcKuwDOATY1rZC9fi\n\t+gS3eR7DdT9Z3iprG416f2VAlIPZO0b7bTVuTCVqaNTB+J2TwuOwGeUVt3f/O/Ko8Aa7\n\t6YeICzb3fjUY/xBjV6ow32q+T5ahLNTfKsdWrErNrjhJIJU2ziDlDNDi19fuUDoimYK5\n\t/y7CB9NNH2NSfzYGeQrVZLRix38czDrcA2KG6t8+5ODXhD3qnKa2ditL054WKjRuFOUB\n\tgzYG1VuafwMQhEBQTkYmiX/Kdn9RJQCfcYWtZ5BW0NLnF71v/MktUibbd5ClfdbZzJTf\n\tcyTA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:sender:subject:to:references:from:message-id\n\t:date:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=swVoNCJ9YCwhGOb1RhV+LubQ6o1EDze+vvlRK+l2UQ4=;\n\tb=tS4vr/4vKseAe68xJXW7WK+1KDoLQEsumQ2GDtFW6HtI3jeiEF+RR8wT9fPejsezvt\n\tTKIbd8XIXGoFRwlIgw8XRsHAnwpHpj+O2XF/3sETJ7NP7QYYTXil2z+vPwSRLD0Xk0VE\n\t0x1CchnreyHqVbSbAmbEZFj4FmwQGSrOnB1qOVF6br/h5I2LzbuIN99lHv8H66P19fPE\n\tI0RvnoX+eWJ2la2VptvJzli+xfscqlsMgpu/DUR1PPQaHagnfZt9Xv0K/i3hXxiaUGWS\n\tFzMJs3b2/b4NWtiaBNNd+kZ9l7wamu1IL1eqgEnnXj+MsMo6frFAZRwRXwIZ4LgkRnEo\n\ttEwQ==","X-Gm-Message-State":"AOAM531jA4JY+OVAPSWSVl6iXLswqdi0ji01mfHJizx/PY+7mHutbjIn\n\tFyYSu05hPxnFgWDbsoxTN8BWLBHEDegbDw==","X-Google-Smtp-Source":"ABdhPJzto4jZiZZaGRIM3FzejciOBwPHYD9B0/uRPDe4QLEX/fuc+v6iG4l+Kb+IPboosnSxuH/sCQ==","X-Received":"by 2002:a2e:8e63:: with SMTP id t3mr1055751ljk.132.1602075142845;\n\tWed, 07 Oct 2020 05:52:22 -0700 (PDT)","To":"kieran.bingham@ideasonboard.com, libcamera-devel@lists.libcamera.org,\n\tNaushir Patuck ,\n\tDavid Plowman ","References":"<20201007110743.55561-1-tomi.valkeinen@iki.fi>\n\t<20201007110743.55561-5-tomi.valkeinen@iki.fi>\n\t<77edf0db-b9bb-c618-8e20-38736cefa79c@ideasonboard.com>","From":"Tomi Valkeinen ","Message-ID":"","Date":"Wed, 7 Oct 2020 15:52:21 +0300","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"<77edf0db-b9bb-c618-8e20-38736cefa79c@ideasonboard.com>","Content-Language":"en-US","Subject":"Re: [libcamera-devel] [PATCH 4/4] ipa: raspberrypi: fix use of\n\tuninitialized fields","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":13055,"web_url":"https://patchwork.libcamera.org/comment/13055/","msgid":"<20201007125442.GB3937@pendragon.ideasonboard.com>","date":"2020-10-07T12:54:42","subject":"Re: [libcamera-devel] [PATCH 4/4] ipa: raspberrypi: fix use of\n\tuninitialized fields","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Tomi,\n\nOn Wed, Oct 07, 2020 at 03:52:21PM +0300, Tomi Valkeinen wrote:\n> On 07/10/2020 15:47, Kieran Bingham wrote:\n> > On 07/10/2020 12:07, Tomi Valkeinen wrote:\n> >> These fields are not initialized, but are used. Set them to 0.\n> >>\n> >> Signed-off-by: Tomi Valkeinen \n> >> ---\n> >> src/ipa/raspberrypi/controller/rpi/agc.hpp | 6 +++---\n> >> 1 file changed, 3 insertions(+), 3 deletions(-)\n> >>\n> >> diff --git a/src/ipa/raspberrypi/controller/rpi/agc.hpp b/src/ipa/raspberrypi/controller/rpi/agc.hpp\n> >> index ba7ae09..23374d5 100644\n> >> --- a/src/ipa/raspberrypi/controller/rpi/agc.hpp\n> >> +++ b/src/ipa/raspberrypi/controller/rpi/agc.hpp\n> >> @@ -116,9 +116,9 @@ private:\n> >> \tstd::string exposure_mode_name_;\n> >> \tstd::string constraint_mode_name_;\n> >> \tdouble ev_;\n> >> -\tdouble flicker_period_;\n> >> -\tdouble fixed_shutter_;\n> >> -\tdouble fixed_analogue_gain_;\n> >> +\tdouble flicker_period_ = 0;\n> > \n> > = 0.0; ?\n> > \n> > Also - this is setting the initialisation in the header definition,\n> > rather than the implementation where we would normally do the\n> > initialisation. Any reason for that?\n> \n> Any reason not to initialize in the header? I think it's much nicer to\n> initialize there when you are setting to a simple literal. It's very\n> easy to miss the init in the implementation file, especially if you\n> have multiple constructors.\n\nThat's the current coding style. I didn't even know this was possible\n:-) I'm not opposed to reconsidering this, but it should then be changed\nglobally.","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D2076BEEDF\n\tfor ;\n\tWed, 7 Oct 2020 12:55:26 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 66941605A8;\n\tWed, 7 Oct 2020 14:55:26 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7E23E6055E\n\tfor ;\n\tWed, 7 Oct 2020 14:55:24 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id EABED9DA;\n\tWed, 7 Oct 2020 14:55:23 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"bmTdjcnm\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1602075324;\n\tbh=redmhhS/Oy7kjOV9aFSn9OUyFm9PCymcu28Z6lUv6hQ=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=bmTdjcnm6J5jtoQtIJ+Iw6i09V+o4/73KG8zRH+RXeN2Ous9M6eD3/XF7AdTFs2up\n\t5nM0luPcfngTAIuncWtg3DDowiYYON9ewDO/pIyvHRSZYFrHg4Z8o1xkpB6+TYaQIQ\n\t+l+XNImP3gSi+bb5ZWoU7dIn6ZaUeXUOXRR5CN5U=","Date":"Wed, 7 Oct 2020 15:54:42 +0300","From":"Laurent Pinchart ","To":"Tomi Valkeinen ","Message-ID":"<20201007125442.GB3937@pendragon.ideasonboard.com>","References":"<20201007110743.55561-1-tomi.valkeinen@iki.fi>\n\t<20201007110743.55561-5-tomi.valkeinen@iki.fi>\n\t<77edf0db-b9bb-c618-8e20-38736cefa79c@ideasonboard.com>\n\t","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"","Subject":"Re: [libcamera-devel] [PATCH 4/4] ipa: raspberrypi: fix use of\n\tuninitialized fields","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":13056,"web_url":"https://patchwork.libcamera.org/comment/13056/","msgid":"<49aeb08d-8f3f-9ad3-c732-35c97841dd2e@ideasonboard.com>","date":"2020-10-07T13:00:49","subject":"Re: [libcamera-devel] [PATCH 4/4] ipa: raspberrypi: fix use of\n\tuninitialized fields","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Laurent,\n\nOn 07/10/2020 13:54, Laurent Pinchart wrote:\n> Hi Tomi,\n> \n> On Wed, Oct 07, 2020 at 03:52:21PM +0300, Tomi Valkeinen wrote:\n>> On 07/10/2020 15:47, Kieran Bingham wrote:\n>>> On 07/10/2020 12:07, Tomi Valkeinen wrote:\n>>>> These fields are not initialized, but are used. Set them to 0.\n>>>>\n>>>> Signed-off-by: Tomi Valkeinen \n>>>> ---\n>>>> src/ipa/raspberrypi/controller/rpi/agc.hpp | 6 +++---\n>>>> 1 file changed, 3 insertions(+), 3 deletions(-)\n>>>>\n>>>> diff --git a/src/ipa/raspberrypi/controller/rpi/agc.hpp b/src/ipa/raspberrypi/controller/rpi/agc.hpp\n>>>> index ba7ae09..23374d5 100644\n>>>> --- a/src/ipa/raspberrypi/controller/rpi/agc.hpp\n>>>> +++ b/src/ipa/raspberrypi/controller/rpi/agc.hpp\n>>>> @@ -116,9 +116,9 @@ private:\n>>>> \tstd::string exposure_mode_name_;\n>>>> \tstd::string constraint_mode_name_;\n>>>> \tdouble ev_;\n>>>> -\tdouble flicker_period_;\n>>>> -\tdouble fixed_shutter_;\n>>>> -\tdouble fixed_analogue_gain_;\n>>>> +\tdouble flicker_period_ = 0;\n>>>\n>>> = 0.0; ?\n>>>\n>>> Also - this is setting the initialisation in the header definition,\n>>> rather than the implementation where we would normally do the\n>>> initialisation. Any reason for that?\n>>\n>> Any reason not to initialize in the header? I think it's much nicer to\n>> initialize there when you are setting to a simple literal. It's very\n>> easy to miss the init in the implementation file, especially if you\n>> have multiple constructors.\n> \n> That's the current coding style. I didn't even know this was possible\n> :-) I'm not opposed to reconsidering this, but it should then be changed\n> globally.\n\nI think for me, equally - this was a \"didn't realise we could\", and\n\"we've always done it that way\" ;-) - but I do feel like it's better.\n\nI bet we can reduce a few constructor initialiser lists with this too!\n\nAnd handling multiple constructors in one hit (I'm not sure how many of\nour classes have multiple constructors, but there's a few I'm sure)\nseems like an instant win too.\n\n/me wishes C++ would just initialise all PODs to 0 ;-)","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id AED29BEEE0\n\tfor ;\n\tWed, 7 Oct 2020 13:00:55 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2F8E360580;\n\tWed, 7 Oct 2020 15:00:55 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 243766055E\n\tfor ;\n\tWed, 7 Oct 2020 15:00:53 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 6D00E9DA;\n\tWed, 7 Oct 2020 15:00:52 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"qhZyIpA0\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1602075652;\n\tbh=iM4jJn5tqHmWjaaRTxhdCRfmwx/cMJJ05J1/fx/kZpU=;\n\th=Reply-To:Subject:To:Cc:References:From:Date:In-Reply-To:From;\n\tb=qhZyIpA0yy08sgOVALj0xkR13ryJBuW0k04EpOdE8ICUcuOEzGj5afsarh4tE9n+A\n\tjwbYYmTvoaKxUiC+4f/YY6oxXhCZePRE0WzNDBghQh2PNsbkMyneMyKd/tFx3aQqt6\n\tXcNJE/XBiyfec0htlRsiwajti6llYajxRB0zEpFw=","To":"Laurent Pinchart ,\n\tTomi Valkeinen ","References":"<20201007110743.55561-1-tomi.valkeinen@iki.fi>\n\t<20201007110743.55561-5-tomi.valkeinen@iki.fi>\n\t<77edf0db-b9bb-c618-8e20-38736cefa79c@ideasonboard.com>\n\t\n\t<20201007125442.GB3937@pendragon.ideasonboard.com>","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<49aeb08d-8f3f-9ad3-c732-35c97841dd2e@ideasonboard.com>","Date":"Wed, 7 Oct 2020 14:00:49 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"<20201007125442.GB3937@pendragon.ideasonboard.com>","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [PATCH 4/4] ipa: raspberrypi: fix use of\n\tuninitialized fields","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"kieran.bingham@ideasonboard.com","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":13062,"web_url":"https://patchwork.libcamera.org/comment/13062/","msgid":"<20201007131303.GD3937@pendragon.ideasonboard.com>","date":"2020-10-07T13:13:03","subject":"Re: [libcamera-devel] [PATCH 4/4] ipa: raspberrypi: fix use of\n\tuninitialized fields","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nOn Wed, Oct 07, 2020 at 02:00:49PM +0100, Kieran Bingham wrote:\n> On 07/10/2020 13:54, Laurent Pinchart wrote:\n> > On Wed, Oct 07, 2020 at 03:52:21PM +0300, Tomi Valkeinen wrote:\n> >> On 07/10/2020 15:47, Kieran Bingham wrote:\n> >>> On 07/10/2020 12:07, Tomi Valkeinen wrote:\n> >>>> These fields are not initialized, but are used. Set them to 0.\n> >>>>\n> >>>> Signed-off-by: Tomi Valkeinen \n> >>>> ---\n> >>>> src/ipa/raspberrypi/controller/rpi/agc.hpp | 6 +++---\n> >>>> 1 file changed, 3 insertions(+), 3 deletions(-)\n> >>>>\n> >>>> diff --git a/src/ipa/raspberrypi/controller/rpi/agc.hpp b/src/ipa/raspberrypi/controller/rpi/agc.hpp\n> >>>> index ba7ae09..23374d5 100644\n> >>>> --- a/src/ipa/raspberrypi/controller/rpi/agc.hpp\n> >>>> +++ b/src/ipa/raspberrypi/controller/rpi/agc.hpp\n> >>>> @@ -116,9 +116,9 @@ private:\n> >>>> \tstd::string exposure_mode_name_;\n> >>>> \tstd::string constraint_mode_name_;\n> >>>> \tdouble ev_;\n> >>>> -\tdouble flicker_period_;\n> >>>> -\tdouble fixed_shutter_;\n> >>>> -\tdouble fixed_analogue_gain_;\n> >>>> +\tdouble flicker_period_ = 0;\n> >>>\n> >>> = 0.0; ?\n> >>>\n> >>> Also - this is setting the initialisation in the header definition,\n> >>> rather than the implementation where we would normally do the\n> >>> initialisation. Any reason for that?\n> >>\n> >> Any reason not to initialize in the header? I think it's much nicer to\n> >> initialize there when you are setting to a simple literal. It's very\n> >> easy to miss the init in the implementation file, especially if you\n> >> have multiple constructors.\n> > \n> > That's the current coding style. I didn't even know this was possible\n> > :-) I'm not opposed to reconsidering this, but it should then be changed\n> > globally.\n> \n> I think for me, equally - this was a \"didn't realise we could\", and\n> \"we've always done it that way\" ;-) - but I do feel like it's better.\n> \n> I bet we can reduce a few constructor initialiser lists with this too!\n>\n> And handling multiple constructors in one hit (I'm not sure how many of\n> our classes have multiple constructors, but there's a few I'm sure)\n> seems like an instant win too.\n\nThere are drawbacks too, it splits initialization between two files,\nmaking it easier to miss things. Let's consider the pros and cons and\nthen make a decision.\n\n> /me wishes C++ would just initialise all PODs to 0 ;-)","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 272E6BEEDF\n\tfor ;\n\tWed, 7 Oct 2020 13:13:47 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A4F20605A8;\n\tWed, 7 Oct 2020 15:13:46 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 75C296055E\n\tfor ;\n\tWed, 7 Oct 2020 15:13:45 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id DF50B9DA;\n\tWed, 7 Oct 2020 15:13:44 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"TJtQ/DcZ\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1602076425;\n\tbh=3NltsxgMISiWHQ1on7fJi2PwzlK61bTn/8Oc3p7nQ3I=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=TJtQ/DcZsSvRXlZUtmUJqV1AhOvMH/XFGWQIv854++Oco7tr2d/erhLKyLzKrU065\n\tokxU8eCybtv7AhuhBeTM6za+y/FXao6NVkoP2/YEDtxL5kX1L+JulHaQP0gDGI3E7u\n\tDVi/ziZgR5ODkub9SCImfvVftCHJlJnqkqZXqzcM=","Date":"Wed, 7 Oct 2020 16:13:03 +0300","From":"Laurent Pinchart ","To":"Kieran Bingham ","Message-ID":"<20201007131303.GD3937@pendragon.ideasonboard.com>","References":"<20201007110743.55561-1-tomi.valkeinen@iki.fi>\n\t<20201007110743.55561-5-tomi.valkeinen@iki.fi>\n\t<77edf0db-b9bb-c618-8e20-38736cefa79c@ideasonboard.com>\n\t\n\t<20201007125442.GB3937@pendragon.ideasonboard.com>\n\t<49aeb08d-8f3f-9ad3-c732-35c97841dd2e@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<49aeb08d-8f3f-9ad3-c732-35c97841dd2e@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 4/4] ipa: raspberrypi: fix use of\n\tuninitialized fields","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org,\n\tTomi Valkeinen ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]