[{"id":13049,"web_url":"https://patchwork.libcamera.org/comment/13049/","msgid":"<5b66a373-02ee-31a6-e23c-baebde4b1975@ideasonboard.com>","date":"2020-10-07T12:41:46","subject":"Re: [libcamera-devel] [PATCH 3/4] ipa: raspberrypi: fix access to\n\tuninitialized variables","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Tomi,\n\nOn 07/10/2020 12:07, Tomi Valkeinen wrote:\n> Set span_r and span_b to -1 so that when they are passed to Pwl::Eval()\n> they won't cause access to uninitialized memory.\n> \n\nThis matches the documentation of Eval at\nsrc/ipa/raspberrypi/controller/pwl.hpp:\n> // Evaluate Pwl, optionally supplying an initial guess for the\n> // \"span\". The \"span\" may be optionally be updated. If you want to know\n> // the \"span\" value but don't have an initial guess you can set it to\n> // -1.\n\nSo I believe this is correct.\n\nReviewed-by: Kieran Bingham \n\n\n> Signed-off-by: Tomi Valkeinen \n> ---\n> src/ipa/raspberrypi/controller/rpi/awb.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/ipa/raspberrypi/controller/rpi/awb.cpp b/src/ipa/raspberrypi/controller/rpi/awb.cpp\n> index a5536e4..469d0e5 100644\n> --- a/src/ipa/raspberrypi/controller/rpi/awb.cpp\n> +++ b/src/ipa/raspberrypi/controller/rpi/awb.cpp\n> @@ -430,7 +430,7 @@ double Awb::coarseSearch(Pwl const &prior)\n> \n> void Awb::fineSearch(double &t, double &r, double &b, Pwl const &prior)\n> {\n> -\tint span_r, span_b;\n> +\tint span_r = -1, span_b = -1;\n> \tconfig_.ct_r.Eval(t, &span_r);\n> \tconfig_.ct_b.Eval(t, &span_b);\n> \tdouble step = t / 10 * config_.coarse_step * 0.1;\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6BA85BEEDF\n\tfor ;\n\tWed, 7 Oct 2020 12:41:51 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id CC5C960580;\n\tWed, 7 Oct 2020 14:41:50 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A433C60553\n\tfor ;\n\tWed, 7 Oct 2020 14:41:49 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 12DF39DA;\n\tWed, 7 Oct 2020 14:41:48 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"S5hN5zG2\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1602074509;\n\tbh=xjU6Pb3+L+O23mORU3U3iPTZzxG2AqVMyKTJKOXL/Cs=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=S5hN5zG2LbPDETgY0bRAj9xc7noxLx1IxzfmTQiS7Ms8okKd9yev8RebZJQohfpYg\n\tzwRCLikCuBkdvECctWM4JfB72GMz/nRsLLj+b/O3er02JAHK7LliB5tz0SGWYlT1IX\n\tIBeXD1qon/cwWBRIapT9YqIm/PNGvqhkVaq1pEL8=","To":"Tomi Valkeinen ,\n\tlibcamera-devel@lists.libcamera.org,\n\tNaushir Patuck , \n\tDavid Plowman ","References":"<20201007110743.55561-1-tomi.valkeinen@iki.fi>\n\t<20201007110743.55561-4-tomi.valkeinen@iki.fi>","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<5b66a373-02ee-31a6-e23c-baebde4b1975@ideasonboard.com>","Date":"Wed, 7 Oct 2020 13:41:46 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"<20201007110743.55561-4-tomi.valkeinen@iki.fi>","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [PATCH 3/4] ipa: raspberrypi: fix access to\n\tuninitialized variables","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"kieran.bingham@ideasonboard.com","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":13060,"web_url":"https://patchwork.libcamera.org/comment/13060/","msgid":"","date":"2020-10-07T13:07:25","subject":"Re: [libcamera-devel] [PATCH 3/4] ipa: raspberrypi: fix access to\n\tuninitialized variables","submitter":{"id":42,"url":"https://patchwork.libcamera.org/api/people/42/","name":"David Plowman","email":"david.plowman@raspberrypi.com"},"content":"Hi Tomi\n\nOn Wed, 7 Oct 2020 at 13:41, Kieran Bingham\n wrote:\n>\n> Hi Tomi,\n>\n> On 07/10/2020 12:07, Tomi Valkeinen wrote:\n> > Set span_r and span_b to -1 so that when they are passed to Pwl::Eval()\n> > they won't cause access to uninitialized memory.\n> >\n>\n> This matches the documentation of Eval at\n> src/ipa/raspberrypi/controller/pwl.hpp:\n> > // Evaluate Pwl, optionally supplying an initial guess for the\n> > // \"span\". The \"span\" may be optionally be updated. If you want to know\n> > // the \"span\" value but don't have an initial guess you can set it to\n> > // -1.\n>\n> So I believe this is correct.\n>\n> Reviewed-by: Kieran Bingham \n\nMea culpa. Thanks very much!\n\nReviewed-by: David Plowman \n\nBest regards\nDavid\n\n>\n>\n> > Signed-off-by: Tomi Valkeinen \n> > ---\n> > src/ipa/raspberrypi/controller/rpi/awb.cpp | 2 +-\n> > 1 file changed, 1 insertion(+), 1 deletion(-)\n> >\n> > diff --git a/src/ipa/raspberrypi/controller/rpi/awb.cpp b/src/ipa/raspberrypi/controller/rpi/awb.cpp\n> > index a5536e4..469d0e5 100644\n> > --- a/src/ipa/raspberrypi/controller/rpi/awb.cpp\n> > +++ b/src/ipa/raspberrypi/controller/rpi/awb.cpp\n> > @@ -430,7 +430,7 @@ double Awb::coarseSearch(Pwl const &prior)\n> >\n> > void Awb::fineSearch(double &t, double &r, double &b, Pwl const &prior)\n> > {\n> > - int span_r, span_b;\n> > + int span_r = -1, span_b = -1;\n> > config_.ct_r.Eval(t, &span_r);\n> > config_.ct_b.Eval(t, &span_b);\n> > double step = t / 10 * config_.coarse_step * 0.1;\n> >\n>\n> --\n> Regards\n> --\n> Kieran","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C0768BEEE0\n\tfor ;\n\tWed, 7 Oct 2020 13:07:39 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4B36C605A8;\n\tWed, 7 Oct 2020 15:07:39 +0200 (CEST)","from mail-oi1-x244.google.com (mail-oi1-x244.google.com\n\t[IPv6:2607:f8b0:4864:20::244])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4E76F6055E\n\tfor ;\n\tWed, 7 Oct 2020 15:07:38 +0200 (CEST)","by mail-oi1-x244.google.com with SMTP id q136so1138640oic.8\n\tfor ;\n\tWed, 07 Oct 2020 06:07:38 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"RvH/RloU\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=hAbuKRYdlwrT31urFetchBhsdlua2aQbYQgVPhKM07Y=;\n\tb=RvH/RloUPFYCmmmzcVJ6OIFt2XALnDDmCU4Bb3ie98F6C715eHh0Xd7ba9HinQU1ot\n\ts5u0FGBqmqt8o2RsBRL+NQprV9dBoOVjiPnyyyh7LmKHH8AnxizNNkm1w/th8F+e4ysy\n\t6r3jCohNo8niHeZl3gQ7nKzq1Eh9f3cl/hI5B1F3ZZbAXI3ZgFyC+aIClwAe2mlj11yk\n\toDNekVXrY3aeirZPxySNXLmv83WHuqy92nHZrO6IQHYemzlRl5BZ5nPoeNTr3YnGoudC\n\tdFILXoCMPDBzcs54vre/VyrlHgRVV6/FSRlUYIOpDDkn1VErnU4TcVHGT3lPHg43UDqI\n\ted8w==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=hAbuKRYdlwrT31urFetchBhsdlua2aQbYQgVPhKM07Y=;\n\tb=e6Buob4V76Se1j+QmQG4pzQ+31NwJJPr9ORr7PcKPSt2nSY0GVKcb5K3LPLwE03F8r\n\tNcTg461dC2urn32mvTRq9AP8v5UamO7JgxotaEXxfMGgjnJhJAx1mK308gL/HgNQyrOt\n\tlnKLb/65ZAfiWqawOFIPNTEcwGSLgXMdnVlZP54muUyKauG9rM02KxD0Itn1FB4r0c3K\n\twoNQA+FC2QXUQe+hH1sTirz5o+2NNO4y6HBTmpVOsN8aT44eprx/6rfSL+u309kY3nH9\n\t26nMUUtLmFKyX/MHI8xNoSB7h+71ALATKtvDFHntQLcZmcNGGRa2dkHk4T7aoofQdNrb\n\tOYNg==","X-Gm-Message-State":"AOAM532nSOIpzMNO3VhL6BDXVHlxnr7kMPUx83kK5fVD0vl5SQpgM/K2\n\tbT9tYjjB3GfoyWldTMe/yTfurFXwFhTS61MVDMODrzvHqPY=","X-Google-Smtp-Source":"ABdhPJx/joNmn0pbawWo9ae+i+B2mpz5NN88h3pBQt7Ey6P87P1t0ZXMGF8jQf4p+I4Xjsg6TwTjNuXGVT61TdgcJew=","X-Received":"by 2002:aca:ef89:: with SMTP id\n\tn131mr1790865oih.22.1602076057107; \n\tWed, 07 Oct 2020 06:07:37 -0700 (PDT)","MIME-Version":"1.0","References":"<20201007110743.55561-1-tomi.valkeinen@iki.fi>\n\t<20201007110743.55561-4-tomi.valkeinen@iki.fi>\n\t<5b66a373-02ee-31a6-e23c-baebde4b1975@ideasonboard.com>","In-Reply-To":"<5b66a373-02ee-31a6-e23c-baebde4b1975@ideasonboard.com>","From":"David Plowman ","Date":"Wed, 7 Oct 2020 14:07:25 +0100","Message-ID":"","To":"Kieran Bingham ","Subject":"Re: [libcamera-devel] [PATCH 3/4] ipa: raspberrypi: fix access to\n\tuninitialized variables","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org,\n\tTomi Valkeinen ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]