[{"id":13048,"web_url":"https://patchwork.libcamera.org/comment/13048/","msgid":"<7ce14c49-9628-c779-b750-645a2c69d5cb@ideasonboard.com>","date":"2020-10-07T12:35:12","subject":"Re: [libcamera-devel] [PATCH 2/4] ipa: raspberrypi: fix missing\n\tinitialize of status_","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Tomi,\n\nOn 07/10/2020 12:07, Tomi Valkeinen wrote:\n> Many fields in status_ are not initialized, causing use of uninitialized\n> memory.\n> \n> Drop the code that clears some of the individual fields, and instead\n> just memset the whole thing.\n> \n\nI think David/Naush' input will be important on this one.\n\n> Signed-off-by: Tomi Valkeinen \n> ---\n> src/ipa/raspberrypi/controller/rpi/agc.cpp | 8 +-------\n> 1 file changed, 1 insertion(+), 7 deletions(-)\n> \n> diff --git a/src/ipa/raspberrypi/controller/rpi/agc.cpp b/src/ipa/raspberrypi/controller/rpi/agc.cpp\n> index df4d364..9e75178 100644\n> --- a/src/ipa/raspberrypi/controller/rpi/agc.cpp\n> +++ b/src/ipa/raspberrypi/controller/rpi/agc.cpp\n> @@ -148,14 +148,8 @@ Agc::Agc(Controller *controller)\n> \t exposure_mode_(nullptr), constraint_mode_(nullptr),\n> \t frame_count_(0), lock_count_(0)\n> {\n> +\tmemset(&status_, 0, sizeof(status_));\n> \tev_ = status_.ev = 1.0;\n> -\tflicker_period_ = status_.flicker_period = 0.0;\n> -\tfixed_shutter_ = status_.fixed_shutter = 0;\n> -\tfixed_analogue_gain_ = status_.fixed_analogue_gain = 0.0;\n> -\t// set to zero initially, so we can tell it's not been calculated\n\nIs there any benefit to retaining this comment in some adjusted form?\n\nOtherwise, I think generally clearing/initialising the whole status\nsounds good.\n\nReviewed-by: Kieran Bingham \n\n\n> -\tstatus_.total_exposure_value = 0.0;\n> -\tstatus_.target_exposure_value = 0.0;\n> -\tstatus_.locked = false;\n> \toutput_status_ = status_;\n> }\n> \n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 66A02BEEE0\n\tfor ;\n\tWed, 7 Oct 2020 12:35:17 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id F36316055E;\n\tWed, 7 Oct 2020 14:35:16 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5B2DE60553\n\tfor ;\n\tWed, 7 Oct 2020 14:35:15 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B419F9DA;\n\tWed, 7 Oct 2020 14:35:14 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"bNzwmIWO\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1602074114;\n\tbh=xAvC/EKEflxFORpeLgUXcml17mNBts1YZSaCgIG5Vy0=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=bNzwmIWOLlMwTcUBS5qjs3nKKDLSmhiYJXwXMBpEOVl9FvNO0us1pfHFkkVSSnmDB\n\t9kfGCp/V0tbZcnRveb2TIjXjvJNR85Kc+R1+c1PQ0jFDfWp+s4KzGxWsxW2DFaBGBB\n\tcc7FM4zfag6DRcdhFZp7PzhgiANvJnjeh47xisDs=","To":"Tomi Valkeinen ,\n\tlibcamera-devel@lists.libcamera.org,\n\tNaushir Patuck , \n\tDavid Plowman ","References":"<20201007110743.55561-1-tomi.valkeinen@iki.fi>\n\t<20201007110743.55561-3-tomi.valkeinen@iki.fi>","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<7ce14c49-9628-c779-b750-645a2c69d5cb@ideasonboard.com>","Date":"Wed, 7 Oct 2020 13:35:12 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"<20201007110743.55561-3-tomi.valkeinen@iki.fi>","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [PATCH 2/4] ipa: raspberrypi: fix missing\n\tinitialize of status_","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"kieran.bingham@ideasonboard.com","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":13051,"web_url":"https://patchwork.libcamera.org/comment/13051/","msgid":"<381e039e-bfd8-8be1-5c34-74980ba224a2@ideasonboard.com>","date":"2020-10-07T12:48:13","subject":"Re: [libcamera-devel] [PATCH 2/4] ipa: raspberrypi: fix missing\n\tinitialize of status_","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"On 07/10/2020 13:35, Kieran Bingham wrote:\n> Hi Tomi,\n> \n> On 07/10/2020 12:07, Tomi Valkeinen wrote:\n>> Many fields in status_ are not initialized, causing use of uninitialized\n>> memory.\n>>\n>> Drop the code that clears some of the individual fields, and instead\n>> just memset the whole thing.\n>>\n> \n> I think David/Naush' input will be important on this one.\n> \n>> Signed-off-by: Tomi Valkeinen \n>> ---\n>> src/ipa/raspberrypi/controller/rpi/agc.cpp | 8 +-------\n>> 1 file changed, 1 insertion(+), 7 deletions(-)\n>>\n>> diff --git a/src/ipa/raspberrypi/controller/rpi/agc.cpp b/src/ipa/raspberrypi/controller/rpi/agc.cpp\n>> index df4d364..9e75178 100644\n>> --- a/src/ipa/raspberrypi/controller/rpi/agc.cpp\n>> +++ b/src/ipa/raspberrypi/controller/rpi/agc.cpp\n>> @@ -148,14 +148,8 @@ Agc::Agc(Controller *controller)\n>> \t exposure_mode_(nullptr), constraint_mode_(nullptr),\n>> \t frame_count_(0), lock_count_(0)\n>> {\n>> +\tmemset(&status_, 0, sizeof(status_));\n>> \tev_ = status_.ev = 1.0;\n>> -\tflicker_period_ = status_.flicker_period = 0.0;\n>> -\tfixed_shutter_ = status_.fixed_shutter = 0;\n>> -\tfixed_analogue_gain_ = status_.fixed_analogue_gain = 0.0;\n>> -\t// set to zero initially, so we can tell it's not been calculated\n> \n> Is there any benefit to retaining this comment in some adjusted form?\n> \n> Otherwise, I think generally clearing/initialising the whole status\n> sounds good.\n> \n> Reviewed-by: Kieran Bingham \n\nAhem, coming back to correct myself - This patch introduces a defect.\nHowever you fix it in 4/4 ... so ... well ... There's a problem. But\nyou've fixed it ;-)\n\nKieran\n\n\n> \n> \n>> -\tstatus_.total_exposure_value = 0.0;\n>> -\tstatus_.target_exposure_value = 0.0;\n>> -\tstatus_.locked = false;\n>> \toutput_status_ = status_;\n>> }\n>> \n>>\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9B728BEEE0\n\tfor ;\n\tWed, 7 Oct 2020 12:48:16 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 677E3605A8;\n\tWed, 7 Oct 2020 14:48:16 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D4EFB6055E\n\tfor ;\n\tWed, 7 Oct 2020 14:48:15 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 52AE09DA;\n\tWed, 7 Oct 2020 14:48:15 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"jlvU801q\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1602074895;\n\tbh=UaYz12PhXTn0jPC/D6HJlmaPpnX7Ue8GSwEnMr1UfXU=;\n\th=Reply-To:Subject:From:To:References:Date:In-Reply-To:From;\n\tb=jlvU801qbKe4jfG2nEYjzprhhroLj/1xazGXASOegc46oGYf6QLRF32g9bo71aUJs\n\t7BzOec1Y08PkWG6+xcCMB4cjZT9dsoMBQFJG2NdI5TffP/i0AcRKCUnY6vNWW9jxoL\n\t5M4lkDNluRbh1AlF7YrQfXXT9XXDvw2AarR7mmB0=","From":"Kieran Bingham ","To":"Tomi Valkeinen ,\n\tlibcamera-devel@lists.libcamera.org,\n\tNaushir Patuck , \n\tDavid Plowman ","References":"<20201007110743.55561-1-tomi.valkeinen@iki.fi>\n\t<20201007110743.55561-3-tomi.valkeinen@iki.fi>\n\t<7ce14c49-9628-c779-b750-645a2c69d5cb@ideasonboard.com>","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<381e039e-bfd8-8be1-5c34-74980ba224a2@ideasonboard.com>","Date":"Wed, 7 Oct 2020 13:48:13 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"<7ce14c49-9628-c779-b750-645a2c69d5cb@ideasonboard.com>","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [PATCH 2/4] ipa: raspberrypi: fix missing\n\tinitialize of status_","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"kieran.bingham@ideasonboard.com","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":13052,"web_url":"https://patchwork.libcamera.org/comment/13052/","msgid":"<4f5bb8af-bb9c-290c-bc33-ce3be1b1a547@iki.fi>","date":"2020-10-07T12:49:28","subject":"Re: [libcamera-devel] [PATCH 2/4] ipa: raspberrypi: fix missing\n\tinitialize of status_","submitter":{"id":70,"url":"https://patchwork.libcamera.org/api/people/70/","name":"Tomi Valkeinen","email":"tomi.valkeinen@iki.fi"},"content":"On 07/10/2020 15:48, Kieran Bingham wrote:\n> On 07/10/2020 13:35, Kieran Bingham wrote:\n>> Hi Tomi,\n>>\n>> On 07/10/2020 12:07, Tomi Valkeinen wrote:\n>>> Many fields in status_ are not initialized, causing use of uninitialized\n>>> memory.\n>>>\n>>> Drop the code that clears some of the individual fields, and instead\n>>> just memset the whole thing.\n>>>\n>>\n>> I think David/Naush' input will be important on this one.\n>>\n>>> Signed-off-by: Tomi Valkeinen \n>>> ---\n>>> src/ipa/raspberrypi/controller/rpi/agc.cpp | 8 +-------\n>>> 1 file changed, 1 insertion(+), 7 deletions(-)\n>>>\n>>> diff --git a/src/ipa/raspberrypi/controller/rpi/agc.cpp b/src/ipa/raspberrypi/controller/rpi/agc.cpp\n>>> index df4d364..9e75178 100644\n>>> --- a/src/ipa/raspberrypi/controller/rpi/agc.cpp\n>>> +++ b/src/ipa/raspberrypi/controller/rpi/agc.cpp\n>>> @@ -148,14 +148,8 @@ Agc::Agc(Controller *controller)\n>>> \t exposure_mode_(nullptr), constraint_mode_(nullptr),\n>>> \t frame_count_(0), lock_count_(0)\n>>> {\n>>> +\tmemset(&status_, 0, sizeof(status_));\n>>> \tev_ = status_.ev = 1.0;\n>>> -\tflicker_period_ = status_.flicker_period = 0.0;\n>>> -\tfixed_shutter_ = status_.fixed_shutter = 0;\n>>> -\tfixed_analogue_gain_ = status_.fixed_analogue_gain = 0.0;\n>>> -\t// set to zero initially, so we can tell it's not been calculated\n>>\n>> Is there any benefit to retaining this comment in some adjusted form?\n>>\n>> Otherwise, I think generally clearing/initialising the whole status\n>> sounds good.\n>>\n>> Reviewed-by: Kieran Bingham \n> \n> Ahem, coming back to correct myself - This patch introduces a defect.\n> However you fix it in 4/4 ... so ... well ... There's a problem. But\n> you've fixed it ;-)\n\nOh, indeed. I was a bit too hasty =).\n\n Tomi","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 12DCBBEEE0\n\tfor ;\n\tWed, 7 Oct 2020 12:49:32 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D56EB605A8;\n\tWed, 7 Oct 2020 14:49:31 +0200 (CEST)","from mail-lf1-x144.google.com (mail-lf1-x144.google.com\n\t[IPv6:2a00:1450:4864:20::144])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BF38F6055E\n\tfor ;\n\tWed, 7 Oct 2020 14:49:30 +0200 (CEST)","by mail-lf1-x144.google.com with SMTP id g2so2119273lfr.10\n\tfor ;\n\tWed, 07 Oct 2020 05:49:30 -0700 (PDT)","from [192.168.1.111] (91-152-83-50.elisa-laajakaista.fi.\n\t[91.152.83.50]) by smtp.gmail.com with ESMTPSA id\n\td7sm339940lja.91.2020.10.07.05.49.29\n\t(version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n\tWed, 07 Oct 2020 05:49:29 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"kbd6wcHN\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=sender:subject:to:references:from:message-id:date:user-agent\n\t:mime-version:in-reply-to:content-language:content-transfer-encoding; \n\tbh=GQjlnPoejVG7knzy3YVtatPH2uNW/yCP/kOWwXgPlrA=;\n\tb=kbd6wcHNf/h9rxeA5hVXHghgDz/0NCSgQs7cQLyDwpmRvr0GEPpH+QNQqlBBVH0Opy\n\trwYcOYEAahUdoHycd/IeezWl+guP57GCD6A83agMthkvRf2EaKvd6UFzXfHmlyIn4A9O\n\thec6qyURMjdRU8UNI6w+QN8KwFN+xgFSI3Vc1AO/VUGB8x8xECbiB/MT0mFiArqmaaAb\n\tc4+61HuB8qvhPZKitp0A6Sq/0cuwwPWj8sJ0XfUK5nL7qYYPKmTkvFxx8ywN8s2Syotq\n\tA7RkgfCvaXkNyCIN7zyPw1/uACNxRjKPCKWUMzNjbPloBzgqPzoEr+eWXem4cXH/J2zp\n\tMRUw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:sender:subject:to:references:from:message-id\n\t:date:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=GQjlnPoejVG7knzy3YVtatPH2uNW/yCP/kOWwXgPlrA=;\n\tb=WfxMEuFBPpF2mam4FcIT6SZzNLfzMD2DhkuA8O6sJeSuiZkK9Kdv2qOHO5Lqr/+bDb\n\tkL9xfOLXUtGTIgAS90GPlBW3IGjm8B14xysUzn/4xkjRMiJOOI3uJxdoSYVoj/af9lRS\n\t+2xA9V/AhuANAvNK9B1WphHH8rZtuuYrdar3FHORT4kIvXHuSTEHqsquLKKhdwI4ZL7p\n\t5n0UvNlebmNYr31EoR88NGlbPfDXZiHjLIagxoIR90Rp1M1wEoD20mMR2S1ESLV7+/3Y\n\tUPko/fNnnab3PJi8DUEVSaKDq6lypqJVSPkaiCoyK61Wxghry7qnbpMRtuwZ1PimDvLX\n\td66w==","X-Gm-Message-State":"AOAM530qOcHVdNJC8RbGu9p6rR2lCnW7bjDvsU/3MzHEDuR4yCKHkkwJ\n\tkxHJY9l06IqMbhbuGoPquVs=","X-Google-Smtp-Source":"ABdhPJwLURdeaw48k8lE4Th4d1AnhVEpsaFrJXTdz+MuaWiJOTxp1htUjuz+beTeZsdslMuF+l7Npg==","X-Received":"by 2002:a19:254:: with SMTP id 81mr835770lfc.405.1602074970156; \n\tWed, 07 Oct 2020 05:49:30 -0700 (PDT)","To":"kieran.bingham@ideasonboard.com, libcamera-devel@lists.libcamera.org,\n\tNaushir Patuck ,\n\tDavid Plowman ","References":"<20201007110743.55561-1-tomi.valkeinen@iki.fi>\n\t<20201007110743.55561-3-tomi.valkeinen@iki.fi>\n\t<7ce14c49-9628-c779-b750-645a2c69d5cb@ideasonboard.com>\n\t<381e039e-bfd8-8be1-5c34-74980ba224a2@ideasonboard.com>","From":"Tomi Valkeinen ","Message-ID":"<4f5bb8af-bb9c-290c-bc33-ce3be1b1a547@iki.fi>","Date":"Wed, 7 Oct 2020 15:49:28 +0300","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"<381e039e-bfd8-8be1-5c34-74980ba224a2@ideasonboard.com>","Content-Language":"en-US","Subject":"Re: [libcamera-devel] [PATCH 2/4] ipa: raspberrypi: fix missing\n\tinitialize of status_","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":13063,"web_url":"https://patchwork.libcamera.org/comment/13063/","msgid":"","date":"2020-10-07T13:16:41","subject":"Re: [libcamera-devel] [PATCH 2/4] ipa: raspberrypi: fix missing\n\tinitialize of status_","submitter":{"id":42,"url":"https://patchwork.libcamera.org/api/people/42/","name":"David Plowman","email":"david.plowman@raspberrypi.com"},"content":"Hi Tomi\n\nThank you for this patch. You are indeed correct, it is much tidier.\n\nHowever, I'd quite like to hold off with this patch (and the related\npatch 4/4) as I'm currently doing some maintenance on the AGC and\nwould like to avoid a conflict! As part of that maintenance I'll be\nsure to grab the memset here, though I may leave the other\ninitialisations here (rather than move them to the header file) as\nthat seems to be the current style.\n\nSo please be sure to check I've done the right thing when I submit my\nset of AGC patches, hopefully early next week.\n\nThanks and best regards\nDavid\n\nOn Wed, 7 Oct 2020 at 13:49, Tomi Valkeinen wrote:\n>\n> On 07/10/2020 15:48, Kieran Bingham wrote:\n> > On 07/10/2020 13:35, Kieran Bingham wrote:\n> >> Hi Tomi,\n> >>\n> >> On 07/10/2020 12:07, Tomi Valkeinen wrote:\n> >>> Many fields in status_ are not initialized, causing use of uninitialized\n> >>> memory.\n> >>>\n> >>> Drop the code that clears some of the individual fields, and instead\n> >>> just memset the whole thing.\n> >>>\n> >>\n> >> I think David/Naush' input will be important on this one.\n> >>\n> >>> Signed-off-by: Tomi Valkeinen \n> >>> ---\n> >>> src/ipa/raspberrypi/controller/rpi/agc.cpp | 8 +-------\n> >>> 1 file changed, 1 insertion(+), 7 deletions(-)\n> >>>\n> >>> diff --git a/src/ipa/raspberrypi/controller/rpi/agc.cpp b/src/ipa/raspberrypi/controller/rpi/agc.cpp\n> >>> index df4d364..9e75178 100644\n> >>> --- a/src/ipa/raspberrypi/controller/rpi/agc.cpp\n> >>> +++ b/src/ipa/raspberrypi/controller/rpi/agc.cpp\n> >>> @@ -148,14 +148,8 @@ Agc::Agc(Controller *controller)\n> >>> exposure_mode_(nullptr), constraint_mode_(nullptr),\n> >>> frame_count_(0), lock_count_(0)\n> >>> {\n> >>> + memset(&status_, 0, sizeof(status_));\n> >>> ev_ = status_.ev = 1.0;\n> >>> - flicker_period_ = status_.flicker_period = 0.0;\n> >>> - fixed_shutter_ = status_.fixed_shutter = 0;\n> >>> - fixed_analogue_gain_ = status_.fixed_analogue_gain = 0.0;\n> >>> - // set to zero initially, so we can tell it's not been calculated\n> >>\n> >> Is there any benefit to retaining this comment in some adjusted form?\n> >>\n> >> Otherwise, I think generally clearing/initialising the whole status\n> >> sounds good.\n> >>\n> >> Reviewed-by: Kieran Bingham \n> >\n> > Ahem, coming back to correct myself - This patch introduces a defect.\n> > However you fix it in 4/4 ... so ... well ... There's a problem. But\n> > you've fixed it ;-)\n>\n> Oh, indeed. I was a bit too hasty =).\n>\n> Tomi","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A4265BEEDF\n\tfor ;\n\tWed, 7 Oct 2020 13:16:55 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 42B6B60579;\n\tWed, 7 Oct 2020 15:16:55 +0200 (CEST)","from mail-oi1-x243.google.com (mail-oi1-x243.google.com\n\t[IPv6:2607:f8b0:4864:20::243])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CD6726055E\n\tfor ;\n\tWed, 7 Oct 2020 15:16:53 +0200 (CEST)","by mail-oi1-x243.google.com with SMTP id u126so2293045oif.13\n\tfor ;\n\tWed, 07 Oct 2020 06:16:53 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"QGUxwhLc\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=7gOYgPRlX9bayHllgCqliA4wvdtsGvyUO2iJ4ZNpxMs=;\n\tb=QGUxwhLcrRbJl/JSMaXuGKnZbhg6Jsl4Lxioqyr/ybAJREO24AiXegi0EJrNVlQiQl\n\t+BG2oH36Iob9mtpbBeluIjtKSPpPXpdGsISEN13DO+qOQG6MMbpMDfIOOLjo42swpSfl\n\t//mhL76jZr5U65R1IJX5NatnZnbrIbMyTkqtgR+Qjg5rUXb3iAORAaNC3YQLgyCv0dLa\n\tmAZDqm10UzQCaetDSy2D6EFGh7thiwcttIFuTZge+wsEJfERRU4wsnapY5HfrWbJzWV1\n\tH/TRly4PKETx8vO9iXOxTDbWMXXpnep0rGLK71f94LCyg6TrF/FgDVx/HRj8a60GEgkn\n\tCB4w==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=7gOYgPRlX9bayHllgCqliA4wvdtsGvyUO2iJ4ZNpxMs=;\n\tb=tv08maRhFeNRgM4gFhF2yH7w48dWl+b7o+nhuvoJuNbEJhd4/j8HB2InOJVsi+a5LV\n\twv0P25fzTOaW1l5cnPFh7BrRbQqj03hv6SGrqH+nyCYYxfSl1vYq8vhAUPtRB1mVJJUs\n\tvIm4UG96+mKXhpI+kmgc7ztPjxPv3XOgYhWro1av6XqrqLfPDMQR2eOszpTc25syHnJO\n\tALZNhE7N7STcF4lc7rgPBpQu0590yO1cj5VixXJcTPsZwOoaadx9rUNzAD1KjWdg8k0C\n\teVZM9taqLGPRiEtFpV/UUOARdfv6VyjJTQs041KsRIONB0g7V4xjlnOXngXmXAP41bKa\n\tITcA==","X-Gm-Message-State":"AOAM53382R5cUPjbD6ecP1aRUm1NI1TanJPMLwmrrk3FzQVtsaj4m7UH\n\trAXYFGD5jzJ7I7XdCNSG0wUKMw2AFk3YpkzegupjvA==","X-Google-Smtp-Source":"ABdhPJykJftMQaSKZnlmhbnn5x2/NbFyD7r65Nf8sbHFyEUj/qHDs5CMFT1QnEQvIP5mhHD9NGfl97bdqq9OzOym0sk=","X-Received":"by 2002:aca:ef89:: with SMTP id\n\tn131mr1822270oih.22.1602076612696; \n\tWed, 07 Oct 2020 06:16:52 -0700 (PDT)","MIME-Version":"1.0","References":"<20201007110743.55561-1-tomi.valkeinen@iki.fi>\n\t<20201007110743.55561-3-tomi.valkeinen@iki.fi>\n\t<7ce14c49-9628-c779-b750-645a2c69d5cb@ideasonboard.com>\n\t<381e039e-bfd8-8be1-5c34-74980ba224a2@ideasonboard.com>\n\t<4f5bb8af-bb9c-290c-bc33-ce3be1b1a547@iki.fi>","In-Reply-To":"<4f5bb8af-bb9c-290c-bc33-ce3be1b1a547@iki.fi>","From":"David Plowman ","Date":"Wed, 7 Oct 2020 14:16:41 +0100","Message-ID":"","To":"Tomi Valkeinen ","Subject":"Re: [libcamera-devel] [PATCH 2/4] ipa: raspberrypi: fix missing\n\tinitialize of status_","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]