[{"id":13047,"web_url":"https://patchwork.libcamera.org/comment/13047/","msgid":"","date":"2020-10-07T12:32:40","subject":"Re: [libcamera-devel] [PATCH 1/4] ipa: raspberrypi: fix bin_x\n\tcalculation","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Tomi,\n\nOn 07/10/2020 12:07, Tomi Valkeinen wrote:\n> I presume this code is supposed to set bin_x and bin_y, and not bin_y\n> two times. This caused use of uninitialized variable later when bin_x\n> was used.\n> \n\nAyeee - indeed this looks accurate to me.\n\nReviewed-by: Kieran Bingham \n\n\n> Signed-off-by: Tomi Valkeinen \n> ---\n> src/ipa/raspberrypi/raspberrypi.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/ipa/raspberrypi/raspberrypi.cpp b/src/ipa/raspberrypi/raspberrypi.cpp\n> index b0c7d1c..48a72dd 100644\n> --- a/src/ipa/raspberrypi/raspberrypi.cpp\n> +++ b/src/ipa/raspberrypi/raspberrypi.cpp\n> @@ -178,7 +178,7 @@ void IPARPi::setMode(const CameraSensorInfo &sensorInfo)\n> \t *\n> \t * \\todo Get the pipeline handle to provide the full data\n> \t */\n> -\tmode_.bin_y = std::min(2, static_cast(mode_.scale_x));\n> +\tmode_.bin_x = std::min(2, static_cast(mode_.scale_x));\n> \tmode_.bin_y = std::min(2, static_cast(mode_.scale_y));\n> \n> \t/* The noise factor is the square root of the total binning factor. */\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D9FBCBEEE0\n\tfor ;\n\tWed, 7 Oct 2020 12:32:44 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 718036055E;\n\tWed, 7 Oct 2020 14:32:44 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4C67660553\n\tfor ;\n\tWed, 7 Oct 2020 14:32:43 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 99E209DA;\n\tWed, 7 Oct 2020 14:32:42 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"HBy1sOrl\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1602073962;\n\tbh=zK5GyZeItoKDVfOkFKe2LRZ7ir8YxKYNnXgZsfJUiLI=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=HBy1sOrl15oylP5oJhFS42eNv8ryazOP1mMmNCmF8X3AEkpUIDDZ+T/tFi8lveWeC\n\tps2UHiu9DK1jxqexerda+iCGrttqVXHHCMPNJbo2huWP7C/nGc1xBa0XT/2D2R8cqZ\n\tjuyBoaH0045ftd+g0JD+glRE1nBr8F9uNHay1fcQ=","To":"Tomi Valkeinen ,\n\tlibcamera-devel@lists.libcamera.org,\n\tNaushir Patuck , \n\tDavid Plowman ","References":"<20201007110743.55561-1-tomi.valkeinen@iki.fi>\n\t<20201007110743.55561-2-tomi.valkeinen@iki.fi>","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"","Date":"Wed, 7 Oct 2020 13:32:40 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"<20201007110743.55561-2-tomi.valkeinen@iki.fi>","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [PATCH 1/4] ipa: raspberrypi: fix bin_x\n\tcalculation","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"kieran.bingham@ideasonboard.com","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":13059,"web_url":"https://patchwork.libcamera.org/comment/13059/","msgid":"","date":"2020-10-07T13:05:09","subject":"Re: [libcamera-devel] [PATCH 1/4] ipa: raspberrypi: fix bin_x\n\tcalculation","submitter":{"id":42,"url":"https://patchwork.libcamera.org/api/people/42/","name":"David Plowman","email":"david.plowman@raspberrypi.com"},"content":"Hi Tomi\n\nOn Wed, 7 Oct 2020 at 13:32, Kieran Bingham\n wrote:\n>\n> Hi Tomi,\n>\n> On 07/10/2020 12:07, Tomi Valkeinen wrote:\n> > I presume this code is supposed to set bin_x and bin_y, and not bin_y\n> > two times. This caused use of uninitialized variable later when bin_x\n> > was used.\n> >\n>\n> Ayeee - indeed this looks accurate to me.\n>\n> Reviewed-by: Kieran Bingham \n>\n\nIndeed!\n\nReviewed-by: David Plowman \n\nThanks very much for this patch!\n\nBest regards\nDavid\n\n>\n> > Signed-off-by: Tomi Valkeinen \n> > ---\n> > src/ipa/raspberrypi/raspberrypi.cpp | 2 +-\n> > 1 file changed, 1 insertion(+), 1 deletion(-)\n> >\n> > diff --git a/src/ipa/raspberrypi/raspberrypi.cpp b/src/ipa/raspberrypi/raspberrypi.cpp\n> > index b0c7d1c..48a72dd 100644\n> > --- a/src/ipa/raspberrypi/raspberrypi.cpp\n> > +++ b/src/ipa/raspberrypi/raspberrypi.cpp\n> > @@ -178,7 +178,7 @@ void IPARPi::setMode(const CameraSensorInfo &sensorInfo)\n> > *\n> > * \\todo Get the pipeline handle to provide the full data\n> > */\n> > - mode_.bin_y = std::min(2, static_cast(mode_.scale_x));\n> > + mode_.bin_x = std::min(2, static_cast(mode_.scale_x));\n> > mode_.bin_y = std::min(2, static_cast(mode_.scale_y));\n> >\n> > /* The noise factor is the square root of the total binning factor. */\n> >\n>\n> --\n> Regards\n> --\n> Kieran","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id EA8AFBEEDF\n\tfor ;\n\tWed, 7 Oct 2020 13:05:23 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id ACB6A605A8;\n\tWed, 7 Oct 2020 15:05:23 +0200 (CEST)","from mail-ot1-x342.google.com (mail-ot1-x342.google.com\n\t[IPv6:2607:f8b0:4864:20::342])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C30AF6055E\n\tfor ;\n\tWed, 7 Oct 2020 15:05:22 +0200 (CEST)","by mail-ot1-x342.google.com with SMTP id m13so2069400otl.9\n\tfor ;\n\tWed, 07 Oct 2020 06:05:22 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"F/AvIzEH\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=tRr2RdPNoFxsFa2QWUffHJ/UsWc/o7KTvOTIP+/bKAA=;\n\tb=F/AvIzEHOHUzSlGPoHe0DKhZ/2s1kg4nSD6OuROzmZaOfJJV058NQrRe3R8qIV2wKx\n\tt44nQb7+AfFr4zw7t4O3vwK15AXDQp0Ii3z3TNTnv+whvCUBBSXsBLfdr7wcpGsKTCT2\n\t5ntdHoOtYY6YFBdkOq7cvrCYq9AL1+cumG52N4FsVrBESIiGkO6cMxcz13mFWSkMi96h\n\tJlZzgnEKRfHNDx1Z5Bqn/eIO2UYsce4yXYwfLvNtrOUIlE81Ef8NFOi78Etc7zoakNEg\n\t31Xh3feQ1uTawc8OLvfSLvBBk6PLh35RIMo0U+Wgcww848Gr/A4YxzvuKDmdDwFRpTUG\n\t88OQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=tRr2RdPNoFxsFa2QWUffHJ/UsWc/o7KTvOTIP+/bKAA=;\n\tb=NkOAw+b4rNS4WY7pNgBJT0OfKbAryFsIXrbpVDsxY2HnGDSWamELjMkuAj+suRCSHR\n\tRNwBF3WuRjzfVMCehOUY/wmhiVXy2Q6ZaW7XarTWOsQ81KjzY5QizZ7qHAWsxp2Zgw5R\n\tJhklU5s/vGQpm3YGSnHyPbUsd2BqlPUChzerbC3tzIA1uIw65hnE43Wv4WNhN2iS3hXz\n\tLoeIy79/hTHlpYt6FADCsvokEaw11GwqEgiextuZPJ0CtvVxkQwVnL7DxwDqfaZA84fv\n\t8LzhuY+xbfhtqcxXD5NMxtheYHXnaaIHH6EcO3LIckg/7ENf7NN8D/1C7ZGxapVOVbk5\n\t7FjQ==","X-Gm-Message-State":"AOAM530x6QHAVYgwRSusJi0bPThyX1ruFdZP/Tu6G+uYpZXvXHNNoQ5h\n\tFaatyL9vU/qE5vGBc6XpIvKKoiZj/VL7RZTPBn7l/Q==","X-Google-Smtp-Source":"ABdhPJxgDjeHJEDt1d/rBeKfXExZz0IHtD9R4xFurg4BEhl5NTg8pzXUvICEs2YDnmg18znqZ5yX4BK1WtrYJcupXks=","X-Received":"by 2002:a9d:7f9a:: with SMTP id\n\tt26mr1840244otp.317.1602075921644; \n\tWed, 07 Oct 2020 06:05:21 -0700 (PDT)","MIME-Version":"1.0","References":"<20201007110743.55561-1-tomi.valkeinen@iki.fi>\n\t<20201007110743.55561-2-tomi.valkeinen@iki.fi>\n\t","In-Reply-To":"","From":"David Plowman ","Date":"Wed, 7 Oct 2020 14:05:09 +0100","Message-ID":"","To":"Kieran Bingham ","Subject":"Re: [libcamera-devel] [PATCH 1/4] ipa: raspberrypi: fix bin_x\n\tcalculation","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org,\n\tTomi Valkeinen ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]