{"id":10005,"url":"https://patchwork.libcamera.org/api/patches/10005/?format=json","web_url":"https://patchwork.libcamera.org/patch/10005/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20201007101745.15104-14-jacopo@jmondi.org>","date":"2020-10-07T10:17:45","name":"[libcamera-devel,v3,13/13] android: camera_device: Clear streams_ at stop time","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"dac320b60160eb42ee7ff02a2e1a46f7877e950e","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/?format=json","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/10005/mbox/","series":[{"id":1361,"url":"https://patchwork.libcamera.org/api/series/1361/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1361","date":"2020-10-07T10:17:32","name":"android: CameraStream rework","version":3,"mbox":"https://patchwork.libcamera.org/series/1361/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/10005/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/10005/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6EC7BBEEDF\n\tfor ;\n\tWed, 7 Oct 2020 10:14:10 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 48CC860423;\n\tWed, 7 Oct 2020 12:14:10 +0200 (CEST)","from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net\n\t[217.70.183.195])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BC2DA6049A\n\tfor ;\n\tWed, 7 Oct 2020 12:14:08 +0200 (CEST)","from uno.lan (93-34-118-233.ip49.fastwebnet.it [93.34.118.233])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay3-d.mail.gandi.net (Postfix) with ESMTPSA id 19BB260012;\n\tWed, 7 Oct 2020 10:14:06 +0000 (UTC)"],"X-Originating-IP":"93.34.118.233","From":"Jacopo Mondi ","To":"libcamera-devel@lists.libcamera.org","Date":"Wed, 7 Oct 2020 12:17:45 +0200","Message-Id":"<20201007101745.15104-14-jacopo@jmondi.org>","X-Mailer":"git-send-email 2.28.0","In-Reply-To":"<20201007101745.15104-1-jacopo@jmondi.org>","References":"<20201007101745.15104-1-jacopo@jmondi.org>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH v3 13/13] android: camera_device: Clear\n\tstreams_ at stop time","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"When the CameraDevice is stopped, we need to clear the vector\nof CameraStream instances to make sure they get deleted and all the\nresources they have acquired get released.\n\nReviewed-by: Umang Jain \nReviewed-by: Kieran Bingham \nReviewed-by: Laurent Pinchart \nSigned-off-by: Jacopo Mondi \n---\n src/android/camera_device.cpp | 2 ++\n 1 file changed, 2 insertions(+)","diff":"diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\nindex c6b6fe4b3ae3..0a94c1ae17ac 100644\n--- a/src/android/camera_device.cpp\n+++ b/src/android/camera_device.cpp\n@@ -517,6 +517,8 @@ int CameraDevice::open(const hw_module_t *hardwareModule)\n \n void CameraDevice::close()\n {\n+\tstreams_.clear();\n+\n \tcamera_->stop();\n \tcamera_->release();\n \n","prefixes":["libcamera-devel","v3","13/13"]}