[{"id":12920,"web_url":"https://patchwork.libcamera.org/comment/12920/","msgid":"<20201001164834.GC3722@pendragon.ideasonboard.com>","date":"2020-10-01T16:48:34","subject":"Re: [libcamera-devel] [PATCH v2 0/6] libcamera: pipeline: rkisp1:\n\tRefresh to match upstream","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Niklas,\n\nThank you for the patches.\n\nOn Thu, Oct 01, 2020 at 05:45:54PM +0200, Niklas Söderlund wrote:\n> Hello,\n> \n> This series refresh the RkISP1 pipeline handler to match what is in the\n> media-tree. As the upstream driver is in staging and bound to change\n> quiet a bit no attempt to keep the libcamera pipeline backwards\n> compatible have been made. To fully test this on must run a system no\n> older then [1] from the linux-media tree.\n> \n> Running a system newer then v5.8 without this series will also fail as\n> there are upstream changes breaking current libcamera master.\n> \n> Apart from aligning the pipeline with the upstream driver it's now\n> trivial to enable support for R8, RGB656 and XBGR8888 in the pipeline.\n> As these have been troublesome in the past due to issues now fixed\n> upstream every format supported by the pipeline (YUYV, NV16, NV61, NV21,\n> NV12, R8, RGB565 and XRGB8888) have been retested and converted using\n> raw2rgbpnm to validate that the captured data is good.\n> \n> 1. 7eba47ab7a310ed8 (\"media: staging: rkisp1: cap: protect access to buf with the spin lock\") \n> \n> Niklas Söderlund (6):\n> libcamera: pipeline: rkisp1: Remove support for YVYU and VYUY\n> libcamera: pipeline: rkisp1: Fix media bus propagation for NV{12,21}\n> libcamera: pipeline: rkisp1: Add support for RGB656\n> libcamera: pipeline: rkisp1: Add support for R8\n> libcamera: Add support for XRGB8888 and XBGR8888\n> libcamera: pipeline: rkisp1: Add support for XRGB8888\n\nFor the whole series,\n\nReviewed-by: Laurent Pinchart \n\nCould you however please follow up with upstream to replace\nMEDIA_BUS_FMT_YUYV8_1_5X8 with MEDIA_BUS_FMT_YUYV8_1X16 ?\n\n> src/libcamera/formats.cpp | 20 ++++++++++++++\n> src/libcamera/pipeline/rkisp1/rkisp1_path.cpp | 27 +++++++++++++------\n> src/libcamera/v4l2_pixelformat.cpp | 2 ++\n> 3 files changed, 41 insertions(+), 8 deletions(-)\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 00CDAC3B5C\n\tfor ;\n\tThu, 1 Oct 2020 16:49:13 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 874F16035F;\n\tThu, 1 Oct 2020 18:49:13 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3D88F6035F\n\tfor ;\n\tThu, 1 Oct 2020 18:49:12 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id AA8C660;\n\tThu, 1 Oct 2020 18:49:11 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"tIcC+F/9\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1601570951;\n\tbh=IUTevINcJj5uloSD6AHhFSb1EUz3KlAK/qHJzN1bBq4=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=tIcC+F/9EqMUcBUtdUUh3O/F7/hYJFz8Li0i8fGRVi344gzXofdAl5pS7VsMTi8xA\n\tKjT5o22PS9UdO0uBA6XsiPpAHpYlIaBh+Z2mh6nmDCU+7FHbCeb1ncAkis6YBmAy2d\n\t14Oweb82upOmmcRkeoSv9mGRhvqpHQ4YUi3W89SU=","Date":"Thu, 1 Oct 2020 19:48:34 +0300","From":"Laurent Pinchart ","To":"Niklas =?utf-8?q?S=C3=B6derlund?= ","Message-ID":"<20201001164834.GC3722@pendragon.ideasonboard.com>","References":"<20201001154600.2722718-1-niklas.soderlund@ragnatech.se>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20201001154600.2722718-1-niklas.soderlund@ragnatech.se>","Subject":"Re: [libcamera-devel] [PATCH v2 0/6] libcamera: pipeline: rkisp1:\n\tRefresh to match upstream","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":12921,"web_url":"https://patchwork.libcamera.org/comment/12921/","msgid":"<20201001202619.oskf27ndmcxagffz@oden.dyn.berto.se>","date":"2020-10-01T20:26:19","subject":"Re: [libcamera-devel] [PATCH v2 0/6] libcamera: pipeline: rkisp1:\n\tRefresh to match upstream","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Laurent,\n\nThanks for your feedback.\n\nOn 2020-10-01 19:48:34 +0300, Laurent Pinchart wrote:\n> Hi Niklas,\n> \n> Thank you for the patches.\n> \n> On Thu, Oct 01, 2020 at 05:45:54PM +0200, Niklas Söderlund wrote:\n> > Hello,\n> > \n> > This series refresh the RkISP1 pipeline handler to match what is in the\n> > media-tree. As the upstream driver is in staging and bound to change\n> > quiet a bit no attempt to keep the libcamera pipeline backwards\n> > compatible have been made. To fully test this on must run a system no\n> > older then [1] from the linux-media tree.\n> > \n> > Running a system newer then v5.8 without this series will also fail as\n> > there are upstream changes breaking current libcamera master.\n> > \n> > Apart from aligning the pipeline with the upstream driver it's now\n> > trivial to enable support for R8, RGB656 and XBGR8888 in the pipeline.\n> > As these have been troublesome in the past due to issues now fixed\n> > upstream every format supported by the pipeline (YUYV, NV16, NV61, NV21,\n> > NV12, R8, RGB565 and XRGB8888) have been retested and converted using\n> > raw2rgbpnm to validate that the captured data is good.\n> > \n> > 1. 7eba47ab7a310ed8 (\"media: staging: rkisp1: cap: protect access to buf with the spin lock\") \n> > \n> > Niklas Söderlund (6):\n> > libcamera: pipeline: rkisp1: Remove support for YVYU and VYUY\n> > libcamera: pipeline: rkisp1: Fix media bus propagation for NV{12,21}\n> > libcamera: pipeline: rkisp1: Add support for RGB656\n> > libcamera: pipeline: rkisp1: Add support for R8\n> > libcamera: Add support for XRGB8888 and XBGR8888\n> > libcamera: pipeline: rkisp1: Add support for XRGB8888\n> \n> For the whole series,\n> \n> Reviewed-by: Laurent Pinchart \n\nThanks.\n\n> \n> Could you however please follow up with upstream to replace\n> MEDIA_BUS_FMT_YUYV8_1_5X8 with MEDIA_BUS_FMT_YUYV8_1X16 ?\n\nI will follow up on this yes.\n\n> \n> > src/libcamera/formats.cpp | 20 ++++++++++++++\n> > src/libcamera/pipeline/rkisp1/rkisp1_path.cpp | 27 +++++++++++++------\n> > src/libcamera/v4l2_pixelformat.cpp | 2 ++\n> > 3 files changed, 41 insertions(+), 8 deletions(-)\n> > \n> \n> -- \n> Regards,\n> \n> Laurent Pinchart","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 34D5FC3B5B\n\tfor ;\n\tThu, 1 Oct 2020 20:26:23 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9452460394;\n\tThu, 1 Oct 2020 22:26:22 +0200 (CEST)","from mail-lj1-x241.google.com (mail-lj1-x241.google.com\n\t[IPv6:2a00:1450:4864:20::241])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B79F46035F\n\tfor ;\n\tThu, 1 Oct 2020 22:26:21 +0200 (CEST)","by mail-lj1-x241.google.com with SMTP id v23so5776609ljd.1\n\tfor ;\n\tThu, 01 Oct 2020 13:26:21 -0700 (PDT)","from localhost (h-209-203.A463.priv.bahnhof.se. [155.4.209.203])\n\tby smtp.gmail.com with ESMTPSA id\n\tj7sm691825lfb.41.2020.10.01.13.26.20\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 01 Oct 2020 13:26:20 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=ragnatech-se.20150623.gappssmtp.com\n\theader.i=@ragnatech-se.20150623.gappssmtp.com\n\theader.b=\"c9H2boGV\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=Nx/4DZ9ydzv/VFcrnTy15DZ+AuQt/eAU2qoQhimBTwI=;\n\tb=c9H2boGVc22BSiGEWy9aqYeK1YxEUh9FNbFgAGYp8EWlocGfZUAEnhF2w9KGdLsga0\n\tEsgdWsXs5h0P12ZnBI4wMDi5xngyQegKdc10MVfEJGM7AJ8WDsUnec2bYZTyV3pS+8rK\n\tYprLFIPUHZb5UuHucyPn11uipWSXrVx+VBcMCT/fdR+TL/ijfW46r4tUCUfJPfg6WjOn\n\t92z8d3S9lXf+jq5DUGqvZUeS8eVWNVfaH2yJIb18siTUg+3JP2RaL3fGraffl7hJzBPV\n\tYcJDT7EdJbjp0j83euYMbxUeA2bKdRIH4ZReOQ96vhJkQ3hJz6O3RdSeh2wxMByO5qx7\n\tGMrg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=Nx/4DZ9ydzv/VFcrnTy15DZ+AuQt/eAU2qoQhimBTwI=;\n\tb=K7vVPh/SMptEtThXM/C1VsGE+3abgnl358YaEmeDXwgS5TR9SQMt++TChuLrt42qzq\n\tLmvaDO5L4COHL0L5xze0nEewKoDqkbFd9vnxuJoAEogAls9cA1v/Lz39VrrexjlrzloD\n\t1JzFIaMtcvp0PREmUlYaQPd2NLpnrnrHYsN2U9u1eabZzDLvzS+7pQITSAMCgG54Q/U7\n\tJDg5l5zMR5Wk6j6hA2aW4ZxHST/IZG7DIIUvHGxcj+Hm/GUhCR4aNoYRXvasqxwNo5Ro\n\tqxTjeTFSv19lR59cTrQfkRSEWtRAE/ClPJbonnikW7Xumj+bE1aEefVnBnbQU183TO3H\n\tem7Q==","X-Gm-Message-State":"AOAM533YcNKgChQt8k4N3wKdpOwJoI+XspyMy6/1adQ1t8mS1GAqHXUR\n\tcicvEoHHvye5Ki3Ce/lhozpZUafl0LR+uQ==","X-Google-Smtp-Source":"ABdhPJz19CBnDzZxUF9agAZn8wmbiY+YMc7hpySTR46bWJeKmormj+EjaYsSgf0jhtSLtnjs5548eg==","X-Received":"by 2002:a2e:b4f5:: with SMTP id\n\ts21mr3017967ljm.270.1601583980926; \n\tThu, 01 Oct 2020 13:26:20 -0700 (PDT)","Date":"Thu, 1 Oct 2020 22:26:19 +0200","From":"Niklas =?utf-8?q?S=C3=B6derlund?= ","To":"Laurent Pinchart ","Message-ID":"<20201001202619.oskf27ndmcxagffz@oden.dyn.berto.se>","References":"<20201001154600.2722718-1-niklas.soderlund@ragnatech.se>\n\t<20201001164834.GC3722@pendragon.ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20201001164834.GC3722@pendragon.ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v2 0/6] libcamera: pipeline: rkisp1:\n\tRefresh to match upstream","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"iso-8859-1\"","Content-Transfer-Encoding":"quoted-printable","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":12943,"web_url":"https://patchwork.libcamera.org/comment/12943/","msgid":"<20201002141253.vf6427rztt3zarrl@uno.localdomain>","date":"2020-10-02T14:12:53","subject":"Re: [libcamera-devel] [PATCH v2 0/6] libcamera: pipeline: rkisp1:\n\tRefresh to match upstream","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Niklas,\n\nOn Thu, Oct 01, 2020 at 07:48:34PM +0300, Laurent Pinchart wrote:\n> Hi Niklas,\n>\n> Thank you for the patches.\n>\n> On Thu, Oct 01, 2020 at 05:45:54PM +0200, Niklas Söderlund wrote:\n> > Hello,\n> >\n> > This series refresh the RkISP1 pipeline handler to match what is in the\n> > media-tree. As the upstream driver is in staging and bound to change\n> > quiet a bit no attempt to keep the libcamera pipeline backwards\n> > compatible have been made. To fully test this on must run a system no\n> > older then [1] from the linux-media tree.\n> >\n> > Running a system newer then v5.8 without this series will also fail as\n> > there are upstream changes breaking current libcamera master.\n> >\n> > Apart from aligning the pipeline with the upstream driver it's now\n> > trivial to enable support for R8, RGB656 and XBGR8888 in the pipeline.\n> > As these have been troublesome in the past due to issues now fixed\n> > upstream every format supported by the pipeline (YUYV, NV16, NV61, NV21,\n> > NV12, R8, RGB565 and XRGB8888) have been retested and converted using\n> > raw2rgbpnm to validate that the captured data is good.\n> >\n> > 1. 7eba47ab7a310ed8 (\"media: staging: rkisp1: cap: protect access to buf with the spin lock\")\n> >\n> > Niklas Söderlund (6):\n> > libcamera: pipeline: rkisp1: Remove support for YVYU and VYUY\n> > libcamera: pipeline: rkisp1: Fix media bus propagation for NV{12,21}\n> > libcamera: pipeline: rkisp1: Add support for RGB656\n> > libcamera: pipeline: rkisp1: Add support for R8\n> > libcamera: Add support for XRGB8888 and XBGR8888\n> > libcamera: pipeline: rkisp1: Add support for XRGB8888\n>\n> For the whole series,\n>\n> Reviewed-by: Laurent Pinchart \n\nWith the small comments clarified, for the series:\n\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n>\n> Could you however please follow up with upstream to replace\n> MEDIA_BUS_FMT_YUYV8_1_5X8 with MEDIA_BUS_FMT_YUYV8_1X16 ?\n>\n> > src/libcamera/formats.cpp | 20 ++++++++++++++\n> > src/libcamera/pipeline/rkisp1/rkisp1_path.cpp | 27 +++++++++++++------\n> > src/libcamera/v4l2_pixelformat.cpp | 2 ++\n> > 3 files changed, 41 insertions(+), 8 deletions(-)\n> >\n>\n> --\n> Regards,\n>\n> Laurent Pinchart\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2E13CC3B5B\n\tfor ;\n\tFri, 2 Oct 2020 14:08:58 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0986263B72;\n\tFri, 2 Oct 2020 16:08:58 +0200 (CEST)","from relay6-d.mail.gandi.net (relay6-d.mail.gandi.net\n\t[217.70.183.198])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C651463B59\n\tfor ;\n\tFri, 2 Oct 2020 16:08:56 +0200 (CEST)","from uno.localdomain (93-34-118-233.ip49.fastwebnet.it\n\t[93.34.118.233]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay6-d.mail.gandi.net (Postfix) with ESMTPSA id 1A6BCC000B;\n\tFri, 2 Oct 2020 14:08:55 +0000 (UTC)"],"X-Originating-IP":"93.34.118.233","Date":"Fri, 2 Oct 2020 16:12:53 +0200","From":"Jacopo Mondi ","To":"Laurent Pinchart ","Message-ID":"<20201002141253.vf6427rztt3zarrl@uno.localdomain>","References":"<20201001154600.2722718-1-niklas.soderlund@ragnatech.se>\n\t<20201001164834.GC3722@pendragon.ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20201001164834.GC3722@pendragon.ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v2 0/6] libcamera: pipeline: rkisp1:\n\tRefresh to match upstream","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":12948,"web_url":"https://patchwork.libcamera.org/comment/12948/","msgid":"<20201002145201.6pi5uvxj75deqfoy@oden.dyn.berto.se>","date":"2020-10-02T14:52:01","subject":"Re: [libcamera-devel] [PATCH v2 0/6] libcamera: pipeline: rkisp1:\n\tRefresh to match upstream","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Jacopo,\n\nOn 2020-10-02 16:12:53 +0200, Jacopo Mondi wrote:\n> Hi Niklas,\n> \n> On Thu, Oct 01, 2020 at 07:48:34PM +0300, Laurent Pinchart wrote:\n> > Hi Niklas,\n> >\n> > Thank you for the patches.\n> >\n> > On Thu, Oct 01, 2020 at 05:45:54PM +0200, Niklas Söderlund wrote:\n> > > Hello,\n> > >\n> > > This series refresh the RkISP1 pipeline handler to match what is in the\n> > > media-tree. As the upstream driver is in staging and bound to change\n> > > quiet a bit no attempt to keep the libcamera pipeline backwards\n> > > compatible have been made. To fully test this on must run a system no\n> > > older then [1] from the linux-media tree.\n> > >\n> > > Running a system newer then v5.8 without this series will also fail as\n> > > there are upstream changes breaking current libcamera master.\n> > >\n> > > Apart from aligning the pipeline with the upstream driver it's now\n> > > trivial to enable support for R8, RGB656 and XBGR8888 in the pipeline.\n> > > As these have been troublesome in the past due to issues now fixed\n> > > upstream every format supported by the pipeline (YUYV, NV16, NV61, NV21,\n> > > NV12, R8, RGB565 and XRGB8888) have been retested and converted using\n> > > raw2rgbpnm to validate that the captured data is good.\n> > >\n> > > 1. 7eba47ab7a310ed8 (\"media: staging: rkisp1: cap: protect access to buf with the spin lock\")\n> > >\n> > > Niklas Söderlund (6):\n> > > libcamera: pipeline: rkisp1: Remove support for YVYU and VYUY\n> > > libcamera: pipeline: rkisp1: Fix media bus propagation for NV{12,21}\n> > > libcamera: pipeline: rkisp1: Add support for RGB656\n> > > libcamera: pipeline: rkisp1: Add support for R8\n> > > libcamera: Add support for XRGB8888 and XBGR8888\n> > > libcamera: pipeline: rkisp1: Add support for XRGB8888\n> >\n> > For the whole series,\n> >\n> > Reviewed-by: Laurent Pinchart \n> \n> With the small comments clarified, for the series:\n> \n> Reviewed-by: Jacopo Mondi \n\nThanks for reviewing this series, unfortunately the series is already \nmerged so I can't record your effort :-(\n\n> \n> Thanks\n> j\n> \n> >\n> > Could you however please follow up with upstream to replace\n> > MEDIA_BUS_FMT_YUYV8_1_5X8 with MEDIA_BUS_FMT_YUYV8_1X16 ?\n> >\n> > > src/libcamera/formats.cpp | 20 ++++++++++++++\n> > > src/libcamera/pipeline/rkisp1/rkisp1_path.cpp | 27 +++++++++++++------\n> > > src/libcamera/v4l2_pixelformat.cpp | 2 ++\n> > > 3 files changed, 41 insertions(+), 8 deletions(-)\n> > >\n> >\n> > --\n> > Regards,\n> >\n> > Laurent Pinchart\n> > _______________________________________________\n> > libcamera-devel mailing list\n> > libcamera-devel@lists.libcamera.org\n> > https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 67CD4C3B5B\n\tfor ;\n\tFri, 2 Oct 2020 14:52:04 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 06C4A63BDD;\n\tFri, 2 Oct 2020 16:52:04 +0200 (CEST)","from mail-lj1-x242.google.com (mail-lj1-x242.google.com\n\t[IPv6:2a00:1450:4864:20::242])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E2CF563BBF\n\tfor ;\n\tFri, 2 Oct 2020 16:52:02 +0200 (CEST)","by mail-lj1-x242.google.com with SMTP id b19so1406586lji.11\n\tfor ;\n\tFri, 02 Oct 2020 07:52:02 -0700 (PDT)","from localhost (h-209-203.A463.priv.bahnhof.se. [155.4.209.203])\n\tby smtp.gmail.com with ESMTPSA id\n\tb16sm260966ljh.34.2020.10.02.07.52.01\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 02 Oct 2020 07:52:01 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=ragnatech-se.20150623.gappssmtp.com\n\theader.i=@ragnatech-se.20150623.gappssmtp.com\n\theader.b=\"lxGZYGQ0\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=uHuGkr+6rCKzh2H+mf0i8SZAQ4mIIqUCkx6fzb6honI=;\n\tb=lxGZYGQ0nqjF92jXhxO3T2YbVS96IbiRijArIqFNJSSQNLBHFzmYdXRlh68AWk0p/h\n\tEk+Wy1Rwa3aVtnEpBxnqFugEbheIG+iy1s0k6gj/VY015HzZ6mcPMS2Fvyh4Eo97KXDZ\n\tKt95y78oafXzoUTA1rgM7e+1iKGLz6s2QL37wtJyPf+WXlvUqIWBzsCS24aIjHKSTeA4\n\ty9v1GHkYFK/s4ZIdjvv5Qnbb1zFborvFqZB+9HEhb7plDcobckebK5ZVR1oi3fIxBX3/\n\t4uI6ph5394Z6oeOnf4TuFcozIiDcAZx343ocF4osbTdoXcneWxgl+CzfzrP5HWsTTlj4\n\t+b7Q==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=uHuGkr+6rCKzh2H+mf0i8SZAQ4mIIqUCkx6fzb6honI=;\n\tb=mkm4C6ezFPJC7LS+slzrutWzWDBpK648EGi6k/3pTPtL+i6F461FfyfT3mqifRcheL\n\tPAyTYfiDCzleB00tJAH9rUOtE1NAt9Ev+uEN7NQ/hpbt10KkGo3/E//SrCe8U6hazYam\n\tjdIaNNRfDkn3mvdPzwcAGktJYNsC/rjZSBfciRLyAN8TbGIPpjvP4acdHE0et4DI4VUM\n\t20ySXCZNSh6JfUlcCqqHQyAONeUZzQvi25AIW8116vPfEXwcQYNnEA29k16GSpkqNlpX\n\t882/xizdqOf7wv2FxfiZFAd0z9YeTmNUSIvFwDY7EbRU4y1HrpzqUVqljcJKX+dvwD+v\n\tuxWQ==","X-Gm-Message-State":"AOAM5304eSg7cGLzfyeic5g+kOjNItKL5WtOep19+VlV/ku29YIXgWz7\n\tMm09pln962fU7N/HTT4va1gvLp0zS9rTRQ==","X-Google-Smtp-Source":"ABdhPJxC6F35/sjZ6UivZ5OGuEb+JCV3nxxDfNfCjZIX5ySi46iZnAcRVhDk3ZA3UffXYW69z9eEuQ==","X-Received":"by 2002:a2e:8257:: with SMTP id j23mr834690ljh.49.1601650322297; \n\tFri, 02 Oct 2020 07:52:02 -0700 (PDT)","Date":"Fri, 2 Oct 2020 16:52:01 +0200","From":"Niklas =?utf-8?q?S=C3=B6derlund?= ","To":"Jacopo Mondi ","Message-ID":"<20201002145201.6pi5uvxj75deqfoy@oden.dyn.berto.se>","References":"<20201001154600.2722718-1-niklas.soderlund@ragnatech.se>\n\t<20201001164834.GC3722@pendragon.ideasonboard.com>\n\t<20201002141253.vf6427rztt3zarrl@uno.localdomain>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20201002141253.vf6427rztt3zarrl@uno.localdomain>","Subject":"Re: [libcamera-devel] [PATCH v2 0/6] libcamera: pipeline: rkisp1:\n\tRefresh to match upstream","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"iso-8859-1\"","Content-Transfer-Encoding":"quoted-printable","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":12949,"web_url":"https://patchwork.libcamera.org/comment/12949/","msgid":"<20201002150333.77o5ew6btcc7ents@uno.localdomain>","date":"2020-10-02T15:03:33","subject":"Re: [libcamera-devel] [PATCH v2 0/6] libcamera: pipeline: rkisp1:\n\tRefresh to match upstream","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Niklas,\n\nOn Fri, Oct 02, 2020 at 04:52:01PM +0200, Niklas Söderlund wrote:\n> Hi Jacopo,\n>\n> On 2020-10-02 16:12:53 +0200, Jacopo Mondi wrote:\n> > Hi Niklas,\n> >\n> > On Thu, Oct 01, 2020 at 07:48:34PM +0300, Laurent Pinchart wrote:\n> > > Hi Niklas,\n> > >\n> > > Thank you for the patches.\n> > >\n> > > On Thu, Oct 01, 2020 at 05:45:54PM +0200, Niklas Söderlund wrote:\n> > > > Hello,\n> > > >\n> > > > This series refresh the RkISP1 pipeline handler to match what is in the\n> > > > media-tree. As the upstream driver is in staging and bound to change\n> > > > quiet a bit no attempt to keep the libcamera pipeline backwards\n> > > > compatible have been made. To fully test this on must run a system no\n> > > > older then [1] from the linux-media tree.\n> > > >\n> > > > Running a system newer then v5.8 without this series will also fail as\n> > > > there are upstream changes breaking current libcamera master.\n> > > >\n> > > > Apart from aligning the pipeline with the upstream driver it's now\n> > > > trivial to enable support for R8, RGB656 and XBGR8888 in the pipeline.\n> > > > As these have been troublesome in the past due to issues now fixed\n> > > > upstream every format supported by the pipeline (YUYV, NV16, NV61, NV21,\n> > > > NV12, R8, RGB565 and XRGB8888) have been retested and converted using\n> > > > raw2rgbpnm to validate that the captured data is good.\n> > > >\n> > > > 1. 7eba47ab7a310ed8 (\"media: staging: rkisp1: cap: protect access to buf with the spin lock\")\n> > > >\n> > > > Niklas Söderlund (6):\n> > > > libcamera: pipeline: rkisp1: Remove support for YVYU and VYUY\n> > > > libcamera: pipeline: rkisp1: Fix media bus propagation for NV{12,21}\n> > > > libcamera: pipeline: rkisp1: Add support for RGB656\n> > > > libcamera: pipeline: rkisp1: Add support for R8\n> > > > libcamera: Add support for XRGB8888 and XBGR8888\n> > > > libcamera: pipeline: rkisp1: Add support for XRGB8888\n> > >\n> > > For the whole series,\n> > >\n> > > Reviewed-by: Laurent Pinchart \n> >\n> > With the small comments clarified, for the series:\n> >\n> > Reviewed-by: Jacopo Mondi \n>\n> Thanks for reviewing this series, unfortunately the series is already\n> merged so I can't record your effort :-(\n>\n\nPlease revert and re-push with my tags\n\n:p\n\nSorry for being late to the party\n\n> >\n> > Thanks\n> > j\n> >\n> > >\n> > > Could you however please follow up with upstream to replace\n> > > MEDIA_BUS_FMT_YUYV8_1_5X8 with MEDIA_BUS_FMT_YUYV8_1X16 ?\n> > >\n> > > > src/libcamera/formats.cpp | 20 ++++++++++++++\n> > > > src/libcamera/pipeline/rkisp1/rkisp1_path.cpp | 27 +++++++++++++------\n> > > > src/libcamera/v4l2_pixelformat.cpp | 2 ++\n> > > > 3 files changed, 41 insertions(+), 8 deletions(-)\n> > > >\n> > >\n> > > --\n> > > Regards,\n> > >\n> > > Laurent Pinchart\n> > > _______________________________________________\n> > > libcamera-devel mailing list\n> > > libcamera-devel@lists.libcamera.org\n> > > https://lists.libcamera.org/listinfo/libcamera-devel\n>\n> --\n> Regards,\n> Niklas Söderlund","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3DB22C3B5C\n\tfor ;\n\tFri, 2 Oct 2020 14:59:38 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D0C5C63BCA;\n\tFri, 2 Oct 2020 16:59:37 +0200 (CEST)","from relay11.mail.gandi.net (relay11.mail.gandi.net\n\t[217.70.178.231])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D51B663BBF\n\tfor ;\n\tFri, 2 Oct 2020 16:59:36 +0200 (CEST)","from uno.localdomain (93-34-118-233.ip49.fastwebnet.it\n\t[93.34.118.233]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay11.mail.gandi.net (Postfix) with ESMTPSA id 2BD9D100013;\n\tFri, 2 Oct 2020 14:59:35 +0000 (UTC)"],"Date":"Fri, 2 Oct 2020 17:03:33 +0200","From":"Jacopo Mondi ","To":"Niklas =?utf-8?q?S=C3=B6derlund?= ","Message-ID":"<20201002150333.77o5ew6btcc7ents@uno.localdomain>","References":"<20201001154600.2722718-1-niklas.soderlund@ragnatech.se>\n\t<20201001164834.GC3722@pendragon.ideasonboard.com>\n\t<20201002141253.vf6427rztt3zarrl@uno.localdomain>\n\t<20201002145201.6pi5uvxj75deqfoy@oden.dyn.berto.se>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20201002145201.6pi5uvxj75deqfoy@oden.dyn.berto.se>","Subject":"Re: [libcamera-devel] [PATCH v2 0/6] libcamera: pipeline: rkisp1:\n\tRefresh to match upstream","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]