[{"id":12836,"web_url":"https://patchwork.libcamera.org/comment/12836/","msgid":"<20200928225631.GY23539@pendragon.ideasonboard.com>","date":"2020-09-28T22:56:31","subject":"Re: [libcamera-devel] [PATCH v3 00/22] libcamera: pipeline: rkisp1:\n\tExtend to support two streams","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Niklas,\n\nThank you for the series.\n\nOn Fri, Sep 25, 2020 at 03:41:45AM +0200, Niklas Söderlund wrote:\n> Hi,\n> \n> This series extends the RkISP1 pipeline handler to work with 2 streams.\n> It allows cameras backed by this pipeline to expose a main path stream,\n> same as the one before this series. And a new self path stream that can\n> operate in addition or independently from the main path.\n> \n> In previous versions of this series RGB formats where added to the self \n> path (new formats not supported by the main path) but further \n> examination of those formats resulted in that the captured frames looks \n> weird. Pending future investigation drop that work from this series.\n\nJust for my own curiosity, how weird ?\n\n> Furthermore this series does not extend support for RAW formats as this\n> is such a special case for this pipeline. Only the main path may be\n> active and no ISP parameters can be processed. This may be added on top\n> but functionality have been proven as a prototype.\n\nI think adding support for the second ISP would then be an interesting\nexperiment. Clearly for (much) later :-)\n\n> New in this version are patches 15/22 to 21/22 that adds a new \n> RkISP1Path class which abstracts the two paths into a single helper \n> class with shared logic. The shared logic can then be leveraged to \n> simplify the pipeline handler.\n\nVery nice cleanups, thanks.\n\n> Patch 22/22 is an attempt to use a lambda function to further simplify \n> error logic in start(). It is primary provided as a proof-of-concept \n> and should be regarded as RFC.\n> \n> To be able to use both main and self path simultaneously must run a\n> kernel that includes [1]. The development of the series is tested on the\n> media-tree [2] with out-of-tree DTS patches for the test Scarlet\n> platform to enable the camera sensors.\n> \n> 1. 60e915354c270357 (\"media: staging: rkisp1: cap: fix return values from pm functions\")\n> 2. f45882cfb152f5d3 (\"media: camss: fix memory leaks on error handling paths in probe\")\n> \n> Niklas Söderlund (22):\n> libcamera: pipeline: rkisp1: Set number of planes based on format\n> libcamera: pipeline: rkisp1: Remove redundant check of buffer in\n> Request\n> libcamera: pipeline: rkisp1: Breakout mainpath size and format\n> constraints\n> libcamera: pipeline: rkisp1: Setup links as part of configuration\n> libcamera: pipeline: rkisp1: Prepare buffer ready handlers for\n> multiple streams\n> libcamera: pipeline: rkisp1: Create RkISP1Frames from camera data\n> libcamera: pipeline: rkisp1: Export stream formats to applications\n> libcamera: pipeline: rkisp1: Set the crop rectangle\n> libcamera: pipeline: rkisp1: Prefix main path video and resizer\n> libcamera: pipeline: rkisp1: Add self path devices\n> libcamera: pipeline: rkisp1: Configure self path\n> libcamera: pipeline: rkisp1: Track buffers for self path\n> libcamera: pipeline: rkisp1: Add format validation for self path\n> libcamera: pipeline: rkisp1: Expose self path stream\n> libcamera: pipeline: rkisp1: Breakout basic path handling to own class\n> libcamera: pipeline: rkisp1: Move path configuration to RkISP1Path\n> libcamera: pipeline: rkisp1: Move path configuration generation and\n> validation to RkISP1Path\n> libcamera: pipeline: rkisp1: Add wrappers for accessing the path video\n> device\n> libcamera: pipeline: rkisp1: Move start and stop of path to RkISP1Path\n> libcamera: pipeline: rkisp1: Move path link handling to RkISP1Path\n> libcamera: pipeline: rkisp1: Use the media link to track if a path is\n> enabled\n> libcamera: pipeline: rkisp1: Use cleanup error paths for start()\n> \n> src/libcamera/pipeline/rkisp1/meson.build | 1 +\n> src/libcamera/pipeline/rkisp1/rkisp1.cpp | 555 +++++++++++--------\n> src/libcamera/pipeline/rkisp1/rkisp1path.cpp | 237 ++++++++\n> src/libcamera/pipeline/rkisp1/rkisp1path.h | 83 +++\n> 4 files changed, 633 insertions(+), 243 deletions(-)\n> create mode 100644 src/libcamera/pipeline/rkisp1/rkisp1path.cpp\n> create mode 100644 src/libcamera/pipeline/rkisp1/rkisp1path.h\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D3298C3B5B\n\tfor ;\n\tMon, 28 Sep 2020 22:57:08 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 40B4060BF7;\n\tTue, 29 Sep 2020 00:57:08 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5224C60394\n\tfor ;\n\tTue, 29 Sep 2020 00:57:06 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C8DCEA58;\n\tTue, 29 Sep 2020 00:57:05 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"uKInactF\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1601333826;\n\tbh=GU29jJh5tpWbMwwn+GMpYyHvEKBR2A0AOjVjwe3JVQo=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=uKInactF57crA07frlkUs4WWvvw3TCqn/euiEnKb/SRtCwxH4PCxBHmMrT8ohYoOE\n\tiIN/of4ujuCIr1v7QlkpaE3B+eU2+AUfAGzM4AAQqiM78h+jVBt3RYAV52pH5iNhv8\n\tD30tNGtQ2EOYEsjkUjJ0zad3qS08xRPaKg2++bi0=","Date":"Tue, 29 Sep 2020 01:56:31 +0300","From":"Laurent Pinchart ","To":"Niklas =?utf-8?q?S=C3=B6derlund?= ","Message-ID":"<20200928225631.GY23539@pendragon.ideasonboard.com>","References":"<20200925014207.1455796-1-niklas.soderlund@ragnatech.se>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200925014207.1455796-1-niklas.soderlund@ragnatech.se>","Subject":"Re: [libcamera-devel] [PATCH v3 00/22] libcamera: pipeline: rkisp1:\n\tExtend to support two streams","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]