[{"id":12869,"web_url":"https://patchwork.libcamera.org/comment/12869/","msgid":"","date":"2020-09-29T08:46:39","subject":"Re: [libcamera-devel] [PATCH 0/4] Code tidy-ups","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"content":"Hi all,\n\nGentle nudge on this one. If there are no further comments, I think\nthis is ready to be submitted - all review tags are present.\n\nMany thanks,\nNaush\n\n\nOn Thu, 24 Sep 2020 at 10:19, Naushir Patuck wrote:\n>\n> Hi,\n>\n> Thank you all for the comments on v1. This v2 update addresses all that was discussed:\n>\n> - Reword commit message for patch 1/4.\n> - Re-order commits 2/4 and 3/4 to have a more logical flow of changes.\n> - Some blank lines added in 4/4 for better code readability.\n> - constexpr int -> constexpr double\n>\n> I have not added an ipa:: namespace. This may warrant some more thought, would we\n> consider adding libcamera core parameters to this namespace, or is it going to be\n> vendor specific? Either way, I think this can be addeded at a later date.\n>\n> Regards,\n> Naush\n>\n>\n> Naushir Patuck (4):\n> pipeline: raspberrypi: Rename RPi::RPiStream and RPi::RPiDevice\n> ipa: raspberrypi: Rename the controller namespace from Rpi to\n> RpiController\n> ipa: raspberrypi: Move IPA parameters to the RPi namespace\n> ipa: raspberrypi: Tidy up variable names to be consistent\n>\n> include/libcamera/ipa/raspberrypi.h | 42 +--\n> src/ipa/raspberrypi/cam_helper.cpp | 2 +-\n> src/ipa/raspberrypi/cam_helper.hpp | 2 +-\n> src/ipa/raspberrypi/cam_helper_imx219.cpp | 2 +-\n> src/ipa/raspberrypi/cam_helper_imx477.cpp | 2 +-\n> src/ipa/raspberrypi/cam_helper_ov5647.cpp | 2 +-\n> .../raspberrypi/controller/agc_algorithm.hpp | 4 +-\n> src/ipa/raspberrypi/controller/algorithm.cpp | 4 +-\n> src/ipa/raspberrypi/controller/algorithm.hpp | 4 +-\n> .../raspberrypi/controller/awb_algorithm.hpp | 4 +-\n> .../raspberrypi/controller/ccm_algorithm.hpp | 4 +-\n> .../controller/contrast_algorithm.hpp | 4 +-\n> src/ipa/raspberrypi/controller/controller.cpp | 2 +-\n> src/ipa/raspberrypi/controller/controller.hpp | 4 +-\n> src/ipa/raspberrypi/controller/histogram.cpp | 2 +-\n> src/ipa/raspberrypi/controller/histogram.hpp | 4 +-\n> src/ipa/raspberrypi/controller/metadata.hpp | 4 +-\n> src/ipa/raspberrypi/controller/pwl.cpp | 2 +-\n> src/ipa/raspberrypi/controller/pwl.hpp | 4 +-\n> src/ipa/raspberrypi/controller/rpi/agc.cpp | 2 +-\n> src/ipa/raspberrypi/controller/rpi/agc.hpp | 4 +-\n> src/ipa/raspberrypi/controller/rpi/alsc.cpp | 2 +-\n> src/ipa/raspberrypi/controller/rpi/alsc.hpp | 4 +-\n> src/ipa/raspberrypi/controller/rpi/awb.cpp | 2 +-\n> src/ipa/raspberrypi/controller/rpi/awb.hpp | 4 +-\n> .../controller/rpi/black_level.cpp | 2 +-\n> .../controller/rpi/black_level.hpp | 4 +-\n> src/ipa/raspberrypi/controller/rpi/ccm.cpp | 2 +-\n> src/ipa/raspberrypi/controller/rpi/ccm.hpp | 4 +-\n> .../raspberrypi/controller/rpi/contrast.cpp | 2 +-\n> .../raspberrypi/controller/rpi/contrast.hpp | 4 +-\n> src/ipa/raspberrypi/controller/rpi/dpc.cpp | 2 +-\n> src/ipa/raspberrypi/controller/rpi/dpc.hpp | 4 +-\n> src/ipa/raspberrypi/controller/rpi/focus.cpp | 2 +-\n> src/ipa/raspberrypi/controller/rpi/focus.hpp | 4 +-\n> src/ipa/raspberrypi/controller/rpi/geq.cpp | 2 +-\n> src/ipa/raspberrypi/controller/rpi/geq.hpp | 4 +-\n> src/ipa/raspberrypi/controller/rpi/lux.cpp | 2 +-\n> src/ipa/raspberrypi/controller/rpi/lux.hpp | 4 +-\n> src/ipa/raspberrypi/controller/rpi/noise.cpp | 2 +-\n> src/ipa/raspberrypi/controller/rpi/noise.hpp | 4 +-\n> src/ipa/raspberrypi/controller/rpi/sdn.cpp | 2 +-\n> src/ipa/raspberrypi/controller/rpi/sdn.hpp | 4 +-\n> .../raspberrypi/controller/rpi/sharpen.cpp | 2 +-\n> .../raspberrypi/controller/rpi/sharpen.hpp | 4 +-\n> .../controller/sharpen_algorithm.hpp | 4 +-\n> src/ipa/raspberrypi/md_parser.cpp | 2 +-\n> src/ipa/raspberrypi/md_parser.hpp | 2 +-\n> src/ipa/raspberrypi/md_parser_rpi.cpp | 2 +-\n> src/ipa/raspberrypi/md_parser_rpi.hpp | 2 +-\n> src/ipa/raspberrypi/raspberrypi.cpp | 269 +++++++++---------\n> .../pipeline/raspberrypi/raspberrypi.cpp | 84 +++---\n> .../pipeline/raspberrypi/rpi_stream.cpp | 38 +--\n> .../pipeline/raspberrypi/rpi_stream.h | 20 +-\n> 54 files changed, 304 insertions(+), 295 deletions(-)\n>\n> --\n> 2.25.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 84BA0C3B5C\n\tfor ;\n\tTue, 29 Sep 2020 08:47:03 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8A01562195;\n\tTue, 29 Sep 2020 10:47:02 +0200 (CEST)","from mail-lf1-x142.google.com (mail-lf1-x142.google.com\n\t[IPv6:2a00:1450:4864:20::142])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D16F660360\n\tfor ;\n\tTue, 29 Sep 2020 10:47:00 +0200 (CEST)","by mail-lf1-x142.google.com with SMTP id b12so4543469lfp.9\n\tfor ;\n\tTue, 29 Sep 2020 01:47:00 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"qUYJFlHI\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to;\n\tbh=5rkhMP+/JY8CCOnlea1Z00nEXTApo0BIK7oB+7P+Zco=;\n\tb=qUYJFlHIBbjua+7VpL06xdU+xczQtMI8pKr2TfCpYfj18vGRol8wA3CxMnoWrrWkqU\n\tpu9A+qPGtkC/Zsm5QfoL4ddj2v9099qgXkcEjozNSoi3ppkq+8hI0voXwn0NJic2nUO8\n\tk72r0XIBbf8cL9Hxr6XIOodO8BdJywINuY++GpQpGfKcRoX+Vah3i5gh7E9tQPznqMJN\n\t64tRCBiKhMtE/2FvMDMFv5w6izLDAMDk8maV0cS9Xt0qvewQ7svNmhWjJbIJjwckmTaD\n\thwSqfm8u39aKdsY1JftXAgSjC2PnZmRtTPDxhfz5ZtQAa+wAQ4sXFvNpmYHecHiMS0vR\n\tSDZw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to;\n\tbh=5rkhMP+/JY8CCOnlea1Z00nEXTApo0BIK7oB+7P+Zco=;\n\tb=cJ7eIqfsC7XWUWQqwxIpVt3bCuL4KCNCEbg2vmvlJoBbGPeGWCePddsuxRULrT0c/V\n\tYMVTyAAIWIMYH/V565+9339iiT2U6TqVHnJYRJL7z5j4KYb3yFmevkb/wwFnumIyiQjk\n\t/bpEQOcFqWYnRDPB0khF3ys4w/IZYMssaSHImStEpTGvVNa9+MvpRY9LNor/JzTPAHMI\n\t9eVa0WPxFl4DvcBVAIcpuRSNAxs5gorCZPwwN5wMzpJFHL0hqcuX1FXiqHU4PhqI8Umi\n\tGPbgnqIZXTetNqRN5jzsgdwIwu7VXdr+Q+j33hY9xNgDGfVmcNUlkRTfp4FzwCN/dsUA\n\tEBYg==","X-Gm-Message-State":"AOAM533XdxiCF3Z8vCXKlDL0zNLZkaRdZFl1qhcu+Fb7MxIyM5w+pKWD\n\tZw1A6u4dxbYYPxqln7j6dKuIGqwRHCfaxQPkLa+9Fo9LLb4=","X-Google-Smtp-Source":"ABdhPJxY9vCaT0Wv5FQ2ThNOvJabmEEuzL4BaG2lz0qf/DZbMtPMxC1Yynb72yQ99lxBMxGVxuIIzb727OhFNN+hrhI=","X-Received":"by 2002:a19:820c:: with SMTP id e12mr762180lfd.215.1601369219237;\n\tTue, 29 Sep 2020 01:46:59 -0700 (PDT)","MIME-Version":"1.0","References":"<20200924091927.116385-1-naush@raspberrypi.com>","In-Reply-To":"<20200924091927.116385-1-naush@raspberrypi.com>","From":"Naushir Patuck ","Date":"Tue, 29 Sep 2020 09:46:39 +0100","Message-ID":"","To":"libcamera-devel@lists.libcamera.org","Subject":"Re: [libcamera-devel] [PATCH 0/4] Code tidy-ups","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":12870,"web_url":"https://patchwork.libcamera.org/comment/12870/","msgid":"","date":"2020-09-29T08:50:08","subject":"Re: [libcamera-devel] [PATCH 0/4] Code tidy-ups","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Naush,\n\nOn 29/09/2020 09:46, Naushir Patuck wrote:\n> Hi all,\n> \n> Gentle nudge on this one. If there are no further comments, I think\n> this is ready to be submitted - all review tags are present.\n\nIndeed, I will be handling this integration along with David's 2D\ntransform series this morning.\n\nThanks.\n\nKieran\n\n\n> \n> Many thanks,\n> Naush\n> \n> \n> On Thu, 24 Sep 2020 at 10:19, Naushir Patuck wrote:\n>>\n>> Hi,\n>>\n>> Thank you all for the comments on v1. This v2 update addresses all that was discussed:\n>>\n>> - Reword commit message for patch 1/4.\n>> - Re-order commits 2/4 and 3/4 to have a more logical flow of changes.\n>> - Some blank lines added in 4/4 for better code readability.\n>> - constexpr int -> constexpr double\n>>\n>> I have not added an ipa:: namespace. This may warrant some more thought, would we\n>> consider adding libcamera core parameters to this namespace, or is it going to be\n>> vendor specific? Either way, I think this can be addeded at a later date.\n>>\n>> Regards,\n>> Naush\n>>\n>>\n>> Naushir Patuck (4):\n>> pipeline: raspberrypi: Rename RPi::RPiStream and RPi::RPiDevice\n>> ipa: raspberrypi: Rename the controller namespace from Rpi to\n>> RpiController\n>> ipa: raspberrypi: Move IPA parameters to the RPi namespace\n>> ipa: raspberrypi: Tidy up variable names to be consistent\n>>\n>> include/libcamera/ipa/raspberrypi.h | 42 +--\n>> src/ipa/raspberrypi/cam_helper.cpp | 2 +-\n>> src/ipa/raspberrypi/cam_helper.hpp | 2 +-\n>> src/ipa/raspberrypi/cam_helper_imx219.cpp | 2 +-\n>> src/ipa/raspberrypi/cam_helper_imx477.cpp | 2 +-\n>> src/ipa/raspberrypi/cam_helper_ov5647.cpp | 2 +-\n>> .../raspberrypi/controller/agc_algorithm.hpp | 4 +-\n>> src/ipa/raspberrypi/controller/algorithm.cpp | 4 +-\n>> src/ipa/raspberrypi/controller/algorithm.hpp | 4 +-\n>> .../raspberrypi/controller/awb_algorithm.hpp | 4 +-\n>> .../raspberrypi/controller/ccm_algorithm.hpp | 4 +-\n>> .../controller/contrast_algorithm.hpp | 4 +-\n>> src/ipa/raspberrypi/controller/controller.cpp | 2 +-\n>> src/ipa/raspberrypi/controller/controller.hpp | 4 +-\n>> src/ipa/raspberrypi/controller/histogram.cpp | 2 +-\n>> src/ipa/raspberrypi/controller/histogram.hpp | 4 +-\n>> src/ipa/raspberrypi/controller/metadata.hpp | 4 +-\n>> src/ipa/raspberrypi/controller/pwl.cpp | 2 +-\n>> src/ipa/raspberrypi/controller/pwl.hpp | 4 +-\n>> src/ipa/raspberrypi/controller/rpi/agc.cpp | 2 +-\n>> src/ipa/raspberrypi/controller/rpi/agc.hpp | 4 +-\n>> src/ipa/raspberrypi/controller/rpi/alsc.cpp | 2 +-\n>> src/ipa/raspberrypi/controller/rpi/alsc.hpp | 4 +-\n>> src/ipa/raspberrypi/controller/rpi/awb.cpp | 2 +-\n>> src/ipa/raspberrypi/controller/rpi/awb.hpp | 4 +-\n>> .../controller/rpi/black_level.cpp | 2 +-\n>> .../controller/rpi/black_level.hpp | 4 +-\n>> src/ipa/raspberrypi/controller/rpi/ccm.cpp | 2 +-\n>> src/ipa/raspberrypi/controller/rpi/ccm.hpp | 4 +-\n>> .../raspberrypi/controller/rpi/contrast.cpp | 2 +-\n>> .../raspberrypi/controller/rpi/contrast.hpp | 4 +-\n>> src/ipa/raspberrypi/controller/rpi/dpc.cpp | 2 +-\n>> src/ipa/raspberrypi/controller/rpi/dpc.hpp | 4 +-\n>> src/ipa/raspberrypi/controller/rpi/focus.cpp | 2 +-\n>> src/ipa/raspberrypi/controller/rpi/focus.hpp | 4 +-\n>> src/ipa/raspberrypi/controller/rpi/geq.cpp | 2 +-\n>> src/ipa/raspberrypi/controller/rpi/geq.hpp | 4 +-\n>> src/ipa/raspberrypi/controller/rpi/lux.cpp | 2 +-\n>> src/ipa/raspberrypi/controller/rpi/lux.hpp | 4 +-\n>> src/ipa/raspberrypi/controller/rpi/noise.cpp | 2 +-\n>> src/ipa/raspberrypi/controller/rpi/noise.hpp | 4 +-\n>> src/ipa/raspberrypi/controller/rpi/sdn.cpp | 2 +-\n>> src/ipa/raspberrypi/controller/rpi/sdn.hpp | 4 +-\n>> .../raspberrypi/controller/rpi/sharpen.cpp | 2 +-\n>> .../raspberrypi/controller/rpi/sharpen.hpp | 4 +-\n>> .../controller/sharpen_algorithm.hpp | 4 +-\n>> src/ipa/raspberrypi/md_parser.cpp | 2 +-\n>> src/ipa/raspberrypi/md_parser.hpp | 2 +-\n>> src/ipa/raspberrypi/md_parser_rpi.cpp | 2 +-\n>> src/ipa/raspberrypi/md_parser_rpi.hpp | 2 +-\n>> src/ipa/raspberrypi/raspberrypi.cpp | 269 +++++++++---------\n>> .../pipeline/raspberrypi/raspberrypi.cpp | 84 +++---\n>> .../pipeline/raspberrypi/rpi_stream.cpp | 38 +--\n>> .../pipeline/raspberrypi/rpi_stream.h | 20 +-\n>> 54 files changed, 304 insertions(+), 295 deletions(-)\n>>\n>> --\n>> 2.25.1\n>>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 626B9C3B5B\n\tfor ;\n\tTue, 29 Sep 2020 08:50:14 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C867E6215B;\n\tTue, 29 Sep 2020 10:50:13 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 66C1560360\n\tfor ;\n\tTue, 29 Sep 2020 10:50:12 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 5CDB99CC;\n\tTue, 29 Sep 2020 10:50:11 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"VRTB2Xp/\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1601369411;\n\tbh=T/n1A6HAWCrn14qjiiXa9KKaypdXcdMILWmG0ekkatw=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=VRTB2Xp//DdMRj9YOfJ0HGuYRwwsggvVA4mgHEYmIHzic9CAB+/HvbHsPRQst6U7t\n\tniW516Rh2gqBv74ymxtXEB698F9V0KAAGQXSvIWhs8QV46KHXmcGq3Gdmkc7UFtcKI\n\tpJJXSOPS2p1856u9Tl4yHdyNRiS6qS92Mw7398JI=","To":"Naushir Patuck ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20200924091927.116385-1-naush@raspberrypi.com>\n\t","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"","Date":"Tue, 29 Sep 2020 09:50:08 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [PATCH 0/4] Code tidy-ups","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"kieran.bingham@ideasonboard.com","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":12873,"web_url":"https://patchwork.libcamera.org/comment/12873/","msgid":"<74a80111-ab38-bc36-8393-24cd9722e443@ideasonboard.com>","date":"2020-09-29T12:02:04","subject":"Re: [libcamera-devel] [PATCH 0/4] Code tidy-ups","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Naush,\n\nOn 29/09/2020 09:50, Kieran Bingham wrote:\n> Hi Naush,\n> \n> On 29/09/2020 09:46, Naushir Patuck wrote:\n>> Hi all,\n>>\n>> Gentle nudge on this one. If there are no further comments, I think\n>> this is ready to be submitted - all review tags are present.\n> \n> Indeed, I will be handling this integration along with David's 2D\n> transform series this morning.\n\n\nThere were some merge conflicts to deal with, and a checkstyle warning\nthat crept in.\n\nI've fixed up the warning, and conflicts due to appyling on top of\nDavid's 2d-transform series, but as your series was only non-functional\nchanges I had a higher confidence that it was correct when compiled, and\nhave pushed upstream.\n\nLet me know if you notice any issues.\n\nRegards\n\nKieran\n\n\n\n\n> Thanks.\n> \n> Kieran\n> \n> \n>>\n>> Many thanks,\n>> Naush\n>>\n>>\n>> On Thu, 24 Sep 2020 at 10:19, Naushir Patuck wrote:\n>>>\n>>> Hi,\n>>>\n>>> Thank you all for the comments on v1. This v2 update addresses all that was discussed:\n>>>\n>>> - Reword commit message for patch 1/4.\n>>> - Re-order commits 2/4 and 3/4 to have a more logical flow of changes.\n>>> - Some blank lines added in 4/4 for better code readability.\n>>> - constexpr int -> constexpr double\n>>>\n>>> I have not added an ipa:: namespace. This may warrant some more thought, would we\n>>> consider adding libcamera core parameters to this namespace, or is it going to be\n>>> vendor specific? Either way, I think this can be addeded at a later date.\n>>>\n>>> Regards,\n>>> Naush\n>>>\n>>>\n>>> Naushir Patuck (4):\n>>> pipeline: raspberrypi: Rename RPi::RPiStream and RPi::RPiDevice\n>>> ipa: raspberrypi: Rename the controller namespace from Rpi to\n>>> RpiController\n>>> ipa: raspberrypi: Move IPA parameters to the RPi namespace\n>>> ipa: raspberrypi: Tidy up variable names to be consistent\n>>>\n>>> include/libcamera/ipa/raspberrypi.h | 42 +--\n>>> src/ipa/raspberrypi/cam_helper.cpp | 2 +-\n>>> src/ipa/raspberrypi/cam_helper.hpp | 2 +-\n>>> src/ipa/raspberrypi/cam_helper_imx219.cpp | 2 +-\n>>> src/ipa/raspberrypi/cam_helper_imx477.cpp | 2 +-\n>>> src/ipa/raspberrypi/cam_helper_ov5647.cpp | 2 +-\n>>> .../raspberrypi/controller/agc_algorithm.hpp | 4 +-\n>>> src/ipa/raspberrypi/controller/algorithm.cpp | 4 +-\n>>> src/ipa/raspberrypi/controller/algorithm.hpp | 4 +-\n>>> .../raspberrypi/controller/awb_algorithm.hpp | 4 +-\n>>> .../raspberrypi/controller/ccm_algorithm.hpp | 4 +-\n>>> .../controller/contrast_algorithm.hpp | 4 +-\n>>> src/ipa/raspberrypi/controller/controller.cpp | 2 +-\n>>> src/ipa/raspberrypi/controller/controller.hpp | 4 +-\n>>> src/ipa/raspberrypi/controller/histogram.cpp | 2 +-\n>>> src/ipa/raspberrypi/controller/histogram.hpp | 4 +-\n>>> src/ipa/raspberrypi/controller/metadata.hpp | 4 +-\n>>> src/ipa/raspberrypi/controller/pwl.cpp | 2 +-\n>>> src/ipa/raspberrypi/controller/pwl.hpp | 4 +-\n>>> src/ipa/raspberrypi/controller/rpi/agc.cpp | 2 +-\n>>> src/ipa/raspberrypi/controller/rpi/agc.hpp | 4 +-\n>>> src/ipa/raspberrypi/controller/rpi/alsc.cpp | 2 +-\n>>> src/ipa/raspberrypi/controller/rpi/alsc.hpp | 4 +-\n>>> src/ipa/raspberrypi/controller/rpi/awb.cpp | 2 +-\n>>> src/ipa/raspberrypi/controller/rpi/awb.hpp | 4 +-\n>>> .../controller/rpi/black_level.cpp | 2 +-\n>>> .../controller/rpi/black_level.hpp | 4 +-\n>>> src/ipa/raspberrypi/controller/rpi/ccm.cpp | 2 +-\n>>> src/ipa/raspberrypi/controller/rpi/ccm.hpp | 4 +-\n>>> .../raspberrypi/controller/rpi/contrast.cpp | 2 +-\n>>> .../raspberrypi/controller/rpi/contrast.hpp | 4 +-\n>>> src/ipa/raspberrypi/controller/rpi/dpc.cpp | 2 +-\n>>> src/ipa/raspberrypi/controller/rpi/dpc.hpp | 4 +-\n>>> src/ipa/raspberrypi/controller/rpi/focus.cpp | 2 +-\n>>> src/ipa/raspberrypi/controller/rpi/focus.hpp | 4 +-\n>>> src/ipa/raspberrypi/controller/rpi/geq.cpp | 2 +-\n>>> src/ipa/raspberrypi/controller/rpi/geq.hpp | 4 +-\n>>> src/ipa/raspberrypi/controller/rpi/lux.cpp | 2 +-\n>>> src/ipa/raspberrypi/controller/rpi/lux.hpp | 4 +-\n>>> src/ipa/raspberrypi/controller/rpi/noise.cpp | 2 +-\n>>> src/ipa/raspberrypi/controller/rpi/noise.hpp | 4 +-\n>>> src/ipa/raspberrypi/controller/rpi/sdn.cpp | 2 +-\n>>> src/ipa/raspberrypi/controller/rpi/sdn.hpp | 4 +-\n>>> .../raspberrypi/controller/rpi/sharpen.cpp | 2 +-\n>>> .../raspberrypi/controller/rpi/sharpen.hpp | 4 +-\n>>> .../controller/sharpen_algorithm.hpp | 4 +-\n>>> src/ipa/raspberrypi/md_parser.cpp | 2 +-\n>>> src/ipa/raspberrypi/md_parser.hpp | 2 +-\n>>> src/ipa/raspberrypi/md_parser_rpi.cpp | 2 +-\n>>> src/ipa/raspberrypi/md_parser_rpi.hpp | 2 +-\n>>> src/ipa/raspberrypi/raspberrypi.cpp | 269 +++++++++---------\n>>> .../pipeline/raspberrypi/raspberrypi.cpp | 84 +++---\n>>> .../pipeline/raspberrypi/rpi_stream.cpp | 38 +--\n>>> .../pipeline/raspberrypi/rpi_stream.h | 20 +-\n>>> 54 files changed, 304 insertions(+), 295 deletions(-)\n>>>\n>>> --\n>>> 2.25.1\n>>>\n>> _______________________________________________\n>> libcamera-devel mailing list\n>> libcamera-devel@lists.libcamera.org\n>> https://lists.libcamera.org/listinfo/libcamera-devel\n>>\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 348A5C3B5B\n\tfor ;\n\tTue, 29 Sep 2020 12:02:10 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8FBF9621C7;\n\tTue, 29 Sep 2020 14:02:09 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A045060365\n\tfor ;\n\tTue, 29 Sep 2020 14:02:08 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 03CED14E1;\n\tTue, 29 Sep 2020 14:02:07 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Dg9hupBR\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1601380928;\n\tbh=iZ11+A6kcq2FG9wWxRNEKvE6P3CthfCgn0ybSZ67qtg=;\n\th=Reply-To:Subject:From:To:References:Date:In-Reply-To:From;\n\tb=Dg9hupBR+8s1e693YRPf9JGCTLQTFvYwukbI4Q4/e8AWbdQoWs1Za2uoTbK2KqHec\n\tKsvONfKy9ZyTyH9YoXeb9IPjPeH6rs7i24gtPa2fobpEfBGSrYUEMDtcAlo4okCCzq\n\tybK/FCoYcHydaQg11vfSK9liiE1Rgmjs8LT/BveQ=","From":"Kieran Bingham ","To":"Naushir Patuck ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20200924091927.116385-1-naush@raspberrypi.com>\n\t\n\t","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<74a80111-ab38-bc36-8393-24cd9722e443@ideasonboard.com>","Date":"Tue, 29 Sep 2020 13:02:04 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [PATCH 0/4] Code tidy-ups","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"kieran.bingham@ideasonboard.com","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":12874,"web_url":"https://patchwork.libcamera.org/comment/12874/","msgid":"","date":"2020-09-29T13:05:32","subject":"Re: [libcamera-devel] [PATCH 0/4] Code tidy-ups","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"content":"Thanks Kieran, will test it out and let you know if I run into any issues.\n\nRegards,\nNaush\n\nOn Tue, 29 Sep 2020 at 13:02, Kieran Bingham\n wrote:\n>\n> Hi Naush,\n>\n> On 29/09/2020 09:50, Kieran Bingham wrote:\n> > Hi Naush,\n> >\n> > On 29/09/2020 09:46, Naushir Patuck wrote:\n> >> Hi all,\n> >>\n> >> Gentle nudge on this one. If there are no further comments, I think\n> >> this is ready to be submitted - all review tags are present.\n> >\n> > Indeed, I will be handling this integration along with David's 2D\n> > transform series this morning.\n>\n>\n> There were some merge conflicts to deal with, and a checkstyle warning\n> that crept in.\n>\n> I've fixed up the warning, and conflicts due to appyling on top of\n> David's 2d-transform series, but as your series was only non-functional\n> changes I had a higher confidence that it was correct when compiled, and\n> have pushed upstream.\n>\n> Let me know if you notice any issues.\n>\n> Regards\n>\n> Kieran\n>\n>\n>\n>\n> > Thanks.\n> >\n> > Kieran\n> >\n> >\n> >>\n> >> Many thanks,\n> >> Naush\n> >>\n> >>\n> >> On Thu, 24 Sep 2020 at 10:19, Naushir Patuck wrote:\n> >>>\n> >>> Hi,\n> >>>\n> >>> Thank you all for the comments on v1. This v2 update addresses all that was discussed:\n> >>>\n> >>> - Reword commit message for patch 1/4.\n> >>> - Re-order commits 2/4 and 3/4 to have a more logical flow of changes.\n> >>> - Some blank lines added in 4/4 for better code readability.\n> >>> - constexpr int -> constexpr double\n> >>>\n> >>> I have not added an ipa:: namespace. This may warrant some more thought, would we\n> >>> consider adding libcamera core parameters to this namespace, or is it going to be\n> >>> vendor specific? Either way, I think this can be addeded at a later date.\n> >>>\n> >>> Regards,\n> >>> Naush\n> >>>\n> >>>\n> >>> Naushir Patuck (4):\n> >>> pipeline: raspberrypi: Rename RPi::RPiStream and RPi::RPiDevice\n> >>> ipa: raspberrypi: Rename the controller namespace from Rpi to\n> >>> RpiController\n> >>> ipa: raspberrypi: Move IPA parameters to the RPi namespace\n> >>> ipa: raspberrypi: Tidy up variable names to be consistent\n> >>>\n> >>> include/libcamera/ipa/raspberrypi.h | 42 +--\n> >>> src/ipa/raspberrypi/cam_helper.cpp | 2 +-\n> >>> src/ipa/raspberrypi/cam_helper.hpp | 2 +-\n> >>> src/ipa/raspberrypi/cam_helper_imx219.cpp | 2 +-\n> >>> src/ipa/raspberrypi/cam_helper_imx477.cpp | 2 +-\n> >>> src/ipa/raspberrypi/cam_helper_ov5647.cpp | 2 +-\n> >>> .../raspberrypi/controller/agc_algorithm.hpp | 4 +-\n> >>> src/ipa/raspberrypi/controller/algorithm.cpp | 4 +-\n> >>> src/ipa/raspberrypi/controller/algorithm.hpp | 4 +-\n> >>> .../raspberrypi/controller/awb_algorithm.hpp | 4 +-\n> >>> .../raspberrypi/controller/ccm_algorithm.hpp | 4 +-\n> >>> .../controller/contrast_algorithm.hpp | 4 +-\n> >>> src/ipa/raspberrypi/controller/controller.cpp | 2 +-\n> >>> src/ipa/raspberrypi/controller/controller.hpp | 4 +-\n> >>> src/ipa/raspberrypi/controller/histogram.cpp | 2 +-\n> >>> src/ipa/raspberrypi/controller/histogram.hpp | 4 +-\n> >>> src/ipa/raspberrypi/controller/metadata.hpp | 4 +-\n> >>> src/ipa/raspberrypi/controller/pwl.cpp | 2 +-\n> >>> src/ipa/raspberrypi/controller/pwl.hpp | 4 +-\n> >>> src/ipa/raspberrypi/controller/rpi/agc.cpp | 2 +-\n> >>> src/ipa/raspberrypi/controller/rpi/agc.hpp | 4 +-\n> >>> src/ipa/raspberrypi/controller/rpi/alsc.cpp | 2 +-\n> >>> src/ipa/raspberrypi/controller/rpi/alsc.hpp | 4 +-\n> >>> src/ipa/raspberrypi/controller/rpi/awb.cpp | 2 +-\n> >>> src/ipa/raspberrypi/controller/rpi/awb.hpp | 4 +-\n> >>> .../controller/rpi/black_level.cpp | 2 +-\n> >>> .../controller/rpi/black_level.hpp | 4 +-\n> >>> src/ipa/raspberrypi/controller/rpi/ccm.cpp | 2 +-\n> >>> src/ipa/raspberrypi/controller/rpi/ccm.hpp | 4 +-\n> >>> .../raspberrypi/controller/rpi/contrast.cpp | 2 +-\n> >>> .../raspberrypi/controller/rpi/contrast.hpp | 4 +-\n> >>> src/ipa/raspberrypi/controller/rpi/dpc.cpp | 2 +-\n> >>> src/ipa/raspberrypi/controller/rpi/dpc.hpp | 4 +-\n> >>> src/ipa/raspberrypi/controller/rpi/focus.cpp | 2 +-\n> >>> src/ipa/raspberrypi/controller/rpi/focus.hpp | 4 +-\n> >>> src/ipa/raspberrypi/controller/rpi/geq.cpp | 2 +-\n> >>> src/ipa/raspberrypi/controller/rpi/geq.hpp | 4 +-\n> >>> src/ipa/raspberrypi/controller/rpi/lux.cpp | 2 +-\n> >>> src/ipa/raspberrypi/controller/rpi/lux.hpp | 4 +-\n> >>> src/ipa/raspberrypi/controller/rpi/noise.cpp | 2 +-\n> >>> src/ipa/raspberrypi/controller/rpi/noise.hpp | 4 +-\n> >>> src/ipa/raspberrypi/controller/rpi/sdn.cpp | 2 +-\n> >>> src/ipa/raspberrypi/controller/rpi/sdn.hpp | 4 +-\n> >>> .../raspberrypi/controller/rpi/sharpen.cpp | 2 +-\n> >>> .../raspberrypi/controller/rpi/sharpen.hpp | 4 +-\n> >>> .../controller/sharpen_algorithm.hpp | 4 +-\n> >>> src/ipa/raspberrypi/md_parser.cpp | 2 +-\n> >>> src/ipa/raspberrypi/md_parser.hpp | 2 +-\n> >>> src/ipa/raspberrypi/md_parser_rpi.cpp | 2 +-\n> >>> src/ipa/raspberrypi/md_parser_rpi.hpp | 2 +-\n> >>> src/ipa/raspberrypi/raspberrypi.cpp | 269 +++++++++---------\n> >>> .../pipeline/raspberrypi/raspberrypi.cpp | 84 +++---\n> >>> .../pipeline/raspberrypi/rpi_stream.cpp | 38 +--\n> >>> .../pipeline/raspberrypi/rpi_stream.h | 20 +-\n> >>> 54 files changed, 304 insertions(+), 295 deletions(-)\n> >>>\n> >>> --\n> >>> 2.25.1\n> >>>\n> >> _______________________________________________\n> >> libcamera-devel mailing list\n> >> libcamera-devel@lists.libcamera.org\n> >> https://lists.libcamera.org/listinfo/libcamera-devel\n> >>\n> >\n>\n> --\n> Regards\n> --\n> Kieran","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7DE36C3B5B\n\tfor ;\n\tTue, 29 Sep 2020 13:05:52 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E3BE0621CD;\n\tTue, 29 Sep 2020 15:05:51 +0200 (CEST)","from mail-lf1-x144.google.com (mail-lf1-x144.google.com\n\t[IPv6:2a00:1450:4864:20::144])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1032860365\n\tfor ;\n\tTue, 29 Sep 2020 15:05:49 +0200 (CEST)","by mail-lf1-x144.google.com with SMTP id d15so5386864lfq.11\n\tfor ;\n\tTue, 29 Sep 2020 06:05:49 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"BkrFe6ft\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=HAmLCSxTn9SQ36pXhYwGWmbXbrlbHUKrJhfqqIZBrCA=;\n\tb=BkrFe6ftdINoAY+Sdae0LTBldBjIOT5FWY2UIJ4Rg3FjeLzIZVtrhOGn6Nhub0m3M3\n\t0mEV5BtEx2zrRmexvRGSrkaP0lxcFUKHt4x8Z9iJGXhDWTdFucDxwcW2dGUj80qHOEAl\n\tBDaNRlfRG+Ojk7Y6JUZjOJzn/of78uAoEt8dJQ+Zsz+aatJD0LFUwvo2SPm6HBZ6IP7L\n\t7nL3Q3Hqunk0nQ1pfwRWTqwMiAXBWcuFCqn8oi53nvkGccmflLdMeUXdX22BWLG7OqA5\n\tm1Uu1ofOvwFA01cuPheyTiNpnyp2psnzruk3fudCr5xV43W9Z+KYdUOzD5cTrkVmPuAW\n\tfItQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=HAmLCSxTn9SQ36pXhYwGWmbXbrlbHUKrJhfqqIZBrCA=;\n\tb=FRSnqTfZ0FKfOGDUtFpWYRszth2RBkGMSXKQoJdAXQxZBZSWTuRVP5x06dkmuNDLWs\n\t/Pq7yi/eJfTJ7AxRttid8QksFxnQm1L+gPJR3gAbIwcJKJA7yKu0F/k0dhv8jbp3KWbj\n\to90T14vH06U8QwdOD9LBxKgZOqI7WNLDfDexRyGKOQtUDBWrjLaS6vmHzbedgEvtVSBA\n\tKkYN8KtT0pQ87iG36Uu/F7HKv6/6R95028toLqNhgj1mn8APf2XrjuMteTqR5Cc90FKr\n\tfgXejEHcpWoTUbtVZoMfV/ZNXopBvd7lj/IdKYsX9DBGpyuGzwjAB1JsJwHF7lRRckRF\n\t6E7w==","X-Gm-Message-State":"AOAM5313Hc8VwbH5q5yQDpvrXHhwPcMVNgD1c4bKWUNeUs6+mAQ4osqf\n\tvJ0FOoJPhpkdvgdeMbeNlLIfjr10HS0fTaI3L1XZn3Myfdk=","X-Google-Smtp-Source":"ABdhPJylisVgJPcoGV7Lve+qfz42HU97IWSllCDRXBZHXflAU9Tm+PtEPLAGqI/FIMbqq78dr/BASjP09LaMPENYNSE=","X-Received":"by 2002:a19:e03:: with SMTP id 3mr1078919lfo.488.1601384748852; \n\tTue, 29 Sep 2020 06:05:48 -0700 (PDT)","MIME-Version":"1.0","References":"<20200924091927.116385-1-naush@raspberrypi.com>\n\t\n\t\n\t<74a80111-ab38-bc36-8393-24cd9722e443@ideasonboard.com>","In-Reply-To":"<74a80111-ab38-bc36-8393-24cd9722e443@ideasonboard.com>","From":"Naushir Patuck ","Date":"Tue, 29 Sep 2020 14:05:32 +0100","Message-ID":"","To":"Kieran Bingham ","Subject":"Re: [libcamera-devel] [PATCH 0/4] Code tidy-ups","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]