{"id":9780,"url":"https://patchwork.libcamera.org/api/covers/9780/?format=json","web_url":"https://patchwork.libcamera.org/cover/9780/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200924091927.116385-1-naush@raspberrypi.com>","date":"2020-09-24T09:19:23","name":"[libcamera-devel,0/4] Code tidy-ups","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/?format=json","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"mbox":"https://patchwork.libcamera.org/cover/9780/mbox/","series":[{"id":1318,"url":"https://patchwork.libcamera.org/api/series/1318/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1318","date":"2020-09-24T09:19:23","name":"Code tidy-ups","version":1,"mbox":"https://patchwork.libcamera.org/series/1318/mbox/"}],"comments":"https://patchwork.libcamera.org/api/covers/9780/comments/","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E4EACC3B5B\n\tfor ;\n\tThu, 24 Sep 2020 09:19:33 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 38D7262FE1;\n\tThu, 24 Sep 2020 11:19:33 +0200 (CEST)","from mail-wr1-x42f.google.com (mail-wr1-x42f.google.com\n\t[IPv6:2a00:1450:4864:20::42f])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8869D60362\n\tfor ;\n\tThu, 24 Sep 2020 11:19:31 +0200 (CEST)","by mail-wr1-x42f.google.com with SMTP id e16so3009092wrm.2\n\tfor ;\n\tThu, 24 Sep 2020 02:19:31 -0700 (PDT)","from naushir-VirtualBox.pitowers.org\n\t([2a00:1098:3142:14:a00:27ff:fe4d:f6a2])\n\tby smtp.gmail.com with ESMTPSA id\n\tw81sm2689324wmg.47.2020.09.24.02.19.29\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 24 Sep 2020 02:19:30 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"JcT0ccdL\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=5IBW7h4S5BQMfLGqQwOvkK3dwRkQRS5xjIlXjV7DCAk=;\n\tb=JcT0ccdL8+omSXBLw2rmL42ZoISaJaIwumWuoolbJuyMLcgy51j++lUn8uORL094UM\n\tMBgM9PIf4WT04FbgwZeFPmQyaREezjx7XQwo1OgwMWc3P7RlIeeyzYUVskqzijgiloUV\n\tvBmTTUrZGVqfS3+u2ftYzPmqTV8xOj5jKW0kIOgNz+ADXqVHfJcsFj83XBiZK0joxydl\n\tadLc1WjKYifxjzrvxsxtQDDV5QpZ2dpuGGmyhG+1Zch3TPtJlZV9kNB4woyDJejN546t\n\tLS51dN/k5ggmQm09kpoBN4Q7awiGuTJKFNKLMrMebeW0dRa24+F+nFbiEO66ui+pbL32\n\tFqBA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=5IBW7h4S5BQMfLGqQwOvkK3dwRkQRS5xjIlXjV7DCAk=;\n\tb=SbZZhQXI1A/PHQFr/OwMM0eJDKsQ1DocGwAVWCdegghyvMV0RkvHGg8RNoBpD9p2Kc\n\t+q4CE7CoPxfdXp1ff7Zv9pXLYRnwnmilrx2Qyr03cm13cC+rrXi96t3sfUZKyWXaxYRn\n\tdKboB62az9TUa43ZLpjxj4hsq8vq/PPl5kG5nMiY8xmb6JZLEBh7f9FvrrleneQaN85H\n\tlKdrbgMl+R9MGDrR6Krmol3eVVIDHXpkrEOdhjIxeadEvB3KTK9qQFTwqhSsuIbxgvBN\n\tCqjHoH00Y5CYcZbaxgjtxYbZ1VP3heDvGqQfNZmAIv1AqFMl1g55BpN81Zu6IthsV4o3\n\tqArw==","X-Gm-Message-State":"AOAM531+1j+fIIXrh+BY+jGh0DFBtiZNtSdu6jW9796CxmenDVLVTIud\n\tf4/PFfU//R4OJuQT84ZDAQndBaTG9aP13g==","X-Google-Smtp-Source":"ABdhPJz2Mg2GkhXZe+ehYdJSmYaOZ+4dYYIbpmncpmORNWEW+4RNfpWQtjJKPam9HzsOONwW1EI/Og==","X-Received":"by 2002:a5d:4c88:: with SMTP id z8mr3982792wrs.218.1600939170822;\n\tThu, 24 Sep 2020 02:19:30 -0700 (PDT)","From":"Naushir Patuck ","To":"libcamera-devel@lists.libcamera.org","Date":"Thu, 24 Sep 2020 10:19:23 +0100","Message-Id":"<20200924091927.116385-1-naush@raspberrypi.com>","X-Mailer":"git-send-email 2.25.1","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH 0/4] Code tidy-ups","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Hi,\n\nThank you all for the comments on v1. This v2 update addresses all that was discussed:\n\n- Reword commit message for patch 1/4.\n- Re-order commits 2/4 and 3/4 to have a more logical flow of changes.\n- Some blank lines added in 4/4 for better code readability.\n- constexpr int -> constexpr double\n\nI have not added an ipa:: namespace. This may warrant some more thought, would we\nconsider adding libcamera core parameters to this namespace, or is it going to be\nvendor specific? Either way, I think this can be addeded at a later date.\n\nRegards,\nNaush\n\n\nNaushir Patuck (4):\n pipeline: raspberrypi: Rename RPi::RPiStream and RPi::RPiDevice\n ipa: raspberrypi: Rename the controller namespace from Rpi to\n RpiController\n ipa: raspberrypi: Move IPA parameters to the RPi namespace\n ipa: raspberrypi: Tidy up variable names to be consistent\n\n include/libcamera/ipa/raspberrypi.h | 42 +--\n src/ipa/raspberrypi/cam_helper.cpp | 2 +-\n src/ipa/raspberrypi/cam_helper.hpp | 2 +-\n src/ipa/raspberrypi/cam_helper_imx219.cpp | 2 +-\n src/ipa/raspberrypi/cam_helper_imx477.cpp | 2 +-\n src/ipa/raspberrypi/cam_helper_ov5647.cpp | 2 +-\n .../raspberrypi/controller/agc_algorithm.hpp | 4 +-\n src/ipa/raspberrypi/controller/algorithm.cpp | 4 +-\n src/ipa/raspberrypi/controller/algorithm.hpp | 4 +-\n .../raspberrypi/controller/awb_algorithm.hpp | 4 +-\n .../raspberrypi/controller/ccm_algorithm.hpp | 4 +-\n .../controller/contrast_algorithm.hpp | 4 +-\n src/ipa/raspberrypi/controller/controller.cpp | 2 +-\n src/ipa/raspberrypi/controller/controller.hpp | 4 +-\n src/ipa/raspberrypi/controller/histogram.cpp | 2 +-\n src/ipa/raspberrypi/controller/histogram.hpp | 4 +-\n src/ipa/raspberrypi/controller/metadata.hpp | 4 +-\n src/ipa/raspberrypi/controller/pwl.cpp | 2 +-\n src/ipa/raspberrypi/controller/pwl.hpp | 4 +-\n src/ipa/raspberrypi/controller/rpi/agc.cpp | 2 +-\n src/ipa/raspberrypi/controller/rpi/agc.hpp | 4 +-\n src/ipa/raspberrypi/controller/rpi/alsc.cpp | 2 +-\n src/ipa/raspberrypi/controller/rpi/alsc.hpp | 4 +-\n src/ipa/raspberrypi/controller/rpi/awb.cpp | 2 +-\n src/ipa/raspberrypi/controller/rpi/awb.hpp | 4 +-\n .../controller/rpi/black_level.cpp | 2 +-\n .../controller/rpi/black_level.hpp | 4 +-\n src/ipa/raspberrypi/controller/rpi/ccm.cpp | 2 +-\n src/ipa/raspberrypi/controller/rpi/ccm.hpp | 4 +-\n .../raspberrypi/controller/rpi/contrast.cpp | 2 +-\n .../raspberrypi/controller/rpi/contrast.hpp | 4 +-\n src/ipa/raspberrypi/controller/rpi/dpc.cpp | 2 +-\n src/ipa/raspberrypi/controller/rpi/dpc.hpp | 4 +-\n src/ipa/raspberrypi/controller/rpi/focus.cpp | 2 +-\n src/ipa/raspberrypi/controller/rpi/focus.hpp | 4 +-\n src/ipa/raspberrypi/controller/rpi/geq.cpp | 2 +-\n src/ipa/raspberrypi/controller/rpi/geq.hpp | 4 +-\n src/ipa/raspberrypi/controller/rpi/lux.cpp | 2 +-\n src/ipa/raspberrypi/controller/rpi/lux.hpp | 4 +-\n src/ipa/raspberrypi/controller/rpi/noise.cpp | 2 +-\n src/ipa/raspberrypi/controller/rpi/noise.hpp | 4 +-\n src/ipa/raspberrypi/controller/rpi/sdn.cpp | 2 +-\n src/ipa/raspberrypi/controller/rpi/sdn.hpp | 4 +-\n .../raspberrypi/controller/rpi/sharpen.cpp | 2 +-\n .../raspberrypi/controller/rpi/sharpen.hpp | 4 +-\n .../controller/sharpen_algorithm.hpp | 4 +-\n src/ipa/raspberrypi/md_parser.cpp | 2 +-\n src/ipa/raspberrypi/md_parser.hpp | 2 +-\n src/ipa/raspberrypi/md_parser_rpi.cpp | 2 +-\n src/ipa/raspberrypi/md_parser_rpi.hpp | 2 +-\n src/ipa/raspberrypi/raspberrypi.cpp | 269 +++++++++---------\n .../pipeline/raspberrypi/raspberrypi.cpp | 84 +++---\n .../pipeline/raspberrypi/rpi_stream.cpp | 38 +--\n .../pipeline/raspberrypi/rpi_stream.h | 20 +-\n 54 files changed, 304 insertions(+), 295 deletions(-)"}