[{"id":12735,"web_url":"https://patchwork.libcamera.org/comment/12735/","msgid":"<20200924141054.GQ3968@pendragon.ideasonboard.com>","date":"2020-09-24T14:10:54","subject":"Re: [libcamera-devel] [PATCH v2 00/11] Fix README.rst","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Ricardo,\n\nThank you for the patches.\n\nOverall this looks good to me. If you agree with the small comments I\nmade in response to 01/13 and 03/13, there's no need to resubmit, I can\nupdate them when applying (although you may want to submit a v2.1 of\n01/13 only, as the commit message needs to be updated too, but I can\nhandle that as well).\n\nOn Thu, Sep 24, 2020 at 09:19:11AM +0200, Ricardo Ribalda wrote:\n> I have started to hack around libcamera inside a docker installation,\n> and while doing that I discovered that some of the documentation is\n> slightly outdated.\n> \n> As this is my first contribution I have splitted the changes maybe too\n> much, please squash them if needed.\n> \n> Cheers!\n> \n> Changelog:\n> \n> v2:\n> \n> - Convert Documentation into features\n> - Boost->dependency for Rpi\n> - Python3-yaml: its own paragraph\n> \n> Ricardo Ribalda (11):\n> README: Unify dependency names\n> README: Move the required dependencies to the top\n> README: Add libboost to list of dependencies\n> README: Move pkg-config to Meson section\n> README: Add missing package for Qt5 tools\n> README: Add missing libtiff-dev package for qcam\n> README: Add missing dependency for documentation\n> Documentation: Search for dot binary\n> Documentation: Move all dependencies into features\n> meson: Bump meson version to 0.51\n> libcamera: Add a check for the yaml module\n> \n> Documentation/meson.build | 7 ++++---\n> README.rst | 28 ++++++++++++++++++++--------\n> meson.build | 6 ++----\n> meson_options.txt | 2 +-\n> src/libcamera/meson.build | 1 +\n> 5 files changed, 28 insertions(+), 16 deletions(-)","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2530EC3B5B\n\tfor ;\n\tThu, 24 Sep 2020 14:11:30 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 89E7A62FDA;\n\tThu, 24 Sep 2020 16:11:29 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4D19360362\n\tfor ;\n\tThu, 24 Sep 2020 16:11:28 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A13892FD;\n\tThu, 24 Sep 2020 16:11:27 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"m/gxN3xA\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1600956687;\n\tbh=sWO+EtEKmT52i+RCHLLiEHofTMGNRCUG4jBGv7AmePs=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=m/gxN3xAEIBTKrbfu0DxeNQ7Rv7ITJV4e82GLjTnjvwRKXMQJCCaWrvo1jzKYHIgf\n\tNPCJv3+P5BORbsIL+bj61Cv6XYk8f8FOGG8Uk+wQUz/Lz0LbeTZcjSDQnpP6wFEDq5\n\t31qsyIFtNq58UHpZ4xDTXCgzKxwLhd5mSbkDMbgE=","Date":"Thu, 24 Sep 2020 17:10:54 +0300","From":"Laurent Pinchart ","To":"Ricardo Ribalda ","Message-ID":"<20200924141054.GQ3968@pendragon.ideasonboard.com>","References":"<20200924071922.231063-1-ricardo@ribalda.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200924071922.231063-1-ricardo@ribalda.com>","Subject":"Re: [libcamera-devel] [PATCH v2 00/11] Fix README.rst","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]