[{"id":12709,"web_url":"https://patchwork.libcamera.org/comment/12709/","msgid":"<20200924031457.GB5239@pendragon.ideasonboard.com>","date":"2020-09-24T03:14:57","subject":"Re: [libcamera-devel] [simple-cam PATCH 0/4] simple-cam: Update to\n\tlatest API usage","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nThank you for the patches.\n\nOn Wed, Sep 23, 2020 at 05:44:08PM +0100, Kieran Bingham wrote:\n> The simple-cam app needs to be updated with a few API updates to work on\n> the latest libcamera builds.\n> \n> This is based on the code at https://github.com/kbingham/simple-cam\n> though I hope to move this to a more official location soon.\n\nFor the whole series,\n\nReviewed-by: Laurent Pinchart \n\nIt would be interesting to test-compile simple-cam when libcamera gains\nnew commits. It can probably wait until libcamera itself gets CI though\n:-)\n\n> Kieran Bingham (4):\n> simple-cam: Use the new BufferMap interface\n> simple-cam: Use a const stream\n> meson: Remove incorrect default\n> meson: Update to C++17\n> \n> meson.build | 3 +--\n> simple-cam.cpp | 4 ++--\n> 2 files changed, 3 insertions(+), 4 deletions(-)","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 861D4C3B5C\n\tfor ;\n\tThu, 24 Sep 2020 03:15:33 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 15B2B62FDE;\n\tThu, 24 Sep 2020 05:15:33 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D9C9D6036A\n\tfor ;\n\tThu, 24 Sep 2020 05:15:31 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 5FF7C2FD;\n\tThu, 24 Sep 2020 05:15:31 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"JPVBwy7/\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1600917331;\n\tbh=U3jR8qzorUSr6ecIhuDPZc7cjb91uqun/f3DLgtsj5U=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=JPVBwy7/4HW9p23Zqch4roEiRg9VVOmRaEcCppi4sHlh1EahjxGGtsu3HH+DhM92f\n\tUgw59QF4o0/VtFm3jUav9MSm/2J+s6PHUS2rW302d3URIakTPAmcVscJmhN0O8dTw5\n\tCZjZHuLz810Ez9wpGFYDAnoops74cq93iDlGRdTU=","Date":"Thu, 24 Sep 2020 06:14:57 +0300","From":"Laurent Pinchart ","To":"Kieran Bingham ","Message-ID":"<20200924031457.GB5239@pendragon.ideasonboard.com>","References":"<20200923164412.319079-1-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200923164412.319079-1-kieran.bingham@ideasonboard.com>","Subject":"Re: [libcamera-devel] [simple-cam PATCH 0/4] simple-cam: Update to\n\tlatest API usage","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":12715,"web_url":"https://patchwork.libcamera.org/comment/12715/","msgid":"","date":"2020-09-24T08:52:11","subject":"Re: [libcamera-devel] [simple-cam PATCH 0/4] simple-cam: Update to\n\tlatest API usage","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Laurent,\n\nOn 24/09/2020 04:14, Laurent Pinchart wrote:\n> Hi Kieran,\n> \n> Thank you for the patches.\n> \n> On Wed, Sep 23, 2020 at 05:44:08PM +0100, Kieran Bingham wrote:\n>> The simple-cam app needs to be updated with a few API updates to work on\n>> the latest libcamera builds.\n>>\n>> This is based on the code at https://github.com/kbingham/simple-cam\n>> though I hope to move this to a more official location soon.\n> \n> For the whole series,\n> \n> Reviewed-by: Laurent Pinchart \n> \n> It would be interesting to test-compile simple-cam when libcamera gains\n> new commits. It can probably wait until libcamera itself gets CI though\n> :-)\n\nThis is something I've been working on.\n\nThere are two options, an easy way and a hard way (to do this without\ninstalling the library on each build).\n\nThe hard way (which is of course what was recommended in #meson) is to\nprovide a meson wrap for libcamera, so that it can be a subproject to\nsimple-cam. This means if libcamera is not found as a dependency it will\nclone libcamera, build it - and automatically link against it statically.\n\nIt doesn't work - due to faults in our set up of the build system and\nincorrect usage of things like meson.build_root() and meson.source_root().\n\nMy conversation led to one of the meson devs deciding to mark those as\ndeprecated :\n (See https://github.com/mesonbuild/meson/pull/7772)\n\nAnyway, the easy and quick way - is that meson creates a pkg-config\n'-uninstalled' location at $BUILD/meson-uninstalled ... and it's really\neasy to build an app against an uninstalled library by pointing\nPKG_CONFIG_DIR=$BUILD/meson-uninstalled\n\nSo that's a really quick and effective way of also compiling the\n'external' simple-cam against a 'just built' libcamera.\n\nI'm adding that to my daily builder, (the one that also does a\ncoverity-scan build, and a full matrix build of all compilers on my\nlaptop) - so I'll know as soon as there is breakage.\n\nAnd indeed, sometime we'll move this to a more fully handled CI system too.\n\nAnyway, thanks for the review, I'll push these patches to my repo.\n\n--\nKieran\n\n\n\n> \n>> Kieran Bingham (4):\n>> simple-cam: Use the new BufferMap interface\n>> simple-cam: Use a const stream\n>> meson: Remove incorrect default\n>> meson: Update to C++17\n>>\n>> meson.build | 3 +--\n>> simple-cam.cpp | 4 ++--\n>> 2 files changed, 3 insertions(+), 4 deletions(-)\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 75D05C3B5B\n\tfor ;\n\tThu, 24 Sep 2020 08:52:16 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0A04D62FDE;\n\tThu, 24 Sep 2020 10:52:16 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 15D6D60362\n\tfor ;\n\tThu, 24 Sep 2020 10:52:15 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 7ACCD2FD;\n\tThu, 24 Sep 2020 10:52:14 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"M7apEmHy\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1600937534;\n\tbh=IBVz1WfFoRpWMwotbZJsgs2eK+C6KCf9G34klzwHcik=;\n\th=Reply-To:Subject:To:Cc:References:From:Date:In-Reply-To:From;\n\tb=M7apEmHyjrlhvvXkkzcMQjz07QrgwgDkrxnsxk0YVga4ehc3zfCnykVXJtSvMQQNe\n\tLpn8T61YkJFPTeNE5PUO+IfsSfmc+SeuXBk0DCYSI29sVzBRgIBBCjlnffZTfyik+6\n\tSl606oxLTrOYjpn2sYm5hHLYJnBK3te2BxZyKiHk=","To":"Laurent Pinchart ","References":"<20200923164412.319079-1-kieran.bingham@ideasonboard.com>\n\t<20200924031457.GB5239@pendragon.ideasonboard.com>","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"","Date":"Thu, 24 Sep 2020 09:52:11 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"<20200924031457.GB5239@pendragon.ideasonboard.com>","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [simple-cam PATCH 0/4] simple-cam: Update to\n\tlatest API usage","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"kieran.bingham@ideasonboard.com","Cc":"libcamera devel ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":12724,"web_url":"https://patchwork.libcamera.org/comment/12724/","msgid":"<20200924114407.GA3968@pendragon.ideasonboard.com>","date":"2020-09-24T11:44:07","subject":"Re: [libcamera-devel] [simple-cam PATCH 0/4] simple-cam: Update to\n\tlatest API usage","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nOn Thu, Sep 24, 2020 at 09:52:11AM +0100, Kieran Bingham wrote:\n> On 24/09/2020 04:14, Laurent Pinchart wrote:\n> > On Wed, Sep 23, 2020 at 05:44:08PM +0100, Kieran Bingham wrote:\n> >> The simple-cam app needs to be updated with a few API updates to work on\n> >> the latest libcamera builds.\n> >>\n> >> This is based on the code at https://github.com/kbingham/simple-cam\n> >> though I hope to move this to a more official location soon.\n> > \n> > For the whole series,\n> > \n> > Reviewed-by: Laurent Pinchart \n> > \n> > It would be interesting to test-compile simple-cam when libcamera gains\n> > new commits. It can probably wait until libcamera itself gets CI though\n> > :-)\n> \n> This is something I've been working on.\n> \n> There are two options, an easy way and a hard way (to do this without\n> installing the library on each build).\n> \n> The hard way (which is of course what was recommended in #meson) is to\n> provide a meson wrap for libcamera, so that it can be a subproject to\n> simple-cam. This means if libcamera is not found as a dependency it will\n> clone libcamera, build it - and automatically link against it statically.\n> \n> It doesn't work - due to faults in our set up of the build system and\n> incorrect usage of things like meson.build_root() and meson.source_root().\n\nPatches are welcome :-)\n\n> My conversation led to one of the meson devs deciding to mark those as\n> deprecated :\n> (See https://github.com/mesonbuild/meson/pull/7772)\n>\n> Anyway, the easy and quick way - is that meson creates a pkg-config\n> '-uninstalled' location at $BUILD/meson-uninstalled ... and it's really\n> easy to build an app against an uninstalled library by pointing\n> PKG_CONFIG_DIR=$BUILD/meson-uninstalled\n> \n> So that's a really quick and effective way of also compiling the\n> 'external' simple-cam against a 'just built' libcamera.\n\nFrom a build server point of view, I thought the builder could get the\nlatest libcamera master branch, build it, and install it. Why would we\nneed an \"uninstalled\" location ?\n\n> I'm adding that to my daily builder, (the one that also does a\n> coverity-scan build, and a full matrix build of all compilers on my\n> laptop) - so I'll know as soon as there is breakage.\n> \n> And indeed, sometime we'll move this to a more fully handled CI system too.\n> \n> Anyway, thanks for the review, I'll push these patches to my repo.\n> \n> >> Kieran Bingham (4):\n> >> simple-cam: Use the new BufferMap interface\n> >> simple-cam: Use a const stream\n> >> meson: Remove incorrect default\n> >> meson: Update to C++17\n> >>\n> >> meson.build | 3 +--\n> >> simple-cam.cpp | 4 ++--\n> >> 2 files changed, 3 insertions(+), 4 deletions(-)","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 72933C3B5C\n\tfor ;\n\tThu, 24 Sep 2020 11:44:43 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0034462FDE;\n\tThu, 24 Sep 2020 13:44:42 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 236F460363\n\tfor ;\n\tThu, 24 Sep 2020 13:44:41 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 9B1312FD;\n\tThu, 24 Sep 2020 13:44:40 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"asNJploi\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1600947880;\n\tbh=gWs0/RkU3Iw0hxfqSXYFLjNaOxDmx2gobh+YXPF/i54=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=asNJploiFVscGgNuFYhNqXr32bbjTIDo3MHfOLU6Hiy+f2h11ZpM6N+HSmbJL3nVN\n\tSNOZSz53CdKS6IKRnuRnyJ5HbG60+NjfsTcIaXUsfzxmvNuhpqej/Q0SwHqvcamaDG\n\tQJK3z6uC92gQfosCo1mgX3uBzVxActpvSZjV9B5M=","Date":"Thu, 24 Sep 2020 14:44:07 +0300","From":"Laurent Pinchart ","To":"Kieran Bingham ","Message-ID":"<20200924114407.GA3968@pendragon.ideasonboard.com>","References":"<20200923164412.319079-1-kieran.bingham@ideasonboard.com>\n\t<20200924031457.GB5239@pendragon.ideasonboard.com>\n\t","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"","Subject":"Re: [libcamera-devel] [simple-cam PATCH 0/4] simple-cam: Update to\n\tlatest API usage","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":12740,"web_url":"https://patchwork.libcamera.org/comment/12740/","msgid":"","date":"2020-09-24T14:47:25","subject":"Re: [libcamera-devel] [simple-cam PATCH 0/4] simple-cam: Update to\n\tlatest API usage","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Laurent,\n\nOn 24/09/2020 12:44, Laurent Pinchart wrote:\n> Hi Kieran,\n> \n> On Thu, Sep 24, 2020 at 09:52:11AM +0100, Kieran Bingham wrote:\n>> On 24/09/2020 04:14, Laurent Pinchart wrote:\n>>> On Wed, Sep 23, 2020 at 05:44:08PM +0100, Kieran Bingham wrote:\n>>>> The simple-cam app needs to be updated with a few API updates to work on\n>>>> the latest libcamera builds.\n>>>>\n>>>> This is based on the code at https://github.com/kbingham/simple-cam\n>>>> though I hope to move this to a more official location soon.\n>>>\n>>> For the whole series,\n>>>\n>>> Reviewed-by: Laurent Pinchart \n>>>\n>>> It would be interesting to test-compile simple-cam when libcamera gains\n>>> new commits. It can probably wait until libcamera itself gets CI though\n>>> :-)\n>>\n>> This is something I've been working on.\n>>\n>> There are two options, an easy way and a hard way (to do this without\n>> installing the library on each build).\n>>\n>> The hard way (which is of course what was recommended in #meson) is to\n>> provide a meson wrap for libcamera, so that it can be a subproject to\n>> simple-cam. This means if libcamera is not found as a dependency it will\n>> clone libcamera, build it - and automatically link against it statically.\n>>\n>> It doesn't work - due to faults in our set up of the build system and\n>> incorrect usage of things like meson.build_root() and meson.source_root().\n> \n> Patches are welcome :-)\n\nSure - they're already on my todo list from yesterday ;-)\n\n\n>> My conversation led to one of the meson devs deciding to mark those as\n>> deprecated :\n>> (See https://github.com/mesonbuild/meson/pull/7772)\n>>\n>> Anyway, the easy and quick way - is that meson creates a pkg-config\n>> '-uninstalled' location at $BUILD/meson-uninstalled ... and it's really\n>> easy to build an app against an uninstalled library by pointing\n>> PKG_CONFIG_DIR=$BUILD/meson-uninstalled\n\nAhem, s/PKG_CONFIG_DIR/PKG_CONFIG_PATH/\n\n>>\n>> So that's a really quick and effective way of also compiling the\n>> 'external' simple-cam against a 'just built' libcamera.\n> \n> From a build server point of view, I thought the builder could get the\n> latest libcamera master branch, build it, and install it. Why would we\n> need an \"uninstalled\" location ?\n\nHrm, my original answer here was 'because you need to be root to\ninstall' ... but that's not correct. You can install to a non-root owned\nlocation (and then make sure the library is on the PKG_CONFIG_PATH...)\n\nSo that's also an option ... and also validates the install procedures.\n\n\n\n> \n>> I'm adding that to my daily builder, (the one that also does a\n>> coverity-scan build, and a full matrix build of all compilers on my\n>> laptop) - so I'll know as soon as there is breakage.\n>>\n>> And indeed, sometime we'll move this to a more fully handled CI system too.\n>>\n>> Anyway, thanks for the review, I'll push these patches to my repo.\n>>\n>>>> Kieran Bingham (4):\n>>>> simple-cam: Use the new BufferMap interface\n>>>> simple-cam: Use a const stream\n>>>> meson: Remove incorrect default\n>>>> meson: Update to C++17\n>>>>\n>>>> meson.build | 3 +--\n>>>> simple-cam.cpp | 4 ++--\n>>>> 2 files changed, 3 insertions(+), 4 deletions(-)\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 492FCC3B5C\n\tfor ;\n\tThu, 24 Sep 2020 14:47:31 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id CE76E60367;\n\tThu, 24 Sep 2020 16:47:30 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 51A5860363\n\tfor ;\n\tThu, 24 Sep 2020 16:47:29 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B1CE42FD;\n\tThu, 24 Sep 2020 16:47:28 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"pv4LaWXh\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1600958848;\n\tbh=Z2fr6aRfwC0l2yVCp9TWJ8hdb+IfEXnQeRzB7scZPqc=;\n\th=Reply-To:Subject:To:Cc:References:From:Date:In-Reply-To:From;\n\tb=pv4LaWXhE5hAMYRpLNAaylyEsATHmR4djBts8JmjLfCSFIxChKPx6JsrMZn4n74gL\n\th9TXI1LShUaa7R54h7apsiV9+xez9M8XLHR51Td4piayVPB13nkZmtjb6R48K9qtcx\n\t0x1nelvnurw0+cM2hAs2C528UUFfa5uovpWR8iE0=","To":"Laurent Pinchart ","References":"<20200923164412.319079-1-kieran.bingham@ideasonboard.com>\n\t<20200924031457.GB5239@pendragon.ideasonboard.com>\n\t\n\t<20200924114407.GA3968@pendragon.ideasonboard.com>","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"","Date":"Thu, 24 Sep 2020 15:47:25 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"<20200924114407.GA3968@pendragon.ideasonboard.com>","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [simple-cam PATCH 0/4] simple-cam: Update to\n\tlatest API usage","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"kieran.bingham@ideasonboard.com","Cc":"libcamera devel ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":12741,"web_url":"https://patchwork.libcamera.org/comment/12741/","msgid":"<20200924145430.GU3968@pendragon.ideasonboard.com>","date":"2020-09-24T14:54:30","subject":"Re: [libcamera-devel] [simple-cam PATCH 0/4] simple-cam: Update to\n\tlatest API usage","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nOn Thu, Sep 24, 2020 at 03:47:25PM +0100, Kieran Bingham wrote:\n> On 24/09/2020 12:44, Laurent Pinchart wrote:\n> > On Thu, Sep 24, 2020 at 09:52:11AM +0100, Kieran Bingham wrote:\n> >> On 24/09/2020 04:14, Laurent Pinchart wrote:\n> >>> On Wed, Sep 23, 2020 at 05:44:08PM +0100, Kieran Bingham wrote:\n> >>>> The simple-cam app needs to be updated with a few API updates to work on\n> >>>> the latest libcamera builds.\n> >>>>\n> >>>> This is based on the code at https://github.com/kbingham/simple-cam\n> >>>> though I hope to move this to a more official location soon.\n> >>>\n> >>> For the whole series,\n> >>>\n> >>> Reviewed-by: Laurent Pinchart \n> >>>\n> >>> It would be interesting to test-compile simple-cam when libcamera gains\n> >>> new commits. It can probably wait until libcamera itself gets CI though\n> >>> :-)\n> >>\n> >> This is something I've been working on.\n> >>\n> >> There are two options, an easy way and a hard way (to do this without\n> >> installing the library on each build).\n> >>\n> >> The hard way (which is of course what was recommended in #meson) is to\n> >> provide a meson wrap for libcamera, so that it can be a subproject to\n> >> simple-cam. This means if libcamera is not found as a dependency it will\n> >> clone libcamera, build it - and automatically link against it statically.\n> >>\n> >> It doesn't work - due to faults in our set up of the build system and\n> >> incorrect usage of things like meson.build_root() and meson.source_root().\n> > \n> > Patches are welcome :-)\n> \n> Sure - they're already on my todo list from yesterday ;-)\n> \n> >> My conversation led to one of the meson devs deciding to mark those as\n> >> deprecated :\n> >> (See https://github.com/mesonbuild/meson/pull/7772)\n> >>\n> >> Anyway, the easy and quick way - is that meson creates a pkg-config\n> >> '-uninstalled' location at $BUILD/meson-uninstalled ... and it's really\n> >> easy to build an app against an uninstalled library by pointing\n> >> PKG_CONFIG_DIR=$BUILD/meson-uninstalled\n> \n> Ahem, s/PKG_CONFIG_DIR/PKG_CONFIG_PATH/\n> \n> >> So that's a really quick and effective way of also compiling the\n> >> 'external' simple-cam against a 'just built' libcamera.\n> > \n> > From a build server point of view, I thought the builder could get the\n> > latest libcamera master branch, build it, and install it. Why would we\n> > need an \"uninstalled\" location ?\n> \n> Hrm, my original answer here was 'because you need to be root to\n> install' ... but that's not correct. You can install to a non-root owned\n> location (and then make sure the library is on the PKG_CONFIG_PATH...)\n> \n> So that's also an option ... and also validates the install procedures.\n\nIf the build of simple-cam was automated on a build server, I would\nassume it would happen in a container, so we can install anything in any\nway we want :-)\n\n> >> I'm adding that to my daily builder, (the one that also does a\n> >> coverity-scan build, and a full matrix build of all compilers on my\n> >> laptop) - so I'll know as soon as there is breakage.\n> >>\n> >> And indeed, sometime we'll move this to a more fully handled CI system too.\n> >>\n> >> Anyway, thanks for the review, I'll push these patches to my repo.\n> >>\n> >>>> Kieran Bingham (4):\n> >>>> simple-cam: Use the new BufferMap interface\n> >>>> simple-cam: Use a const stream\n> >>>> meson: Remove incorrect default\n> >>>> meson: Update to C++17\n> >>>>\n> >>>> meson.build | 3 +--\n> >>>> simple-cam.cpp | 4 ++--\n> >>>> 2 files changed, 3 insertions(+), 4 deletions(-)","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A10C5C3B5C\n\tfor ;\n\tThu, 24 Sep 2020 14:55:06 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 10D4962FE3;\n\tThu, 24 Sep 2020 16:55:06 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9419860363\n\tfor ;\n\tThu, 24 Sep 2020 16:55:04 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 0EE6F2FD;\n\tThu, 24 Sep 2020 16:55:04 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"XnpTlvt7\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1600959304;\n\tbh=Hqi5h4RhKJo51olzYTITfaAITjnMRI7zgcobSY/mVEE=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=XnpTlvt7od78vjJ8Xe2a8yLaUMkGaPydX8kan3IgU2UPpruB/9M+gNcOUS8cjgR69\n\tt13KK2VaIORoyXnKT3cB99H393HHPj5L2moAb4Q4psf9iQsF1YpilxT9Z01t7tgh/2\n\t+FFUrjrUeXVfM3erh/zA6p4O9/xIXhp7envtqwgQ=","Date":"Thu, 24 Sep 2020 17:54:30 +0300","From":"Laurent Pinchart ","To":"Kieran Bingham ","Message-ID":"<20200924145430.GU3968@pendragon.ideasonboard.com>","References":"<20200923164412.319079-1-kieran.bingham@ideasonboard.com>\n\t<20200924031457.GB5239@pendragon.ideasonboard.com>\n\t\n\t<20200924114407.GA3968@pendragon.ideasonboard.com>\n\t","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"","Subject":"Re: [libcamera-devel] [simple-cam PATCH 0/4] simple-cam: Update to\n\tlatest API usage","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]