[{"id":12711,"web_url":"https://patchwork.libcamera.org/comment/12711/","msgid":"<20200924074412.GM45948@pyrite.rasen.tech>","date":"2020-09-24T07:44:12","subject":"Re: [libcamera-devel] [PATCH v2 0/4] Unify utils locations","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"Hi Kieran,\n\nOn Wed, Sep 23, 2020 at 03:39:45PM +0100, Kieran Bingham wrote:\n> Various utilities are scattered across the source trees, and are\n> declared as GPLv2.\n> \n> Update the meson build to process the utils subdirectory first, giving\n> us a location where we can define our utilities in a common location.\n> \n> Then move key generator scripts to the utils directory.\n> The ipa_gen_priv_key custom target command is renamed to be in keeping\n> with the other generator commands.\n> \n> The scripts which handle module signing upon installation are not\n> handled in this series, as they currently expect to be run from their\n> current location, and external build systems may be currently\n> referencing from their current location too.\n> \n> Later work will aim to tackle the module-signing scripts, moving those\n> will affect external users.\n> \n> Also of interest is the definition of the gen-version command used by\n> the vcs_tag ... but the vcs tag function does not accept a 'files()'\n> list as it's command parameter, so it's not (yet) suitable to move that\n> variable declaration to utils/meson.build which had aimed to do.\n> \n> Kieran Bingham (4):\n> meson: Process utils first\n> libcamera: Move Header generation utilities to utils\n> src: meson: Rename ipa_gen_priv_key to gen_ipa_priv_key\n> libcamera: ipa: Move key generation to utils\n\nFor all patches in this series:\n\nReviewed-by: Paul Elder \n\n> include/libcamera/meson.build | 6 ------\n> meson.build | 4 +++-\n> src/libcamera/meson.build | 3 ---\n> src/meson.build | 3 +--\n> {src/libcamera => utils}/gen-controls.py | 0\n> {include/libcamera => utils}/gen-formats.py | 0\n> {include/libcamera => utils}/gen-header.sh | 0\n> {src/ipa => utils}/gen-ipa-priv-key.sh | 0\n> {src/libcamera => utils}/gen-ipa-pub-key.py | 0\n> utils/meson.build | 9 +++++++++\n> 10 files changed, 13 insertions(+), 12 deletions(-)\n> rename {src/libcamera => utils}/gen-controls.py (100%)\n> rename {include/libcamera => utils}/gen-formats.py (100%)\n> rename {include/libcamera => utils}/gen-header.sh (100%)\n> rename {src/ipa => utils}/gen-ipa-priv-key.sh (100%)\n> rename {src/libcamera => utils}/gen-ipa-pub-key.py (100%)\n> \n> -- \n> 2.25.1\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 30D4CC3B5B\n\tfor ;\n\tThu, 24 Sep 2020 07:44:23 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B99BB62FD8;\n\tThu, 24 Sep 2020 09:44:22 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9F5B262FD2\n\tfor ;\n\tThu, 24 Sep 2020 09:44:20 +0200 (CEST)","from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id EE9B62FD;\n\tThu, 24 Sep 2020 09:44:18 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"iqaqE3qa\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1600933460;\n\tbh=xzlJz14tIlW1pGm3YPVGYh3nZnQ2DKdtRuY1D/ASG5E=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=iqaqE3qagFRxMWciuLPMRb6zA7g019CTesmgVR6GHrRLMedWZZwHGpdLavj6mGlZR\n\thPOo/H+eWyDCzxPLCxrbfw++rtaSWwG49NgzwYkQ9M18BpD0eqBjJpBfV0Z1K/di6M\n\tdErFpY0Aefqs+npgB8MZCriYZpR4q3WsdHmtseC0=","Date":"Thu, 24 Sep 2020 16:44:12 +0900","From":"paul.elder@ideasonboard.com","To":"Kieran Bingham ","Message-ID":"<20200924074412.GM45948@pyrite.rasen.tech>","References":"<20200923143949.310439-1-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200923143949.310439-1-kieran.bingham@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v2 0/4] Unify utils locations","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]