[{"id":12708,"web_url":"https://patchwork.libcamera.org/comment/12708/","msgid":"<20200924031211.GA5239@pendragon.ideasonboard.com>","date":"2020-09-24T03:12:11","subject":"Re: [libcamera-devel] [PATCH 0/4] Code tidy-ups","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Naush,\n\nThank you for the patch.\n\nOn Tue, Sep 22, 2020 at 10:50:14AM +0100, Naushir Patuck wrote:\n> Hi,\n> \n> This patch set contains some overdue tidying up of the Raspberry Pi\n> controller, ipa, and pipeline hander code. Mostly moving things into\n> their own namespace and removing the \"RPi\" prefix off variable names.\n> Note there there are no functional changes in any of the 4 patches,\n> only adding some syntactic sugar :)\n\nVery nice cleanup series ! I've glanced over it, and Kieran and Jacopo\nhave already pointed out the small issues I've seen.\n\nI'm sure we could bikeshed libcamera::RPi:: vs. IPA::RPi:: (lowercase or\nuppercase), and while I think the suggestion to create an IPA namespace\nis interesting, it doesn't necessarily need to be introduced now (unless\neveryone is convinced).\n\nFor the whole series,\n\nAcked-by: Laurent Pinchart \n\n> Naushir Patuck (4):\n> pipeline: raspberrypi: Move RPiStream and RPiDevice to its own\n> namespace\n> ipa: raspberrypi: Move IPA parameters to the RPi namespace\n> ipa: raspberrypi: Rename the controller namespace from Rpi to\n> RpiController\n> ipa: raspberrypi: Tidy up variable names to be consistent\n> \n> include/libcamera/ipa/raspberrypi.h | 42 +--\n> src/ipa/raspberrypi/cam_helper.cpp | 2 +-\n> src/ipa/raspberrypi/cam_helper.hpp | 2 +-\n> src/ipa/raspberrypi/cam_helper_imx219.cpp | 2 +-\n> src/ipa/raspberrypi/cam_helper_imx477.cpp | 2 +-\n> src/ipa/raspberrypi/cam_helper_ov5647.cpp | 2 +-\n> .../raspberrypi/controller/agc_algorithm.hpp | 4 +-\n> src/ipa/raspberrypi/controller/algorithm.cpp | 4 +-\n> src/ipa/raspberrypi/controller/algorithm.hpp | 4 +-\n> .../raspberrypi/controller/awb_algorithm.hpp | 4 +-\n> .../raspberrypi/controller/ccm_algorithm.hpp | 4 +-\n> .../controller/contrast_algorithm.hpp | 4 +-\n> src/ipa/raspberrypi/controller/controller.cpp | 2 +-\n> src/ipa/raspberrypi/controller/controller.hpp | 4 +-\n> src/ipa/raspberrypi/controller/histogram.cpp | 2 +-\n> src/ipa/raspberrypi/controller/histogram.hpp | 4 +-\n> src/ipa/raspberrypi/controller/metadata.hpp | 4 +-\n> src/ipa/raspberrypi/controller/pwl.cpp | 2 +-\n> src/ipa/raspberrypi/controller/pwl.hpp | 4 +-\n> src/ipa/raspberrypi/controller/rpi/agc.cpp | 2 +-\n> src/ipa/raspberrypi/controller/rpi/agc.hpp | 4 +-\n> src/ipa/raspberrypi/controller/rpi/alsc.cpp | 2 +-\n> src/ipa/raspberrypi/controller/rpi/alsc.hpp | 4 +-\n> src/ipa/raspberrypi/controller/rpi/awb.cpp | 2 +-\n> src/ipa/raspberrypi/controller/rpi/awb.hpp | 4 +-\n> .../controller/rpi/black_level.cpp | 2 +-\n> .../controller/rpi/black_level.hpp | 4 +-\n> src/ipa/raspberrypi/controller/rpi/ccm.cpp | 2 +-\n> src/ipa/raspberrypi/controller/rpi/ccm.hpp | 4 +-\n> .../raspberrypi/controller/rpi/contrast.cpp | 2 +-\n> .../raspberrypi/controller/rpi/contrast.hpp | 4 +-\n> src/ipa/raspberrypi/controller/rpi/dpc.cpp | 2 +-\n> src/ipa/raspberrypi/controller/rpi/dpc.hpp | 4 +-\n> src/ipa/raspberrypi/controller/rpi/focus.cpp | 2 +-\n> src/ipa/raspberrypi/controller/rpi/focus.hpp | 4 +-\n> src/ipa/raspberrypi/controller/rpi/geq.cpp | 2 +-\n> src/ipa/raspberrypi/controller/rpi/geq.hpp | 4 +-\n> src/ipa/raspberrypi/controller/rpi/lux.cpp | 2 +-\n> src/ipa/raspberrypi/controller/rpi/lux.hpp | 4 +-\n> src/ipa/raspberrypi/controller/rpi/noise.cpp | 2 +-\n> src/ipa/raspberrypi/controller/rpi/noise.hpp | 4 +-\n> src/ipa/raspberrypi/controller/rpi/sdn.cpp | 2 +-\n> src/ipa/raspberrypi/controller/rpi/sdn.hpp | 4 +-\n> .../raspberrypi/controller/rpi/sharpen.cpp | 2 +-\n> .../raspberrypi/controller/rpi/sharpen.hpp | 4 +-\n> .../controller/sharpen_algorithm.hpp | 4 +-\n> src/ipa/raspberrypi/md_parser.cpp | 2 +-\n> src/ipa/raspberrypi/md_parser.hpp | 2 +-\n> src/ipa/raspberrypi/md_parser_rpi.cpp | 2 +-\n> src/ipa/raspberrypi/md_parser_rpi.hpp | 2 +-\n> src/ipa/raspberrypi/raspberrypi.cpp | 256 +++++++++---------\n> .../pipeline/raspberrypi/raspberrypi.cpp | 84 +++---\n> .../pipeline/raspberrypi/rpi_stream.cpp | 38 +--\n> .../pipeline/raspberrypi/rpi_stream.h | 20 +-\n> 54 files changed, 295 insertions(+), 291 deletions(-)","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C5E26C3B5C\n\tfor ;\n\tThu, 24 Sep 2020 03:12:46 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5809F62FE3;\n\tThu, 24 Sep 2020 05:12:46 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 810E56036A\n\tfor ;\n\tThu, 24 Sep 2020 05:12:45 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 035202FD;\n\tThu, 24 Sep 2020 05:12:44 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"cP+pK6SL\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1600917165;\n\tbh=3azi3iHHqSIwb6+c/jQUezfgXSMlAa2FvhDwgbYWNXs=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=cP+pK6SL6rtEjkBShWVqhOmMOVGvtnJ8JLMwgIyfmYfk07JD79msViFFXx4KglVB8\n\towiOof8OxOnbV3cYsjFZlXT8bhREhS4RW2sFYQyKtMxXCVD7o6db8v0EzfPzmb+FVj\n\t3hH1bRN02QysUqqYWQ5WV36piMco/BMjWYoIXhzs=","Date":"Thu, 24 Sep 2020 06:12:11 +0300","From":"Laurent Pinchart ","To":"Naushir Patuck ","Message-ID":"<20200924031211.GA5239@pendragon.ideasonboard.com>","References":"<20200922095018.68434-1-naush@raspberrypi.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200922095018.68434-1-naush@raspberrypi.com>","Subject":"Re: [libcamera-devel] [PATCH 0/4] Code tidy-ups","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]