[{"id":12635,"web_url":"https://patchwork.libcamera.org/comment/12635/","msgid":"<20200922081704.GE8290@pendragon.ideasonboard.com>","date":"2020-09-22T08:17:04","subject":"Re: [libcamera-devel] [PATCH v3 0/8] android: camera_device: Add\n\tsupport for internal buffers","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jacopo,\n\nOn Mon, Sep 21, 2020 at 05:37:28PM +0200, Jacopo Mondi wrote:\n> Minimal changes:\n> - added Niklas tag\n> - use switch() instead of if() in 7/8 as suggested by Niklas\n> \n> I would like to push this if no objections\n\nI only see the cover letter, could we also get the patches ? :-)\n\n> Jacopo Mondi (8):\n> android: camera_device: Add CameraStream::Type\n> android: camera_device: Add frame allocator\n> libcamera: frame_buffer_allocator: Add clear()\n> android: camera_device: Clear allocator at configureStream\n> android: camera_device: Allocate buffer pools\n> android: camera_device: Add methods to get and return buffers\n> android: camera_device: Use libcamera buffer pool\n> android: camera_device: Add stream mapping log\n> \n> include/libcamera/framebuffer_allocator.h | 1 +\n> src/android/camera_device.cpp | 164 +++++++++++++++++++---\n> src/android/camera_device.h | 102 +++++++++++++-\n> src/libcamera/framebuffer_allocator.cpp | 8 ++\n> 4 files changed, 252 insertions(+), 23 deletions(-)","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id EFABAC3B5B\n\tfor ;\n\tTue, 22 Sep 2020 08:17:55 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5912C62FD3;\n\tTue, 22 Sep 2020 10:17:55 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0277A60364\n\tfor ;\n\tTue, 22 Sep 2020 10:17:53 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 2B36E2D7;\n\tTue, 22 Sep 2020 10:17:37 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"BczBhigP\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1600762657;\n\tbh=RIFi0xCBOgIkTCTY3hV++TnolW3yWGtXG5TVppXFEtU=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=BczBhigPyt5gLQqKRNgmvNlTfB++yMkjWICYErKpG1hrjmwVdYFQXouojcUBNrVLE\n\t/kZsN9skDgEOuUQNXzaaTJYY0d3EQvWoWFTt9ZPyvAw1asZLwXQ2gIKxTVDgsMATLC\n\thR5uK9721h/q+hbG3moiEFwtKI41uRWuwnV/TaGQ=","Date":"Tue, 22 Sep 2020 11:17:04 +0300","From":"Laurent Pinchart ","To":"Jacopo Mondi ","Message-ID":"<20200922081704.GE8290@pendragon.ideasonboard.com>","References":"<20200921153736.24070-1-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200921153736.24070-1-jacopo@jmondi.org>","Subject":"Re: [libcamera-devel] [PATCH v3 0/8] android: camera_device: Add\n\tsupport for internal buffers","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"hanlinchen@chromium.org, libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":12636,"web_url":"https://patchwork.libcamera.org/comment/12636/","msgid":"<20200922094446.7ppiuqfpphiwmf2y@uno.localdomain>","date":"2020-09-22T09:44:46","subject":"Re: [libcamera-devel] [PATCH v3 0/8] android: camera_device: Add\n\tsupport for internal buffers","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Laurent,\n\nOn Tue, Sep 22, 2020 at 11:17:04AM +0300, Laurent Pinchart wrote:\n> Hi Jacopo,\n>\n> On Mon, Sep 21, 2020 at 05:37:28PM +0200, Jacopo Mondi wrote:\n> > Minimal changes:\n> > - added Niklas tag\n> > - use switch() instead of if() in 7/8 as suggested by Niklas\n> >\n> > I would like to push this if no objections\n>\n> I only see the cover letter, could we also get the patches ? :-)\n>\n\nI hoped you didn't notice and I could merge the series :)\n\nDon't know what happened, the cover letter has the right To: field,\nthe other patches don't... I'll re-send!\n\nThanks\n j\n\n> > Jacopo Mondi (8):\n> > android: camera_device: Add CameraStream::Type\n> > android: camera_device: Add frame allocator\n> > libcamera: frame_buffer_allocator: Add clear()\n> > android: camera_device: Clear allocator at configureStream\n> > android: camera_device: Allocate buffer pools\n> > android: camera_device: Add methods to get and return buffers\n> > android: camera_device: Use libcamera buffer pool\n> > android: camera_device: Add stream mapping log\n> >\n> > include/libcamera/framebuffer_allocator.h | 1 +\n> > src/android/camera_device.cpp | 164 +++++++++++++++++++---\n> > src/android/camera_device.h | 102 +++++++++++++-\n> > src/libcamera/framebuffer_allocator.cpp | 8 ++\n> > 4 files changed, 252 insertions(+), 23 deletions(-)\n>\n> --\n> Regards,\n>\n> Laurent Pinchart","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 86DCDC3B5B\n\tfor ;\n\tTue, 22 Sep 2020 09:40:56 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 08FF362FD3;\n\tTue, 22 Sep 2020 11:40:56 +0200 (CEST)","from relay6-d.mail.gandi.net (relay6-d.mail.gandi.net\n\t[217.70.183.198])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 372AE60364\n\tfor ;\n\tTue, 22 Sep 2020 11:40:54 +0200 (CEST)","from uno.localdomain (93-34-118-233.ip49.fastwebnet.it\n\t[93.34.118.233]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay6-d.mail.gandi.net (Postfix) with ESMTPSA id 5E109C0017;\n\tTue, 22 Sep 2020 09:40:53 +0000 (UTC)"],"X-Originating-IP":"93.34.118.233","Date":"Tue, 22 Sep 2020 11:44:46 +0200","From":"Jacopo Mondi ","To":"Laurent Pinchart ","Message-ID":"<20200922094446.7ppiuqfpphiwmf2y@uno.localdomain>","References":"<20200921153736.24070-1-jacopo@jmondi.org>\n\t<20200922081704.GE8290@pendragon.ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200922081704.GE8290@pendragon.ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v3 0/8] android: camera_device: Add\n\tsupport for internal buffers","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"hanlinchen@chromium.org, libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]