{"id":9567,"url":"https://patchwork.libcamera.org/api/covers/9567/?format=json","web_url":"https://patchwork.libcamera.org/cover/9567/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200911085514.30021-1-show.liu@linaro.org>","date":"2020-09-11T08:55:10","name":"[libcamera-devel,v6,0/4] qcam: accelerate format conversion by OpenGL shader","submitter":{"id":24,"url":"https://patchwork.libcamera.org/api/people/24/?format=json","name":"Show Liu","email":"show.liu@linaro.org"},"mbox":"https://patchwork.libcamera.org/cover/9567/mbox/","series":[{"id":1284,"url":"https://patchwork.libcamera.org/api/series/1284/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1284","date":"2020-09-11T08:55:10","name":"qcam: accelerate format conversion by OpenGL shader","version":6,"mbox":"https://patchwork.libcamera.org/series/1284/mbox/"}],"comments":"https://patchwork.libcamera.org/api/covers/9567/comments/","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E0AA6BDB1D\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 11 Sep 2020 08:55:38 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6B84462901;\n\tFri, 11 Sep 2020 10:55:38 +0200 (CEST)","from mail-pj1-x102d.google.com (mail-pj1-x102d.google.com\n\t[IPv6:2607:f8b0:4864:20::102d])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 65CFC62901\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 11 Sep 2020 10:55:37 +0200 (CEST)","by mail-pj1-x102d.google.com with SMTP id a9so1401572pjg.1\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 11 Sep 2020 01:55:37 -0700 (PDT)","from localhost.localdomain (211-20-20-223.HINET-IP.hinet.net.\n\t[211.20.20.223]) by smtp.gmail.com with ESMTPSA id\n\tw192sm1616543pfd.156.2020.09.11.01.55.34\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 11 Sep 2020 01:55:34 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"SKw5NDOE\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google;\n\th=from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=g5rF5kBuicw7A3no2yHMSF6fvsXZ/+AJ6Lk34A9w4Lk=;\n\tb=SKw5NDOEroMUnkmFMLBCdf5BVByUxiQamz+NpDnmoPBTKfWKnE2Yq99SoQzr7nhpRV\n\tuFbfGxSunX73Aqv59JgALhabLftuINg5rLl10D57n2A2WgqZVIlkOwiqDisgOk0zM5BB\n\t7zHKumUGvVEWrQhZJD1E/+sk0VSiDbVuGyhPK3iJ6+Bbi5qWEr3p7xHq5s0NY4AT8bgA\n\tozwMsDMiOWQnD4M+s4vMw3H2GsL6jsZAONzm1CFrbmkb+Loq8wTi3/+/YoAlNrTWLjZd\n\tuDLy6byBDXlXoTDP3NUzPEve9qeOYn5WoTsc3fcNtK2EVkr1REkyRHiuFmpVY+bLM3+2\n\tcWvQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=g5rF5kBuicw7A3no2yHMSF6fvsXZ/+AJ6Lk34A9w4Lk=;\n\tb=qRzjt/0z/58qlR4gdxndV38wOqYZhoAAMLC81dWsv6h7qPvWD9fE6AS0lG9UF1dBoC\n\tvJK+kU4cO8ooRV3D10OFkckDL5ouh5MGPZrKELL8zc08FJwN7WsSr7Nf43+CAneC/SIj\n\tyx2HzCiBdYsTLznqZQhXw1g7DMJsAU47tb93PxXNwS5Q3RoYTlkydUwB+CU1xjSj8Qcj\n\ttGm4q3oOvoxo2xT669UkOmXuAfEXyBtkSWbTnCX69S9ntZ1NTyJjiAVRsSFcjCF8qoTH\n\twspR7xpjkmHz+EyZdrPHQ1GLoOlEgn51u2lWZ4UFDFKhQUoBNFhDBOk5LbMFUsQzbdhF\n\tTSww==","X-Gm-Message-State":"AOAM533zFEtsyXJAiwVhjMrlrtOZCNNkNQjGmNoM6BCG+AndGs2AQQB9\n\tXH3hndUCMzTSN0lJsMgBl8U1nepEAzgwHQ==","X-Google-Smtp-Source":"ABdhPJzH+66GgIoZ26VuC+yYYdbrVD5MtEGvGc8yA6XbZoTERzzhBJSerChanHh1FucZiyx9ZiX6qw==","X-Received":"by 2002:a17:90a:54f:: with SMTP id\n\th15mr1333042pjf.191.1599814535416; \n\tFri, 11 Sep 2020 01:55:35 -0700 (PDT)","From":"Show Liu <show.liu@linaro.org>","To":"libcamera-devel@lists.libcamera.org","Date":"Fri, 11 Sep 2020 16:55:10 +0800","Message-Id":"<20200911085514.30021-1-show.liu@linaro.org>","X-Mailer":"git-send-email 2.20.1","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH v6 0/4] qcam: accelerate format conversion\n\tby OpenGL shader","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"},"content":"Hi Laurent,\n\n  This is patch set v6 for qcam accelerated format conversion by OpenGL shader.\n  \nThe changes mainly based on your comments on v5, including:\n  * New coordinates matrix for vertex and texture mapping \n  * Move the NV 3 planes fragment shader into one file, and the YUV420 and YVU420 format \n    use the same one.\n  * And this version is always renew the fragment shader when set format to avoid\n    if the format changed.\n  * And of course refine some parts you mentioned.\n\nPlease let me know if I still lose something.\n\nKnown issue:\n  * The on/off issue is still there, not fixed yet.\n\nThanks,\nShow \n\nShow Liu (4):\n  qcam: add OpenGL shader code as Qt resource\n  qcam: new viewfinder hierarchy\n  qcam: add viewfinderGL class to accelerate the format convert\n  qcam: add additional command line option to select the render type\n\n meson.build                                   |   1 +\n src/qcam/assets/shader/NV_2_planes_UV_f.glsl  |  32 ++\n src/qcam/assets/shader/NV_2_planes_VU_f.glsl  |  32 ++\n src/qcam/assets/shader/NV_3_planes_f.glsl     |  33 ++\n src/qcam/assets/shader/NV_vertex_shader.glsl  |  16 +\n src/qcam/assets/shader/shaders.qrc            |   9 +\n src/qcam/main.cpp                             |   3 +\n src/qcam/main_window.cpp                      |  31 +-\n src/qcam/main_window.h                        |   3 +\n src/qcam/meson.build                          |  20 +-\n src/qcam/viewfinder.h                         |  57 +--\n src/qcam/viewfinder_gl.cpp                    | 456 ++++++++++++++++++\n src/qcam/viewfinder_gl.h                      |  96 ++++\n .../{viewfinder.cpp => viewfinder_qt.cpp}     |  24 +-\n src/qcam/viewfinder_qt.h                      |  64 +++\n 15 files changed, 812 insertions(+), 65 deletions(-)\n create mode 100644 src/qcam/assets/shader/NV_2_planes_UV_f.glsl\n create mode 100644 src/qcam/assets/shader/NV_2_planes_VU_f.glsl\n create mode 100644 src/qcam/assets/shader/NV_3_planes_f.glsl\n create mode 100644 src/qcam/assets/shader/NV_vertex_shader.glsl\n create mode 100644 src/qcam/assets/shader/shaders.qrc\n create mode 100644 src/qcam/viewfinder_gl.cpp\n create mode 100644 src/qcam/viewfinder_gl.h\n rename src/qcam/{viewfinder.cpp => viewfinder_qt.cpp} (86%)\n create mode 100644 src/qcam/viewfinder_qt.h"}