[{"id":12602,"web_url":"https://patchwork.libcamera.org/comment/12602/","msgid":"","date":"2020-09-21T06:20:53","subject":"Re: [libcamera-devel] [PATCH v8 0/8] 2D transforms","submitter":{"id":42,"url":"https://patchwork.libcamera.org/api/people/42/","name":"David Plowman","email":"david.plowman@raspberrypi.com"},"content":"Hi everyone\n\nI was wondering if I could give this one a little nudge, is there\nanything else we think we still need to do?\n\nThanks!\nDavid\n\nDavid\n\nOn Mon, 7 Sep 2020 at 08:16, David Plowman\n wrote:\n>\n> Hi everyone\n>\n> Here's version 8 of the 2D transforms, benefitting from the latest\n> round of reviews from Laurent. Besides a couple of clarifications and\n> small fixes (discussed in an earlier email) the main changes are to\n> the BayerFormat class. Here, among other smaller things, I've changed\n> the \"modifiers\" to \"packing\", and added the IPU3 packing type and\n> formats.\n>\n> Otherwise the changes have the same format and 8 commits as before.\n>\n> Thanks and best regards\n> David\n>\n> David Plowman (8):\n> libcamera: pipeline: raspberrypi: Revert \"Set sensor default\n> orientation before configure()\"\n> libcamera: Allow access to v4l2_query_ext_ctrl structure for a V4L2\n> control\n> libcamera: Add Transform enum to represent 2D plane transforms.\n> libcamera: Add BayerFormat type\n> libcamera: Add user Transform to CameraConfiguration\n> libcamera: raspberrypi: Set camera flips correctly from user transform\n> libcamera: raspberrypi: Plumb user transform through to IPA\n> libcamera: ipa: raspberrypi: ALSC: Handle user transform\n>\n> include/libcamera/camera.h | 3 +\n> include/libcamera/internal/bayer_format.h | 61 ++++\n> include/libcamera/internal/v4l2_device.h | 2 +\n> include/libcamera/meson.build | 1 +\n> include/libcamera/transform.h | 78 +++++\n> src/ipa/raspberrypi/controller/camera_mode.h | 4 +\n> src/ipa/raspberrypi/controller/rpi/alsc.cpp | 13 +-\n> src/ipa/raspberrypi/raspberrypi.cpp | 48 +--\n> src/libcamera/bayer_format.cpp | 268 +++++++++++++++\n> src/libcamera/camera.cpp | 16 +-\n> src/libcamera/meson.build | 2 +\n> src/libcamera/pipeline/ipu3/ipu3.cpp | 5 +\n> .../pipeline/raspberrypi/raspberrypi.cpp | 161 ++++++++-\n> src/libcamera/pipeline/rkisp1/rkisp1.cpp | 5 +\n> src/libcamera/pipeline/simple/simple.cpp | 5 +\n> src/libcamera/pipeline/uvcvideo/uvcvideo.cpp | 5 +\n> src/libcamera/pipeline/vimc/vimc.cpp | 5 +\n> src/libcamera/transform.cpp | 322 ++++++++++++++++++\n> src/libcamera/v4l2_device.cpp | 15 +\n> 19 files changed, 985 insertions(+), 34 deletions(-)\n> create mode 100644 include/libcamera/internal/bayer_format.h\n> create mode 100644 include/libcamera/transform.h\n> create mode 100644 src/libcamera/bayer_format.cpp\n> create mode 100644 src/libcamera/transform.cpp\n>\n> --\n> 2.20.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3AF83BF01C\n\tfor ;\n\tMon, 21 Sep 2020 06:21:06 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id AF78F62FBF;\n\tMon, 21 Sep 2020 08:21:05 +0200 (CEST)","from mail-oi1-x243.google.com (mail-oi1-x243.google.com\n\t[IPv6:2607:f8b0:4864:20::243])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5D9B560363\n\tfor ;\n\tMon, 21 Sep 2020 08:21:04 +0200 (CEST)","by mail-oi1-x243.google.com with SMTP id c13so15730375oiy.6\n\tfor ;\n\tSun, 20 Sep 2020 23:21:04 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"Vid4AcdX\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to;\n\tbh=URHmOz36flDppu0NOy4LS1lVOecjfQr4TlsV7KJZQ08=;\n\tb=Vid4AcdXOzsBxo+pRCzb5u5M8qHAmSSWJvwB2bYBE27eAvtixORaRarSlFx/dV+DyP\n\t/6JkKaF3ALHDy6XpQoMYoINN7pEZqNdS5Uy0UpmZrDGpga9HM0XPSf72lkFdCwmDYlv6\n\tw2M4sI2ND3UhSIjSUIhBm7RPiju9SrIkIBBmbv3avI2ZP4RHusvAIiZrmgY9dre653/D\n\t+mroG8Vz8nGEbULMf1dGVZxoOxQsHVzRWi26fCPqk3UkAkjhXBe77EcK/gbcIpFg/86a\n\t7tzp8ztlP3e2jIBOS0XxKyvlUZp3o5F3BbmzujDOXux3zFXSjpgcMn/MPmTzJbh/Jtqz\n\tXlQw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to;\n\tbh=URHmOz36flDppu0NOy4LS1lVOecjfQr4TlsV7KJZQ08=;\n\tb=lplJffUX4OS70xFW00l4+XCJIubeFRuBf9WvMo6+Sf2a0N6HFOc9RHkgodqnakKJ2M\n\tTbUE4fgN8N2kg63ba6vyp26nRSHHWAo6YHEkQx3sriTm76w1u9/Ns5LuB+eeO4x5FYMo\n\tCeWrDOPMOgT3SF20fQKmqJhsM7i7DDGVq5svffg5DftTKU63D/BcBv1b/PFvT7Jm7eQZ\n\tm+hydbu+EdxVnZbxQJl7P9H110S3ikfxjx+TR3mGUjMTyZvXHG9tjEr81OO7zcOMcHSj\n\tb/u2siinutUkHCgbgzFDjkhF8l7Plh4dRa5u/TYGqrcqsOxK1RqvKL1fsCjDUIQj269E\n\tfjUw==","X-Gm-Message-State":"AOAM531oJrLx5ZPKLSMkoACUASJeG/by7tHYPnDknbRhDxzNiEgVH3wE\n\t+PjpkbGkXJK8Ove2o9AOfsK85vGTXppFV5EPllwPnLCzyPQ=","X-Google-Smtp-Source":"ABdhPJwqwIq79gLZu1XWWc2eVOrwH+hq4qqnyuOS2fNGeJGuwhZMGlrVnsx1kgbEeIw93drHIwS859g4ERcD4HOnYNI=","X-Received":"by 2002:aca:42c2:: with SMTP id\n\tp185mr15914354oia.55.1600669262636; \n\tSun, 20 Sep 2020 23:21:02 -0700 (PDT)","MIME-Version":"1.0","References":"<20200907071604.8355-1-david.plowman@raspberrypi.com>","In-Reply-To":"<20200907071604.8355-1-david.plowman@raspberrypi.com>","From":"David Plowman ","Date":"Mon, 21 Sep 2020 07:20:53 +0100","Message-ID":"","To":"libcamera-devel@lists.libcamera.org","Subject":"Re: [libcamera-devel] [PATCH v8 0/8] 2D transforms","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":12792,"web_url":"https://patchwork.libcamera.org/comment/12792/","msgid":"","date":"2020-09-27T07:48:08","subject":"Re: [libcamera-devel] [PATCH v8 0/8] 2D transforms","submitter":{"id":42,"url":"https://patchwork.libcamera.org/api/people/42/","name":"David Plowman","email":"david.plowman@raspberrypi.com"},"content":"Hi again\n\nCould I perhaps give this set of patches another little nudge, please?\n\nThanks\nDavid\n\nOn Mon, 21 Sep 2020 at 07:20, David Plowman\n wrote:\n>\n> Hi everyone\n>\n> I was wondering if I could give this one a little nudge, is there\n> anything else we think we still need to do?\n>\n> Thanks!\n> David\n>\n> David\n>\n> On Mon, 7 Sep 2020 at 08:16, David Plowman\n> wrote:\n> >\n> > Hi everyone\n> >\n> > Here's version 8 of the 2D transforms, benefitting from the latest\n> > round of reviews from Laurent. Besides a couple of clarifications and\n> > small fixes (discussed in an earlier email) the main changes are to\n> > the BayerFormat class. Here, among other smaller things, I've changed\n> > the \"modifiers\" to \"packing\", and added the IPU3 packing type and\n> > formats.\n> >\n> > Otherwise the changes have the same format and 8 commits as before.\n> >\n> > Thanks and best regards\n> > David\n> >\n> > David Plowman (8):\n> > libcamera: pipeline: raspberrypi: Revert \"Set sensor default\n> > orientation before configure()\"\n> > libcamera: Allow access to v4l2_query_ext_ctrl structure for a V4L2\n> > control\n> > libcamera: Add Transform enum to represent 2D plane transforms.\n> > libcamera: Add BayerFormat type\n> > libcamera: Add user Transform to CameraConfiguration\n> > libcamera: raspberrypi: Set camera flips correctly from user transform\n> > libcamera: raspberrypi: Plumb user transform through to IPA\n> > libcamera: ipa: raspberrypi: ALSC: Handle user transform\n> >\n> > include/libcamera/camera.h | 3 +\n> > include/libcamera/internal/bayer_format.h | 61 ++++\n> > include/libcamera/internal/v4l2_device.h | 2 +\n> > include/libcamera/meson.build | 1 +\n> > include/libcamera/transform.h | 78 +++++\n> > src/ipa/raspberrypi/controller/camera_mode.h | 4 +\n> > src/ipa/raspberrypi/controller/rpi/alsc.cpp | 13 +-\n> > src/ipa/raspberrypi/raspberrypi.cpp | 48 +--\n> > src/libcamera/bayer_format.cpp | 268 +++++++++++++++\n> > src/libcamera/camera.cpp | 16 +-\n> > src/libcamera/meson.build | 2 +\n> > src/libcamera/pipeline/ipu3/ipu3.cpp | 5 +\n> > .../pipeline/raspberrypi/raspberrypi.cpp | 161 ++++++++-\n> > src/libcamera/pipeline/rkisp1/rkisp1.cpp | 5 +\n> > src/libcamera/pipeline/simple/simple.cpp | 5 +\n> > src/libcamera/pipeline/uvcvideo/uvcvideo.cpp | 5 +\n> > src/libcamera/pipeline/vimc/vimc.cpp | 5 +\n> > src/libcamera/transform.cpp | 322 ++++++++++++++++++\n> > src/libcamera/v4l2_device.cpp | 15 +\n> > 19 files changed, 985 insertions(+), 34 deletions(-)\n> > create mode 100644 include/libcamera/internal/bayer_format.h\n> > create mode 100644 include/libcamera/transform.h\n> > create mode 100644 src/libcamera/bayer_format.cpp\n> > create mode 100644 src/libcamera/transform.cpp\n> >\n> > --\n> > 2.20.1\n> >","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3C3CBC3B5C\n\tfor ;\n\tSun, 27 Sep 2020 07:48:22 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id AA27A63041;\n\tSun, 27 Sep 2020 09:48:21 +0200 (CEST)","from mail-oi1-x242.google.com (mail-oi1-x242.google.com\n\t[IPv6:2607:f8b0:4864:20::242])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B7ABF60361\n\tfor ;\n\tSun, 27 Sep 2020 09:48:20 +0200 (CEST)","by mail-oi1-x242.google.com with SMTP id w16so7913368oia.2\n\tfor ;\n\tSun, 27 Sep 2020 00:48:20 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"QI5hqhT0\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to;\n\tbh=SwzwGD0P5rg4zUAZStV171EdeVX//LjFM1NPjutCp8s=;\n\tb=QI5hqhT0lcoq7e4+flDxZYsBmZBiZInwzLhPIlGlJNY1mBa4lfNpejueqNRQk4Md2u\n\tf7yK+RisMDYSmb3a1+K7zgBTQAfM+AAIlcAY+4C7vRR1oFVKDyxtSAxsdt4h8mbcwXB4\n\t2RZGLyVvBSQTBNYv7CgFMHpRIPIeAntVVhesSWkaVFkZJ9jgW7vxeyLt9TE2GzKHa8v0\n\tn0T4jCsVpL9kUCUBQvlEaTlt7oZd1v9n+rf36t1CTXwf4RIDwmOXV/yIXcWLL6v47ea1\n\tIdPgFOI6TYiT2flxtMCLTYJya54vxDzk3xEgPPYuDlI8trI4ULnEJlOQ2ZzC01zDJUI+\n\tSZBA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to;\n\tbh=SwzwGD0P5rg4zUAZStV171EdeVX//LjFM1NPjutCp8s=;\n\tb=R8L0xhV95f1/NpkP868/NleBoNoNdzT7Dn8FsW9d5eEi46fTT4tmexo3/Ph9tI68Lt\n\tCQeO5VrNxfzzuzHYF+K5R/zVQIk6NW/ikuYY3zup3R7WGeyRqpGJVphT+W8uVY7gZfX/\n\toTmahkTJlxz4kvuh6OpXJy93x8B6j9tjYq4E/MsiPoOPIC9CXsWWSfFT6hd8Zo+bxuXu\n\tHZqX4hXSVu5d+VWuTBep772dX5owUI95U/Gc0uY6jCPBRHxFfjuMNRaODVq2wL8eVveJ\n\tvmB6oGJD8QIz/0MLGJ8gE74HMHKzh+mMdAp/VUGFCZiHKWTFSroQ+JAj9oZ5m9sQBi64\n\tSoYw==","X-Gm-Message-State":"AOAM530v8N8pJc3q0JHsrejQwG9HntulN9H3UTNJDc4tGhAtY2PAMVXP\n\tJHIEDmrRT61P2M8EZsEMb7nxGYeboSl8Xb2voXZkWpjXE7k=","X-Google-Smtp-Source":"ABdhPJww6dEMmNZgm8Qd2UT6hRJb8OFMQ+UxpSaz2XqK6YH8WgJjaWUXfnIoMu4is6WnVQO/5uK9aFjVc9jLVSTEcmM=","X-Received":"by 2002:aca:42c2:: with SMTP id\n\tp185mr2876110oia.55.1601192898946; \n\tSun, 27 Sep 2020 00:48:18 -0700 (PDT)","MIME-Version":"1.0","References":"<20200907071604.8355-1-david.plowman@raspberrypi.com>\n\t","In-Reply-To":"","From":"David Plowman ","Date":"Sun, 27 Sep 2020 08:48:08 +0100","Message-ID":"","To":"libcamera-devel@lists.libcamera.org","Subject":"Re: [libcamera-devel] [PATCH v8 0/8] 2D transforms","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":12807,"web_url":"https://patchwork.libcamera.org/comment/12807/","msgid":"<259d7910-4b43-18d3-7ffb-c3f66a741140@ideasonboard.com>","date":"2020-09-28T11:34:54","subject":"Re: [libcamera-devel] [PATCH v8 0/8] 2D transforms","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi David,\n\nOn 27/09/2020 08:48, David Plowman wrote:\n> Hi again\n> \n> Could I perhaps give this set of patches another little nudge, please?\n\nThanks - your nudge triggered the appropriate NMI on Laurent, and he's\nadded tags to the last two remaining patches, with only one small minor\ncomment.\n\nI've fixed that, and rebased, but there were merge conflicts, due to\nNaush's work getting in first.\n\nIt's run through a compile test fine, but I was wondering if you could\njust test/check the rebasing I've done please?\n\nI've pushed to\n\n https://github.com/kbingham/libcamera.git rpi/david/2d-transforms\n\nWith your ack, I'll push these to master.\n\nThanks\n\nKieran\n\n\n> \n> Thanks\n> David\n> \n> On Mon, 21 Sep 2020 at 07:20, David Plowman\n> wrote:\n>>\n>> Hi everyone\n>>\n>> I was wondering if I could give this one a little nudge, is there\n>> anything else we think we still need to do?\n>>\n>> Thanks!\n>> David\n>>\n>> David\n>>\n>> On Mon, 7 Sep 2020 at 08:16, David Plowman\n>> wrote:\n>>>\n>>> Hi everyone\n>>>\n>>> Here's version 8 of the 2D transforms, benefitting from the latest\n>>> round of reviews from Laurent. Besides a couple of clarifications and\n>>> small fixes (discussed in an earlier email) the main changes are to\n>>> the BayerFormat class. Here, among other smaller things, I've changed\n>>> the \"modifiers\" to \"packing\", and added the IPU3 packing type and\n>>> formats.\n>>>\n>>> Otherwise the changes have the same format and 8 commits as before.\n>>>\n>>> Thanks and best regards\n>>> David\n>>>\n>>> David Plowman (8):\n>>> libcamera: pipeline: raspberrypi: Revert \"Set sensor default\n>>> orientation before configure()\"\n>>> libcamera: Allow access to v4l2_query_ext_ctrl structure for a V4L2\n>>> control\n>>> libcamera: Add Transform enum to represent 2D plane transforms.\n>>> libcamera: Add BayerFormat type\n>>> libcamera: Add user Transform to CameraConfiguration\n>>> libcamera: raspberrypi: Set camera flips correctly from user transform\n>>> libcamera: raspberrypi: Plumb user transform through to IPA\n>>> libcamera: ipa: raspberrypi: ALSC: Handle user transform\n>>>\n>>> include/libcamera/camera.h | 3 +\n>>> include/libcamera/internal/bayer_format.h | 61 ++++\n>>> include/libcamera/internal/v4l2_device.h | 2 +\n>>> include/libcamera/meson.build | 1 +\n>>> include/libcamera/transform.h | 78 +++++\n>>> src/ipa/raspberrypi/controller/camera_mode.h | 4 +\n>>> src/ipa/raspberrypi/controller/rpi/alsc.cpp | 13 +-\n>>> src/ipa/raspberrypi/raspberrypi.cpp | 48 +--\n>>> src/libcamera/bayer_format.cpp | 268 +++++++++++++++\n>>> src/libcamera/camera.cpp | 16 +-\n>>> src/libcamera/meson.build | 2 +\n>>> src/libcamera/pipeline/ipu3/ipu3.cpp | 5 +\n>>> .../pipeline/raspberrypi/raspberrypi.cpp | 161 ++++++++-\n>>> src/libcamera/pipeline/rkisp1/rkisp1.cpp | 5 +\n>>> src/libcamera/pipeline/simple/simple.cpp | 5 +\n>>> src/libcamera/pipeline/uvcvideo/uvcvideo.cpp | 5 +\n>>> src/libcamera/pipeline/vimc/vimc.cpp | 5 +\n>>> src/libcamera/transform.cpp | 322 ++++++++++++++++++\n>>> src/libcamera/v4l2_device.cpp | 15 +\n>>> 19 files changed, 985 insertions(+), 34 deletions(-)\n>>> create mode 100644 include/libcamera/internal/bayer_format.h\n>>> create mode 100644 include/libcamera/transform.h\n>>> create mode 100644 src/libcamera/bayer_format.cpp\n>>> create mode 100644 src/libcamera/transform.cpp\n>>>\n>>> --\n>>> 2.20.1\n>>>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 496AAC3B5B\n\tfor ;\n\tMon, 28 Sep 2020 11:35:15 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A354360BD7;\n\tMon, 28 Sep 2020 13:35:14 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 044E360364\n\tfor ;\n\tMon, 28 Sep 2020 13:35:13 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 2A745A58;\n\tMon, 28 Sep 2020 13:34:57 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"kkPf9WTp\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1601292899;\n\tbh=Pwu6y23BmgGAj6g1Oy506SZ2W5rwItadmB94HL9Ol5E=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=kkPf9WTpDfF5b0Pgf1u5Zl5xLLT+KNRLe8U4AoMmKzb4rLYlUUCDBnJAQ4e8aNjUH\n\tdqO1odn+V6TgLoUh5KLVYh78m4/WXHU5RCtwBvjYszamhsNRMb0WUbanmUYlYtcNhb\n\t/Ol/75kld/kJOwvIoS6eqc96q51dWmo3TtkcZJ74=","To":"David Plowman ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20200907071604.8355-1-david.plowman@raspberrypi.com>\n\t\n\t","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<259d7910-4b43-18d3-7ffb-c3f66a741140@ideasonboard.com>","Date":"Mon, 28 Sep 2020 12:34:54 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [PATCH v8 0/8] 2D transforms","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"kieran.bingham@ideasonboard.com","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":12812,"web_url":"https://patchwork.libcamera.org/comment/12812/","msgid":"","date":"2020-09-28T16:55:19","subject":"Re: [libcamera-devel] [PATCH v8 0/8] 2D transforms","submitter":{"id":42,"url":"https://patchwork.libcamera.org/api/people/42/","name":"David Plowman","email":"david.plowman@raspberrypi.com"},"content":"Hi Kieran\n\nThanks very much for doing this. I've taken a look at your branch -\npresumably it's only our pipeline handler raspberrypi.c where Naush\nand I have been fighting - and it looks good to me. I've also\ndownloaded and run it - no problems. So:\n\nAcked-by: David Plowman \n\nBest regards\nDavid\n\nOn Mon, 28 Sep 2020 at 12:35, Kieran Bingham\n wrote:\n>\n> Hi David,\n>\n> On 27/09/2020 08:48, David Plowman wrote:\n> > Hi again\n> >\n> > Could I perhaps give this set of patches another little nudge, please?\n>\n> Thanks - your nudge triggered the appropriate NMI on Laurent, and he's\n> added tags to the last two remaining patches, with only one small minor\n> comment.\n>\n> I've fixed that, and rebased, but there were merge conflicts, due to\n> Naush's work getting in first.\n>\n> It's run through a compile test fine, but I was wondering if you could\n> just test/check the rebasing I've done please?\n>\n> I've pushed to\n>\n> https://github.com/kbingham/libcamera.git rpi/david/2d-transforms\n>\n> With your ack, I'll push these to master.\n>\n> Thanks\n>\n> Kieran\n>\n>\n> >\n> > Thanks\n> > David\n> >\n> > On Mon, 21 Sep 2020 at 07:20, David Plowman\n> > wrote:\n> >>\n> >> Hi everyone\n> >>\n> >> I was wondering if I could give this one a little nudge, is there\n> >> anything else we think we still need to do?\n> >>\n> >> Thanks!\n> >> David\n> >>\n> >> David\n> >>\n> >> On Mon, 7 Sep 2020 at 08:16, David Plowman\n> >> wrote:\n> >>>\n> >>> Hi everyone\n> >>>\n> >>> Here's version 8 of the 2D transforms, benefitting from the latest\n> >>> round of reviews from Laurent. Besides a couple of clarifications and\n> >>> small fixes (discussed in an earlier email) the main changes are to\n> >>> the BayerFormat class. Here, among other smaller things, I've changed\n> >>> the \"modifiers\" to \"packing\", and added the IPU3 packing type and\n> >>> formats.\n> >>>\n> >>> Otherwise the changes have the same format and 8 commits as before.\n> >>>\n> >>> Thanks and best regards\n> >>> David\n> >>>\n> >>> David Plowman (8):\n> >>> libcamera: pipeline: raspberrypi: Revert \"Set sensor default\n> >>> orientation before configure()\"\n> >>> libcamera: Allow access to v4l2_query_ext_ctrl structure for a V4L2\n> >>> control\n> >>> libcamera: Add Transform enum to represent 2D plane transforms.\n> >>> libcamera: Add BayerFormat type\n> >>> libcamera: Add user Transform to CameraConfiguration\n> >>> libcamera: raspberrypi: Set camera flips correctly from user transform\n> >>> libcamera: raspberrypi: Plumb user transform through to IPA\n> >>> libcamera: ipa: raspberrypi: ALSC: Handle user transform\n> >>>\n> >>> include/libcamera/camera.h | 3 +\n> >>> include/libcamera/internal/bayer_format.h | 61 ++++\n> >>> include/libcamera/internal/v4l2_device.h | 2 +\n> >>> include/libcamera/meson.build | 1 +\n> >>> include/libcamera/transform.h | 78 +++++\n> >>> src/ipa/raspberrypi/controller/camera_mode.h | 4 +\n> >>> src/ipa/raspberrypi/controller/rpi/alsc.cpp | 13 +-\n> >>> src/ipa/raspberrypi/raspberrypi.cpp | 48 +--\n> >>> src/libcamera/bayer_format.cpp | 268 +++++++++++++++\n> >>> src/libcamera/camera.cpp | 16 +-\n> >>> src/libcamera/meson.build | 2 +\n> >>> src/libcamera/pipeline/ipu3/ipu3.cpp | 5 +\n> >>> .../pipeline/raspberrypi/raspberrypi.cpp | 161 ++++++++-\n> >>> src/libcamera/pipeline/rkisp1/rkisp1.cpp | 5 +\n> >>> src/libcamera/pipeline/simple/simple.cpp | 5 +\n> >>> src/libcamera/pipeline/uvcvideo/uvcvideo.cpp | 5 +\n> >>> src/libcamera/pipeline/vimc/vimc.cpp | 5 +\n> >>> src/libcamera/transform.cpp | 322 ++++++++++++++++++\n> >>> src/libcamera/v4l2_device.cpp | 15 +\n> >>> 19 files changed, 985 insertions(+), 34 deletions(-)\n> >>> create mode 100644 include/libcamera/internal/bayer_format.h\n> >>> create mode 100644 include/libcamera/transform.h\n> >>> create mode 100644 src/libcamera/bayer_format.cpp\n> >>> create mode 100644 src/libcamera/transform.cpp\n> >>>\n> >>> --\n> >>> 2.20.1\n> >>>\n> > _______________________________________________\n> > libcamera-devel mailing list\n> > libcamera-devel@lists.libcamera.org\n> > https://lists.libcamera.org/listinfo/libcamera-devel\n> >\n>\n> --\n> Regards\n> --\n> Kieran","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C45D2C3B5B\n\tfor ;\n\tMon, 28 Sep 2020 16:55:33 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 94AE060BF7;\n\tMon, 28 Sep 2020 18:55:33 +0200 (CEST)","from mail-ot1-x343.google.com (mail-ot1-x343.google.com\n\t[IPv6:2607:f8b0:4864:20::343])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5DC0860366\n\tfor ;\n\tMon, 28 Sep 2020 18:55:32 +0200 (CEST)","by mail-ot1-x343.google.com with SMTP id n61so1589102ota.10\n\tfor ;\n\tMon, 28 Sep 2020 09:55:32 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"JhwW6FEE\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=+B7fAFjBmKk+WMLKv6vaze5JwCu3cRZeyl70l1pSHrQ=;\n\tb=JhwW6FEELqTELdZ9UiODb13XIgzNlX7l8+POVUKRivwnGa0I0BYJR6sPvcJmb5jt/U\n\tGlZB7Hg1wK4m+/9F5o3hlt5kWCPihuzmc7qT8MefZoaCtua0xzE0FoGh1yNegX5weJAc\n\ttB3Bas4O9J4UWZ4I/cNR6n3Ld2BaZIAfEYaZ2odHtlqmoNqif4hwK2fLJsrtfOIv6AqS\n\tyFJCwlVlVCbRzNgPddAprU5s3QsbxxAn4znpYGTHd5aBQR5xaZndk9y7k+CwCq8IHUuA\n\t2rs0p8XBgdQGgZUQ330XbXITkY54//78IWrcRzZpIm4R5LSQq1AFiiQ2uIec5D0qX4nC\n\twZNQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=+B7fAFjBmKk+WMLKv6vaze5JwCu3cRZeyl70l1pSHrQ=;\n\tb=e+jiZB7RWBlxdCVSeusbk3N+wgs/rcVBDsz7x1Uc2JQtSujoqf4ZuinuvGG/FlUV2G\n\t0Yqn3gcBdtCkiyhGJIlWZKvv0Bmi7rTdcBaHv1RaST2cztvCOXIp7YHw413+jtlu8a4l\n\tPCLvLJkgNepVPSg22gt7IEbQKQJO4l2lEU1jjA4XYjtOJEMBYUfCIDtDOdpQ+YQmWQex\n\tWkhPQGSyOX8WCSGIwW6DNsbtcRv6BRwKELYRk56OGW/J7YAUFxrczjR6fBaHdaNcghTL\n\tctq875rFWad0m2jMAXxwE7LvxayVceGJYrI6BCK5pCi03KSQMdbY1+NbLlpBlm0FxQ+S\n\t/2Gg==","X-Gm-Message-State":"AOAM531WZdISptm5SRI/0roBje59ekZme+cQAHUOzm1zS0yG6LQomW5A\n\tuyP+gIQKKbcOsk5Hw+Dd2g5klfUnx+Q2z0sVQwcSRQ2Kzqk=","X-Google-Smtp-Source":"ABdhPJyNV5LyBfxqGPgmYxIMs0/YSh5wmNCHAKJCJoe55Ah6Eo2a2hRP2F0QbIDvqGk5hMKqqU9Wq3G3hpRvZ69Q4XM=","X-Received":"by 2002:a9d:5eb:: with SMTP id 98mr1621600otd.317.1601312131014; \n\tMon, 28 Sep 2020 09:55:31 -0700 (PDT)","MIME-Version":"1.0","References":"<20200907071604.8355-1-david.plowman@raspberrypi.com>\n\t\n\t\n\t<259d7910-4b43-18d3-7ffb-c3f66a741140@ideasonboard.com>","In-Reply-To":"<259d7910-4b43-18d3-7ffb-c3f66a741140@ideasonboard.com>","From":"David Plowman ","Date":"Mon, 28 Sep 2020 17:55:19 +0100","Message-ID":"","To":"Kieran Bingham ","Subject":"Re: [libcamera-devel] [PATCH v8 0/8] 2D transforms","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]