[{"id":12249,"web_url":"https://patchwork.libcamera.org/comment/12249/","msgid":"<50710ceb-d5eb-17fa-76a5-bde11deb172d@ideasonboard.com>","date":"2020-09-02T12:45:43","subject":"Re: [libcamera-devel] [PATCH 0/5] android: camera_device: List\n\tJPEG/RAW correct resolutions","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Jacopo\n\nOn 02/09/2020 11:47, Jacopo Mondi wrote:\n> With the recent introduction of JPEG and RAW support in the libcamera\n> camera HAL, the initialization of formats and sizes wasn't properly\n> advanced.\n> \n> 1) We assumed all sizes were valid for JPEG format\n> 2) RAW sizes were not enumerated, if not they luckily matched one of the tested\n> resolutions\n> \n> This small series aims to fix this by:\n> 1) Claiming support for JPEG sizes based on the supported YCbCr_888 sizes\n> 2) Enumerate the RAW sizes differently from the processed ones\n> \n> The result is the following enumeration on Soraka cam0\n> \n> camera_device.cpp:508 '\\_SB_.PCI0.I2C2.CAM0': { 320x240 - 0x00000022 }\n> camera_device.cpp:508 '\\_SB_.PCI0.I2C2.CAM0': { 640x480 - 0x00000022 }\n> camera_device.cpp:508 '\\_SB_.PCI0.I2C2.CAM0': { 1280x720 - 0x00000022 }\n> camera_device.cpp:508 '\\_SB_.PCI0.I2C2.CAM0': { 1920x1080 - 0x00000022 }\n> camera_device.cpp:508 '\\_SB_.PCI0.I2C2.CAM0': { 4160x3104 - 0x00000022 }\n> camera_device.cpp:508 '\\_SB_.PCI0.I2C2.CAM0': { 320x240 - 0x00000023 }\n> camera_device.cpp:508 '\\_SB_.PCI0.I2C2.CAM0': { 320x240 - 0x00000021 }\n> camera_device.cpp:508 '\\_SB_.PCI0.I2C2.CAM0': { 640x480 - 0x00000023 }\n> camera_device.cpp:508 '\\_SB_.PCI0.I2C2.CAM0': { 640x480 - 0x00000021 }\n> camera_device.cpp:508 '\\_SB_.PCI0.I2C2.CAM0': { 1280x720 - 0x00000023 }\n> camera_device.cpp:508 '\\_SB_.PCI0.I2C2.CAM0': { 1280x720 - 0x00000021 }\n> camera_device.cpp:508 '\\_SB_.PCI0.I2C2.CAM0': { 1920x1080 - 0x00000023 }\n> camera_device.cpp:508 '\\_SB_.PCI0.I2C2.CAM0': { 1920x1080 - 0x00000021 }\n> camera_device.cpp:508 '\\_SB_.PCI0.I2C2.CAM0': { 4160x3104 - 0x00000023 }\n> camera_device.cpp:508 '\\_SB_.PCI0.I2C2.CAM0': { 4160x3104 - 0x00000021 }\n> camera_device.cpp:508 '\\_SB_.PCI0.I2C2.CAM0': { 1056x784 - 0x00000024 }\n> camera_device.cpp:508 '\\_SB_.PCI0.I2C2.CAM0': { 2112x1188 - 0x00000024 }\n> camera_device.cpp:508 '\\_SB_.PCI0.I2C2.CAM0': { 2112x1568 - 0x00000024 }\n> camera_device.cpp:508 '\\_SB_.PCI0.I2C2.CAM0': { 4224x3136 - 0x00000024 }\n\nAyeee.\n\nWe really need a toString on those 21,22,23,24 values ...\n\n\n\n> \n> Thanks\n> j\n> \n> Jacopo Mondi (5):\n> android: camera_device: Refuse unsupported formats\n> android: camera_device: Generate JPEG sizes\n> android: camera_device: Add debug to stream initialization\n> android: camera_device: Break out size calculation\n> android: camera_device: List RAW resolutions\n> \n> src/android/camera_device.cpp | 123 +++++++++++++++++++++++++++-------\n> src/android/camera_device.h | 7 ++\n> 2 files changed, 107 insertions(+), 23 deletions(-)\n> \n> --\n> 2.28.0\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9E152BE174\n\tfor ;\n\tWed, 2 Sep 2020 12:45:56 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 351D262984;\n\tWed, 2 Sep 2020 14:45:56 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6C29D60374\n\tfor ;\n\tWed, 2 Sep 2020 14:45:54 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 91DF09CC;\n\tWed, 2 Sep 2020 14:45:46 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"YYquCGDk\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1599050746;\n\tbh=vOuuAkD+M7r2OtIi77o2Na+VIW9CvFLmWPQ1+DtEoRI=;\n\th=Reply-To:Subject:To:Cc:References:From:Date:In-Reply-To:From;\n\tb=YYquCGDk6LMynPjeiyWgZyKqTtBPIUVmMFAk9ThArPNFvMJ+tfg3PZQ2AOk3Oqr8A\n\t32FhDcBY9gs/hVlGbCLgGMHj2ZTOyAk90lFA/jXZPkICGeoVJzZ+4F8ticEGVuw6Ml\n\t06ccrOHFqhrCFiIBf6DAb4eA0PcZgVQrZG9BiGLo=","To":"Jacopo Mondi , libcamera-devel@lists.libcamera.org","References":"<20200902104730.43451-1-jacopo@jmondi.org>","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<50710ceb-d5eb-17fa-76a5-bde11deb172d@ideasonboard.com>","Date":"Wed, 2 Sep 2020 13:45:43 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"<20200902104730.43451-1-jacopo@jmondi.org>","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [PATCH 0/5] android: camera_device: List\n\tJPEG/RAW correct resolutions","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"kieran.bingham@ideasonboard.com","Cc":"tfiga@google.com, hiroh@google.com","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]