[{"id":12194,"web_url":"https://patchwork.libcamera.org/comment/12194/","msgid":"","date":"2020-08-28T14:55:57","subject":"Re: [libcamera-devel] [PATCH v4 0/7] 2D transforms","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi David,\n\nOn 28/08/2020 15:41, David Plowman wrote:\n> Hi everyone\n> \n> Here's the latest version of 2D transforms. It's practically identical\n> to the previous version, except for the (mostly documentation)\n> improvements that were suggested, and the following points noted\n> below.\n> \n> Firstly, there are 2 new commits at the start of this set. The first\n> of these reverts the commit 1e8c91b65695449c5246d17ba7dc439c8058b781\n> that Kieran kindly pushed for us yesterday. Unfortunately that patch,\n> whilst fine when Naush originally authored it, made it impossible to\n> implement user-supplied transforms. Had it not been lurking in a\n> rather forgotten state for so long I might have woken up to its\n> problems sooner, so apologies for that. Anyway, I'm not quite sure if\n> you have any conventions for exactly how to revert a patch.\n\nOh my :-( I'm sorry - That's a pain.\n\nI think the revert commit you've sent is the right way to do this.\n\n\n> The second of these new patches moves the change made by the now\n> reverted patch into the validate() method. This is early enough to fix\n> the original bug (which was that raw streams were advertising an\n> incorrect Bayer format), but co-exists happily with the transform\n> code. (Would these two be better squished together?)\n\nKeeping them separate is fine, if you want to keep the intent clear.\nOtherwise you could move it directly too - but I don't think it's a\nproblem either way.\n\n> Beyond that the only issues to bring up are in what is now the fifth\n> commit of this series (third in the previous version). These relate to\n> that email I sent a few days back. Specifically:\n> \n> * I assume the intention is, when no user-supplied transform is given,\n> that we give out images that are corrected for any camera\n> rotation. That is, the image, when viewed without any supplementary\n> manipulations, should look like the world did when the picture was\n> taken. Is this correct?\n\nThat would be my expectation.\n\n> * So if a camera advertises itself as having a 90 degree rotation, do\n> I need to perform a 90 degree clockwise rotation to the image to\n> correct it, or counter-clockwise? I read the documentation on the\n> rotation property but must confess I was left a little hazy! (The\n> consequence would be that the rotation angle may need negating.)\n\nI think if a camera advertises itself as rotated, we need to either:\n\na) Report that rotation if we don't make any change:\nb) Change it - and make sure the 'new' rotation is reported?\n\nSometimes b might not be possible, so you would have to do a) as a\nminimum, (I think?)\n\n> * I've added a comment to say why I only flip the transpose bit when\n> the combined transform is one we don't support. It makes life easier\n> for the application because it either gets the transform it\n> requested, or it only has to do a simple transpose. All the other\n> possible transforms an application might worry about having to do\n> just can't happen. Does that make sense?\n\nNot having to worry about things that can't happen makes sense ;-)\n\nHopefully the code will explain the rest.\n\n> \n> I think that's everything!\n> \n> Thanks and best regards\n> David\n> \n> David Plowman (7):\n> libcamera: pipeline: raspberrypi: Revert \"Set sensor default\n> orientation before configure()\"\n> libcamera: pipeline: raspberrypi: Set sensor orientation during\n> validate\n> libcamera: Add Transform enum to represet 2D plane transforms.\n> libcamera: Add user Transform to CameraConfiguration\n> libcamera: raspberrypi: Set camera flips correctly from user transform\n> libcamera: raspberrypi: Plumb user transform through to IPA\n> libcamera: ipa: raspberrypi: ALSC: Handle user transform\n> \n> include/libcamera/camera.h | 3 +\n> include/libcamera/meson.build | 1 +\n> include/libcamera/transform.h | 73 ++++\n> src/ipa/raspberrypi/controller/camera_mode.h | 4 +\n> src/ipa/raspberrypi/controller/rpi/alsc.cpp | 13 +-\n> src/ipa/raspberrypi/raspberrypi.cpp | 48 +--\n> src/libcamera/camera.cpp | 16 +-\n> src/libcamera/meson.build | 1 +\n> src/libcamera/pipeline/ipu3/ipu3.cpp | 5 +\n> .../pipeline/raspberrypi/raspberrypi.cpp | 60 +++-\n> src/libcamera/pipeline/rkisp1/rkisp1.cpp | 5 +\n> src/libcamera/pipeline/simple/simple.cpp | 5 +\n> src/libcamera/pipeline/uvcvideo/uvcvideo.cpp | 5 +\n> src/libcamera/pipeline/vimc/vimc.cpp | 5 +\n> src/libcamera/transform.cpp | 312 ++++++++++++++++++\n> 15 files changed, 522 insertions(+), 34 deletions(-)\n> create mode 100644 include/libcamera/transform.h\n> create mode 100644 src/libcamera/transform.cpp\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A91FCBDC71\n\tfor ;\n\tFri, 28 Aug 2020 14:56:04 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2165D628F3;\n\tFri, 28 Aug 2020 16:56:04 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4F57D6037B\n\tfor ;\n\tFri, 28 Aug 2020 16:56:02 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id BFFD7303;\n\tFri, 28 Aug 2020 16:56:00 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"bkpGeaUI\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1598626560;\n\tbh=DmXKrEigE/HIaxIF2pT820NXS1a+VxXrsV9APyzEam4=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=bkpGeaUIaDWW7jmU/K4wrAyCRI7dKKeZK+dsGObW1kRFM6Rin1tXW8/1E8JsjYQvH\n\tAIsJ6HtNx12u4WSqeiiWNp0P/yX5OWzUhPwK5rehsGcTbHHT8a/TDqD3v7xa3BntOc\n\tJN2RHFRq3Nta07Tvzr2u1abIlgUbNCcJ9jYH12Uo=","To":"David Plowman ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20200828144110.17303-1-david.plowman@raspberrypi.com>","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"","Date":"Fri, 28 Aug 2020 15:55:57 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"<20200828144110.17303-1-david.plowman@raspberrypi.com>","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [PATCH v4 0/7] 2D transforms","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"kieran.bingham@ideasonboard.com","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]