{"id":9378,"url":"https://patchwork.libcamera.org/api/covers/9378/?format=json","web_url":"https://patchwork.libcamera.org/cover/9378/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200824204646.16866-1-email@uajain.com>","date":"2020-08-24T20:46:53","name":"[libcamera-devel,0/3] Initial EXIF metadata support","submitter":{"id":1,"url":"https://patchwork.libcamera.org/api/people/1/?format=json","name":"Umang Jain","email":"email@uajain.com"},"mbox":"https://patchwork.libcamera.org/cover/9378/mbox/","series":[{"id":1240,"url":"https://patchwork.libcamera.org/api/series/1240/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1240","date":"2020-08-24T20:46:53","name":"Initial EXIF metadata support","version":1,"mbox":"https://patchwork.libcamera.org/series/1240/mbox/"}],"comments":"https://patchwork.libcamera.org/api/covers/9378/comments/","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5266FBE174\n\tfor ;\n\tMon, 24 Aug 2020 20:46:59 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1C59462886;\n\tMon, 24 Aug 2020 22:46:58 +0200 (CEST)","from o1.f.az.sendgrid.net (o1.f.az.sendgrid.net [208.117.55.132])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 47BEA6170D\n\tfor ;\n\tMon, 24 Aug 2020 22:46:55 +0200 (CEST)","by filterdrecv-p3las1-c4cf4f4c5-xkgx4 with SMTP id\n\tfilterdrecv-p3las1-c4cf4f4c5-xkgx4-18-5F44273C-54\n\t2020-08-24 20:46:53.121276345 +0000 UTC m=+17333.395237647","from mail.uajain.com (unknown)\n\tby ismtpd0006p1maa1.sendgrid.net (SG) with ESMTP id\n\t_yV0s2lMQeSzzrDhJ0axzw for ;\n\tMon, 24 Aug 2020 20:46:52.541 +0000 (UTC)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=uajain.com header.i=@uajain.com\n\theader.b=\"x7LTnJvF\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=uajain.com;\n\th=from:subject:mime-version:to:cc:content-transfer-encoding:\n\tcontent-type;\n\ts=s1; bh=x68/QGoXKPZAeUuahYD68q9TuzaUjle/BJcELKeMLmg=;\n\tb=x7LTnJvFV278Mp089sCYGHwBJc0Mpsrfab4oV3jksizeYb3SI1e3uKwPPHYNQ33o5tMv\n\t00Xu9VUG68bysLfGRLzCpN8ot4+RtKAE+mjVCKCmrPvrKN87QceVy1J/8eee1DAFGLhTJd\n\t8dTUKSIYuHeUySQjE9pfKhWvYRXal/pE0=","From":"Umang Jain ","Date":"Mon, 24 Aug 2020 20:46:53 +0000 (UTC)","Message-Id":"<20200824204646.16866-1-email@uajain.com>","Mime-Version":"1.0","X-SG-EID":"1Q40EQ7YGir8a9gjSIAdTjhngY657NMk9ckeo4dbHZDiOpywc/L3L9rFqlwE4KPc9vLW9W8H4bP+KZ0PPVtun8fdbw/eKUFmYBZIBeqB3eXv3pPcVrLPTgUgIJzscGexFsNuij0gi+DyQ7gOrKNTAHrKRq64Hj6TF18B7QvOPwdgngto8gEhXq0US9zpbXzavs/QRYLynD6CQebyOWtr3a3MZPByxPeod9v4P2kH+kGVNc6T14tUqmVTMI6iPc0O6OU6R6uzxJkYn2jhmNd01Q==","To":"libcamera-devel@lists.libcamera.org","Subject":"[libcamera-devel] [PATCH 0/3] Initial EXIF metadata support","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Hi all,\n\nThis patch series targets adding initial EXIF metadata support\nfor the frames captured in Android/Libcamera framework.\n\nIt is initial in the sense, it adds the base infrastructure for\nExif metadata support via 'libexif' and also encodes a initial\nset of metadata tags into the frames.\n\nTesting:\nThe testing of this work was carried out via vivid pipeline-handler\nin conjunction with patch in `cam` using EncoderLibJpeg as the\nfile sink [1]. That way we could see what EXIF metadata could be written\nand inspect that `exif` or `exiv2` commandline tools.\n\n($) ./build/src/cam/cam -c vivid -C5 -F -s pixelformat=NV12\n\nSample output (1): exif frame-stream0-000000.jpg\nEXIF tags in 'frame-stream0-000000.jpg' ('Intel' byte order):\n--------------------+----------------------------------------------------------\nTag |Value\n--------------------+----------------------------------------------------------\nImage Width |1280\nImage Length |720\nManufacturer |Libcamera\nModel |Camera2111\nOrientation |Bottom-left\nX-Resolution |72\nY-Resolution |72\nResolution Unit |Inch\nDate and Time |Sun Oct 13 07:03:20 734137\n\nYCbCr Positioning |Centered\nExif Version |Exif Version 2.1\nDate and Time (Origi|Sun Oct 13 07:03:20 734137\n\nDate and Time (Digit|Sun Oct 13 07:03:20 734137\n\nComponents Configura|Y Cb Cr -\nFlashPixVersion |FlashPix Version 1.0\nColor Space |Internal error (unknown value 65535)\nPixel X Dimension |1280\nPixel Y Dimension |720\n\n\n\nSample output (2): exiv2 frame-stream0-000000.jpg \nFile name : frame-stream0-000000.jpg\nFile size : 38787 Bytes\nMIME type : image/jpeg\nImage size : 1280 x 720\nCamera make : Libcamera\nCamera model : Camera2111\nImage timestamp : Sun Oct 13 07:03:20 734137\n\nImage number : \nExposure time : \nAperture : \nExposure bias : \nFlash : \nFlash bias : \nFocal length : \nSubject distance: \nISO speed : \nExposure mode : \nMetering mode : \nMacro mode : \nImage quality : \nExif Resolution : 1280 x 720\nWhite balance : \nThumbnail : None\nCopyright : \nExif comment : \n\nThere are still a lot of tags that needs to be populated,\nthat can be built on top of this groundwork.\n\n[1]: https://github.com/kbingham/libcamera/commit/10ed8ec\n\nKieran Bingham (1):\n libcamera: android: Add EXIF infrastructure\n\nUmang Jain (2):\n android: jpeg: Pass a Exif object while encoding\n android: Support initial set of EXIF metadata tags\n\n src/android/camera_device.cpp | 12 +-\n src/android/jpeg/encoder.h | 5 +-\n src/android/jpeg/encoder_libjpeg.cpp | 15 +-\n src/android/jpeg/encoder_libjpeg.h | 3 +-\n src/android/jpeg/exif.cpp | 210 +++++++++++++++++++++++++++\n src/android/jpeg/exif.h | 53 +++++++\n src/android/meson.build | 2 +\n 7 files changed, 296 insertions(+), 4 deletions(-)\n create mode 100644 src/android/jpeg/exif.cpp\n create mode 100644 src/android/jpeg/exif.h"}