{"id":9193,"url":"https://patchwork.libcamera.org/api/covers/9193/?format=json","web_url":"https://patchwork.libcamera.org/cover/9193/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200804214711.177645-1-kieran.bingham@ideasonboard.com>","date":"2020-08-04T21:46:58","name":"[libcamera-devel,v3,00/13] android: JPEG support","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/?format=json","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"mbox":"https://patchwork.libcamera.org/cover/9193/mbox/","series":[{"id":1191,"url":"https://patchwork.libcamera.org/api/series/1191/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1191","date":"2020-08-04T21:46:58","name":"android: JPEG support","version":3,"mbox":"https://patchwork.libcamera.org/series/1191/mbox/"}],"comments":"https://patchwork.libcamera.org/api/covers/9193/comments/","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 753CABD87A\n\tfor ;\n\tTue, 4 Aug 2020 21:47:18 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8812D60552;\n\tTue, 4 Aug 2020 23:47:17 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 70D7560545\n\tfor ;\n\tTue, 4 Aug 2020 23:47:16 +0200 (CEST)","from Q.local (cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net\n\t[86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id BABDE27B;\n\tTue, 4 Aug 2020 23:47:15 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"DBooJi1h\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1596577635;\n\tbh=Qw6nRK06IJDT1qXTi1X/RkCDlHFQpu3zuSGwpVrUnQI=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=DBooJi1h7+S/qUVSDV0PmA6yJKHPOH6UMWiwEnYmTjATPlc4RYveWLukD0hgkh40i\n\tPssG2dv5hY/ozF9Q2rglY/BPNiLqJoX6L8Ce/O8W5BYfHAzORSPI81Y6VtibtzprZT\n\tJg94zT7HYYlFu+5k2Yl89CG7wRGzHIASCSDoin6Q=","From":"Kieran Bingham ","To":"libcamera devel ","Date":"Tue, 4 Aug 2020 22:46:58 +0100","Message-Id":"<20200804214711.177645-1-kieran.bingham@ideasonboard.com>","X-Mailer":"git-send-email 2.25.1","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH v3 00/13] android: JPEG support","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"A revision of the recently posted JPEG support for the android layer,\nthis includes fixups to review comments and an addition of a test case\nfor the newly introduced mapped-buffers class.\n\n\nWith just these patches applied, the CCA application runs and can\ncapture an image successfully.\n\nThere is still plenty to do on top however:\n\n - The JPEG compression does not run in a separate thread\n - Added streams do not have buffering\n - RAW API could be used for JPEG compression\n - EXIF tag support is started but not included in this series.\n - No rescaler is supported yet\n\n\nI believe all comments from previous review are integrated in this\nversion, and while there is still plenty more to do for JPEG, this is\nheaded towards a suitable base point.\n\n\nKieran Bingham (13):\n libcamera: buffer: Correct FrameBuffer references\n libcamera: formats: add numPlanes helper\n libcamera: buffer: Create a MappedBuffer\n test: mapped-buffers: Provide MappedBuffer test\n libcamera: buffer: Convert copyFrom to use MappedFrameBuffer\n android: camera_device: Fix trivial spelling\n android: camera_device: Report an error in notifyError()\n android: camera_device: Only construct required planes\n android: camera_device: Query plane length\n android: camera_device: Report configuration changes from validate()\n android: camera_device: Generate ResultMetadata earlier\n android: Introduce JPEG compression\n android: camera_device: Support MJPEG stream construction\n\n include/libcamera/internal/buffer.h | 47 +++++\n include/libcamera/internal/formats.h | 2 +\n src/android/camera_device.cpp | 290 ++++++++++++++++++++++++---\n src/android/camera_device.h | 12 ++\n src/android/jpeg/compressor.h | 28 +++\n src/android/jpeg/compressor_jpeg.cpp | 217 ++++++++++++++++++++\n src/android/jpeg/compressor_jpeg.h | 45 +++++\n src/android/meson.build | 1 +\n src/libcamera/buffer.cpp | 205 ++++++++++++++++---\n src/libcamera/formats.cpp | 18 ++\n src/libcamera/meson.build | 2 +\n test/mapped-buffers.cpp | 113 +++++++++++\n test/meson.build | 1 +\n 13 files changed, 925 insertions(+), 56 deletions(-)\n create mode 100644 include/libcamera/internal/buffer.h\n create mode 100644 src/android/jpeg/compressor.h\n create mode 100644 src/android/jpeg/compressor_jpeg.cpp\n create mode 100644 src/android/jpeg/compressor_jpeg.h\n create mode 100644 test/mapped-buffers.cpp"}