[{"id":11848,"web_url":"https://patchwork.libcamera.org/comment/11848/","msgid":"<20200804194712.GO6075@pendragon.ideasonboard.com>","date":"2020-08-04T19:47:12","subject":"Re: [libcamera-devel] [PATCH v7 0/9] libcamera: Generate unique and\n\tstable camera IDs","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Niklas,\n\nThank you for the patches.\n\nOn Tue, Aug 04, 2020 at 06:13:49PM +0200, Niklas Söderlund wrote:\n> Hello,\n> \n> This series aims to make and enforce unique camera names that are static\n> between system resets. This version is a complete rewrite of previous \n> versions and centers around on firmware descriptions. Biggest chance in \n> this version is that the UVC ides are reworked from scratch.\n> \n> Before this series camera names on different systems looked like this (I\n> do not have access to a simple pipeline device):\n> \n> - ipu3\n> ov13858 8-0010\n> ov5670 10-0036\n> - raspberrypi\n> imx219\n> - rkisp1\n> ov5695 7-0036\n> ov2685 7-003c\n> - uvcvideo\n> Venus USB2.0 Camera: Venus USB2\n> Logitech Webcam C930e\n> - vimc\n> VIMC Sensor B\n> \n> With this series applied camera names on the same systems:\n> \n> - ipu3\n> \\_SB_.PCI0.I2C2.CAM0\n> \\_SB_.PCI0.I2C4.CAM1\n> - raspberrypi\n> base/soc/i2c0mux/i2c@1/imx219@10\n> - rkisp1\n> base/i2c@ff160000/camera@36\n> base/i2c@ff160000/camera@3c\n> - uvcvideo\n> \\_SB_.PCI0.RP05.PXSX-2.1.1:1.0-0ac8:3420\n> \\_SB_.PCI0.RP05.PXSX-2.4:1.0-046d:0843\n> - vimc\n> platform:vimc Sensor B\n\nThat's really nice :-)\n\nI've tested the patches with the simple pipeline handler:\n\n- Before: imx296 2-0036\n- After: base/soc/bus@30800000/i2c@30a40000/camera@36\n\n> Niklas Söderlund (9):\n> libcamera: sysfs: Add new namespace to interact with sysfs\n> libcamera: sysfs: Add method to lookup firmware ID\n> libcamera: v4l2_device: Add method to lookup device path\n> libcamera: camera_sensor: Generate a sensor ID\n> libcamera: camera_sensor: Add accessors for sensor ID\n> libcamera: pipelines: Use sensor ID as camera name\n> libcamera: pipeline: uvcvideo: Generate unique camera names\n> libcamera: camera: Rename name() to id()\n> libcamera: camera_manager: Enforce unique camera IDs\n> \n> include/libcamera/camera.h | 6 +-\n> include/libcamera/internal/camera_sensor.h | 4 +\n> include/libcamera/internal/meson.build | 1 +\n> include/libcamera/internal/sysfs.h | 24 ++++\n> include/libcamera/internal/v4l2_device.h | 1 +\n> src/android/camera_device.cpp | 4 +-\n> src/cam/main.cpp | 8 +-\n> src/gstreamer/gstlibcameraprovider.cpp | 4 +-\n> src/gstreamer/gstlibcamerasrc.cpp | 6 +-\n> src/libcamera/camera.cpp | 40 ++++---\n> src/libcamera/camera_controls.cpp | 2 +-\n> src/libcamera/camera_manager.cpp | 20 ++--\n> src/libcamera/camera_sensor.cpp | 48 ++++++++\n> src/libcamera/framebuffer_allocator.cpp | 2 +-\n> src/libcamera/meson.build | 1 +\n> src/libcamera/pipeline/ipu3/ipu3.cpp | 12 +-\n> .../pipeline/raspberrypi/raspberrypi.cpp | 7 +-\n> src/libcamera/pipeline/rkisp1/rkisp1.cpp | 16 +--\n> src/libcamera/pipeline/simple/simple.cpp | 2 +-\n> src/libcamera/pipeline/uvcvideo/uvcvideo.cpp | 77 ++++++++++++-\n> src/libcamera/pipeline/vimc/vimc.cpp | 4 +-\n> src/libcamera/sysfs.cpp | 105 ++++++++++++++++++\n> src/libcamera/v4l2_device.cpp | 28 +++++\n> src/qcam/dng_writer.cpp | 4 +-\n> src/qcam/main_window.cpp | 18 +--\n> src/v4l2/v4l2_camera_proxy.cpp | 2 +-\n> test/camera/buffer_import.cpp | 2 +-\n> test/camera/capture.cpp | 2 +-\n> test/camera/configuration_default.cpp | 2 +-\n> test/camera/configuration_set.cpp | 2 +-\n> test/camera/statemachine.cpp | 2 +-\n> test/controls/control_info_map.cpp | 2 +-\n> test/controls/control_list.cpp | 2 +-\n> test/pipeline/ipu3/ipu3_pipeline_test.cpp | 2 +-\n> test/pipeline/rkisp1/rkisp1_pipeline_test.cpp | 2 +-\n> test/serialization/serialization_test.h | 2 +-\n> 36 files changed, 381 insertions(+), 85 deletions(-)\n> create mode 100644 include/libcamera/internal/sysfs.h\n> create mode 100644 src/libcamera/sysfs.cpp\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id F4194BD86F\n\tfor ;\n\tTue, 4 Aug 2020 19:47:26 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 82F1360545;\n\tTue, 4 Aug 2020 21:47:26 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5C9B560545\n\tfor ;\n\tTue, 4 Aug 2020 21:47:25 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id BDBA727B;\n\tTue, 4 Aug 2020 21:47:24 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"GzceRnL5\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1596570444;\n\tbh=uWFPG25pFw+wW7FAUlXj8W8+k0+AY50O0Ch3t6u85H8=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=GzceRnL5/qLMCCViQhCvCnTzpLjO7DE/Yg1uMLcKBjKjW127/ZVz9boERW0Bnzwyp\n\t+XgPcscUswOHRcUno/y1sAK90fZGhnTCWlaf5g3ADJ7pB+EdAIQrgGuFLI4yYEnpWv\n\tEQlIlgr/9VbvYhgUayHkxF1Y2/LFyG2O9z17b0RU=","Date":"Tue, 4 Aug 2020 22:47:12 +0300","From":"Laurent Pinchart ","To":"Niklas =?utf-8?q?S=C3=B6derlund?= ","Message-ID":"<20200804194712.GO6075@pendragon.ideasonboard.com>","References":"<20200804161358.1628962-1-niklas.soderlund@ragnatech.se>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200804161358.1628962-1-niklas.soderlund@ragnatech.se>","Subject":"Re: [libcamera-devel] [PATCH v7 0/9] libcamera: Generate unique and\n\tstable camera IDs","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":11873,"web_url":"https://patchwork.libcamera.org/comment/11873/","msgid":"<20200805103921.GD2712616@oden.dyn.berto.se>","date":"2020-08-05T10:39:21","subject":"Re: [libcamera-devel] [PATCH v7 0/9] libcamera: Generate unique and\n\tstable camera IDs","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Laurent,\n\nThanks for your feedback.\n\nOn 2020-08-04 22:47:12 +0300, Laurent Pinchart wrote:\n> Hi Niklas,\n> \n> Thank you for the patches.\n> \n> On Tue, Aug 04, 2020 at 06:13:49PM +0200, Niklas Söderlund wrote:\n> > Hello,\n> > \n> > This series aims to make and enforce unique camera names that are static\n> > between system resets. This version is a complete rewrite of previous \n> > versions and centers around on firmware descriptions. Biggest chance in \n> > this version is that the UVC ides are reworked from scratch.\n> > \n> > Before this series camera names on different systems looked like this (I\n> > do not have access to a simple pipeline device):\n> > \n> > - ipu3\n> > ov13858 8-0010\n> > ov5670 10-0036\n> > - raspberrypi\n> > imx219\n> > - rkisp1\n> > ov5695 7-0036\n> > ov2685 7-003c\n> > - uvcvideo\n> > Venus USB2.0 Camera: Venus USB2\n> > Logitech Webcam C930e\n> > - vimc\n> > VIMC Sensor B\n> > \n> > With this series applied camera names on the same systems:\n> > \n> > - ipu3\n> > \\_SB_.PCI0.I2C2.CAM0\n> > \\_SB_.PCI0.I2C4.CAM1\n> > - raspberrypi\n> > base/soc/i2c0mux/i2c@1/imx219@10\n> > - rkisp1\n> > base/i2c@ff160000/camera@36\n> > base/i2c@ff160000/camera@3c\n> > - uvcvideo\n> > \\_SB_.PCI0.RP05.PXSX-2.1.1:1.0-0ac8:3420\n> > \\_SB_.PCI0.RP05.PXSX-2.4:1.0-046d:0843\n> > - vimc\n> > platform:vimc Sensor B\n> \n> That's really nice :-)\n> \n> I've tested the patches with the simple pipeline handler:\n> \n> - Before: imx296 2-0036\n> - After: base/soc/bus@30800000/i2c@30a40000/camera@36\n\nThis for this report, I'm happy it works for other hardware then the one \nI'm able to test on ;-)\n\n> \n> > Niklas Söderlund (9):\n> > libcamera: sysfs: Add new namespace to interact with sysfs\n> > libcamera: sysfs: Add method to lookup firmware ID\n> > libcamera: v4l2_device: Add method to lookup device path\n> > libcamera: camera_sensor: Generate a sensor ID\n> > libcamera: camera_sensor: Add accessors for sensor ID\n> > libcamera: pipelines: Use sensor ID as camera name\n> > libcamera: pipeline: uvcvideo: Generate unique camera names\n> > libcamera: camera: Rename name() to id()\n> > libcamera: camera_manager: Enforce unique camera IDs\n> > \n> > include/libcamera/camera.h | 6 +-\n> > include/libcamera/internal/camera_sensor.h | 4 +\n> > include/libcamera/internal/meson.build | 1 +\n> > include/libcamera/internal/sysfs.h | 24 ++++\n> > include/libcamera/internal/v4l2_device.h | 1 +\n> > src/android/camera_device.cpp | 4 +-\n> > src/cam/main.cpp | 8 +-\n> > src/gstreamer/gstlibcameraprovider.cpp | 4 +-\n> > src/gstreamer/gstlibcamerasrc.cpp | 6 +-\n> > src/libcamera/camera.cpp | 40 ++++---\n> > src/libcamera/camera_controls.cpp | 2 +-\n> > src/libcamera/camera_manager.cpp | 20 ++--\n> > src/libcamera/camera_sensor.cpp | 48 ++++++++\n> > src/libcamera/framebuffer_allocator.cpp | 2 +-\n> > src/libcamera/meson.build | 1 +\n> > src/libcamera/pipeline/ipu3/ipu3.cpp | 12 +-\n> > .../pipeline/raspberrypi/raspberrypi.cpp | 7 +-\n> > src/libcamera/pipeline/rkisp1/rkisp1.cpp | 16 +--\n> > src/libcamera/pipeline/simple/simple.cpp | 2 +-\n> > src/libcamera/pipeline/uvcvideo/uvcvideo.cpp | 77 ++++++++++++-\n> > src/libcamera/pipeline/vimc/vimc.cpp | 4 +-\n> > src/libcamera/sysfs.cpp | 105 ++++++++++++++++++\n> > src/libcamera/v4l2_device.cpp | 28 +++++\n> > src/qcam/dng_writer.cpp | 4 +-\n> > src/qcam/main_window.cpp | 18 +--\n> > src/v4l2/v4l2_camera_proxy.cpp | 2 +-\n> > test/camera/buffer_import.cpp | 2 +-\n> > test/camera/capture.cpp | 2 +-\n> > test/camera/configuration_default.cpp | 2 +-\n> > test/camera/configuration_set.cpp | 2 +-\n> > test/camera/statemachine.cpp | 2 +-\n> > test/controls/control_info_map.cpp | 2 +-\n> > test/controls/control_list.cpp | 2 +-\n> > test/pipeline/ipu3/ipu3_pipeline_test.cpp | 2 +-\n> > test/pipeline/rkisp1/rkisp1_pipeline_test.cpp | 2 +-\n> > test/serialization/serialization_test.h | 2 +-\n> > 36 files changed, 381 insertions(+), 85 deletions(-)\n> > create mode 100644 include/libcamera/internal/sysfs.h\n> > create mode 100644 src/libcamera/sysfs.cpp\n> > \n> \n> -- \n> Regards,\n> \n> Laurent Pinchart","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id F0FD5BD87A\n\tfor ;\n\tWed, 5 Aug 2020 10:39:24 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 489CF6055E;\n\tWed, 5 Aug 2020 12:39:24 +0200 (CEST)","from mail-lf1-x141.google.com (mail-lf1-x141.google.com\n\t[IPv6:2a00:1450:4864:20::141])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A31426039D\n\tfor ;\n\tWed, 5 Aug 2020 12:39:23 +0200 (CEST)","by mail-lf1-x141.google.com with SMTP id i80so23982825lfi.13\n\tfor ;\n\tWed, 05 Aug 2020 03:39:23 -0700 (PDT)","from localhost (h-209-203.A463.priv.bahnhof.se. [155.4.209.203])\n\tby smtp.gmail.com with ESMTPSA id\n\tt10sm720305ljg.60.2020.08.05.03.39.21\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 05 Aug 2020 03:39:22 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=ragnatech-se.20150623.gappssmtp.com\n\theader.i=@ragnatech-se.20150623.gappssmtp.com\n\theader.b=\"FsoSFom2\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=NgwPhCyW6WPGWrRwUE/45Y8jbCKCbY927x1unv/HfEA=;\n\tb=FsoSFom2gUCIpaJg7UZnwnCtay6hCM62DhforiVFlFyeyztpa9AntYp9YPD9lQ4HrU\n\tsO5+UR+vNZhHxk2WfMFd9SkhKpCZfIuZxrFkiGM43/r8aPxydTHTkz9YTWCwHAchv0j8\n\tFALOqurHJCRLKmPkiX42g1HM0WdIxz5BlOSZbpInkDChT/Z1RVUfWEcolAl8lC0ZkrGV\n\tafqhcNl+y089ZO+L75uwPl8ccQMgkyaphaS3fpbi0bkpXgUGW0eUpfLPJFhunGKVADnM\n\tjtZPORP+SxfZl9Y0eAbTLJtT1GEhJxg03GL5FmG6QmYZEGh/Y2vueOYytd9OEolCLxeV\n\toLuQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=NgwPhCyW6WPGWrRwUE/45Y8jbCKCbY927x1unv/HfEA=;\n\tb=UKKdF9F9GEF+kbevSz7w8vj+c3ywfgzL9RaZLfCIglVm+sE3TE8VvcH5AL3JUBv4NK\n\tOWiAkvfPWHPm/lBoHev6Dir6aaANXsSA9syzo3GaIcgr4nH3Pr6kFRG3dj4L16B+tdVi\n\tgtjx7i5lxecOj7t9N07Oe/4nMhNqxMMYCwQBSzupGjV9EDBWbyRS/Buc063WjUMRfsIu\n\t82qE6G3kPmwtWD0AC3i7Qb9IIBaEQYaABKaJ3dzBRQByFIn2qq5e0ck3SMjmT0eSO1w5\n\tycYsPbTtuE9K7SwZMpXpa1LlWQkCSjdixIykPT3L3iaFS4eBdIa60c2sGEycUlzeitjp\n\tZiqg==","X-Gm-Message-State":"AOAM531GE5lWb4VcnfdZr1lIf4dR+x6N2ow4w6/sS/HBpqYizeWTW0R2\n\tmdTaN6zkW7+sZhFDMxpfxxzuhPZk8z4=","X-Google-Smtp-Source":"ABdhPJxv8g6rXBVlHA0gLOGqZcPvJ+Usm8AAa8RZU0H681XbyowoxhlnM20KZuh7Fn4VJM9ShpYOEg==","X-Received":"by 2002:ac2:522b:: with SMTP id i11mr1299275lfl.30.1596623962777;\n\tWed, 05 Aug 2020 03:39:22 -0700 (PDT)","Date":"Wed, 5 Aug 2020 12:39:21 +0200","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Laurent Pinchart ","Message-ID":"<20200805103921.GD2712616@oden.dyn.berto.se>","References":"<20200804161358.1628962-1-niklas.soderlund@ragnatech.se>\n\t<20200804194712.GO6075@pendragon.ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200804194712.GO6075@pendragon.ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v7 0/9] libcamera: Generate unique and\n\tstable camera IDs","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"iso-8859-1\"","Content-Transfer-Encoding":"quoted-printable","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]