{"id":9118,"url":"https://patchwork.libcamera.org/api/covers/9118/?format=json","web_url":"https://patchwork.libcamera.org/cover/9118/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200731181410.99892-1-email@uajain.com>","date":"2020-07-31T18:14:13","name":"[libcamera-devel,v4,0/4] libcamera: object: Add deleteLater() support","submitter":{"id":1,"url":"https://patchwork.libcamera.org/api/people/1/?format=json","name":"Umang Jain","email":"email@uajain.com"},"mbox":"https://patchwork.libcamera.org/cover/9118/mbox/","series":[{"id":1172,"url":"https://patchwork.libcamera.org/api/series/1172/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1172","date":"2020-07-31T18:14:13","name":"libcamera: object: Add deleteLater() support","version":4,"mbox":"https://patchwork.libcamera.org/series/1172/mbox/"}],"comments":"https://patchwork.libcamera.org/api/covers/9118/comments/","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9C514BD86F\n\tfor ;\n\tFri, 31 Jul 2020 18:14:17 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id EA1CA61EAB;\n\tFri, 31 Jul 2020 20:14:16 +0200 (CEST)","from o1.f.az.sendgrid.net (o1.f.az.sendgrid.net [208.117.55.132])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7D8F460396\n\tfor ;\n\tFri, 31 Jul 2020 20:14:15 +0200 (CEST)","by filterdrecv-p3iad2-d8cc6d457-gjvhw with SMTP id\n\tfilterdrecv-p3iad2-d8cc6d457-gjvhw-19-5F245F75-6D\n\t2020-07-31 18:14:13.921725941 +0000 UTC m=+173152.753361242","from mail.uajain.com (unknown)\n\tby ismtpd0001p1maa1.sendgrid.net (SG) with ESMTP id\n\t8hX03oOORcGER8vZ8btOEg for ;\n\tFri, 31 Jul 2020 18:14:13.218 +0000 (UTC)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=uajain.com header.i=@uajain.com\n\theader.b=\"AQkQEZFp\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=uajain.com;\n\th=from:subject:mime-version:to:cc:content-transfer-encoding:\n\tcontent-type;\n\ts=s1; bh=VCAjHIA//k9VRNDgElE1wegAjb0Yl2puPK1eft2QrTY=;\n\tb=AQkQEZFpYNn86NrBdYEBntIYLrDikOu3vnNtPZOlvQQEN8S9B06Y+idcV7Iy75g2Z7a6\n\tHdzM+c4NIvpF8bsVPIqxZx07P2RZ9xwkqBLMyGf/20ny1e+zz58/0Rhg0tp8MgBf7rdVM7\n\tRC3iBLUEonEx7Xtd8hgdzMQU4cTaIkHtI=","From":"Umang Jain ","Date":"Fri, 31 Jul 2020 18:14:13 +0000 (UTC)","Message-Id":"<20200731181410.99892-1-email@uajain.com>","Mime-Version":"1.0","X-SG-EID":"1Q40EQ7YGir8a9gjSIAdTjhngY657NMk9ckeo4dbHZDiOpywc/L3L9rFqlwE4KPcZj5z9XHfwy1Ge6f/0y1LY2Nhbyg1xVAwe2IdfC2V0bLXfIJMylEdXO/1Y/kfKsYz7x4abhCAJDvRYpkd1LQLLJ0LsiIKXKsXIgz8Qrj0ZyvQfjIOWEAVvYXESPljiirhLBmZW7CE4b6kR5lPuedTKN+eiBQSAcWXuigt18DAL0126gjIL/biYvCZFGNMswWlGYYDTxPdgK1T5t7vMKf93w==","To":"libcamera-devel@lists.libcamera.org","Subject":"[libcamera-devel] [PATCH v4 0/4] libcamera: object: Add\n\tdeleteLater() support","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Changes in v4:\n - Split out object-delete unit test from 2/3 in v3. The test is modified\n to also check for multiple deleteLater() calls.\n - Fix a bug in dispatchMessages() to erase list entries for empty\n messages (which was not happening in v3).\n - Indentation fixes. \n\nChanges in v3:\n - Address review for 1/3. dispatchMessages() message loop changed to support\n handling dispatching of all or per type messages.\n\nChanges in v2:\n - Extend Thread::setEventDispatcher to selectively deliver messages\n - This will help if we want to explicitly deliver some messages if\n event loop is not running.\n - Include Object::deleteLater() unit test\n - One \\todo here as one case pending to cover; multiple\n deleteLater() should only delete the object once.\n - Review comments (mostly documentation fixes).\n\nUmang Jain (4):\n libcamera: thread: Support selective message dispatch to thread\n libcamera: object: Add deleteLater() support\n tests: Add a test case for the Object::deleteLater() API, to verify\n libcamera: camera: Ensure deletion via deleteLater()\n\n include/libcamera/camera.h | 3 +-\n include/libcamera/internal/message.h | 1 +\n include/libcamera/internal/thread.h | 3 +-\n include/libcamera/object.h | 2 +\n src/libcamera/camera.cpp | 2 +-\n src/libcamera/camera_manager.cpp | 6 +-\n src/libcamera/message.cpp | 2 +\n src/libcamera/object.cpp | 48 ++++++++++++++\n src/libcamera/thread.cpp | 35 +++++++---\n test/meson.build | 1 +\n test/object-delete.cpp | 97 ++++++++++++++++++++++++++++\n 11 files changed, 187 insertions(+), 13 deletions(-)\n create mode 100644 test/object-delete.cpp"}