[{"id":11971,"web_url":"https://patchwork.libcamera.org/comment/11971/","msgid":"<5509d15c28bc53f2404966fb48fa329f50891f4b.camel@ndufresne.ca>","date":"2020-08-10T16:01:51","subject":"Re: [libcamera-devel] [PATCH v4 0/5] libcamera: Generate unique and\n\tstable camera names","submitter":{"id":30,"url":"https://patchwork.libcamera.org/api/people/30/","name":"Nicolas Dufresne","email":"nicolas@ndufresne.ca"},"content":"Hi there,\n\nthanks for working on this.\n\nLe mercredi 29 juillet 2020 à 11:21 +0200, Niklas Söderlund a écrit :\n> Hello,\n> \n> This series aims to make and enforce unique camera names that are static\n> between system resets. This v3 is a complete rewrite of v1 and v2 of\n> this series that centered around bus information and location informat\n> instead of this v3 that focus on firmware descriptions.\n> \n> Before this series camera names on different systems looked like this (I\n> do not have access to a simple pipeline device):\n\nI haven't looked at the code, but is that saying that instead of adding\na new API for the unique ID the human readable name was replaced and\nremoved ?\n\n> \n> - ipu3\n> ov13858 8-0010\n> ov5670 10-0036\n> - raspberrypi\n> imx219\n> - rkisp1\n> ov5695 7-0036\n> ov2685 7-003c\n> - uvcvideo\n> Venus USB2.0 Camera: Venus USB2\n> Logitech Webcam C930e\n> - vimc\n> VIMC Sensor B\n> \n> With this series applied camera names on the same systems:\n> \n> - ipu3\n> \\_SB_.PCI0.I2C2.CAM0\n> \\_SB_.PCI0.I2C4.CAM1\n> - raspberrypi\n> base/soc/i2c0mux/i2c@1/imx219@10\n> - rkisp1\n> base/i2c@ff160000/camera@36\n> base/i2c@ff160000/camera@3c\n> - uvcvideo\n> 0ac8:3420:3:10\n> 046d:0843:3:4\n> - vimc\n> VIMC Sensor B\n> \n> Niklas Söderlund (5):\n> libcamera: v4l2_device: Add method to lookup device path\n> libcamera: camera_sensor: Generate a sensor ID\n> libcamera: camera: Generate camera name from a CameraSensor\n> libcamera: pipeline: uvcvideo: Generate unique camera names\n> libcamera: camera_manager: Enforce unique camera names\n> \n> include/libcamera/camera.h | 5 +\n> include/libcamera/internal/camera_sensor.h | 4 +\n> include/libcamera/internal/v4l2_device.h | 1 +\n> src/libcamera/camera.cpp | 18 ++++\n> src/libcamera/camera_manager.cpp | 6 +-\n> src/libcamera/camera_sensor.cpp | 94 +++++++++++++++++++\n> src/libcamera/pipeline/ipu3/ipu3.cpp | 12 +--\n> .../pipeline/raspberrypi/raspberrypi.cpp | 3 +-\n> src/libcamera/pipeline/rkisp1/rkisp1.cpp | 2 +-\n> src/libcamera/pipeline/simple/simple.cpp | 2 +-\n> src/libcamera/pipeline/uvcvideo/uvcvideo.cpp | 35 ++++++-\n> src/libcamera/pipeline/vimc/vimc.cpp | 4 +-\n> src/libcamera/v4l2_device.cpp | 24 +++++\n> 13 files changed, 194 insertions(+), 16 deletions(-)\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 461E4BD87D\n\tfor ;\n\tMon, 10 Aug 2020 16:01:57 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A499261012;\n\tMon, 10 Aug 2020 18:01:56 +0200 (CEST)","from mail-qk1-x743.google.com (mail-qk1-x743.google.com\n\t[IPv6:2607:f8b0:4864:20::743])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2764D6038F\n\tfor ;\n\tMon, 10 Aug 2020 18:01:55 +0200 (CEST)","by mail-qk1-x743.google.com with SMTP id b79so8767112qkg.9\n\tfor ;\n\tMon, 10 Aug 2020 09:01:55 -0700 (PDT)","from skullcanyon ([192.222.193.21])\n\tby smtp.gmail.com with ESMTPSA id\n\ti14sm6234760qtq.33.2020.08.10.09.01.52\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 10 Aug 2020 09:01:52 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=ndufresne-ca.20150623.gappssmtp.com\n\theader.i=@ndufresne-ca.20150623.gappssmtp.com\n\theader.b=\"wRuPaKkf\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ndufresne-ca.20150623.gappssmtp.com; s=20150623;\n\th=message-id:subject:from:to:date:in-reply-to:references:user-agent\n\t:mime-version:content-transfer-encoding;\n\tbh=Fu61BmFhpzgmd8H0MR3W5w7qhSc95eU2ykAPy8yUDps=;\n\tb=wRuPaKkfMcuEu+Fvu/KBTJG3LOlfE+gT9oORn/3OTiZotw6Y2BcN4e72iH2aC37Fjj\n\tqarsC7l8Dz5AxGPMFMb8wrhWGoNlnATGVg7eKN2qWCgpP5SladWxiLOkqoznv4jjq6+8\n\tP0m3HJxIk7W9W0aJWk9DaWgjAn4BRQE+++nSS26CQ84v+cH1YZ0vk8rvDBOb5wlrW0l8\n\tGd6OP16bGdBsO2EsqcUlHiaOiD0sKY8G7ws07/hupiKqkhAy7BxDflJumpzSp0ADihpQ\n\tBf5v/K7HXJtAjzqcGDHLHtBR9tMoeynb91N1I/AIxSZVDxpc7Jn0uWD9/uOlRBIHzRK7\n\tyJMQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:message-id:subject:from:to:date:in-reply-to\n\t:references:user-agent:mime-version:content-transfer-encoding;\n\tbh=Fu61BmFhpzgmd8H0MR3W5w7qhSc95eU2ykAPy8yUDps=;\n\tb=i5lybzGKXCDUtH0gXS9NiAX1MwDQgsU5MRXwmzgyqrL1IwC+J0PlLTJthI9TMSwlkK\n\tA0ieqhQlcNxJNkRC8Nc+0yHmAm2/2RyfhI/e4MVNe0LU0aiwfaDfeiWW06q0LehOVzhB\n\tFPOZuoir0mfxBIzVFFQKR2Dd9r1JRwv/qRYknNerODmcbf9rQCdOtwaVLcSx1MNV9PbC\n\tJLTwWGph1GDRe6n/C465X6RKWiy2IlpPuc7ZcWUWdVj9DgnKma5hKX8e5qyQxAdOzJab\n\tCFpBCf8NEZGneGtdJ91Wd7CmWpIiXP7oUsV4E3lqxme0wZ6PEfvq8c9/lTYqj47oil6w\n\twy1A==","X-Gm-Message-State":"AOAM530piGTL+pW7ujSEExl+UMX+AZAF/wd9/o6PDMEDvF3z843JroxF\n\td7yBPsIl2mpMXx5T7xvxbVdk2coYJTLIpA==","X-Google-Smtp-Source":"ABdhPJzixEi4wDoHfwA0pSjFYYXjMMIjZce4o0sIAVR9VprFLvvaF6BoJjot0ltYMMORIOjDUcuyyQ==","X-Received":"by 2002:a37:48ce:: with SMTP id\n\tv197mr27387780qka.458.1597075313499; \n\tMon, 10 Aug 2020 09:01:53 -0700 (PDT)","Message-ID":"<5509d15c28bc53f2404966fb48fa329f50891f4b.camel@ndufresne.ca>","From":"Nicolas Dufresne ","To":"Niklas =?iso-8859-1?q?S=F6derlund?= ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Mon, 10 Aug 2020 12:01:51 -0400","In-Reply-To":"<20200729092122.3765539-1-niklas.soderlund@ragnatech.se>","References":"<20200729092122.3765539-1-niklas.soderlund@ragnatech.se>","User-Agent":"Evolution 3.36.4 (3.36.4-1.fc32) ","MIME-Version":"1.0","Subject":"Re: [libcamera-devel] [PATCH v4 0/5] libcamera: Generate unique and\n\tstable camera names","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":11973,"web_url":"https://patchwork.libcamera.org/comment/11973/","msgid":"<20200810162028.GH6056@pendragon.ideasonboard.com>","date":"2020-08-10T16:20:28","subject":"Re: [libcamera-devel] [PATCH v4 0/5] libcamera: Generate unique and\n\tstable camera names","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Nicolas,\n\nOn Mon, Aug 10, 2020 at 12:01:51PM -0400, Nicolas Dufresne wrote:\n> Hi there,\n> \n> thanks for working on this.\n> \n> Le mercredi 29 juillet 2020 à 11:21 +0200, Niklas Söderlund a écrit :\n> > Hello,\n> > \n> > This series aims to make and enforce unique camera names that are static\n> > between system resets. This v3 is a complete rewrite of v1 and v2 of\n> > this series that centered around bus information and location informat\n> > instead of this v3 that focus on firmware descriptions.\n> > \n> > Before this series camera names on different systems looked like this (I\n> > do not have access to a simple pipeline device):\n> \n> I haven't looked at the code, but is that saying that instead of adding\n> a new API for the unique ID the human readable name was replaced and\n> removed ?\n\nThe human-readable name was never fully designed. This series replaces\nit with a unique ID, and Niklas has posted a second series that\nintroduces support to create human-readable names.\n\n> > - ipu3\n> > ov13858 8-0010\n> > ov5670 10-0036\n> > - raspberrypi\n> > imx219\n> > - rkisp1\n> > ov5695 7-0036\n> > ov2685 7-003c\n> > - uvcvideo\n> > Venus USB2.0 Camera: Venus USB2\n> > Logitech Webcam C930e\n> > - vimc\n> > VIMC Sensor B\n> > \n> > With this series applied camera names on the same systems:\n> > \n> > - ipu3\n> > \\_SB_.PCI0.I2C2.CAM0\n> > \\_SB_.PCI0.I2C4.CAM1\n> > - raspberrypi\n> > base/soc/i2c0mux/i2c@1/imx219@10\n> > - rkisp1\n> > base/i2c@ff160000/camera@36\n> > base/i2c@ff160000/camera@3c\n> > - uvcvideo\n> > 0ac8:3420:3:10\n> > 046d:0843:3:4\n> > - vimc\n> > VIMC Sensor B\n> > \n> > Niklas Söderlund (5):\n> > libcamera: v4l2_device: Add method to lookup device path\n> > libcamera: camera_sensor: Generate a sensor ID\n> > libcamera: camera: Generate camera name from a CameraSensor\n> > libcamera: pipeline: uvcvideo: Generate unique camera names\n> > libcamera: camera_manager: Enforce unique camera names\n> > \n> > include/libcamera/camera.h | 5 +\n> > include/libcamera/internal/camera_sensor.h | 4 +\n> > include/libcamera/internal/v4l2_device.h | 1 +\n> > src/libcamera/camera.cpp | 18 ++++\n> > src/libcamera/camera_manager.cpp | 6 +-\n> > src/libcamera/camera_sensor.cpp | 94 +++++++++++++++++++\n> > src/libcamera/pipeline/ipu3/ipu3.cpp | 12 +--\n> > .../pipeline/raspberrypi/raspberrypi.cpp | 3 +-\n> > src/libcamera/pipeline/rkisp1/rkisp1.cpp | 2 +-\n> > src/libcamera/pipeline/simple/simple.cpp | 2 +-\n> > src/libcamera/pipeline/uvcvideo/uvcvideo.cpp | 35 ++++++-\n> > src/libcamera/pipeline/vimc/vimc.cpp | 4 +-\n> > src/libcamera/v4l2_device.cpp | 24 +++++\n> > 13 files changed, 194 insertions(+), 16 deletions(-)","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5C611BD87D\n\tfor ;\n\tMon, 10 Aug 2020 16:20:44 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E6D8B6038F;\n\tMon, 10 Aug 2020 18:20:43 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E9E116038F\n\tfor ;\n\tMon, 10 Aug 2020 18:20:42 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 8FC16548;\n\tMon, 10 Aug 2020 18:20:40 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"pJ8ER9DN\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1597076440;\n\tbh=5CSmlDckrRdSc6NzJTi8rWilwbkHCoeySmqHkd0oEow=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=pJ8ER9DN/bskGrWozco+ukI11TDvcAD6/5xV+/bduGlmYA02+q5SGQAZ88VvHbIiD\n\tvBbhwwR+v4zrTWOavj4dh+TVd66jKuHxPCvg0zUkmC+X8gw+CvEGxjzY/Igpjd5Iur\n\tnzES+llTN+P88sAVSAvprEzdnRP7ypiMFvJW8e5g=","Date":"Mon, 10 Aug 2020 19:20:28 +0300","From":"Laurent Pinchart ","To":"Nicolas Dufresne ","Message-ID":"<20200810162028.GH6056@pendragon.ideasonboard.com>","References":"<20200729092122.3765539-1-niklas.soderlund@ragnatech.se>\n\t<5509d15c28bc53f2404966fb48fa329f50891f4b.camel@ndufresne.ca>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<5509d15c28bc53f2404966fb48fa329f50891f4b.camel@ndufresne.ca>","Subject":"Re: [libcamera-devel] [PATCH v4 0/5] libcamera: Generate unique and\n\tstable camera names","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]