[{"id":11570,"web_url":"https://patchwork.libcamera.org/comment/11570/","msgid":"<20200724161057.GK5921@pendragon.ideasonboard.com>","date":"2020-07-24T16:10:57","subject":"Re: [libcamera-devel] [PATCH v2 0/4] android: camera_device:\n\tImprove on format related tags","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Niklas,\n\nThank you for the patches.\n\nOn Fri, Jul 24, 2020 at 11:07:40AM +0200, Niklas Söderlund wrote:\n> Hi,\n> \n> While working on extending the HAL to support RAW format I stumbled upon\n> some small issues with how we report formats to users. These where found\n> running the Open Camera application [1] under a debugger and observing\n> how it consumed tags and by reading the Android documentation.\n> \n> I have tested these changes together with Kieran's JPEG work and the\n> stock camera applications behaves the same as it does without this\n> series so I'm not able to provoke any regressions.\n> \n> This series is a preparation for a small series enabling RAW streams in\n> the HAL. Using this series, the JPEG work and a yet to be sent RAW\n> series I mange to light up the RAW capture options in Open Camera while\n> retaining a functioning stock camera application.\n> \n> 1. https://opencamera.org.uk/\n> \n> Niklas Söderlund (4):\n> android: camera_device: Remove ANDROID_SCALER_AVAILABLE_FORMATS\n> android: camera_device: Use HAL_PIXEL_FORMAT_* defines for formats\n> android: camera_device: Remove scaler format information from\n> Camera3Format\n> android: camera_device: Add ANDROID_REQUEST_MAX_NUM_INPUT_STREAMS\n\nFor the whole series,\n\nReviewed-by: Laurent Pinchart \n\n> src/android/camera_device.cpp | 35 ++++++++++++-----------------------\n> src/android/camera_device.h | 2 +-\n> 2 files changed, 13 insertions(+), 24 deletions(-)\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 12EFDBD86F\n\tfor ;\n\tFri, 24 Jul 2020 16:11:07 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 99DFF60939;\n\tFri, 24 Jul 2020 18:11:06 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7D8D6605B2\n\tfor ;\n\tFri, 24 Jul 2020 18:11:04 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id EBAFB538;\n\tFri, 24 Jul 2020 18:11:03 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Cg+BIUc6\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1595607064;\n\tbh=N2U1cY5wgsM/o2wEyTCAZh/MFWAo/UyNGii6S4beCc0=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=Cg+BIUc6YozTBTXcxY9M7eJe1e4+S/2+akVYolzgTNHhQx4abp7fuBiha5YWTJD3s\n\tFJ9DZqP8uHwln2G0eiaNEIHQAlP5ZQ+UQJ5NcFXx4ZuSRaGVplpwkWrBEtw2BX/o9Q\n\t2nvxbVIeXwbt2r/wO6iES4UkAuySpfiCS28r00gQ=","Date":"Fri, 24 Jul 2020 19:10:57 +0300","From":"Laurent Pinchart ","To":"Niklas =?utf-8?q?S=C3=B6derlund?= ","Message-ID":"<20200724161057.GK5921@pendragon.ideasonboard.com>","References":"<20200724090744.508110-1-niklas.soderlund@ragnatech.se>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200724090744.508110-1-niklas.soderlund@ragnatech.se>","Subject":"Re: [libcamera-devel] [PATCH v2 0/4] android: camera_device:\n\tImprove on format related tags","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]