[{"id":11731,"web_url":"https://patchwork.libcamera.org/comment/11731/","msgid":"<CAEmqJPrvKqiOAcT6j0iaRDXw4cqc=0n3O0YFT2iSDzs0SwwgfA@mail.gmail.com>","date":"2020-07-30T08:39:38","subject":"Re: [libcamera-devel] [PATCH v5 00/10] Zero-copy RAW stream work","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"content":"Hi all,\n\nIs there any further changes anyone would like me to make for this\nseries?  I know Laurent had comments on what I was trying to achieve\nin patches 09/10 and 10/10 - I have made some minor changes with\nvariable names and comments to hopefully explain the code better.  If\nthere are other clarifications to be made, please let me know and I\nwill be happy to do so.\n\nRegards,\nNaush\n\nOn Fri, 24 Jul 2020 at 08:22, Naushir Patuck <naush@raspberrypi.com> wrote:\n>\n> Hi,\n>\n> This is patchset v5 of the zero copy RAW stream work for the Raspberry Pi platform.\n> All minor changes in the review feedback have been addressed.  The only other difference\n> is in patch 9/10 where I have renamed requeueBuffers_ to requestBuffers_ and made minor\n> changes to the comments to hopefully make the usage slightly more understandable.  I\n> have left the review tags in place, as there is no functional change, hope that is ok.\n>\n> Regards,\n> Naush\n>\n> Naushir Patuck (10):\n>   libcamera: pipeline: raspberrypi: Move RPiStream into a separate file\n>   libcamera: pipeline: ipa: raspberrypi: Rework drop frame signalling\n>   libcamera: request: Add log point on a completed request\n>   libcamera: pipeline: raspberrypi: Add some debug logging\n>   libcamera: pipeline: raspberrypi: Increase the number of RAW buffers\n>   libcamera: pipeline: raspberrypi: Remove const qualifier from\n>     RPiStream\n>   libcamera: pipeline: raspberrypi: Rework stream buffer logic for\n>     zero-copy\n>   libcamera: pipeline: raspberrypi: Fix bug in passing configuration to\n>     IPA\n>   libcamera: pipeline: raspberrypi: Add more robust stream buffer logic\n>   libcamera: pipeline: ipa: raspberrypi: Remove use of FrameBuffer\n>     cookie\n>\n>  include/libcamera/ipa/raspberrypi.h           |   2 +-\n>  src/ipa/raspberrypi/raspberrypi.cpp           |  20 +-\n>  .../pipeline/raspberrypi/meson.build          |   1 +\n>  .../pipeline/raspberrypi/raspberrypi.cpp      | 522 +++++++-----------\n>  .../pipeline/raspberrypi/rpi_stream.cpp       | 216 ++++++++\n>  .../pipeline/raspberrypi/rpi_stream.h         | 131 +++++\n>  src/libcamera/request.cpp                     |   3 +\n>  7 files changed, 563 insertions(+), 332 deletions(-)\n>  create mode 100644 src/libcamera/pipeline/raspberrypi/rpi_stream.cpp\n>  create mode 100644 src/libcamera/pipeline/raspberrypi/rpi_stream.h\n>\n> --\n> 2.25.1\n>","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4E732BD86F\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 30 Jul 2020 08:39:58 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9B949617C8;\n\tThu, 30 Jul 2020 10:39:57 +0200 (CEST)","from mail-lj1-x241.google.com (mail-lj1-x241.google.com\n\t[IPv6:2a00:1450:4864:20::241])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BFE6060396\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 30 Jul 2020 10:39:55 +0200 (CEST)","by mail-lj1-x241.google.com with SMTP id 185so17772192ljj.7\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 30 Jul 2020 01:39:55 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"m1XqHoN+\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to;\n\tbh=XGjVzwnzmdshVruNlDssKnq/tuLbZhKUkZSxivyOFjM=;\n\tb=m1XqHoN+PFPGvw+dJs8td2edMdVD8av2rMsWZlx/i97925lug+ck6GbQVDF3V+19sZ\n\tS5Aq+tsZYjLYhV4z0rL5q+NH6vyb1/qtPRgKgELmuGOpTJlWuMXrXNK1tjnZTy2MmtsH\n\t1yJg0YraBMrjm0CVgDpQ6GKS2t2GQ7ryZvqHoxfOgvCy7zPOgPfTasesx284NgLB1PYs\n\tdbhAH9XB/uTIagTPLl4bh/TzLhVlCpj8PEhgGJ73cbsWbSQ7LoETczKV9nX1iWXywVZa\n\tjAMeteBB2Fh3AM5hQghbwreN/91J/pyBVLT2yNF1kOmgRqECRs0TGW4GdNFzJvJf26Dh\n\tMLPA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to;\n\tbh=XGjVzwnzmdshVruNlDssKnq/tuLbZhKUkZSxivyOFjM=;\n\tb=g3i5ZLVbiYOf6TEPsBGNuDiZDXgwSZVLu+WjQbk5hgB5k8InSqO3EgiBgl7mWjtNIA\n\tf19mL9qPPZR37YAYqrNevhFYJBhyKPX3UYdUAYYNgZEIBzd7cxZFuHPBhwY4kFkiOM05\n\tsjtVsKSBO0GXJEqxmA0xMt8okORH+1wg+x459uoF2kBuP1q63UCJ8xJrNMYh81rF231t\n\tcXTs7QvYwjoirgYrTCD9P5lV9el5CZZAh4G1dPh6r3wSq6fokBX36mr4eLonMAIgWUkJ\n\tynsVyJQhcFG1lzyJRN5/Gq//pCj5nhgyvDE0E/lz5QldfCQ966APdiDsxboyFvGRZXUk\n\tK+Qg==","X-Gm-Message-State":"AOAM530rzQjl8z7CpWgQTlh9bGFcn9LvgOWjsCtI/KRX/rZvFP/wxNUN\n\tCgB8m4KtkMowY8iG6SApOVj1Bp0o4Tq3FuFdpcRgmzTRZe4=","X-Google-Smtp-Source":"ABdhPJzBw3YfB2tnImgjsinHyHUtmZ29z5ZBsHGbAel3A6yc0O8EJ12NGrSHOqJdtTjrvQ4HKTEjYPhPIeL5zAd95UY=","X-Received":"by 2002:a2e:9dcc:: with SMTP id x12mr985647ljj.415.1596098394484;\n\tThu, 30 Jul 2020 01:39:54 -0700 (PDT)","MIME-Version":"1.0","References":"<20200724072218.943245-1-naush@raspberrypi.com>","In-Reply-To":"<20200724072218.943245-1-naush@raspberrypi.com>","From":"Naushir Patuck <naush@raspberrypi.com>","Date":"Thu, 30 Jul 2020 09:39:38 +0100","Message-ID":"<CAEmqJPrvKqiOAcT6j0iaRDXw4cqc=0n3O0YFT2iSDzs0SwwgfA@mail.gmail.com>","To":"libcamera-devel@lists.libcamera.org","Subject":"Re: [libcamera-devel] [PATCH v5 00/10] Zero-copy RAW stream work","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":11763,"web_url":"https://patchwork.libcamera.org/comment/11763/","msgid":"<20200801092242.GD1379367@oden.dyn.berto.se>","date":"2020-08-01T09:22:42","subject":"Re: [libcamera-devel] [PATCH v5 00/10] Zero-copy RAW stream work","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Naushir,\n\nOn 2020-07-30 09:39:38 +0100, Naushir Patuck wrote:\n> Hi all,\n> \n> Is there any further changes anyone would like me to make for this\n> series?  I know Laurent had comments on what I was trying to achieve\n> in patches 09/10 and 10/10 - I have made some minor changes with\n> variable names and comments to hopefully explain the code better.  If\n> there are other clarifications to be made, please let me know and I\n> will be happy to do so.\n\nOn one hand I think this series improves the pipeline but at the same \ntime it's hard to know if the direction will solve the zero-copy problem \nas that patch have been dropped from the series. If you and others are \npushing for this series to be integrated I would be fine doing so, but \nif possible it would be nice to see a version with the zero-copy raw \nfeature added back.\n\n> \n> Regards,\n> Naush\n> \n> On Fri, 24 Jul 2020 at 08:22, Naushir Patuck <naush@raspberrypi.com> wrote:\n> >\n> > Hi,\n> >\n> > This is patchset v5 of the zero copy RAW stream work for the Raspberry Pi platform.\n> > All minor changes in the review feedback have been addressed.  The only other difference\n> > is in patch 9/10 where I have renamed requeueBuffers_ to requestBuffers_ and made minor\n> > changes to the comments to hopefully make the usage slightly more understandable.  I\n> > have left the review tags in place, as there is no functional change, hope that is ok.\n> >\n> > Regards,\n> > Naush\n> >\n> > Naushir Patuck (10):\n> >   libcamera: pipeline: raspberrypi: Move RPiStream into a separate file\n> >   libcamera: pipeline: ipa: raspberrypi: Rework drop frame signalling\n> >   libcamera: request: Add log point on a completed request\n> >   libcamera: pipeline: raspberrypi: Add some debug logging\n> >   libcamera: pipeline: raspberrypi: Increase the number of RAW buffers\n> >   libcamera: pipeline: raspberrypi: Remove const qualifier from\n> >     RPiStream\n> >   libcamera: pipeline: raspberrypi: Rework stream buffer logic for\n> >     zero-copy\n> >   libcamera: pipeline: raspberrypi: Fix bug in passing configuration to\n> >     IPA\n> >   libcamera: pipeline: raspberrypi: Add more robust stream buffer logic\n> >   libcamera: pipeline: ipa: raspberrypi: Remove use of FrameBuffer\n> >     cookie\n> >\n> >  include/libcamera/ipa/raspberrypi.h           |   2 +-\n> >  src/ipa/raspberrypi/raspberrypi.cpp           |  20 +-\n> >  .../pipeline/raspberrypi/meson.build          |   1 +\n> >  .../pipeline/raspberrypi/raspberrypi.cpp      | 522 +++++++-----------\n> >  .../pipeline/raspberrypi/rpi_stream.cpp       | 216 ++++++++\n> >  .../pipeline/raspberrypi/rpi_stream.h         | 131 +++++\n> >  src/libcamera/request.cpp                     |   3 +\n> >  7 files changed, 563 insertions(+), 332 deletions(-)\n> >  create mode 100644 src/libcamera/pipeline/raspberrypi/rpi_stream.cpp\n> >  create mode 100644 src/libcamera/pipeline/raspberrypi/rpi_stream.h\n> >\n> > --\n> > 2.25.1\n> >\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B3923BD86F\n\tfor <parsemail@patchwork.libcamera.org>;\n\tSat,  1 Aug 2020 09:22:46 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 37FEB61F24;\n\tSat,  1 Aug 2020 11:22:46 +0200 (CEST)","from mail-lf1-x142.google.com (mail-lf1-x142.google.com\n\t[IPv6:2a00:1450:4864:20::142])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8515C60394\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSat,  1 Aug 2020 11:22:44 +0200 (CEST)","by mail-lf1-x142.google.com with SMTP id b30so18050838lfj.12\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSat, 01 Aug 2020 02:22:44 -0700 (PDT)","from localhost (h-209-203.A463.priv.bahnhof.se. [155.4.209.203])\n\tby smtp.gmail.com with ESMTPSA id\n\tp1sm2229003lji.93.2020.08.01.02.22.43\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tSat, 01 Aug 2020 02:22:43 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=ragnatech-se.20150623.gappssmtp.com\n\theader.i=@ragnatech-se.20150623.gappssmtp.com\n\theader.b=\"gb5Z108U\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=/GIQjMUZXWCl9+jeIk52AdzPso6D3NeWxJIaUyCGJE0=;\n\tb=gb5Z108UvTjzAMB21cKsW3O/VUJhejtHyXfryGkhz5JpG7abBGHuP8fv4Zxw7xEdHD\n\t0CNxpHKWh1xKFBNXxDNeoqpfDO1IbXvO8bhB4qRfsjMxiCnNan3IsVUyLe5RG0tIoR+8\n\tM4nsg349FggHpWX4hQ2h3Roc1hh+EDtwh8g5vFArPdpCS2dN3+MILQ0Jzir90tfrt9Fc\n\tXaWpKfUUz/5u8J1VkDFwtfHDuwypL1yYoTWLSuWdUwLw3CWHPoXy88d+V83Xlt3UxfWP\n\tFpjjFYFmizUhhuXKYPsrS3QL4AbaS/FgOUHEHMe876qz/cLSjXKZb2ySohV1RknOxLXH\n\tjLPA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=/GIQjMUZXWCl9+jeIk52AdzPso6D3NeWxJIaUyCGJE0=;\n\tb=ox8wPMkbCZzYCeeyw0QGMFMg4oFYu/iZ0n1s5c1V565Dq0GyUgGNY3LBF2V9Tr8m/C\n\tQNmDfecJBnB8YSVL+t8Kl7Z6IALOppB/Cx2a8iChYVUPb2gPiuxO3Sr7UIt+Mx11kW18\n\tZ0i+8w85VY/DnMv1ew51ZhHrqOw6peLgaJs17maVRQ5uR+Dwpo/UAdnPL+L7gDMqfeU9\n\ti96DHBTw+3LKIKbTO4gDn2F3GUIfgZrde+f2J0s7ezaTfeAVRDr/UlnHvDjBgvdShJj9\n\twO6R/cT55/xme6ktnI/BKkfMB7H8HgejvLQmqDcrnsaa7F839cnip6fcAanQNZJDY718\n\trHaw==","X-Gm-Message-State":"AOAM531qKukf/j2DLwB414Rm7RIwIgY8jME2WN7mBKNDZgrCPyyG4t0W\n\tJvWVYgmlyEHymoJyTVeEQ7dW1+j2Xig=","X-Google-Smtp-Source":"ABdhPJxy9Co30RMOIVxyzss74uS4b7BtDmOJMXFtwp0yDDRt3j6CscaGvWnj3s4r650WA7l7clOsEw==","X-Received":"by 2002:ac2:43ca:: with SMTP id\n\tu10mr3920245lfl.147.1596273763862; \n\tSat, 01 Aug 2020 02:22:43 -0700 (PDT)","Date":"Sat, 1 Aug 2020 11:22:42 +0200","From":"Niklas =?iso-8859-1?q?S=F6derlund?= <niklas.soderlund@ragnatech.se>","To":"Naushir Patuck <naush@raspberrypi.com>","Message-ID":"<20200801092242.GD1379367@oden.dyn.berto.se>","References":"<20200724072218.943245-1-naush@raspberrypi.com>\n\t<CAEmqJPrvKqiOAcT6j0iaRDXw4cqc=0n3O0YFT2iSDzs0SwwgfA@mail.gmail.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<CAEmqJPrvKqiOAcT6j0iaRDXw4cqc=0n3O0YFT2iSDzs0SwwgfA@mail.gmail.com>","Subject":"Re: [libcamera-devel] [PATCH v5 00/10] Zero-copy RAW stream work","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"iso-8859-1\"","Content-Transfer-Encoding":"quoted-printable","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":11766,"web_url":"https://patchwork.libcamera.org/comment/11766/","msgid":"<CAEmqJPoFwO_Hj9OpPgd497XS=bijW5UsS6rm9NvcaLrBNTF=6g@mail.gmail.com>","date":"2020-08-01T10:32:19","subject":"Re: [libcamera-devel] [PATCH v5 00/10] Zero-copy RAW stream work","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"content":"Hi Niklas,\n\n\nOn Sat, 1 Aug 2020, 10:22 am Niklas Söderlund, <\nniklas.soderlund@ragnatech.se> wrote:\n\n> Hi Naushir,\n>\n> On 2020-07-30 09:39:38 +0100, Naushir Patuck wrote:\n> > Hi all,\n> >\n> > Is there any further changes anyone would like me to make for this\n> > series?  I know Laurent had comments on what I was trying to achieve\n> > in patches 09/10 and 10/10 - I have made some minor changes with\n> > variable names and comments to hopefully explain the code better.  If\n> > there are other clarifications to be made, please let me know and I\n> > will be happy to do so.\n>\n> On one hand I think this series improves the pipeline but at the same\n> time it's hard to know if the direction will solve the zero-copy problem\n> as that patch have been dropped from the series. If you and others are\n> pushing for this series to be integrated I would be fine doing so, but\n> if possible it would be nice to see a version with the zero-copy raw\n> feature added back.\n>\n\nAll the patches in the series will enable zero-copy RAW (or any other\nstream really) captures in the raspberry pi platform. I've been testing\nthis with cam, qcam, and our in-house libcamera application.\n\nThe only feature missing is that applications cannot use buffers that have\nnot been allocated or exported by the v4l2 videodevice (e.g. a random\ndmabuf), but none of the above applications do that right now as far as I\ncan tell. I have a patch series waiting to add support for this and will\nsubmit for review once this is gone through. Hope that is ok?\n\nRegards,\nNaush\n\n\n\n> >\n> > Regards,\n> > Naush\n> >\n> > On Fri, 24 Jul 2020 at 08:22, Naushir Patuck <naush@raspberrypi.com>\n> wrote:\n> > >\n> > > Hi,\n> > >\n> > > This is patchset v5 of the zero copy RAW stream work for the Raspberry\n> Pi platform.\n> > > All minor changes in the review feedback have been addressed.  The\n> only other difference\n> > > is in patch 9/10 where I have renamed requeueBuffers_ to\n> requestBuffers_ and made minor\n> > > changes to the comments to hopefully make the usage slightly more\n> understandable.  I\n> > > have left the review tags in place, as there is no functional change,\n> hope that is ok.\n> > >\n> > > Regards,\n> > > Naush\n> > >\n> > > Naushir Patuck (10):\n> > >   libcamera: pipeline: raspberrypi: Move RPiStream into a separate file\n> > >   libcamera: pipeline: ipa: raspberrypi: Rework drop frame signalling\n> > >   libcamera: request: Add log point on a completed request\n> > >   libcamera: pipeline: raspberrypi: Add some debug logging\n> > >   libcamera: pipeline: raspberrypi: Increase the number of RAW buffers\n> > >   libcamera: pipeline: raspberrypi: Remove const qualifier from\n> > >     RPiStream\n> > >   libcamera: pipeline: raspberrypi: Rework stream buffer logic for\n> > >     zero-copy\n> > >   libcamera: pipeline: raspberrypi: Fix bug in passing configuration to\n> > >     IPA\n> > >   libcamera: pipeline: raspberrypi: Add more robust stream buffer logic\n> > >   libcamera: pipeline: ipa: raspberrypi: Remove use of FrameBuffer\n> > >     cookie\n> > >\n> > >  include/libcamera/ipa/raspberrypi.h           |   2 +-\n> > >  src/ipa/raspberrypi/raspberrypi.cpp           |  20 +-\n> > >  .../pipeline/raspberrypi/meson.build          |   1 +\n> > >  .../pipeline/raspberrypi/raspberrypi.cpp      | 522 +++++++-----------\n> > >  .../pipeline/raspberrypi/rpi_stream.cpp       | 216 ++++++++\n> > >  .../pipeline/raspberrypi/rpi_stream.h         | 131 +++++\n> > >  src/libcamera/request.cpp                     |   3 +\n> > >  7 files changed, 563 insertions(+), 332 deletions(-)\n> > >  create mode 100644 src/libcamera/pipeline/raspberrypi/rpi_stream.cpp\n> > >  create mode 100644 src/libcamera/pipeline/raspberrypi/rpi_stream.h\n> > >\n> > > --\n> > > 2.25.1\n> > >\n> > _______________________________________________\n> > libcamera-devel mailing list\n> > libcamera-devel@lists.libcamera.org\n> > https://lists.libcamera.org/listinfo/libcamera-devel\n>\n> --\n> Regards,\n> Niklas Söderlund\n>","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7E7C5BD86F\n\tfor <parsemail@patchwork.libcamera.org>;\n\tSat,  1 Aug 2020 10:32:32 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id F20A561F81;\n\tSat,  1 Aug 2020 12:32:31 +0200 (CEST)","from mail-lj1-x22e.google.com (mail-lj1-x22e.google.com\n\t[IPv6:2a00:1450:4864:20::22e])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E2DA461F24\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSat,  1 Aug 2020 12:32:30 +0200 (CEST)","by mail-lj1-x22e.google.com with SMTP id t23so11371566ljc.3\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSat, 01 Aug 2020 03:32:30 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"BBapYuRV\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=2yEdWJ8y45h+D4QLwc+lKv5mQmX2S10XXsUBWl7W5TA=;\n\tb=BBapYuRVhn5/97nt+h+5bmeyEQiHcTp7vTBKhzdKShsh2GEUqN9yOhI1njxgAMhBLZ\n\tbjZf4IVbT/mUJyBdER5dRpSMfYTTso4mC/Xkjgc/WYREEyXKr6vUcrRsbpTC2xR0iI4l\n\tidHUyihZdVva+ucxplEZAXPiJHxpbXLDMim3/WZ/OR41clJ4eVyiNtnhGTOFE+PaUXcr\n\tIo3k+36uvidnfgMBbZYQ4GZ2R4FWRbvR3VeH5S5U1TfCs3ndMJebY7JENTm4xfcFgGMn\n\tCk3FNnpWrRi6TeONVPpnSIKCwmddEjnj/YKlpdyEHTYc+gHymWplkbr0MDBG9QGmGWA2\n\t42gQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=2yEdWJ8y45h+D4QLwc+lKv5mQmX2S10XXsUBWl7W5TA=;\n\tb=WRr1YkHje92xQ1MjprPTCBwpa5HDJLXt9D0vVbX+vYuz3vd89SLLgzkXpW5yfvHiXs\n\tzX4fSjkGlPw/7QrKjQIC0ttQkR4Oo85xp6/s+lGFHIbOoLMOUms66R/GXIpeAQRMupGD\n\t4SIbDcfeFDI3L8N5tKtD5lBVLryEyCbsXxj6PXVDQIBZjbLqWS5wlZYVWEJC42GSYHbN\n\t2A5T3g9kWYcwEuN02noh9R2Em7ADsIKzIQ8ycKG5+Ibi+RMe2b4qOxx4gj1g5uj17Nlj\n\t37mxSskm9eqwM/dPodWKphc122szMP/oGj5uU9cUcnQhG8/1WAOuvuL+TcRSyQ5Ifduu\n\tIeAw==","X-Gm-Message-State":"AOAM532BDY7pfo6A1MTpkV71wz+PLJVwDDO1COiysssyTLC7w8FIvubI\n\th4Rc1rEpGYOng3uXp8OjrLMKzD73yVuzKqCH6xwXpVAp","X-Google-Smtp-Source":"ABdhPJwi4Pgo79JHX1EUvotIYawNNeGAJrARIRdOYAuJXv0T2OVRP4EvcR6X30ucdo4JJEnWyJk9l2Tf1SgnLKYjPSM=","X-Received":"by 2002:a2e:b5d6:: with SMTP id\n\tg22mr3852410ljn.252.1596277950190; \n\tSat, 01 Aug 2020 03:32:30 -0700 (PDT)","MIME-Version":"1.0","References":"<20200724072218.943245-1-naush@raspberrypi.com>\n\t<CAEmqJPrvKqiOAcT6j0iaRDXw4cqc=0n3O0YFT2iSDzs0SwwgfA@mail.gmail.com>\n\t<20200801092242.GD1379367@oden.dyn.berto.se>","In-Reply-To":"<20200801092242.GD1379367@oden.dyn.berto.se>","From":"Naushir Patuck <naush@raspberrypi.com>","Date":"Sat, 1 Aug 2020 11:32:19 +0100","Message-ID":"<CAEmqJPoFwO_Hj9OpPgd497XS=bijW5UsS6rm9NvcaLrBNTF=6g@mail.gmail.com>","To":"=?utf-8?q?Niklas_S=C3=B6derlund?= <niklas.soderlund@ragnatech.se>","Subject":"Re: [libcamera-devel] [PATCH v5 00/10] Zero-copy RAW stream work","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"multipart/mixed;\n\tboundary=\"===============0768626780790018725==\"","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":11791,"web_url":"https://patchwork.libcamera.org/comment/11791/","msgid":"<20200803115056.GA2160023@oden.dyn.berto.se>","date":"2020-08-03T11:50:56","subject":"Re: [libcamera-devel] [PATCH v5 00/10] Zero-copy RAW stream work","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Naushir,\n\nOn 2020-08-01 11:32:19 +0100, Naushir Patuck wrote:\n> Hi Niklas,\n> \n> \n> On Sat, 1 Aug 2020, 10:22 am Niklas Söderlund, <\n> niklas.soderlund@ragnatech.se> wrote:\n> \n> > Hi Naushir,\n> >\n> > On 2020-07-30 09:39:38 +0100, Naushir Patuck wrote:\n> > > Hi all,\n> > >\n> > > Is there any further changes anyone would like me to make for this\n> > > series?  I know Laurent had comments on what I was trying to achieve\n> > > in patches 09/10 and 10/10 - I have made some minor changes with\n> > > variable names and comments to hopefully explain the code better.  If\n> > > there are other clarifications to be made, please let me know and I\n> > > will be happy to do so.\n> >\n> > On one hand I think this series improves the pipeline but at the same\n> > time it's hard to know if the direction will solve the zero-copy problem\n> > as that patch have been dropped from the series. If you and others are\n> > pushing for this series to be integrated I would be fine doing so, but\n> > if possible it would be nice to see a version with the zero-copy raw\n> > feature added back.\n> >\n> \n> All the patches in the series will enable zero-copy RAW (or any other\n> stream really) captures in the raspberry pi platform. I've been testing\n> this with cam, qcam, and our in-house libcamera application.\n\nYou are right, what version of the series did I look at? I thought the \ncopyFrom() was still present in the pipeline. My bad, sorry about that.\n\n> \n> The only feature missing is that applications cannot use buffers that have\n> not been allocated or exported by the v4l2 videodevice (e.g. a random\n> dmabuf), but none of the above applications do that right now as far as I\n> can tell. I have a patch series waiting to add support for this and will\n> submit for review once this is gone through. Hope that is ok?\n> \n\nThis is unfortunately a problem as it introduces a regression. What's in \nmaster work's with external buffers, but just in a zero-copy fashion.  \nThe Android HAL component uses external buffers which libcamera can't \ncontrol so I think removing the ability to work with external buffers \ndoes more harm then good.\n\nWould it be possible to merge the two series? Or in some other way break \nout the cleanup in one and the entablement of zero-copy in another?\n\n> Regards,\n> Naush\n> \n> \n> \n> > >\n> > > Regards,\n> > > Naush\n> > >\n> > > On Fri, 24 Jul 2020 at 08:22, Naushir Patuck <naush@raspberrypi.com>\n> > wrote:\n> > > >\n> > > > Hi,\n> > > >\n> > > > This is patchset v5 of the zero copy RAW stream work for the Raspberry\n> > Pi platform.\n> > > > All minor changes in the review feedback have been addressed.  The\n> > only other difference\n> > > > is in patch 9/10 where I have renamed requeueBuffers_ to\n> > requestBuffers_ and made minor\n> > > > changes to the comments to hopefully make the usage slightly more\n> > understandable.  I\n> > > > have left the review tags in place, as there is no functional change,\n> > hope that is ok.\n> > > >\n> > > > Regards,\n> > > > Naush\n> > > >\n> > > > Naushir Patuck (10):\n> > > >   libcamera: pipeline: raspberrypi: Move RPiStream into a separate file\n> > > >   libcamera: pipeline: ipa: raspberrypi: Rework drop frame signalling\n> > > >   libcamera: request: Add log point on a completed request\n> > > >   libcamera: pipeline: raspberrypi: Add some debug logging\n> > > >   libcamera: pipeline: raspberrypi: Increase the number of RAW buffers\n> > > >   libcamera: pipeline: raspberrypi: Remove const qualifier from\n> > > >     RPiStream\n> > > >   libcamera: pipeline: raspberrypi: Rework stream buffer logic for\n> > > >     zero-copy\n> > > >   libcamera: pipeline: raspberrypi: Fix bug in passing configuration to\n> > > >     IPA\n> > > >   libcamera: pipeline: raspberrypi: Add more robust stream buffer logic\n> > > >   libcamera: pipeline: ipa: raspberrypi: Remove use of FrameBuffer\n> > > >     cookie\n> > > >\n> > > >  include/libcamera/ipa/raspberrypi.h           |   2 +-\n> > > >  src/ipa/raspberrypi/raspberrypi.cpp           |  20 +-\n> > > >  .../pipeline/raspberrypi/meson.build          |   1 +\n> > > >  .../pipeline/raspberrypi/raspberrypi.cpp      | 522 +++++++-----------\n> > > >  .../pipeline/raspberrypi/rpi_stream.cpp       | 216 ++++++++\n> > > >  .../pipeline/raspberrypi/rpi_stream.h         | 131 +++++\n> > > >  src/libcamera/request.cpp                     |   3 +\n> > > >  7 files changed, 563 insertions(+), 332 deletions(-)\n> > > >  create mode 100644 src/libcamera/pipeline/raspberrypi/rpi_stream.cpp\n> > > >  create mode 100644 src/libcamera/pipeline/raspberrypi/rpi_stream.h\n> > > >\n> > > > --\n> > > > 2.25.1\n> > > >\n> > > _______________________________________________\n> > > libcamera-devel mailing list\n> > > libcamera-devel@lists.libcamera.org\n> > > https://lists.libcamera.org/listinfo/libcamera-devel\n> >\n> > --\n> > Regards,\n> > Niklas Söderlund\n> >","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 19D4FBD87A\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon,  3 Aug 2020 11:51:00 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A06866194F;\n\tMon,  3 Aug 2020 13:50:59 +0200 (CEST)","from mail-lf1-x142.google.com (mail-lf1-x142.google.com\n\t[IPv6:2a00:1450:4864:20::142])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A297C60536\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon,  3 Aug 2020 13:50:58 +0200 (CEST)","by mail-lf1-x142.google.com with SMTP id c15so2990015lfi.3\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 03 Aug 2020 04:50:58 -0700 (PDT)","from localhost (h-209-203.A463.priv.bahnhof.se. [155.4.209.203])\n\tby smtp.gmail.com with ESMTPSA id\n\tu5sm4736236lfr.3.2020.08.03.04.50.56\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 03 Aug 2020 04:50:57 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=ragnatech-se.20150623.gappssmtp.com\n\theader.i=@ragnatech-se.20150623.gappssmtp.com\n\theader.b=\"Ha39jAOk\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=xc9AAeK5hqGXNMPUXhcKGNF//GXK4zgnDydF4JJkr7E=;\n\tb=Ha39jAOk5t6wMu/xiyhWlomk7sPZGtBmABo3UdkAff52NB6+nsPkBBuYk9Dw6yBYP0\n\t6MtJFJN3m2+nmJPsPbomF5ysAkZG6N9oEEDFGFs8WP/BbCTaq55jS47mVMuT7B+AoAfs\n\tG2uHow6eP7MDKTk7EI062CtVbdH8rUvDYyndbwVaJ8/sg4/xZpuVngqvZAgaWO+4cOkI\n\tXWLVzFMCKh/RAqtvtMAtXTe8W31cYGClfPcaSYF6PBvL1zdgD1w0WkCrboaHMlgO+MnB\n\tpAsjWmWhD7/Lm339K+u8EEg3XXv+vTkIFw1q8ITtIgxV4Kp5UCyx/heZx7QBUUDXBHkw\n\tufYA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=xc9AAeK5hqGXNMPUXhcKGNF//GXK4zgnDydF4JJkr7E=;\n\tb=umxFLSsTbvz/FmyGmfqHnLf/A4uWC+grqasiz6WXjfFFJFmzENnpBTi33Q7pPZ1RT7\n\tdNoNyOdAFXjIvwOmnELPJCstYbTKDySa0rFa1qPdAKeWIfos5LP85eehFfnBsMA8f+3j\n\tNdLQ4PdIoKRUs5MMLbY1wWXGGj28S86K44Sgdg6vIbuD+iS5msmym/gj3oDXXXdpHi2K\n\tbgmN9Y4dC3HiOufqXhIyujIdN77ziZUlGHvcPXRHztdpagRN3FuI1e+C8ZcTr2neQiWs\n\thI2lbF0krC+IZeuehlGhACCGVAM8hytdvXY9+l/GtqvFdnybekpqFmjbRYoaVcBh6LJe\n\tvUMw==","X-Gm-Message-State":"AOAM531AIVKdW2MQKTTBkzpoxCQXXL+OafZrQkSO+MIEqGxedl1Yrmx0\n\t5Rw78dHlQT+JZHO966vIHv+b3A==","X-Google-Smtp-Source":"ABdhPJzdZMCjbxz+KNIenfonnq372dvYTC1Lx0GkHAhCmBC0I8uVMhSXQCqxklPZettVbVYGEIh0ng==","X-Received":"by 2002:a19:c7d0:: with SMTP id\n\tx199mr8336418lff.205.1596455457731; \n\tMon, 03 Aug 2020 04:50:57 -0700 (PDT)","Date":"Mon, 3 Aug 2020 13:50:56 +0200","From":"Niklas =?iso-8859-1?q?S=F6derlund?= <niklas.soderlund@ragnatech.se>","To":"Naushir Patuck <naush@raspberrypi.com>","Message-ID":"<20200803115056.GA2160023@oden.dyn.berto.se>","References":"<20200724072218.943245-1-naush@raspberrypi.com>\n\t<CAEmqJPrvKqiOAcT6j0iaRDXw4cqc=0n3O0YFT2iSDzs0SwwgfA@mail.gmail.com>\n\t<20200801092242.GD1379367@oden.dyn.berto.se>\n\t<CAEmqJPoFwO_Hj9OpPgd497XS=bijW5UsS6rm9NvcaLrBNTF=6g@mail.gmail.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<CAEmqJPoFwO_Hj9OpPgd497XS=bijW5UsS6rm9NvcaLrBNTF=6g@mail.gmail.com>","Subject":"Re: [libcamera-devel] [PATCH v5 00/10] Zero-copy RAW stream work","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"iso-8859-1\"","Content-Transfer-Encoding":"quoted-printable","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":11814,"web_url":"https://patchwork.libcamera.org/comment/11814/","msgid":"<CAEmqJPqJjNYLfCNN11NZvbAfMWocKPdodutXWjHphiTR_D_Xhw@mail.gmail.com>","date":"2020-08-04T08:52:53","subject":"Re: [libcamera-devel] [PATCH v5 00/10] Zero-copy RAW stream work","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"content":"Hi Niklas,\n\nOn Mon, 3 Aug 2020 at 12:50, Niklas Söderlund\n<niklas.soderlund@ragnatech.se> wrote:\n>\n> Hi Naushir,\n>\n> On 2020-08-01 11:32:19 +0100, Naushir Patuck wrote:\n> > Hi Niklas,\n> >\n> >\n> > On Sat, 1 Aug 2020, 10:22 am Niklas Söderlund, <\n> > niklas.soderlund@ragnatech.se> wrote:\n> >\n> > > Hi Naushir,\n> > >\n> > > On 2020-07-30 09:39:38 +0100, Naushir Patuck wrote:\n> > > > Hi all,\n> > > >\n> > > > Is there any further changes anyone would like me to make for this\n> > > > series?  I know Laurent had comments on what I was trying to achieve\n> > > > in patches 09/10 and 10/10 - I have made some minor changes with\n> > > > variable names and comments to hopefully explain the code better.  If\n> > > > there are other clarifications to be made, please let me know and I\n> > > > will be happy to do so.\n> > >\n> > > On one hand I think this series improves the pipeline but at the same\n> > > time it's hard to know if the direction will solve the zero-copy problem\n> > > as that patch have been dropped from the series. If you and others are\n> > > pushing for this series to be integrated I would be fine doing so, but\n> > > if possible it would be nice to see a version with the zero-copy raw\n> > > feature added back.\n> > >\n> >\n> > All the patches in the series will enable zero-copy RAW (or any other\n> > stream really) captures in the raspberry pi platform. I've been testing\n> > this with cam, qcam, and our in-house libcamera application.\n>\n> You are right, what version of the series did I look at? I thought the\n> copyFrom() was still present in the pipeline. My bad, sorry about that.\n>\n> >\n> > The only feature missing is that applications cannot use buffers that have\n> > not been allocated or exported by the v4l2 videodevice (e.g. a random\n> > dmabuf), but none of the above applications do that right now as far as I\n> > can tell. I have a patch series waiting to add support for this and will\n> > submit for review once this is gone through. Hope that is ok?\n> >\n>\n> This is unfortunately a problem as it introduces a regression. What's in\n> master work's with external buffers, but just in a zero-copy fashion.\n> The Android HAL component uses external buffers which libcamera can't\n> control so I think removing the ability to work with external buffers\n> does more harm then good.\n>\n> Would it be possible to merge the two series? Or in some other way break\n> out the cleanup in one and the entablement of zero-copy in another?\n\nI see now.  Was not aware the Android HAL worked in this way.  Easiest\nthing for me would be to merge the two series so that the\nfunctionality remains intact for the patchset.  I'll post an update\nshortly.\n\nRegards,\nNaush\n\n\n>\n> > Regards,\n> > Naush\n> >\n> >\n> >\n> > > >\n> > > > Regards,\n> > > > Naush\n> > > >\n> > > > On Fri, 24 Jul 2020 at 08:22, Naushir Patuck <naush@raspberrypi.com>\n> > > wrote:\n> > > > >\n> > > > > Hi,\n> > > > >\n> > > > > This is patchset v5 of the zero copy RAW stream work for the Raspberry\n> > > Pi platform.\n> > > > > All minor changes in the review feedback have been addressed.  The\n> > > only other difference\n> > > > > is in patch 9/10 where I have renamed requeueBuffers_ to\n> > > requestBuffers_ and made minor\n> > > > > changes to the comments to hopefully make the usage slightly more\n> > > understandable.  I\n> > > > > have left the review tags in place, as there is no functional change,\n> > > hope that is ok.\n> > > > >\n> > > > > Regards,\n> > > > > Naush\n> > > > >\n> > > > > Naushir Patuck (10):\n> > > > >   libcamera: pipeline: raspberrypi: Move RPiStream into a separate file\n> > > > >   libcamera: pipeline: ipa: raspberrypi: Rework drop frame signalling\n> > > > >   libcamera: request: Add log point on a completed request\n> > > > >   libcamera: pipeline: raspberrypi: Add some debug logging\n> > > > >   libcamera: pipeline: raspberrypi: Increase the number of RAW buffers\n> > > > >   libcamera: pipeline: raspberrypi: Remove const qualifier from\n> > > > >     RPiStream\n> > > > >   libcamera: pipeline: raspberrypi: Rework stream buffer logic for\n> > > > >     zero-copy\n> > > > >   libcamera: pipeline: raspberrypi: Fix bug in passing configuration to\n> > > > >     IPA\n> > > > >   libcamera: pipeline: raspberrypi: Add more robust stream buffer logic\n> > > > >   libcamera: pipeline: ipa: raspberrypi: Remove use of FrameBuffer\n> > > > >     cookie\n> > > > >\n> > > > >  include/libcamera/ipa/raspberrypi.h           |   2 +-\n> > > > >  src/ipa/raspberrypi/raspberrypi.cpp           |  20 +-\n> > > > >  .../pipeline/raspberrypi/meson.build          |   1 +\n> > > > >  .../pipeline/raspberrypi/raspberrypi.cpp      | 522 +++++++-----------\n> > > > >  .../pipeline/raspberrypi/rpi_stream.cpp       | 216 ++++++++\n> > > > >  .../pipeline/raspberrypi/rpi_stream.h         | 131 +++++\n> > > > >  src/libcamera/request.cpp                     |   3 +\n> > > > >  7 files changed, 563 insertions(+), 332 deletions(-)\n> > > > >  create mode 100644 src/libcamera/pipeline/raspberrypi/rpi_stream.cpp\n> > > > >  create mode 100644 src/libcamera/pipeline/raspberrypi/rpi_stream.h\n> > > > >\n> > > > > --\n> > > > > 2.25.1\n> > > > >\n> > > > _______________________________________________\n> > > > libcamera-devel mailing list\n> > > > libcamera-devel@lists.libcamera.org\n> > > > https://lists.libcamera.org/listinfo/libcamera-devel\n> > >\n> > > --\n> > > Regards,\n> > > Niklas Söderlund\n> > >\n>\n> --\n> Regards,\n> Niklas Söderlund","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 29244BD87A\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue,  4 Aug 2020 08:53:12 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id AA20E61B3F;\n\tTue,  4 Aug 2020 10:53:11 +0200 (CEST)","from mail-lj1-x241.google.com (mail-lj1-x241.google.com\n\t[IPv6:2a00:1450:4864:20::241])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5FBC86038F\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue,  4 Aug 2020 10:53:10 +0200 (CEST)","by mail-lj1-x241.google.com with SMTP id w25so7228238ljo.12\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 04 Aug 2020 01:53:10 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"DvTemGXN\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc:content-transfer-encoding;\n\tbh=rJggkINabGwhJLV8m4FOcbPKIYirIZvMKk9AqTAjKNE=;\n\tb=DvTemGXNiiWEAcrECWfQPBtrXboS/g5RidkX8/MdY5MsBqOWOQEIBc1QOjct1jNQSX\n\tmtsayOr6Rb7ihhrphqrvJ2MFzKFLBnpzOylGOtanDu2cFg78kTaKiFMVuVhJLx5BMI8R\n\tlzAL5UEDttUsAUdelI7JNsWZhwlzPqaVOK89p9KpKIMKNp9ph/Pbj6Uv1Wm0H2r1XS5T\n\tn23bOG/D8SxwwJ9Ee2tY+6Y8FNmYOI69AYDqejhlzYTpA+cuneH78xsnjdAHmcooYYf2\n\t4IFfghfEQ7+OVG+ZJJY72w7ZAwTN2AcmpWScH3m9+ook61xNPEIlFSkTKJRgLughq/Tg\n\tWRSQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc:content-transfer-encoding;\n\tbh=rJggkINabGwhJLV8m4FOcbPKIYirIZvMKk9AqTAjKNE=;\n\tb=qnBBTdf/qac4+gTjoQ1nRmO7ctH+i9QevQLpmMOxysTRGYQiTr3h8+YHQuzIxMFqOP\n\tk+sjTM2cgH9GPBQ70SWT3R5zDIsMhf/509JcDFsV0kGIimCYCaMGhkYIFefEaQMYunpt\n\taFlh6I2/bootKHWqRkGtIYwwCH0cHMwPH0+q+RVeqUXVU2VLOyPEUH8adQp4br43c0Wo\n\tOhEHwSEfCpnsMViGVAHn4+XaCg67eGyb3AFTWzTecWE22UpfVEP5i5FsrAPkO7ms95a+\n\tAwTuTC23zNyD/8LdLz2zcphOqi5xZVsCTiYl9B0lvzntH3VwgMYZgZ1GIzXjEPEOpOYE\n\trSUQ==","X-Gm-Message-State":"AOAM530qoMX/N4Th6ZOkftzTmC6xlevbV3HPEYmF086tTUC65W5xEagO\n\tPErqdzsRffZNtOq9aNoDiAdeyP2DlHQ3RUDuREuSDhadodQ=","X-Google-Smtp-Source":"ABdhPJyGTFkns9/g7kh5n6+JwPeymJhDe3xQZKa0j49+HNLxUVgxCnmdqPvllRrB31WicZddwIu18+RgEff7iM7W/mk=","X-Received":"by 2002:a2e:80a:: with SMTP id 10mr9967839lji.103.1596531189654; \n\tTue, 04 Aug 2020 01:53:09 -0700 (PDT)","MIME-Version":"1.0","References":"<20200724072218.943245-1-naush@raspberrypi.com>\n\t<CAEmqJPrvKqiOAcT6j0iaRDXw4cqc=0n3O0YFT2iSDzs0SwwgfA@mail.gmail.com>\n\t<20200801092242.GD1379367@oden.dyn.berto.se>\n\t<CAEmqJPoFwO_Hj9OpPgd497XS=bijW5UsS6rm9NvcaLrBNTF=6g@mail.gmail.com>\n\t<20200803115056.GA2160023@oden.dyn.berto.se>","In-Reply-To":"<20200803115056.GA2160023@oden.dyn.berto.se>","From":"Naushir Patuck <naush@raspberrypi.com>","Date":"Tue, 4 Aug 2020 09:52:53 +0100","Message-ID":"<CAEmqJPqJjNYLfCNN11NZvbAfMWocKPdodutXWjHphiTR_D_Xhw@mail.gmail.com>","To":"=?utf-8?q?Niklas_S=C3=B6derlund?= <niklas.soderlund@ragnatech.se>","Subject":"Re: [libcamera-devel] [PATCH v5 00/10] Zero-copy RAW stream work","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}}]