[{"id":11573,"web_url":"https://patchwork.libcamera.org/comment/11573/","msgid":"<20200724170051.GO5921@pendragon.ideasonboard.com>","date":"2020-07-24T17:00:51","subject":"Re: [libcamera-devel] [RFC PATCH 0/8] RFC MappedBuffers","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nThank you for the patch.\n\nOn Mon, Jul 20, 2020 at 11:42:24PM +0100, Kieran Bingham wrote:\n> These are some patches which have begun to form the pre-requisite base\n> for my JPEG software stream work, and as such - I'm posted as an RFC to\n> get early review while I try to clean up and fix up the JPEG stream.\n> \n> Kieran Bingham (8):\n> libcamera: buffer: Create a MappedFrameBuffer\n> libcamera: buffer: Convert copyFrom to use MappedFrameBuffer\n> qcam: Convert to use MappedFrameBuffer\n> buffer: Provide a base MappedBuffer class\n> android: camera_device: Report an error in notifyError()\n> android: camera_device: Only construct required planes\n> android: camera_device: Query plane length\n> RFC-Only: android: camera_device: Provide a MappedCamera3Buffer\n> \n> include/libcamera/buffer.h | 27 +++++++\n> src/android/camera_device.cpp | 69 ++++++++++++++++--\n> src/libcamera/buffer.cpp | 132 ++++++++++++++++++++++++++++------\n> src/qcam/main_window.cpp | 27 +++----\n> src/qcam/main_window.h | 2 +-\n> src/qcam/viewfinder.cpp | 4 +-\n> src/qcam/viewfinder.h | 7 +-\n\nIn case you're not aware yet, this is missing a unit test.\n\n> 7 files changed, 213 insertions(+), 55 deletions(-)","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 53733BD86F\n\tfor ;\n\tFri, 24 Jul 2020 17:01:00 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 10F55605B2;\n\tFri, 24 Jul 2020 19:01:00 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D73FE605B2\n\tfor ;\n\tFri, 24 Jul 2020 19:00:58 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 6C69A538;\n\tFri, 24 Jul 2020 19:00:58 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"W2Uieg3R\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1595610058;\n\tbh=PQBsV3llrRgT/u5JSWQ6MniBsyrEdh77WiwYq68TiuQ=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=W2Uieg3RGp9fWX8mOtGGfhRhUbZrgYz7fdXyenz2McHxPHvvIulEk4iWNLz7hpr+O\n\t2mhZmBap5TAauEraFm01Q06hMh+J/P2dW9WqBWsB/aCJGDHhsQysK7eN2iU58nV2Nx\n\tBeBtZDJCHKZIJQD+cb3en9mCJOECto4FzPw2ja5s=","Date":"Fri, 24 Jul 2020 20:00:51 +0300","From":"Laurent Pinchart ","To":"Kieran Bingham ","Message-ID":"<20200724170051.GO5921@pendragon.ideasonboard.com>","References":"<20200720224232.153717-1-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200720224232.153717-1-kieran.bingham@ideasonboard.com>","Subject":"Re: [libcamera-devel] [RFC PATCH 0/8] RFC MappedBuffers","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]