[{"id":11446,"web_url":"https://patchwork.libcamera.org/comment/11446/","msgid":"","date":"2020-07-21T10:13:03","subject":"Re: [libcamera-devel] [PATCH v4 0/9] Zero-copy RAW stream work","submitter":{"id":42,"url":"https://patchwork.libcamera.org/api/people/42/","name":"David Plowman","email":"david.plowman@raspberrypi.com"},"content":"Hi Naush, everyone\n\nThanks for all these patches! I've downloaded and tried them, with our\nnascent raspistill replacement as well as in qcam and it's all been\nworking well for me.\n\nCan I add\n\nTested-by: David Plowman \n\nto all the patches?\n\nThanks\nDavid\n\nOn Mon, 20 Jul 2020 at 10:13, Naushir Patuck wrote:\n>\n> Hi,\n>\n> Here is v4 of the patch set. I have removed the patch related to external buffer\n> handling. This needs a bit more though on how to implement, but should be fine,\n> as no application uses this method of buffer handling yet. This will be added\n> separately.\n>\n> Regards,\n> Naush\n>\n>\n> Naushir Patuck (9):\n> libcamera: pipeline: raspberrypi: Move RPiStream into a separate file\n> libcamera: pipeline: ipa: raspberrypi: Rework drop frame signalling\n> libcamera: pipeline: raspberrypi: Add some debug logging\n> libcamera: pipeline: raspberrypi: Increase the number of RAW buffers\n> libcamera: pipeline: raspberrypi: Remove const qualifier from\n> RPiStream\n> libcamera: pipeline: raspberrypi: Rework stream buffer logic for\n> zero-copy\n> libcamera: pipeline: raspberrypi: Fix bug in passing configuration to\n> IPA\n> libcamera: pipeline: raspberrypi: Add more robust stream buffer logic\n> libcamera: pipeline: ipa: raspberrypi: Remove use of FrameBuffer\n> cookie\n>\n> include/libcamera/ipa/raspberrypi.h | 2 +-\n> src/ipa/raspberrypi/raspberrypi.cpp | 20 +-\n> .../pipeline/raspberrypi/meson.build | 1 +\n> .../pipeline/raspberrypi/raspberrypi.cpp | 524 +++++++-----------\n> .../pipeline/raspberrypi/rpi_stream.cpp | 216 ++++++++\n> .../pipeline/raspberrypi/rpi_stream.h | 118 ++++\n> 6 files changed, 546 insertions(+), 335 deletions(-)\n> create mode 100644 src/libcamera/pipeline/raspberrypi/rpi_stream.cpp\n> create mode 100644 src/libcamera/pipeline/raspberrypi/rpi_stream.h\n>\n> --\n> 2.25.1\n>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 134AAC0109\n\tfor ;\n\tTue, 21 Jul 2020 10:13:18 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9888B60832;\n\tTue, 21 Jul 2020 12:13:17 +0200 (CEST)","from mail-ot1-x341.google.com (mail-ot1-x341.google.com\n\t[IPv6:2607:f8b0:4864:20::341])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6D10660496\n\tfor ;\n\tTue, 21 Jul 2020 12:13:16 +0200 (CEST)","by mail-ot1-x341.google.com with SMTP id 5so14611087oty.11\n\tfor ;\n\tTue, 21 Jul 2020 03:13:16 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"i/P5h1M3\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=od9FrgbuQEqXa1md2d1e07p2jGMajJXp4Jr9GbGoBDo=;\n\tb=i/P5h1M3hcFHWLxYPwCgc3GtDONfeEGIiWDzRm422l0V7OpQtUsYCeEg9KdUEcEC4v\n\tAas0S+o177qiKbYRQipDR/8oPB+EdhPwXtASEG9UDjOhVepvTX76X0nr8i54RyABzdWM\n\tHLAAqrfNxImLibfgKhoxD3dwfmNf3PlV5cqEPNYxvlado3+NqsifbxAs8UUQ8dlt3gTq\n\tXO2H55OxlLtPr5lyUBZZWfMLb5RCa/AEm1maBWZNbKOOiorH0dFSirVJnxJuDxF7mejw\n\tTOOaofxKuZmFL5iVT7Br1Qc1mezb4Fe3PXKZlvdgmzAv1jvRWG3ucWV89WMCrcM2O3C1\n\trJ3A==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=od9FrgbuQEqXa1md2d1e07p2jGMajJXp4Jr9GbGoBDo=;\n\tb=X6br8lBU1t9OSOfs2bnHCRif/O7eIxIp3y1tcFfz/PLPFgvlVPiwhLUQtB3s0nvl/y\n\tOPyJprrK7PoZXaZ++wB+39m+jkXZJ2/gkLP7LohzePQTIb+oaee6eEGE+FiHkrUYbD6a\n\t4hFsdy60uoQooVdBaA9W/bymJL9SxG1e2O8Z5dJXDHsQFhnpfXz4+5gc+XOw/bPrkEqr\n\tTQ0qLpFb3/ndRqr6JZ/tu3z2U0kW5SVNuRd6FKHIBitxlfJR8jgaJXfDKmMr5XSzbC+i\n\tfzY6nO1d7kkqzJQpuAlE98Fede7S02WVx692fGLJIWnDEqrgiFwWS09TBjyhooY3T/mj\n\tlePg==","X-Gm-Message-State":"AOAM531StBOxiF94n+O3c7Qt3dgPta+GxS9tThmhmsl6QWWtc+bjdODG\n\tCZIJZ/asfz/vXzv1AhCI1vqQ5W1k/Dt2VSQTEojXHg==","X-Google-Smtp-Source":"ABdhPJyZ48WiFQlEjGKNnY9/PVr7oeNzFIgCxZ0GkvIaJZ+fq1yO1gxDcXPrq55kvxMCFxgi9ul6r8gRr4wA3HK2QN0=","X-Received":"by 2002:a05:6830:14d4:: with SMTP id\n\tt20mr23538663otq.166.1595326395184; \n\tTue, 21 Jul 2020 03:13:15 -0700 (PDT)","MIME-Version":"1.0","References":"<20200720091311.805092-1-naush@raspberrypi.com>","In-Reply-To":"<20200720091311.805092-1-naush@raspberrypi.com>","From":"David Plowman ","Date":"Tue, 21 Jul 2020 11:13:03 +0100","Message-ID":"","To":"Naushir Patuck ","Subject":"Re: [libcamera-devel] [PATCH v4 0/9] Zero-copy RAW stream work","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":11501,"web_url":"https://patchwork.libcamera.org/comment/11501/","msgid":"<20200722145342.GD29813@pendragon.ideasonboard.com>","date":"2020-07-22T14:53:42","subject":"Re: [libcamera-devel] [PATCH v4 0/9] Zero-copy RAW stream work","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi David,\n\nOn Tue, Jul 21, 2020 at 11:13:03AM +0100, David Plowman wrote:\n> Hi Naush, everyone\n> \n> Thanks for all these patches! I've downloaded and tried them, with our\n> nascent raspistill replacement as well as in qcam and it's all been\n> working well for me.\n> \n> Can I add\n> \n> Tested-by: David Plowman \n> \n> to all the patches?\n\nSure :-) Naush mentioned he will post a new version, I thus expect him\nto add your tag to the patches.\n\n> On Mon, 20 Jul 2020 at 10:13, Naushir Patuck wrote:\n> >\n> > Hi,\n> >\n> > Here is v4 of the patch set. I have removed the patch related to external buffer\n> > handling. This needs a bit more though on how to implement, but should be fine,\n> > as no application uses this method of buffer handling yet. This will be added\n> > separately.\n> >\n> > Regards,\n> > Naush\n> >\n> >\n> > Naushir Patuck (9):\n> > libcamera: pipeline: raspberrypi: Move RPiStream into a separate file\n> > libcamera: pipeline: ipa: raspberrypi: Rework drop frame signalling\n> > libcamera: pipeline: raspberrypi: Add some debug logging\n> > libcamera: pipeline: raspberrypi: Increase the number of RAW buffers\n> > libcamera: pipeline: raspberrypi: Remove const qualifier from\n> > RPiStream\n> > libcamera: pipeline: raspberrypi: Rework stream buffer logic for\n> > zero-copy\n> > libcamera: pipeline: raspberrypi: Fix bug in passing configuration to\n> > IPA\n> > libcamera: pipeline: raspberrypi: Add more robust stream buffer logic\n> > libcamera: pipeline: ipa: raspberrypi: Remove use of FrameBuffer\n> > cookie\n> >\n> > include/libcamera/ipa/raspberrypi.h | 2 +-\n> > src/ipa/raspberrypi/raspberrypi.cpp | 20 +-\n> > .../pipeline/raspberrypi/meson.build | 1 +\n> > .../pipeline/raspberrypi/raspberrypi.cpp | 524 +++++++-----------\n> > .../pipeline/raspberrypi/rpi_stream.cpp | 216 ++++++++\n> > .../pipeline/raspberrypi/rpi_stream.h | 118 ++++\n> > 6 files changed, 546 insertions(+), 335 deletions(-)\n> > create mode 100644 src/libcamera/pipeline/raspberrypi/rpi_stream.cpp\n> > create mode 100644 src/libcamera/pipeline/raspberrypi/rpi_stream.h","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 23943C2E68\n\tfor ;\n\tWed, 22 Jul 2020 14:53:50 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B265360948;\n\tWed, 22 Jul 2020 16:53:49 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A93546039F\n\tfor ;\n\tWed, 22 Jul 2020 16:53:48 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 286C0329;\n\tWed, 22 Jul 2020 16:53:48 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Fejg18QF\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1595429628;\n\tbh=MfgqQsfFepinq7TtwuvDVmlj1JeVYkxRdHYsD5y4BvE=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=Fejg18QFLvk5cbVT6plhq57Da4zJz1bEnyAQS8S+PkFZrolR34M3QcB6EZzgezAVJ\n\tbOqRWhjspFxP9rNgXiUOv5HaCv3JLHFeIlyLSf8tWTq1kkioSwas/R6mGSdbwnxXvb\n\tn7mhLxrZmo7iWp1h6aDo93Cwn2nB9WtNnu0YXz4I=","Date":"Wed, 22 Jul 2020 17:53:42 +0300","From":"Laurent Pinchart ","To":"David Plowman ","Message-ID":"<20200722145342.GD29813@pendragon.ideasonboard.com>","References":"<20200720091311.805092-1-naush@raspberrypi.com>\n\t","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"","Subject":"Re: [libcamera-devel] [PATCH v4 0/9] Zero-copy RAW stream work","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]