[{"id":11408,"web_url":"https://patchwork.libcamera.org/comment/11408/","msgid":"","date":"2020-07-15T11:30:34","subject":"Re: [libcamera-devel] [PATCH v2 00/13] raspberrypi: Report sensor\n\torientation through DT","submitter":{"id":27,"url":"https://patchwork.libcamera.org/api/people/27/","name":"Dave Stevenson","email":"dave.stevenson@raspberrypi.com"},"content":"Hi Laurent\n\nOn Wed, 15 Jul 2020 at 02:18, Laurent Pinchart\n wrote:\n>\n> Hi Dave,\n>\n> This patch series reports sensor orientation through DT for the OV5647,\n> IMX219 and IMX477. The first 8 patches are backported from mainline,\n> while the last 5 patches are new.\n>\n> Compared to v1, I've mentioned the upstream commit SHA1 in all the\n> backported patches, and enabled DT overlay parameter support.\n>\n> The patches are based on top of rpi-5.4.y. I've posted\n> https://github.com/raspberrypi/linux/pull/3723 (I'm sure it's at least\n> partly due to me being used to the mailing list workflow, but going\n> through the github UI is so frustrating :-S).\n\nI'd say the exact opposite!\n\n> The kernel and libcamera sides need to be merged together. Could you\n> please let me know when you plan to merge the kernel changes ? I'll push\n> the libcamera changes accordingly.\n\nPhil's the main gatekeeper on the repo, but other than the couple of\nminor comments that he's made, I see no reason for the merge to be\nsignificantly delayed.\n\nI haven't checked the libcamera side - does it fail totally if the\ncontrols aren't defined, or drop back to some default? I have a docs\npage[1] that tries to list out all the controls and ioctls that are\nmandatory for libcamera on the Pi.\n\n Dave\n\n[1] https://www.raspberrypi.org/documentation/linux/software/libcamera/csi-2-usage.md\n\n> Jacopo Mondi (8):\n> media: dt-bindings: video-interfaces: Document 'orientation' property\n> media: dt-bindings: video-interface: Replace 'rotation' description\n> media: v4l2-ctrl: Document V4L2_CID_CAMERA_ORIENTATION\n> media: v4l2-ctrl: Document V4L2_CID_CAMERA_SENSOR_ROTATION\n> media: v4l2-ctrls: Add camera orientation and rotation\n> media: v4l2-fwnode: Add helper to parse device properties\n> media: v4l2-ctrls: Add helper to register properties\n> media: i2c: imx219: Parse and register properties\n>\n> Laurent Pinchart (5):\n> media: i2c: ov5647: Parse and register properties\n> media: i2c: imx477: Parse and register properties\n> dt/dtoverlays: ov5647: Add parameter to set camera module rotation\n> dt/dtoverlays: imx219: Add parameter to set camera module rotation\n> dt/dtoverlays: imx477: Add parameter to set camera module rotation\n>\n> .../bindings/media/video-interfaces.txt | 370 +++++++++++++++++-\n> .../media/uapi/v4l/ext-ctrls-camera.rst | 151 +++++++\n> arch/arm/boot/dts/overlays/README | 15 +-\n> arch/arm/boot/dts/overlays/imx219-overlay.dts | 6 +\n> arch/arm/boot/dts/overlays/imx477-overlay.dts | 6 +\n> arch/arm/boot/dts/overlays/ov5647-overlay.dts | 4 +\n> drivers/media/i2c/imx219.c | 12 +-\n> drivers/media/i2c/imx477.c | 12 +-\n> drivers/media/i2c/ov5647.c | 13 +-\n> drivers/media/v4l2-core/v4l2-ctrls.c | 53 +++\n> drivers/media/v4l2-core/v4l2-fwnode.c | 42 ++\n> include/media/v4l2-ctrls.h | 26 ++\n> include/media/v4l2-fwnode.h | 47 +++\n> include/uapi/linux/v4l2-controls.h | 7 +\n> 14 files changed, 752 insertions(+), 12 deletions(-)\n>\n> --\n> Regards,\n>\n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A4986BD790\n\tfor ;\n\tWed, 15 Jul 2020 11:30:50 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3B76D60998;\n\tWed, 15 Jul 2020 13:30:50 +0200 (CEST)","from mail-wr1-x442.google.com (mail-wr1-x442.google.com\n\t[IPv6:2a00:1450:4864:20::442])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5AB366093A\n\tfor ;\n\tWed, 15 Jul 2020 13:30:49 +0200 (CEST)","by mail-wr1-x442.google.com with SMTP id f18so2338542wrs.0\n\tfor ;\n\tWed, 15 Jul 2020 04:30:49 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"MgvItGIs\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=HufOCzybihZ0rgWcrkVZ1fVsgyKv3lMtQIaRAxOmGbY=;\n\tb=MgvItGIsMxcXbLA2rAZ8VKMfTneurVlaQi4ESWg8EqMod6xahy3HbZr8uJkLHLgMEj\n\tTQbdr05VQSjc3tR6hYCPxm7hsaigzUOsMxv3OYqeCf+pooaOB5BVQx1hQmKYp/FukCye\n\tE6hQP7SXC4gwT4SWOyqU/r15KMD6dPnRFvZpOx/q5QqlKvzIhN2DjniSB/Yc4jQcWjGs\n\tsmbGrSLKl3nRB6eoUSuNerXbloJKKgOb+vbReV6rOQJLt/c3zl1S6gVFhPdTEtDyRQ2Y\n\t40QEGZKEVp+9WbGKusQGZaoKHQYtRTNnNDpOpKvJLMtNgsqSD1rJoMqMwV4ure/XxfFR\n\t0JNA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=HufOCzybihZ0rgWcrkVZ1fVsgyKv3lMtQIaRAxOmGbY=;\n\tb=Bttj+P4oF00EN8gZF4dXQAlifPSXG+ggt6eTAdrQ/3Tv3teCU94ZlViw/osp4ORJI0\n\t5dLbV1w2q9na3VVD2Y1gJedaJs39VG6rs4YgRVELqk1ya9rzn0DnRIJH0bklfZJhFFFu\n\t0SnU6Q2m9e0MoRSStBouZeP23Q05E8mAK0nZQ4Q8ysxq4BCZfP/B9pDMobsP8U24knEk\n\tVMEdL5DGazUw7LBKnlPMoMulHyij5yS3oZMWRQ5JOHw8ISjP9yrMgrtL+Vsn7OCrBIIh\n\tYIqA0PCRXW/hha5hCcXFrfAilw9c8oYN30mHS9R35GxJYH7yp9+V1ExonsgEiVD4bo9h\n\txBgQ==","X-Gm-Message-State":"AOAM53340ZOTBmdHmxhmDzuHcobJmfOaiS7Rj6liOtn78obWb8c7JI/0\n\tNY0tqbckFB7TmsKyfwZDEB6SHOxl1kjnKQj6ZD1xXegpaso=","X-Google-Smtp-Source":"ABdhPJyHE80dxnI7N/1pfS2RSyq9tZlfT+cZDsWSuhhzV6igxMq4hQj/5ZtQlA4Gpbwnu1SWvIpW8GNR7xt2UZmJ01I=","X-Received":"by 2002:adf:cc85:: with SMTP id\n\tp5mr10731668wrj.273.1594812649003; \n\tWed, 15 Jul 2020 04:30:49 -0700 (PDT)","MIME-Version":"1.0","References":"<20200715011833.24600-1-laurent.pinchart@ideasonboard.com>","In-Reply-To":"<20200715011833.24600-1-laurent.pinchart@ideasonboard.com>","From":"Dave Stevenson ","Date":"Wed, 15 Jul 2020 12:30:34 +0100","Message-ID":"","To":"Laurent Pinchart ","Subject":"Re: [libcamera-devel] [PATCH v2 00/13] raspberrypi: Report sensor\n\torientation through DT","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":11412,"web_url":"https://patchwork.libcamera.org/comment/11412/","msgid":"<20200715225410.GG6144@pendragon.ideasonboard.com>","date":"2020-07-15T22:54:10","subject":"Re: [libcamera-devel] [PATCH v2 00/13] raspberrypi: Report sensor\n\torientation through DT","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Dave,\n\nOn Wed, Jul 15, 2020 at 12:30:34PM +0100, Dave Stevenson wrote:\n> On Wed, 15 Jul 2020 at 02:18, Laurent Pinchart wrote:\n> >\n> > Hi Dave,\n> >\n> > This patch series reports sensor orientation through DT for the OV5647,\n> > IMX219 and IMX477. The first 8 patches are backported from mainline,\n> > while the last 5 patches are new.\n> >\n> > Compared to v1, I've mentioned the upstream commit SHA1 in all the\n> > backported patches, and enabled DT overlay parameter support.\n> >\n> > The patches are based on top of rpi-5.4.y. I've posted\n> > https://github.com/raspberrypi/linux/pull/3723 (I'm sure it's at least\n> > partly due to me being used to the mailing list workflow, but going\n> > through the github UI is so frustrating :-S).\n> \n> I'd say the exact opposite!\n\nChanges are hard, right ? :-)\n\n> > The kernel and libcamera sides need to be merged together. Could you\n> > please let me know when you plan to merge the kernel changes ? I'll push\n> > the libcamera changes accordingly.\n> \n> Phil's the main gatekeeper on the repo, but other than the couple of\n> minor comments that he's made, I see no reason for the merge to be\n> significantly delayed.\n> \n> I haven't checked the libcamera side - does it fail totally if the\n> controls aren't defined, or drop back to some default? I have a docs\n> page[1] that tries to list out all the controls and ioctls that are\n> mandatory for libcamera on the Pi.\n\nlibcamera will fallback to default values, so it should be safe (but\nwill result in an upside-down image during the transition). It's\nactually safe to merge the kernel patches without the libcamera side, so\nI'll wait for Phil to merge the branch, and I'll then push the patches\nin libcamera.\n\n> [1] https://www.raspberrypi.org/documentation/linux/software/libcamera/csi-2-usage.md\n\nThat's an interesting document, thanks. Could you add\nV4L2_CID_CAMERA_ORIENTATION and V4L2_CID_CAMERA_SENSOR_ROTATION ? While\nnot strictly mandatory, it's a good practice to support them.\n\n> > Jacopo Mondi (8):\n> > media: dt-bindings: video-interfaces: Document 'orientation' property\n> > media: dt-bindings: video-interface: Replace 'rotation' description\n> > media: v4l2-ctrl: Document V4L2_CID_CAMERA_ORIENTATION\n> > media: v4l2-ctrl: Document V4L2_CID_CAMERA_SENSOR_ROTATION\n> > media: v4l2-ctrls: Add camera orientation and rotation\n> > media: v4l2-fwnode: Add helper to parse device properties\n> > media: v4l2-ctrls: Add helper to register properties\n> > media: i2c: imx219: Parse and register properties\n> >\n> > Laurent Pinchart (5):\n> > media: i2c: ov5647: Parse and register properties\n> > media: i2c: imx477: Parse and register properties\n> > dt/dtoverlays: ov5647: Add parameter to set camera module rotation\n> > dt/dtoverlays: imx219: Add parameter to set camera module rotation\n> > dt/dtoverlays: imx477: Add parameter to set camera module rotation\n> >\n> > .../bindings/media/video-interfaces.txt | 370 +++++++++++++++++-\n> > .../media/uapi/v4l/ext-ctrls-camera.rst | 151 +++++++\n> > arch/arm/boot/dts/overlays/README | 15 +-\n> > arch/arm/boot/dts/overlays/imx219-overlay.dts | 6 +\n> > arch/arm/boot/dts/overlays/imx477-overlay.dts | 6 +\n> > arch/arm/boot/dts/overlays/ov5647-overlay.dts | 4 +\n> > drivers/media/i2c/imx219.c | 12 +-\n> > drivers/media/i2c/imx477.c | 12 +-\n> > drivers/media/i2c/ov5647.c | 13 +-\n> > drivers/media/v4l2-core/v4l2-ctrls.c | 53 +++\n> > drivers/media/v4l2-core/v4l2-fwnode.c | 42 ++\n> > include/media/v4l2-ctrls.h | 26 ++\n> > include/media/v4l2-fwnode.h | 47 +++\n> > include/uapi/linux/v4l2-controls.h | 7 +\n> > 14 files changed, 752 insertions(+), 12 deletions(-)","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C585CBD790\n\tfor ;\n\tWed, 15 Jul 2020 22:54:21 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2F19B605AC;\n\tThu, 16 Jul 2020 00:54:21 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0C43D60493\n\tfor ;\n\tThu, 16 Jul 2020 00:54:19 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 6D62F564;\n\tThu, 16 Jul 2020 00:54:18 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"p9WAOgFh\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1594853658;\n\tbh=PJoRFmED8X8AfX/RCqSvOawl3RADXetk2VMMKAAToC0=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=p9WAOgFhtkb3uTnMB885VwBSQpR4AgOzv4yIy2WooOFSU86xXjIyG+acaHZWxYn3M\n\tB06asaEFsLkeCt4xLyp7P04CCewUNarVXYmDkZucqSwn0TvugjRpZJyPlFIHHNjMhd\n\tmmvXt+HyMpkjr1lpoF8teHNkmNgoxk9EPV060NIg=","Date":"Thu, 16 Jul 2020 01:54:10 +0300","From":"Laurent Pinchart ","To":"Dave Stevenson ","Message-ID":"<20200715225410.GG6144@pendragon.ideasonboard.com>","References":"<20200715011833.24600-1-laurent.pinchart@ideasonboard.com>\n\t","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"","Subject":"Re: [libcamera-devel] [PATCH v2 00/13] raspberrypi: Report sensor\n\torientation through DT","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]