[{"id":11385,"web_url":"https://patchwork.libcamera.org/comment/11385/","msgid":"<20200714181435.GA5854@pendragon.ideasonboard.com>","date":"2020-07-14T18:14:35","subject":"Re: [libcamera-devel] [PATCH 0/2] Replace vcsm with dmabuf alloc","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Naush,\n\nOn Tue, Jul 14, 2020 at 01:08:42PM +0100, Naushir Patuck wrote:\n> Hi,\n> \n> This patch replaces the existing vcsm with dmabuf allocations for the lens shading tables.\n> This change will break existing functionality without the equivalent linux kernel\n> change (https://github.com/raspberrypi/linux/pull/3715) being present and built..\n> \n> Laurent, since this is an ABI breakage, once the review is complete, could you\n> let me know before you are about to merge this change so we can sync push the\n> kernel change at the same time and inform our users please?\n\nSure, I'll do so.\n\n> Naushir Patuck (2):\n> include: linux: Add dma-buf.h and dma-heap.h uapi headers\n> libcamera: pipeline: ipa: raspberrypi: Use dma heap allocs for LS\n> tables\n> \n> include/linux/bcm2835-isp.h | 4 +-\n> include/linux/dma-buf.h | 50 ++++++\n> include/linux/dma-heap.h | 53 +++++++\n> include/linux/vc_sm_cma_ioctl.h | 135 ----------------\n> src/ipa/raspberrypi/raspberrypi.cpp | 27 +++-\n> .../pipeline/raspberrypi/dma-heaps.h | 102 ++++++++++++\n> .../pipeline/raspberrypi/raspberrypi.cpp | 44 ++----\n> src/libcamera/pipeline/raspberrypi/vcsm.h | 149 ------------------\n> 8 files changed, 241 insertions(+), 323 deletions(-)\n> create mode 100644 include/linux/dma-buf.h\n> create mode 100644 include/linux/dma-heap.h\n> delete mode 100644 include/linux/vc_sm_cma_ioctl.h\n> create mode 100644 src/libcamera/pipeline/raspberrypi/dma-heaps.h\n> delete mode 100644 src/libcamera/pipeline/raspberrypi/vcsm.h","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 75B99BD790\n\tfor ;\n\tTue, 14 Jul 2020 18:14:45 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id EFB31605B0;\n\tTue, 14 Jul 2020 20:14:44 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0EF2C605AC\n\tfor ;\n\tTue, 14 Jul 2020 20:14:43 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 807BF71D;\n\tTue, 14 Jul 2020 20:14:42 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"pP+tpmfx\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1594750482;\n\tbh=83/RSSeIzdjzoNJdQ8VigfN6u9Dgnet3Lo9UfBjx7XI=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=pP+tpmfxmhapt72YuvFVjLpkOa2C12J7BJAmxck3kcQ+mu0Y39lStd58qfXYyR4pB\n\t/WFjwNsP2AJi+C8iiqtEV880L2bwqG5dZYfoRfu7OvjwU+wp4oRuTWIVyLSNZ4RV6d\n\tBq9n4SadUoOANW0HOGeLHeyVkDjf0MCAe9DrjzME=","Date":"Tue, 14 Jul 2020 21:14:35 +0300","From":"Laurent Pinchart ","To":"Naushir Patuck ","Message-ID":"<20200714181435.GA5854@pendragon.ideasonboard.com>","References":"<20200714120844.520732-1-naush@raspberrypi.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200714120844.520732-1-naush@raspberrypi.com>","Subject":"Re: [libcamera-devel] [PATCH 0/2] Replace vcsm with dmabuf alloc","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]