[{"id":11431,"web_url":"https://patchwork.libcamera.org/comment/11431/","msgid":"","date":"2020-07-19T11:33:44","subject":"Re: [libcamera-devel] [PATCH 0/3] ColourCorrectionMatrixControl","submitter":{"id":42,"url":"https://patchwork.libcamera.org/api/people/42/","name":"David Plowman","email":"david.plowman@raspberrypi.com"},"content":"Hi everyone\n\nPerhaps I can gently nudge people to have a look at this patch? It's\nparticularly helpful to anyone who wants to process the raw files\ncoming out of qcam.\n\nThanks\nDavid\n\nOn Sat, 4 Jul 2020 at 10:59, David Plowman\n wrote:\n>\n> Hi everyone\n>\n> This patch set adds the ColourCorrectionMatrix control, though its use\n> is for now mainly to get hold of the Colour Correction Matrix (CCM)\n> used by the imaging pipeline in the libcamera metadata. There are 3\n> commits:\n>\n> 1. The basic ColourCorrectionMatrix control.\n>\n> 2. The implementation for the Raspberry Pi platform.\n>\n> 3. Use of the new metadata to produce better colours in the DNG files\n> saved by qcam. Tools like dcraw (with -w) and RawTherapee should\n> produce reasonable looking images by default.\n>\n> In the 3rd patch I use a little matrix arithmetic. I thought I might\n> be able to use Qt for this, but it appears not to have a proper 3x3\n> matrix class (that finds determinants and inverts them) so I ended up\n> rolling my own. It's only a very small amount of code but does anyone\n> have a better suggestion?\n>\n> Thanks and best regards\n> David\n>\n> David Plowman (3):\n> libcamera: Add ColourCorrectionMatrix control\n> libcamera: raspberrypi: Add ColourCorrectionMatrix control\n> libcamera: qcam: Improve colour information in DNG files\n>\n> include/libcamera/ipa/raspberrypi.h | 1 +\n> src/ipa/raspberrypi/raspberrypi.cpp | 9 +++\n> src/libcamera/control_ids.yaml | 12 ++++\n> src/qcam/dng_writer.cpp | 93 +++++++++++++++++++++++++++++\n> 4 files changed, 115 insertions(+)\n>\n> --\n> 2.20.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C6543BD792\n\tfor ;\n\tSun, 19 Jul 2020 11:33:58 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 40F8060589;\n\tSun, 19 Jul 2020 13:33:58 +0200 (CEST)","from mail-ot1-x342.google.com (mail-ot1-x342.google.com\n\t[IPv6:2607:f8b0:4864:20::342])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 864B260540\n\tfor ;\n\tSun, 19 Jul 2020 13:33:56 +0200 (CEST)","by mail-ot1-x342.google.com with SMTP id t18so10109073otq.5\n\tfor ;\n\tSun, 19 Jul 2020 04:33:56 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"jUyoxZVv\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to;\n\tbh=+/OsEhzeWzI0WoNMpr/OGJRQRCFvjAHvLOVbjve1eT4=;\n\tb=jUyoxZVvxCI2T+AhmwhQypzwQaHm3uNZJPCvLrGg/qYPpjMu1jgzjUt1N4bFjt/9dy\n\tNB5vo5x/zg6Z9kXwCNdqqoRZpO0xOWqZNQXI4BZppk7QVkFTcxbKjBdI0oQTRAHX9HDG\n\tmDdU7OQBddwSG9uJt3nH2u3O0g9uvStf2q3iSxc6V5BRvmr0AbIBwrfIV09jBDWr9q9/\n\tyK3Ki2A+9y7Qy7aWrdNMcLaglSKrGduuCyoxUvq78ZwCa0RCqykdGd3o/ilgXduEbeHT\n\tMPAONprN2hfRzfRXdRNbQWLDN8HL7Fo2o/6LLB3PeGF5qddhsPUeihZFkOxEhd7mlukP\n\tEucg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to;\n\tbh=+/OsEhzeWzI0WoNMpr/OGJRQRCFvjAHvLOVbjve1eT4=;\n\tb=DvJF5xFV1Fgt6+F0FKOb22aQOpAsAIILNAYJTGNo62UuLMzQxH7uO/q3Ddxc7+AgiP\n\tlW2GDhQhcDrGAwWgCMTE3+9IazQN2MsbhRYlxc7fd0cGw2SWVb7e0LiwgCLpqTAqWE0G\n\tMBPP8TmUTHNtXBC9xNe9VGwBfx7pV+Cf4vmyejnQC2eQH/IhwoKjBP1AZJcawe03WmmG\n\t+RdOJHVDBx/D3yc76IwXJxggDCXbjVjcupMDOW87ho4oL06wOyRyx/y2Q8qCvO24o7qP\n\tLrrjsdg8omyFjxSlwxq1KsYMeq6HSN1Q34r1Ubv+Hq5hWznqmuQfL/oGepVTnciNjvn2\n\tipig==","X-Gm-Message-State":"AOAM532nuKgCAzo1CpI00MHe7mMWW8etkU1nI0VS7scdk5H6I+WbOqOI\n\ta0ReLFMGjg0cDpkKsOyZLAsnOEKy6bduTUd0abMQvV7gNhA=","X-Google-Smtp-Source":"ABdhPJypHV456NRJFkHWk4EW82JY//JCP1OitnTxq4Orf9vAISTUmCimd2zhCF4nFGajQMTJMNJP5K+R5QKfwC4JGjE=","X-Received":"by 2002:a05:6830:14d4:: with SMTP id\n\tt20mr15788033otq.166.1595158434771; \n\tSun, 19 Jul 2020 04:33:54 -0700 (PDT)","MIME-Version":"1.0","References":"<20200704095914.17344-1-david.plowman@raspberrypi.com>","In-Reply-To":"<20200704095914.17344-1-david.plowman@raspberrypi.com>","From":"David Plowman ","Date":"Sun, 19 Jul 2020 12:33:44 +0100","Message-ID":"","To":"libcamera-devel@lists.libcamera.org","Subject":"Re: [libcamera-devel] [PATCH 0/3] ColourCorrectionMatrixControl","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":11526,"web_url":"https://patchwork.libcamera.org/comment/11526/","msgid":"<20200724001608.GF21353@pendragon.ideasonboard.com>","date":"2020-07-24T00:16:08","subject":"Re: [libcamera-devel] [PATCH 0/3] ColourCorrectionMatrixControl","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi David,\n\nThank you for the patches.\n\nOn Sat, Jul 04, 2020 at 10:59:11AM +0100, David Plowman wrote:\n> Hi everyone\n> \n> This patch set adds the ColourCorrectionMatrix control, though its use\n> is for now mainly to get hold of the Colour Correction Matrix (CCM)\n> used by the imaging pipeline in the libcamera metadata. There are 3\n> commits:\n> \n> 1. The basic ColourCorrectionMatrix control.\n> \n> 2. The implementation for the Raspberry Pi platform.\n> \n> 3. Use of the new metadata to produce better colours in the DNG files\n> saved by qcam. Tools like dcraw (with -w) and RawTherapee should\n> produce reasonable looking images by default.\n> \n> In the 3rd patch I use a little matrix arithmetic. I thought I might\n> be able to use Qt for this, but it appears not to have a proper 3x3\n> matrix class (that finds determinants and inverts them) so I ended up\n> rolling my own. It's only a very small amount of code but does anyone\n> have a better suggestion?\n\nI think this is fine for now. Another option would be\nboost::numeric::ublas, eigen (http://eigen.tuxfamily.org/) or another\nsimilar linear algebra library, but that's likely overkill for now.\n\n> David Plowman (3):\n> libcamera: Add ColourCorrectionMatrix control\n> libcamera: raspberrypi: Add ColourCorrectionMatrix control\n> libcamera: qcam: Improve colour information in DNG files\n> \n> include/libcamera/ipa/raspberrypi.h | 1 +\n> src/ipa/raspberrypi/raspberrypi.cpp | 9 +++\n> src/libcamera/control_ids.yaml | 12 ++++\n> src/qcam/dng_writer.cpp | 93 +++++++++++++++++++++++++++++\n> 4 files changed, 115 insertions(+)","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B4071BD878\n\tfor ;\n\tFri, 24 Jul 2020 00:16:17 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 20E0D61167;\n\tFri, 24 Jul 2020 02:16:17 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B389760539\n\tfor ;\n\tFri, 24 Jul 2020 02:16:15 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 37AB5279;\n\tFri, 24 Jul 2020 02:16:15 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"d+YvjqSK\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1595549775;\n\tbh=gx2/lHgYcv96pgnirF1Lw1wTCQawprzKAT7AAlUtgqU=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=d+YvjqSK+HEGnK4s/ijMxuyvlkN9q6vEw4zB9Iqr6r4JEtIa6tIPa55wJBc872SEF\n\tzrUylyJRnX4x+aNw8XiS6k/RoGRUDrmCsv0rApeqDCJW5IJ1Jmp9f8uY4eDj0lrlVD\n\t+anAHwHw+XA5scbVmYkpC7Hy0JmP8oXh+RfP11BI=","Date":"Fri, 24 Jul 2020 03:16:08 +0300","From":"Laurent Pinchart ","To":"David Plowman ","Message-ID":"<20200724001608.GF21353@pendragon.ideasonboard.com>","References":"<20200704095914.17344-1-david.plowman@raspberrypi.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200704095914.17344-1-david.plowman@raspberrypi.com>","Subject":"Re: [libcamera-devel] [PATCH 0/3] ColourCorrectionMatrixControl","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]