[{"id":11225,"web_url":"https://patchwork.libcamera.org/comment/11225/","msgid":"","date":"2020-07-06T17:33:41","subject":"Re: [libcamera-devel] [PATCH 00/12] raspberrypi: Report sensor\n\torientation through DT","submitter":{"id":27,"url":"https://patchwork.libcamera.org/api/people/27/","name":"Dave Stevenson","email":"dave.stevenson@raspberrypi.com"},"content":"Hi Laurent.\n\nOn Sat, 4 Jul 2020 at 01:40, Laurent Pinchart\n wrote:\n>\n> Hi Dave,\n>\n> This patch series reports sensor orientation through DT for the OV5647,\n> IMX219 and IMX477. The first 8 patches are backported from mainline,\n> while the last 4 patches are new. Patch 09/12 could possibly be skipped\n> for now, as we don't use the rotation property in the ov5647 DT overlay.\n>\n> The patches are based on top of rpi-5.4.y. libcamera patches will follow\n> shortly.\n\nThe patches look reasonable. I'd suggest that rotation really ought to\nbe a dtoverlay property rather than hard coded. Particularly with\nIMX219 there is no defined \"right way\" of mounting it. IMX477 with the\ntripod screw-hole does have a natural orientation.\nAre you expecting those to be merged into our kernel tree? We normally\nuse Github pull requests rather than mailing lists.\n\n Dave\n\n> Jacopo Mondi (8):\n> media: dt-bindings: video-interfaces: Document 'orientation' property\n> media: dt-bindings: video-interface: Replace 'rotation' description\n> media: v4l2-ctrl: Document V4L2_CID_CAMERA_ORIENTATION\n> media: v4l2-ctrl: Document V4L2_CID_CAMERA_SENSOR_ROTATION\n> media: v4l2-ctrls: Add camera orientation and rotation\n> media: v4l2-fwnode: Add helper to parse device properties\n> media: v4l2-ctrls: Add helper to register properties\n> media: i2c: imx219: Parse and register properties\n>\n> Laurent Pinchart (4):\n> media: i2c: ov5647: Parse and register properties\n> media: i2c: imx477: Parse and register properties\n> dt/dtoverlays: imx219: Set sensor rotation\n> dt/dtoverlays: imx477: Set sensor rotation\n>\n> .../bindings/media/video-interfaces.txt | 370 +++++++++++++++++-\n> .../media/uapi/v4l/ext-ctrls-camera.rst | 151 +++++++\n> arch/arm/boot/dts/overlays/imx219-overlay.dts | 2 +\n> arch/arm/boot/dts/overlays/imx477-overlay.dts | 2 +\n> drivers/media/i2c/imx219.c | 12 +-\n> drivers/media/i2c/imx477.c | 12 +-\n> drivers/media/i2c/ov5647.c | 13 +-\n> drivers/media/v4l2-core/v4l2-ctrls.c | 53 +++\n> drivers/media/v4l2-core/v4l2-fwnode.c | 42 ++\n> include/media/v4l2-ctrls.h | 26 ++\n> include/media/v4l2-fwnode.h | 47 +++\n> include/uapi/linux/v4l2-controls.h | 7 +\n> 12 files changed, 731 insertions(+), 6 deletions(-)\n>\n> --\n> Regards,\n>\n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 69234BD790\n\tfor ;\n\tMon, 6 Jul 2020 17:34:01 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E2D3260E05;\n\tMon, 6 Jul 2020 19:34:00 +0200 (CEST)","from mail-wr1-x443.google.com (mail-wr1-x443.google.com\n\t[IPv6:2a00:1450:4864:20::443])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 08888603B4\n\tfor ;\n\tMon, 6 Jul 2020 19:33:59 +0200 (CEST)","by mail-wr1-x443.google.com with SMTP id r12so41978754wrj.13\n\tfor ;\n\tMon, 06 Jul 2020 10:33:58 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"kCzboVXZ\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=WXt4RTAuWQ6lnVvNJvhVNzaEUsG7EqQm5KDCL6yOCo8=;\n\tb=kCzboVXZu7SWowcOKCOYZFXPe/tsMeFjNCWnYZJJL+JsBL+1xNX/GQfIfksohBgoVm\n\tOM6uMAWRjVHVUMebjFj32rfHBioy5hJwI7NoYYilWcUUrhhyloQ+PnZkpB2UEhjsUaIA\n\tKRvtQY5/OTzxAFxs/i5YLzXUI1UGZ6M7rPH/l+FFzteOoWQr3/fXB/ZATJFuwC8S3I3t\n\t96itORN+HEauqUoqu7LtTDgoQmmYkb8SqKLXf8E8Zy1LMW+csq5GFk9t9QEj7PmQCgwM\n\tld27pkcqwaFBk2KYhInFSFFJMnAqnSIfBqVs7m7VjGPLtcG0nOLRVuF46lO/HOUm084u\n\t07HA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=WXt4RTAuWQ6lnVvNJvhVNzaEUsG7EqQm5KDCL6yOCo8=;\n\tb=GSahADy1s7hKaaXLuCGp9q6mGb3JxetEMZXFde0Ip09g6bKlnIBm+D/eZgTv/KyXfR\n\t3XldH9Y9PXUdSSCYKoBbLXXnC24epIfXkKDePtYxswKkhMT3tjGfveWQUitAGg6DeeVN\n\tMhUYueV7fB33L+fUgBkimB4d3ITy3JYtUl3xBpIp5WdAoOFufg4o/16OBelVm24uMd5Z\n\tYdxD+EcRY36v7zODx1JXeDzfdqC6BdsIoAK2ZXeEKstkvAGA0VtinAa1I0+aXUAIE+Xr\n\tNZn2+2+a+J18FWmOGtZwU1SqngAFEzhNILW9RH6ODTRqCa3cHDpSQ+W942c39ZcsYXqA\n\tJegg==","X-Gm-Message-State":"AOAM533yW3xfUk4Arv2Wd/jGiLdldIijP4N7x3qujwgHAUuDk8yMenHS\n\ttNxgmezjUBgbJp1XG8MmXSVkai+3QVo0dtKWZ7QIng==","X-Google-Smtp-Source":"ABdhPJylLJ2z4mwmAPP1u+23Quu4PJUk6NlodHjfgC3U2N14J/jgzmV30yP+D3YGRk6mFawYMeawhfLsH51vMgi786s=","X-Received":"by 2002:adf:fc90:: with SMTP id\n\tg16mr49469818wrr.42.1594056838494; \n\tMon, 06 Jul 2020 10:33:58 -0700 (PDT)","MIME-Version":"1.0","References":"<20200704004028.21153-1-laurent.pinchart@ideasonboard.com>","In-Reply-To":"<20200704004028.21153-1-laurent.pinchart@ideasonboard.com>","From":"Dave Stevenson ","Date":"Mon, 6 Jul 2020 18:33:41 +0100","Message-ID":"","To":"Laurent Pinchart ","Subject":"Re: [libcamera-devel] [PATCH 00/12] raspberrypi: Report sensor\n\torientation through DT","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":11234,"web_url":"https://patchwork.libcamera.org/comment/11234/","msgid":"<20200707031122.GJ19803@pendragon.ideasonboard.com>","date":"2020-07-07T16:47:56","subject":"Re: [libcamera-devel] [PATCH 00/12] raspberrypi: Report sensor\n\torientation through DT","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Dave,\n\nOn Mon, Jul 06, 2020 at 06:33:41PM +0100, Dave Stevenson wrote:\n> On Sat, 4 Jul 2020 at 01:40, Laurent Pinchart wrote:\n> >\n> > Hi Dave,\n> >\n> > This patch series reports sensor orientation through DT for the OV5647,\n> > IMX219 and IMX477. The first 8 patches are backported from mainline,\n> > while the last 4 patches are new. Patch 09/12 could possibly be skipped\n> > for now, as we don't use the rotation property in the ov5647 DT overlay.\n> >\n> > The patches are based on top of rpi-5.4.y. libcamera patches will follow\n> > shortly.\n> \n> The patches look reasonable. I'd suggest that rotation really ought to\n> be a dtoverlay property rather than hard coded. Particularly with\n> IMX219 there is no defined \"right way\" of mounting it. IMX477 with the\n> tripod screw-hole does have a natural orientation.\n\nI agree, the rotation belongs to an overlay, as it will depend on how\nthe camera module is integrated in the final product. This patch series\nmoves the default rotation from the RPi IPA to the camera sensor\noverlays to provide the same default value as currently used, but it's\nreally up to the user to decide on the correct value.\n\n> Are you expecting those to be merged into our kernel tree? We normally\n> use Github pull requests rather than mailing lists.\n\nI wanted the patches to appear on the libcamera-devel mailing list in\ncase discussions were needed, and to provide a reference to the kernel\nmodifications required by the corresponding libcamera patches I've\nposted. Should I send a pull request, or are there issues you think need\nto be addressed first ?\n\n> > Jacopo Mondi (8):\n> > media: dt-bindings: video-interfaces: Document 'orientation' property\n> > media: dt-bindings: video-interface: Replace 'rotation' description\n> > media: v4l2-ctrl: Document V4L2_CID_CAMERA_ORIENTATION\n> > media: v4l2-ctrl: Document V4L2_CID_CAMERA_SENSOR_ROTATION\n> > media: v4l2-ctrls: Add camera orientation and rotation\n> > media: v4l2-fwnode: Add helper to parse device properties\n> > media: v4l2-ctrls: Add helper to register properties\n> > media: i2c: imx219: Parse and register properties\n> >\n> > Laurent Pinchart (4):\n> > media: i2c: ov5647: Parse and register properties\n> > media: i2c: imx477: Parse and register properties\n> > dt/dtoverlays: imx219: Set sensor rotation\n> > dt/dtoverlays: imx477: Set sensor rotation\n> >\n> > .../bindings/media/video-interfaces.txt | 370 +++++++++++++++++-\n> > .../media/uapi/v4l/ext-ctrls-camera.rst | 151 +++++++\n> > arch/arm/boot/dts/overlays/imx219-overlay.dts | 2 +\n> > arch/arm/boot/dts/overlays/imx477-overlay.dts | 2 +\n> > drivers/media/i2c/imx219.c | 12 +-\n> > drivers/media/i2c/imx477.c | 12 +-\n> > drivers/media/i2c/ov5647.c | 13 +-\n> > drivers/media/v4l2-core/v4l2-ctrls.c | 53 +++\n> > drivers/media/v4l2-core/v4l2-fwnode.c | 42 ++\n> > include/media/v4l2-ctrls.h | 26 ++\n> > include/media/v4l2-fwnode.h | 47 +++\n> > include/uapi/linux/v4l2-controls.h | 7 +\n> > 12 files changed, 731 insertions(+), 6 deletions(-)","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id EDB69BD790\n\tfor ;\n\tTue, 7 Jul 2020 16:48:04 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 357AF60F7D;\n\tTue, 7 Jul 2020 18:48:04 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7AB99603AA\n\tfor ;\n\tTue, 7 Jul 2020 18:48:02 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 007159CC;\n\tTue, 7 Jul 2020 18:48:01 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"czgh/FN/\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1594140482;\n\tbh=mne2AQw/jsbcJTXpgCtTFV1gGRRpW/3w76Pn/SzITnE=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=czgh/FN/GzVrTVeDEVD3iHCFdjV7d5cIbEh+qGdhPknm6bo9fzrhZKzEyz4/10yD3\n\t8D+7tzdxKm9PB3EBwhbFCevOC6Qm8aVzqIO6zivtqlKdyRr1GFmuOYIzpQupHMGyhv\n\tHgA8C5zCgtP3xQbJva3Y7aa+q2JG29UhgLfTO+wc=","Date":"Tue, 7 Jul 2020 19:47:56 +0300","From":"Laurent Pinchart ","To":"Dave Stevenson ","Message-ID":"<20200707031122.GJ19803@pendragon.ideasonboard.com>","References":"<20200704004028.21153-1-laurent.pinchart@ideasonboard.com>\n\t","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"","Subject":"Re: [libcamera-devel] [PATCH 00/12] raspberrypi: Report sensor\n\torientation through DT","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":11237,"web_url":"https://patchwork.libcamera.org/comment/11237/","msgid":"","date":"2020-07-07T21:13:04","subject":"Re: [libcamera-devel] [PATCH 00/12] raspberrypi: Report sensor\n\torientation through DT","submitter":{"id":27,"url":"https://patchwork.libcamera.org/api/people/27/","name":"Dave Stevenson","email":"dave.stevenson@raspberrypi.com"},"content":"On Tue, 7 Jul 2020 at 17:48, Laurent Pinchart\n wrote:\n>\n> Hi Dave,\n>\n> On Mon, Jul 06, 2020 at 06:33:41PM +0100, Dave Stevenson wrote:\n> > On Sat, 4 Jul 2020 at 01:40, Laurent Pinchart wrote:\n> > >\n> > > Hi Dave,\n> > >\n> > > This patch series reports sensor orientation through DT for the OV5647,\n> > > IMX219 and IMX477. The first 8 patches are backported from mainline,\n> > > while the last 4 patches are new. Patch 09/12 could possibly be skipped\n> > > for now, as we don't use the rotation property in the ov5647 DT overlay.\n> > >\n> > > The patches are based on top of rpi-5.4.y. libcamera patches will follow\n> > > shortly.\n> >\n> > The patches look reasonable. I'd suggest that rotation really ought to\n> > be a dtoverlay property rather than hard coded. Particularly with\n> > IMX219 there is no defined \"right way\" of mounting it. IMX477 with the\n> > tripod screw-hole does have a natural orientation.\n>\n> I agree, the rotation belongs to an overlay, as it will depend on how\n> the camera module is integrated in the final product. This patch series\n> moves the default rotation from the RPi IPA to the camera sensor\n> overlays to provide the same default value as currently used, but it's\n> really up to the user to decide on the correct value.\n>\n> > Are you expecting those to be merged into our kernel tree? We normally\n> > use Github pull requests rather than mailing lists.\n>\n> I wanted the patches to appear on the libcamera-devel mailing list in\n> case discussions were needed, and to provide a reference to the kernel\n> modifications required by the corresponding libcamera patches I've\n> posted. Should I send a pull request, or are there issues you think need\n> to be addressed first ?\n\nIt'd be nice if rotation was a dt overlay parameter before creating\nthe PR, but otherwise it looks fine to me.\n\nWhere patches are backports of patches that have been merged to\nmainline, we normally add a line\n\"Commit upstream\"\nto the commit text, just to make Dom's job easier when he pulls stuff\nforward to newer kernels.\n\n Dave\n\n> > > Jacopo Mondi (8):\n> > > media: dt-bindings: video-interfaces: Document 'orientation' property\n> > > media: dt-bindings: video-interface: Replace 'rotation' description\n> > > media: v4l2-ctrl: Document V4L2_CID_CAMERA_ORIENTATION\n> > > media: v4l2-ctrl: Document V4L2_CID_CAMERA_SENSOR_ROTATION\n> > > media: v4l2-ctrls: Add camera orientation and rotation\n> > > media: v4l2-fwnode: Add helper to parse device properties\n> > > media: v4l2-ctrls: Add helper to register properties\n> > > media: i2c: imx219: Parse and register properties\n> > >\n> > > Laurent Pinchart (4):\n> > > media: i2c: ov5647: Parse and register properties\n> > > media: i2c: imx477: Parse and register properties\n> > > dt/dtoverlays: imx219: Set sensor rotation\n> > > dt/dtoverlays: imx477: Set sensor rotation\n> > >\n> > > .../bindings/media/video-interfaces.txt | 370 +++++++++++++++++-\n> > > .../media/uapi/v4l/ext-ctrls-camera.rst | 151 +++++++\n> > > arch/arm/boot/dts/overlays/imx219-overlay.dts | 2 +\n> > > arch/arm/boot/dts/overlays/imx477-overlay.dts | 2 +\n> > > drivers/media/i2c/imx219.c | 12 +-\n> > > drivers/media/i2c/imx477.c | 12 +-\n> > > drivers/media/i2c/ov5647.c | 13 +-\n> > > drivers/media/v4l2-core/v4l2-ctrls.c | 53 +++\n> > > drivers/media/v4l2-core/v4l2-fwnode.c | 42 ++\n> > > include/media/v4l2-ctrls.h | 26 ++\n> > > include/media/v4l2-fwnode.h | 47 +++\n> > > include/uapi/linux/v4l2-controls.h | 7 +\n> > > 12 files changed, 731 insertions(+), 6 deletions(-)\n>\n> --\n> Regards,\n>\n> Laurent Pinchart","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6BF70BD792\n\tfor ;\n\tTue, 7 Jul 2020 21:13:23 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E45CD61028;\n\tTue, 7 Jul 2020 23:13:22 +0200 (CEST)","from mail-wr1-x443.google.com (mail-wr1-x443.google.com\n\t[IPv6:2a00:1450:4864:20::443])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DF6CE60DFA\n\tfor ;\n\tTue, 7 Jul 2020 23:13:21 +0200 (CEST)","by mail-wr1-x443.google.com with SMTP id k6so46781629wrn.3\n\tfor ;\n\tTue, 07 Jul 2020 14:13:21 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"AGT4sWUN\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=hNfN1VTu2BIirzov60CBTAte3D45HBToOxC1dZJjBp8=;\n\tb=AGT4sWUNEnhIlwSSdjT9vqCUUPqz4c/ktxu5iGydxyKyHgGboLP6+WswwT47e0SXaT\n\t85wa0kBHMFUWd6ZChBSH/yb/mx8kuYq3ee0dK8tMiND/GKcAZ12xwiMl1LYx9vGZzphf\n\t302h13U4IGURf/yHBDxaw1DI9LurtRka3w+mvxQ2Z5ZY1i8ZVgWOcRUapQ0aHyPXRCR3\n\tXdUcW0hCUeZa+KcDoGFSGbJS8WFFQIQTuiCRTN4rZLvNW3vboi9Sz4jVKevKvXwvnrgP\n\tiu98KRkuAETCeZU+uxD7VokLt/ZQoCX4mrJ+GSV9X4Yh+OcaRTbRcRkr2zAUb1ptQwN2\n\tq6uw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=hNfN1VTu2BIirzov60CBTAte3D45HBToOxC1dZJjBp8=;\n\tb=uWuT2ICxReyt5vjmwm7Lj3hAOmV95+h0I4W3LC0JjU6Gjqe8mPt2kAo+mvAN0QzDRj\n\tV8nHM6ZzmX+BDhrWNXfZ46nUmWf5hx7ByTiEDjL4fTn9Wxkl+f5r15HlnThfL7gSKGNd\n\titvzdhRRzg/Kif7A/znXgI5IGDeSNc1TQ6VSVbgXuUXuxCBzJbTSjbv9wKMPrrsVGseB\n\tvqHEtqfPpnVNjm/eVCSML1r4Ekh+WoNV3n6LYEJ32oouPdQ0pCnNVrT53sYV52Mg8y4/\n\t4tuCvVkZsGDNaIooNkMFj01pfevMf104YQq8PjTpLmXSmO2s9KcyrPi0dWfu3zKDw93V\n\tg07Q==","X-Gm-Message-State":"AOAM532StksG5R8t/8Y8qF3wxEVBywCvt25Z6VFi6etFe1033HUQbMeO\n\twAPQH1F7Nbt9NsSfVU6Gd1r+CwaGDymx2EsB30NdUMKU","X-Google-Smtp-Source":"ABdhPJzgBpbaUKJ+i+OiPLYmBDXuWZMU62Ys3H2NlDAyyiAFakxXmFE/3KMjSYf8R9/WaA/WdyjGysikEDlF32WRPKo=","X-Received":"by 2002:adf:fc90:: with SMTP id\n\tg16mr54965680wrr.42.1594156401304; \n\tTue, 07 Jul 2020 14:13:21 -0700 (PDT)","MIME-Version":"1.0","References":"<20200704004028.21153-1-laurent.pinchart@ideasonboard.com>\n\t\n\t<20200707031122.GJ19803@pendragon.ideasonboard.com>","In-Reply-To":"<20200707031122.GJ19803@pendragon.ideasonboard.com>","From":"Dave Stevenson ","Date":"Tue, 7 Jul 2020 22:13:04 +0100","Message-ID":"","To":"Laurent Pinchart ","Subject":"Re: [libcamera-devel] [PATCH 00/12] raspberrypi: Report sensor\n\torientation through DT","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":11238,"web_url":"https://patchwork.libcamera.org/comment/11238/","msgid":"<20200707214021.GQ19803@pendragon.ideasonboard.com>","date":"2020-07-07T21:40:21","subject":"Re: [libcamera-devel] [PATCH 00/12] raspberrypi: Report sensor\n\torientation through DT","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Dave,\n\nOn Tue, Jul 07, 2020 at 10:13:04PM +0100, Dave Stevenson wrote:\n> On Tue, 7 Jul 2020 at 17:48, Laurent Pinchart wrote:\n> > On Mon, Jul 06, 2020 at 06:33:41PM +0100, Dave Stevenson wrote:\n> > > On Sat, 4 Jul 2020 at 01:40, Laurent Pinchart wrote:\n> > > >\n> > > > Hi Dave,\n> > > >\n> > > > This patch series reports sensor orientation through DT for the OV5647,\n> > > > IMX219 and IMX477. The first 8 patches are backported from mainline,\n> > > > while the last 4 patches are new. Patch 09/12 could possibly be skipped\n> > > > for now, as we don't use the rotation property in the ov5647 DT overlay.\n> > > >\n> > > > The patches are based on top of rpi-5.4.y. libcamera patches will follow\n> > > > shortly.\n> > >\n> > > The patches look reasonable. I'd suggest that rotation really ought to\n> > > be a dtoverlay property rather than hard coded. Particularly with\n> > > IMX219 there is no defined \"right way\" of mounting it. IMX477 with the\n> > > tripod screw-hole does have a natural orientation.\n> >\n> > I agree, the rotation belongs to an overlay, as it will depend on how\n> > the camera module is integrated in the final product. This patch series\n> > moves the default rotation from the RPi IPA to the camera sensor\n> > overlays to provide the same default value as currently used, but it's\n> > really up to the user to decide on the correct value.\n> >\n> > > Are you expecting those to be merged into our kernel tree? We normally\n> > > use Github pull requests rather than mailing lists.\n> >\n> > I wanted the patches to appear on the libcamera-devel mailing list in\n> > case discussions were needed, and to provide a reference to the kernel\n> > modifications required by the corresponding libcamera patches I've\n> > posted. Should I send a pull request, or are there issues you think need\n> > to be addressed first ?\n> \n> It'd be nice if rotation was a dt overlay parameter before creating\n> the PR, but otherwise it looks fine to me.\n\nI wasn't aware of the DT parameters mechanism. I'll adapt the patches\naccordingly, and will also reference upstream commit for backported\npatches.\n\n> Where patches are backports of patches that have been merged to\n> mainline, we normally add a line\n> \"Commit upstream\"\n> to the commit text, just to make Dom's job easier when he pulls stuff\n> forward to newer kernels.\n> \n> > > > Jacopo Mondi (8):\n> > > > media: dt-bindings: video-interfaces: Document 'orientation' property\n> > > > media: dt-bindings: video-interface: Replace 'rotation' description\n> > > > media: v4l2-ctrl: Document V4L2_CID_CAMERA_ORIENTATION\n> > > > media: v4l2-ctrl: Document V4L2_CID_CAMERA_SENSOR_ROTATION\n> > > > media: v4l2-ctrls: Add camera orientation and rotation\n> > > > media: v4l2-fwnode: Add helper to parse device properties\n> > > > media: v4l2-ctrls: Add helper to register properties\n> > > > media: i2c: imx219: Parse and register properties\n> > > >\n> > > > Laurent Pinchart (4):\n> > > > media: i2c: ov5647: Parse and register properties\n> > > > media: i2c: imx477: Parse and register properties\n> > > > dt/dtoverlays: imx219: Set sensor rotation\n> > > > dt/dtoverlays: imx477: Set sensor rotation\n> > > >\n> > > > .../bindings/media/video-interfaces.txt | 370 +++++++++++++++++-\n> > > > .../media/uapi/v4l/ext-ctrls-camera.rst | 151 +++++++\n> > > > arch/arm/boot/dts/overlays/imx219-overlay.dts | 2 +\n> > > > arch/arm/boot/dts/overlays/imx477-overlay.dts | 2 +\n> > > > drivers/media/i2c/imx219.c | 12 +-\n> > > > drivers/media/i2c/imx477.c | 12 +-\n> > > > drivers/media/i2c/ov5647.c | 13 +-\n> > > > drivers/media/v4l2-core/v4l2-ctrls.c | 53 +++\n> > > > drivers/media/v4l2-core/v4l2-fwnode.c | 42 ++\n> > > > include/media/v4l2-ctrls.h | 26 ++\n> > > > include/media/v4l2-fwnode.h | 47 +++\n> > > > include/uapi/linux/v4l2-controls.h | 7 +\n> > > > 12 files changed, 731 insertions(+), 6 deletions(-)","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 97D66BD790\n\tfor ;\n\tTue, 7 Jul 2020 21:40:28 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2265661028;\n\tTue, 7 Jul 2020 23:40:28 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5FF8860DFA\n\tfor ;\n\tTue, 7 Jul 2020 23:40:27 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id BB58A293;\n\tTue, 7 Jul 2020 23:40:26 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"uy50kt9I\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1594158026;\n\tbh=kxpS+x9sPMzdW4kR9j2HeBTPZd0iz5z517R96PNxIjU=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=uy50kt9Inp+yPMP7EMLqsUN/wAuESSI6fsQIgSqG2H4NpEJnZiscIPh9Og48wQbpC\n\tpL0oJJiQM0dQPIigUA30rcdw9CuQ/QM+NR3y5YCNyXov2J/XKFtc/plV4pMQEHLtLK\n\tZKwuLuS1L0+fYaBTW1lBhO9EZejP7av8oB1B+IFs=","Date":"Wed, 8 Jul 2020 00:40:21 +0300","From":"Laurent Pinchart ","To":"Dave Stevenson ","Message-ID":"<20200707214021.GQ19803@pendragon.ideasonboard.com>","References":"<20200704004028.21153-1-laurent.pinchart@ideasonboard.com>\n\t\n\t<20200707031122.GJ19803@pendragon.ideasonboard.com>\n\t","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"","Subject":"Re: [libcamera-devel] [PATCH 00/12] raspberrypi: Report sensor\n\torientation through DT","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":11241,"web_url":"https://patchwork.libcamera.org/comment/11241/","msgid":"","date":"2020-07-08T10:32:47","subject":"Re: [libcamera-devel] [PATCH 00/12] raspberrypi: Report sensor\n\torientation through DT","submitter":{"id":27,"url":"https://patchwork.libcamera.org/api/people/27/","name":"Dave Stevenson","email":"dave.stevenson@raspberrypi.com"},"content":"On Tue, 7 Jul 2020 at 22:40, Laurent Pinchart\n wrote:\n>\n> Hi Dave,\n>\n> On Tue, Jul 07, 2020 at 10:13:04PM +0100, Dave Stevenson wrote:\n> > On Tue, 7 Jul 2020 at 17:48, Laurent Pinchart wrote:\n> > > On Mon, Jul 06, 2020 at 06:33:41PM +0100, Dave Stevenson wrote:\n> > > > On Sat, 4 Jul 2020 at 01:40, Laurent Pinchart wrote:\n> > > > >\n> > > > > Hi Dave,\n> > > > >\n> > > > > This patch series reports sensor orientation through DT for the OV5647,\n> > > > > IMX219 and IMX477. The first 8 patches are backported from mainline,\n> > > > > while the last 4 patches are new. Patch 09/12 could possibly be skipped\n> > > > > for now, as we don't use the rotation property in the ov5647 DT overlay.\n> > > > >\n> > > > > The patches are based on top of rpi-5.4.y. libcamera patches will follow\n> > > > > shortly.\n> > > >\n> > > > The patches look reasonable. I'd suggest that rotation really ought to\n> > > > be a dtoverlay property rather than hard coded. Particularly with\n> > > > IMX219 there is no defined \"right way\" of mounting it. IMX477 with the\n> > > > tripod screw-hole does have a natural orientation.\n> > >\n> > > I agree, the rotation belongs to an overlay, as it will depend on how\n> > > the camera module is integrated in the final product. This patch series\n> > > moves the default rotation from the RPi IPA to the camera sensor\n> > > overlays to provide the same default value as currently used, but it's\n> > > really up to the user to decide on the correct value.\n> > >\n> > > > Are you expecting those to be merged into our kernel tree? We normally\n> > > > use Github pull requests rather than mailing lists.\n> > >\n> > > I wanted the patches to appear on the libcamera-devel mailing list in\n> > > case discussions were needed, and to provide a reference to the kernel\n> > > modifications required by the corresponding libcamera patches I've\n> > > posted. Should I send a pull request, or are there issues you think need\n> > > to be addressed first ?\n> >\n> > It'd be nice if rotation was a dt overlay parameter before creating\n> > the PR, but otherwise it looks fine to me.\n>\n> I wasn't aware of the DT parameters mechanism. I'll adapt the patches\n> accordingly, and will also reference upstream commit for backported\n> patches.\n\nThanks. If you're stuck then create the PR and I'll either add any\nadditional changes, or make comment as to what is needed.\n\nPhil will be wanting an update to\nhttps://github.com/raspberrypi/linux/blob/rpi-5.4.y/arch/arm/boot/dts/overlays/README\nas well so that the help text reflects any parameters.\n\n> > Where patches are backports of patches that have been merged to\n> > mainline, we normally add a line\n> > \"Commit upstream\"\n> > to the commit text, just to make Dom's job easier when he pulls stuff\n> > forward to newer kernels.\n> >\n> > > > > Jacopo Mondi (8):\n> > > > > media: dt-bindings: video-interfaces: Document 'orientation' property\n> > > > > media: dt-bindings: video-interface: Replace 'rotation' description\n> > > > > media: v4l2-ctrl: Document V4L2_CID_CAMERA_ORIENTATION\n> > > > > media: v4l2-ctrl: Document V4L2_CID_CAMERA_SENSOR_ROTATION\n> > > > > media: v4l2-ctrls: Add camera orientation and rotation\n> > > > > media: v4l2-fwnode: Add helper to parse device properties\n> > > > > media: v4l2-ctrls: Add helper to register properties\n> > > > > media: i2c: imx219: Parse and register properties\n> > > > >\n> > > > > Laurent Pinchart (4):\n> > > > > media: i2c: ov5647: Parse and register properties\n> > > > > media: i2c: imx477: Parse and register properties\n> > > > > dt/dtoverlays: imx219: Set sensor rotation\n> > > > > dt/dtoverlays: imx477: Set sensor rotation\n> > > > >\n> > > > > .../bindings/media/video-interfaces.txt | 370 +++++++++++++++++-\n> > > > > .../media/uapi/v4l/ext-ctrls-camera.rst | 151 +++++++\n> > > > > arch/arm/boot/dts/overlays/imx219-overlay.dts | 2 +\n> > > > > arch/arm/boot/dts/overlays/imx477-overlay.dts | 2 +\n> > > > > drivers/media/i2c/imx219.c | 12 +-\n> > > > > drivers/media/i2c/imx477.c | 12 +-\n> > > > > drivers/media/i2c/ov5647.c | 13 +-\n> > > > > drivers/media/v4l2-core/v4l2-ctrls.c | 53 +++\n> > > > > drivers/media/v4l2-core/v4l2-fwnode.c | 42 ++\n> > > > > include/media/v4l2-ctrls.h | 26 ++\n> > > > > include/media/v4l2-fwnode.h | 47 +++\n> > > > > include/uapi/linux/v4l2-controls.h | 7 +\n> > > > > 12 files changed, 731 insertions(+), 6 deletions(-)\n>\n> --\n> Regards,\n>\n> Laurent Pinchart","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 30C22BD790\n\tfor ;\n\tWed, 8 Jul 2020 10:33:08 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 831AB610F4;\n\tWed, 8 Jul 2020 12:33:07 +0200 (CEST)","from mail-wm1-x343.google.com (mail-wm1-x343.google.com\n\t[IPv6:2a00:1450:4864:20::343])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E69F160E05\n\tfor ;\n\tWed, 8 Jul 2020 12:33:05 +0200 (CEST)","by mail-wm1-x343.google.com with SMTP id w3so2366750wmi.4\n\tfor ;\n\tWed, 08 Jul 2020 03:33:05 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"a9BA4AdE\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=Rj4rHl24NWxzsR7kxZGS7nvX4ZQt8R2LOzehO96R2gM=;\n\tb=a9BA4AdEbcpz7CjQw0V5h0Y7XeOB7zAgXABQs39Gplo7hU1LDrQ5vAAKb+lpZcoQpH\n\tO913a59gu8R+8MBaVvFJLSaEdLCyFB5QEyj2nqxaQKvb+vJ8eGZreziMNl69SLnY2Prb\n\t7R9OcTqv1i2oTdUco4JQlTLh/BMdpEVVIBAg4zfeZFzmOW7jS9TLMa1vIFy3Jp3eAu6N\n\tObKlOEQcKtYg+vkym6RU2H27Ds9srU7FRdIKIGNMiBplYXAqPPz02vPydUzwHTUUpQXE\n\t9sDQERF3LK8Jaei5YZTqzKmwq+bYpjLxAJl7eWlCi5c5WLM+MYlT6XPK/1mYYDxnvtMG\n\tC+Fg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=Rj4rHl24NWxzsR7kxZGS7nvX4ZQt8R2LOzehO96R2gM=;\n\tb=Qt9rId2M+qiNZnqyGnED++7u4SQR7uDvNUcq1f0b0wnP4gpjvEV7lWRO2QGA0ZGX01\n\tPxIshbox88/vXOc0j/+pXUcumwRBAqDt1OzWiHvVPjHVsBMWDNz1+0O4tRLXbWyedhMb\n\tPWxdd9cm9SparykSgGlxG5KyxPQENWryCpfJfrs8g7BCnzb14O+UPWvjjKjIAeaas/uu\n\tTU+s2y3XzLsFrZ883gqTdtksPVfPQwUitjwGKIRuxkfns8WGnddKyWr5+B5Y/g7alJOI\n\t17of/bezNOCvnaV6ySwv8e91G6rsj7VoUF9zvJY55mqT1vQ0NVC/MKN0ApzPbdP4sHvM\n\ttAbg==","X-Gm-Message-State":"AOAM5324Tqea1fdSKsLNKj+pCUXpkiXyDmLQAZrPYlSldSBtfdqbEh1J\n\tuCoFPZiiBGQWssFe6K3o330cO9F5/6fsB/GsNCc5jdwHSm0=","X-Google-Smtp-Source":"ABdhPJx2abgD49DddebNRAewUQD8qlyyylLaYGdflTmi/aY3r2qdJmkjSshN1GQGiEiO0wtDiWtyuZOWAFTM3emNqAk=","X-Received":"by 2002:a05:600c:d7:: with SMTP id\n\tu23mr8208734wmm.183.1594204385468; \n\tWed, 08 Jul 2020 03:33:05 -0700 (PDT)","MIME-Version":"1.0","References":"<20200704004028.21153-1-laurent.pinchart@ideasonboard.com>\n\t\n\t<20200707031122.GJ19803@pendragon.ideasonboard.com>\n\t\n\t<20200707214021.GQ19803@pendragon.ideasonboard.com>","In-Reply-To":"<20200707214021.GQ19803@pendragon.ideasonboard.com>","From":"Dave Stevenson ","Date":"Wed, 8 Jul 2020 11:32:47 +0100","Message-ID":"","To":"Laurent Pinchart ","Subject":"Re: [libcamera-devel] [PATCH 00/12] raspberrypi: Report sensor\n\torientation through DT","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]