[{"id":11117,"web_url":"https://patchwork.libcamera.org/comment/11117/","msgid":"<20200703084341.botc45jy5asgaxck@uno.localdomain>","date":"2020-07-03T08:43:41","subject":"Re: [libcamera-devel] [PATCH v3 0/2] libcamera: utils: Add\n\tmap_keys() function","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Niklas\n\nOn Fri, Jul 03, 2020 at 01:11:05AM +0200, Niklas Söderlund wrote:\n> Hi,\n>\n> This is mostly Laurent's work that I fished out of the ML so I could\n> send out the last IPU3 patches I have locally which makes of Laurent's\n> work.\n>\n> I have modified 1/2 so that the utils::map_keys() helper returns a\n> std::vector instead of a std::set after some discussions on v1 and on\n> IRC.\n\nReviewed-by: Jacopo Mondi \n\nfor both patches, but I think this should aim to remove the custom\nV4L2PixelFormat maps from pipeline handlers too, doesn't it ?\n\nThanks\n j\n\n>\n> Laurent Pinchart (1):\n> libcamera: utils: Add map_keys() function\n>\n> Niklas Söderlund (1):\n> libcamera: ipu3: cio2: Make use of utils::map_keys() helper\n>\n> include/libcamera/internal/utils.h | 10 ++++++++++\n> src/libcamera/pipeline/ipu3/cio2.cpp | 19 +++----------------\n> src/libcamera/utils.cpp | 7 +++++++\n> test/utils.cpp | 22 ++++++++++++++++++++++\n> 4 files changed, 42 insertions(+), 16 deletions(-)\n>\n> --\n> 2.27.0\n>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7AC8ABFFE2\n\tfor ;\n\tFri, 3 Jul 2020 08:40:12 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1E80A60C50;\n\tFri, 3 Jul 2020 10:40:12 +0200 (CEST)","from relay6-d.mail.gandi.net (relay6-d.mail.gandi.net\n\t[217.70.183.198])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E66ED603AD\n\tfor ;\n\tFri, 3 Jul 2020 10:40:09 +0200 (CEST)","from uno.localdomain (93-34-118-233.ip49.fastwebnet.it\n\t[93.34.118.233]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay6-d.mail.gandi.net (Postfix) with ESMTPSA id 49117C0006;\n\tFri, 3 Jul 2020 08:40:08 +0000 (UTC)"],"X-Originating-IP":"93.34.118.233","Date":"Fri, 3 Jul 2020 10:43:41 +0200","From":"Jacopo Mondi ","To":"Niklas =?utf-8?q?S=C3=B6derlund?= ","Message-ID":"<20200703084341.botc45jy5asgaxck@uno.localdomain>","References":"<20200702231107.1800602-1-niklas.soderlund@ragnatech.se>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200702231107.1800602-1-niklas.soderlund@ragnatech.se>","Subject":"Re: [libcamera-devel] [PATCH v3 0/2] libcamera: utils: Add\n\tmap_keys() function","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]