{"id":8436,"url":"https://patchwork.libcamera.org/api/covers/8436/?format=json","web_url":"https://patchwork.libcamera.org/cover/8436/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200626102531.1187650-1-naush@raspberrypi.com>","date":"2020-06-26T10:25:27","name":"[libcamera-devel,0/4] Focus feedback control","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/?format=json","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"mbox":"https://patchwork.libcamera.org/cover/8436/mbox/","series":[{"id":1044,"url":"https://patchwork.libcamera.org/api/series/1044/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1044","date":"2020-06-26T10:25:27","name":"Focus feedback control","version":1,"mbox":"https://patchwork.libcamera.org/series/1044/mbox/"}],"comments":"https://patchwork.libcamera.org/api/covers/8436/comments/","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id ECD2FC0109\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 26 Jun 2020 10:25:49 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 78288609C6;\n\tFri, 26 Jun 2020 12:25:49 +0200 (CEST)","from mail-wm1-x32d.google.com (mail-wm1-x32d.google.com\n\t[IPv6:2a00:1450:4864:20::32d])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 865FC609A3\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 26 Jun 2020 12:25:48 +0200 (CEST)","by mail-wm1-x32d.google.com with SMTP id l17so8357654wmj.0\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 26 Jun 2020 03:25:48 -0700 (PDT)","from naushir-VirtualBox.patuck.local ([88.97.76.4])\n\tby smtp.gmail.com with ESMTPSA id\n\tr8sm21959679wrp.40.2020.06.26.03.25.46\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 26 Jun 2020 03:25:47 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"CEWTGL/C\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=G5CYLtzO4jUHmgTRrc1m13ONQ/BCSddDmFE3psNWyYg=;\n\tb=CEWTGL/Ca2fFYqz7r3nsWTxcHbOCihijkOwwLdvTHENHADCuhP7U4GwfyHb3LTZmdS\n\tryfLsRD3OD7/t0HXjtoFFyYanvewlgUeAFq2DBNIHtEck5ORi1Sk7GSfEWirYohzZNUT\n\tbj7szhM4ytHy4LAbcyBzk4pc2UF79DqJjuTCQvdCKhFFdnUoIHe6TMvo7VaZ0inIeyn9\n\tCsPmTXL0QkgwxBjQc7CJ+oJ9mhyhR8xZkjP9h4R0bTIhq0UsPd6rH4iKNyBot0nXCJQg\n\tqU+7vTN47gt5rF87zgd/aUWS2vlRO0tR8qkXEb1D9hMoQr5lxeHgiuMBswxkyYXsYFXT\n\trGsw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=G5CYLtzO4jUHmgTRrc1m13ONQ/BCSddDmFE3psNWyYg=;\n\tb=jocu0OrMttcJA7TJGWhzY7gY+2GYZzXDp9YsA5p4VwJpgsGKfMlqWSgwVjKOuQ8jCQ\n\tqMBSoYaNFlT8M2EVcfWfftD88p9yYphrwguIbGUtGKso0OyvmBT4OZvqgpEc4ZFY3cJu\n\t3k3B9SZneagvIdP/8L6yQMHGo5OWGMKoMUgHc4A5Y+apnjSx3ldskSXf7MTewwOKYj9P\n\tZeM5XcLbVoCdeXiVSGZj2/rk8boxo65myORMEM1iCufUCYQN1w9kIuEEGQW3lNeUPhAv\n\tvF31FxZr2VN53zq2TPY5vqTTHYEMqIF6H0zOQ0FC1ccB82oGarwqnQATesRNuGI5Ontw\n\tJa0w==","X-Gm-Message-State":"AOAM5324smFtnonOsmGkkFH6rYgHxZCtKzAXfzw0LI3/2Vr07eAOfVmr\n\t51l+9X9FvH+JhZL96Is1W6SBx3Hhgyk=","X-Google-Smtp-Source":"ABdhPJz5Bo+nOdbRdFZBzJvrBm4YByFyqP4Xr76fjW+gg5yW3HUJalTpzUN9Bs3kfq+yX+c9Oq2Euw==","X-Received":"by 2002:a7b:c441:: with SMTP id l1mr2517252wmi.7.1593167147912; \n\tFri, 26 Jun 2020 03:25:47 -0700 (PDT)","From":"Naushir Patuck <naush@raspberrypi.com>","To":"libcamera-devel@lists.libcamera.org","Date":"Fri, 26 Jun 2020 11:25:27 +0100","Message-Id":"<20200626102531.1187650-1-naush@raspberrypi.com>","X-Mailer":"git-send-email 2.25.1","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH 0/4] Focus feedback control","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"},"content":"Hi all,\n\nA number of our users use a focus metric for manually focussing the HQ camera\nlenses.  This metric is derived from the ISP statistics block.\n\nThis set of changes adds a Figure of Merit (FoM) libcamera control that can be\nused for such situations.  As a note, this is a singular value that\ngives a numeric score for how in-focus an image is, not a means to run an AF\nalgorithm.  It is up to the IPA to calculate this score however it sees fit.\nThe Raspberry Pi averages the middle two regions in a 4x3 grid to start with.\nWe may change this later when we have adjustable regions.\n\nAs always, comments welcome.\n\nRegards,\nNaush\n\n\nNaushir Patuck (4):\n  libcamera: controls: Add focus Figure of Merit (FoM) control\n  libcamera: ipa: raspberrypi: focus: Fix for uninitialised variable\n  libcamera: ipa: raspberrypi: Populate libcamera metadata after\n    controller process\n  libcamera: ipa: raspberrypi: Populate focus FoM from the ISP\n    statistics\n\n src/ipa/raspberrypi/controller/focus_status.h |  2 +-\n src/ipa/raspberrypi/controller/rpi/focus.cpp  |  2 +-\n src/ipa/raspberrypi/raspberrypi.cpp           | 15 ++++++++++++++-\n src/libcamera/control_ids.yaml                | 11 +++++++++++\n 4 files changed, 27 insertions(+), 3 deletions(-)"}