[{"id":1146,"web_url":"https://patchwork.libcamera.org/comment/1146/","msgid":"<20190327080744.xyigwnejduws5htn@uno.localdomain>","date":"2019-03-27T08:07:44","subject":"Re: [libcamera-devel] [PATCH v2 0/3] cam: options: Add support for\n\trepeatable options","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Niklas,\n\nOn Wed, Mar 27, 2019 at 01:21:04AM +0100, Niklas Söderlund wrote:\n> Hi,\n>\n> This series extends the option parser for the cam tool to support\n> repeatable options. This will be needed to extend the tool to support\n> multiple streams.\n>\n> This was posted earlier as a RFC that included a fourth patch to make\n> use of the new interface in the cam utility. That patch was incomplete\n> and did not fully add multiple stream support to the cam tool and is\n> therefor dropped in this non-RFC series which is intended to be merged\n>\n> All patches have review tags but as there was some debate in v1 I post\n> v2 and let it stew for a day or two before pushing it in case someone\n> have additional comment.\n>\n\nDon't hold this series for my comments on v1 as it seems they are not\naddressable.\n\nThanks\n j\n\n> Niklas Söderlund (3):\n> cam: options: Create separate enum for OptionValue types\n> cam: options: Add an array data type to OptionValue\n> cam: options: Add support for repeatable options\n>\n> src/cam/options.cpp | 59 ++++++++++++++++++++++++++++++++++-----------\n> src/cam/options.h | 23 +++++++++++++++---\n> 2 files changed, 64 insertions(+), 18 deletions(-)\n>\n> --\n> 2.21.0\n>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from relay6-d.mail.gandi.net (relay6-d.mail.gandi.net\n\t[217.70.183.198])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C1D86610B3\n\tfor ;\n\tWed, 27 Mar 2019 09:07:02 +0100 (CET)","from uno.localdomain (2-224-242-101.ip172.fastwebnet.it\n\t[2.224.242.101]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay6-d.mail.gandi.net (Postfix) with ESMTPSA id 32756C0004;\n\tWed, 27 Mar 2019 08:07:01 +0000 (UTC)"],"X-Originating-IP":"2.224.242.101","Date":"Wed, 27 Mar 2019 09:07:44 +0100","From":"Jacopo Mondi ","To":"Niklas =?utf-8?q?S=C3=B6derlund?= ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190327080744.xyigwnejduws5htn@uno.localdomain>","References":"<20190327002107.24487-1-niklas.soderlund@ragnatech.se>","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\"; boundary=\"2el6mbtixujdmqqm\"","Content-Disposition":"inline","In-Reply-To":"<20190327002107.24487-1-niklas.soderlund@ragnatech.se>","User-Agent":"NeoMutt/20180716","Subject":"Re: [libcamera-devel] [PATCH v2 0/3] cam: options: Add support for\n\trepeatable options","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Wed, 27 Mar 2019 08:07:03 -0000"}},{"id":1149,"web_url":"https://patchwork.libcamera.org/comment/1149/","msgid":"<20190327140833.GE23466@bigcity.dyn.berto.se>","date":"2019-03-27T14:08:33","subject":"Re: [libcamera-devel] [PATCH v2 0/3] cam: options: Add support for\n\trepeatable options","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi,\n\nOn 2019-03-27 09:07:44 +0100, Jacopo Mondi wrote:\n> Hi Niklas,\n> \n> On Wed, Mar 27, 2019 at 01:21:04AM +0100, Niklas Söderlund wrote:\n> > Hi,\n> >\n> > This series extends the option parser for the cam tool to support\n> > repeatable options. This will be needed to extend the tool to support\n> > multiple streams.\n> >\n> > This was posted earlier as a RFC that included a fourth patch to make\n> > use of the new interface in the cam utility. That patch was incomplete\n> > and did not fully add multiple stream support to the cam tool and is\n> > therefor dropped in this non-RFC series which is intended to be merged\n> >\n> > All patches have review tags but as there was some debate in v1 I post\n> > v2 and let it stew for a day or two before pushing it in case someone\n> > have additional comment.\n> >\n> \n> Don't hold this series for my comments on v1 as it seems they are not\n> addressable.\n\nThanks, I have now pushed this series to master.\n\n> \n> Thanks\n> j\n> \n> > Niklas Söderlund (3):\n> > cam: options: Create separate enum for OptionValue types\n> > cam: options: Add an array data type to OptionValue\n> > cam: options: Add support for repeatable options\n> >\n> > src/cam/options.cpp | 59 ++++++++++++++++++++++++++++++++++-----------\n> > src/cam/options.h | 23 +++++++++++++++---\n> > 2 files changed, 64 insertions(+), 18 deletions(-)\n> >\n> > --\n> > 2.21.0\n> >\n> > _______________________________________________\n> > libcamera-devel mailing list\n> > libcamera-devel@lists.libcamera.org\n> > https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from mail-lj1-f196.google.com (mail-lj1-f196.google.com\n\t[209.85.208.196])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C0D8C610BF\n\tfor ;\n\tWed, 27 Mar 2019 15:09:36 +0100 (CET)","by mail-lj1-f196.google.com with SMTP id k8so14506337lja.8\n\tfor ;\n\tWed, 27 Mar 2019 07:09:36 -0700 (PDT)","from localhost (89-233-230-99.cust.bredband2.com. [89.233.230.99])\n\tby smtp.gmail.com with ESMTPSA id\n\tv11sm4750092ljd.3.2019.03.27.07.08.33\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tWed, 27 Mar 2019 07:08:33 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to\n\t:user-agent; bh=bWApcqLxB5z3C+gCTWYziRxoxgqrOLPUD+RIRRnwtMI=;\n\tb=1uB4L52oxpO+ts8JS+yuKmG5a4UEaj1nM9aIyg8KqIRQC2kfUhYvoaCkJuLk1i+dEf\n\t7M2PeTF7+2V78ybBtvZqu/k9scCgJULHXyKsmSaUdWJssR1y6zajzDEFUEb3Esh6ljxJ\n\tPIyAa3w52jYn1ZsERm+qDt+E8DZetxr8cwalaAHx1jvaGS2Ep1LknN7eupDI6DTV+rE2\n\tCcW6NDegyxQUwP4KM5B6a8jgGZgIiwWT74/zTNugtmlWu1yCPgzNDY3iZrLxWVSCIh1x\n\tvGZJuOP2CEsTlTpi+yQJoKlGMRqqtoG1v+RyAQ/aE0NxkfBdP3DQVZz+h98JJrqQMyzB\n\t6W5A==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to:user-agent;\n\tbh=bWApcqLxB5z3C+gCTWYziRxoxgqrOLPUD+RIRRnwtMI=;\n\tb=tWFMpq+5Ylbry4WGUl7EU5lI6wr8e9ffTKfGbLXMvxEQGsCmhzjhbUJ2JC5eSDpv2s\n\tuo44Bzvof9x7trmTbMh1AUof1T9C19jT5NhZ8rn6/2qSA0ERYyu8Cx8GLRsiaZeAytC6\n\tdx+Iy8OWzddyj4GtCWL23//0wcOTNbe+2hBLrH/MfHYwG5w9y8Stm3FdNz3nEqRw4Zhr\n\t1HZbNYdh4vqM6XEGzDJ+ueTm5dtJZKBkZPJiBfw9CyKHcw4ZMnxidn7J+xJeTWIiQxfF\n\tEotNwXJ8aKy4eEDoqdLhgFTIBBfHWV/d0miEiIJHH9qREz8NuR3kGYSw9JmKHSPCvBGR\n\tlyvw==","X-Gm-Message-State":"APjAAAUYL/PWQnPjjSPVlu3pgg39Q0Vsr/sF/AJ9uOlPViGv7tMycP1X\n\tg9FJXBvrtuQQLoDR+d6yzjgsjVwi3a0=","X-Google-Smtp-Source":"APXvYqwftaSMGOr404ylzUYScJA4HyFCs5xQtzvu5uWLQT7O3RTGub6dBKJ4oXqQSUQ/aSM4acTqfA==","X-Received":"by 2002:a2e:810d:: with SMTP id\n\td13mr10647264ljg.93.1553695714589; \n\tWed, 27 Mar 2019 07:08:34 -0700 (PDT)","Date":"Wed, 27 Mar 2019 15:08:33 +0100","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Jacopo Mondi ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190327140833.GE23466@bigcity.dyn.berto.se>","References":"<20190327002107.24487-1-niklas.soderlund@ragnatech.se>\n\t<20190327080744.xyigwnejduws5htn@uno.localdomain>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20190327080744.xyigwnejduws5htn@uno.localdomain>","User-Agent":"Mutt/1.11.3 (2019-02-01)","Subject":"Re: [libcamera-devel] [PATCH v2 0/3] cam: options: Add support for\n\trepeatable options","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Wed, 27 Mar 2019 14:09:37 -0000"}}]