[{"id":1049,"web_url":"https://patchwork.libcamera.org/comment/1049/","msgid":"","date":"2019-03-13T09:32:55","subject":"Re: [libcamera-devel] [PATCH v3 0/4] test: camera: Add basic tests\n\tfor the camera","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Niklas,\n\nOn 13/03/2019 01:05, Niklas Söderlund wrote:\n> Hi,\n> \n> This series add basic tests for the camera implementation. The tests\n> involve reading and setting configurations, access control of the state\n> machine and capturing.\n> \n> All tests uses the vimc pipeline to allow the tests to run on as many\n> platforms as possible. Down the line this might be expanded to run an\n> all cameras detected by libcamera.\n> \n> All patches in the series are reviewed but I feel that posting it for \n> one more round is the right thing to do. If no comments come to light \n> within a day or two I aim to push this series. If you wish to review \n> this but don't have time ping and I will delay until you have had time \n> to do so.\n\n\nThese look good to me.\n\nFor the series,\n\nReviewed-by: Kieran Bingham \n\n\n> \n> * Changes since v2\n> - Update all error messages if a test should fail.\n> \n> \n> Niklas Söderlund (4):\n> test: camera: Add read default configuration test\n> test: camera: Add setting of configuration test\n> test: camera: Add capture test\n> test: camera: Add state machine test\n> \n> test/camera/camera_test.cpp | 74 +++++++\n> test/camera/camera_test.h | 35 ++++\n> test/camera/capture.cpp | 142 +++++++++++++\n> test/camera/configuration_default.cpp | 71 +++++++\n> test/camera/configuration_set.cpp | 91 +++++++++\n> test/camera/meson.build | 15 ++\n> test/camera/statemachine.cpp | 275 ++++++++++++++++++++++++++\n> test/meson.build | 1 +\n> 8 files changed, 704 insertions(+)\n> create mode 100644 test/camera/camera_test.cpp\n> create mode 100644 test/camera/camera_test.h\n> create mode 100644 test/camera/capture.cpp\n> create mode 100644 test/camera/configuration_default.cpp\n> create mode 100644 test/camera/configuration_set.cpp\n> create mode 100644 test/camera/meson.build\n> create mode 100644 test/camera/statemachine.cpp\n>","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id EED32610B3\n\tfor ;\n\tWed, 13 Mar 2019 10:32:59 +0100 (CET)","from [192.168.0.20]\n\t(cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 4979A5AA;\n\tWed, 13 Mar 2019 10:32:59 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1552469579;\n\tbh=Bu0heSBn8uFt5BCtAYpXYkfQA/h5Fz73tlbuU/hTLLs=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=B9pKk/Vsn9xwz4ptQepcdzcYBI61M3cUAv5+8uh+Fy7RbjbMo09K7uVTPs+AZUEf7\n\tkzB7AQg4HlePiomikA4aIr7ik/uoajAKvbqH+ABOac4h/Kc5W2r/q4OsT55Nn4w1Uv\n\t+eX+tF1JYiSPlIDwnhvHc2cUVBRgc+SPUGAJMtOQ=","Reply-To":"kieran.bingham@ideasonboard.com","To":"=?utf-8?q?Niklas_S=C3=B6derlund?= ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20190313010532.28960-1-niklas.soderlund@ragnatech.se>","From":"Kieran Bingham ","Openpgp":"preference=signencrypt","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAkAEEwEKACoCGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEFAlnDk/gFCQeA/YsACgkQoR5GchCkYf3X5w/9EaZ7\n\tcnUcT6dxjxrcmmMnfFPoQA1iQXr/MXQJBjFWfxRUWYzjvUJb2D/FpA8FY7y+vksoJP7pWDL7\n\tQTbksdwzagUEk7CU45iLWL/CZ/knYhj1I/+5LSLFmvZ/5Gf5xn2ZCsmg7C0MdW/GbJ8IjWA8\n\t/LKJSEYH8tefoiG6+9xSNp1p0Gesu3vhje/GdGX4wDsfAxx1rIYDYVoX4bDM+uBUQh7sQox/\n\tR1bS0AaVJzPNcjeC14MS226mQRUaUPc9250aj44WmDfcg44/kMsoLFEmQo2II9aOlxUDJ+x1\n\txohGbh9mgBoVawMO3RMBihcEjo/8ytW6v7xSF+xP4Oc+HOn7qebAkxhSWcRxQVaQYw3S9iZz\n\t2iA09AXAkbvPKuMSXi4uau5daXStfBnmOfalG0j+9Y6hOFjz5j0XzaoF6Pln0jisDtWltYhP\n\tX9LjFVhhLkTzPZB/xOeWGmsG4gv2V2ExbU3uAmb7t1VSD9+IO3Km4FtnYOKBWlxwEd8qOFpS\n\tjEqMXURKOiJvnw3OXe9MqG19XdeENA1KyhK5rqjpwdvPGfSn2V+SlsdJA0DFsobUScD9qXQw\n\tOvhapHe3XboK2+Rd7L+g/9Ud7ZKLQHAsMBXOVJbufA1AT+IaOt0ugMcFkAR5UbBg5+dZUYJj\n\t1QbPQcGmM3wfvuaWV5+SlJ+WeKIb8ta5Ag0EVgT9ZgEQAM4o5G/kmruIQJ3K9SYzmPishRHV\n\tDcUcvoakyXSX2mIoccmo9BHtD9MxIt+QmxOpYFNFM7YofX4lG0ld8H7FqoNVLd/+a0yru5Cx\n\tadeZBe3qr1eLns10Q90LuMo7/6zJhCW2w+HE7xgmCHejAwuNe3+7yt4QmwlSGUqdxl8cgtS1\n\tPlEK93xXDsgsJj/bw1EfSVdAUqhx8UQ3aVFxNug5OpoX9FdWJLKROUrfNeBE16RLrNrq2ROc\n\tiSFETpVjyC/oZtzRFnwD9Or7EFMi76/xrWzk+/b15RJ9WrpXGMrttHUUcYZEOoiC2lEXMSAF\n\tSSSj4vHbKDJ0vKQdEFtdgB1roqzxdIOg4rlHz5qwOTynueiBpaZI3PHDudZSMR5Fk6QjFooE\n\tXTw3sSl/km/lvUFiv9CYyHOLdygWohvDuMkV/Jpdkfq8XwFSjOle+vT/4VqERnYFDIGBxaRx\n\tkoBLfNDiiuR3lD8tnJ4A1F88K6ojOUs+jndKsOaQpDZV6iNFv8IaNIklTPvPkZsmNDhJMRHH\n\tIu60S7BpzNeQeT4yyY4dX9lC2JL/LOEpw8DGf5BNOP1KgjCvyp1/KcFxDAo89IeqljaRsCdP\n\t7WCIECWYem6pLwaw6IAL7oX+tEqIMPph/G/jwZcdS6Hkyt/esHPuHNwX4guqTbVEuRqbDzDI\n\t2DJO5FbxABEBAAGJAiUEGAEKAA8CGwwFAlnDlGsFCQeA/gIACgkQoR5GchCkYf1yYRAAq+Yo\n\tnbf9DGdK1kTAm2RTFg+w9oOp2Xjqfhds2PAhFFvrHQg1XfQR/UF/SjeUmaOmLSczM0s6XMeO\n\tVcE77UFtJ/+hLo4PRFKm5X1Pcar6g5m4xGqa+Xfzi9tRkwC29KMCoQOag1BhHChgqYaUH3yo\n\tUzaPwT/fY75iVI+yD0ih/e6j8qYvP8pvGwMQfrmN9YB0zB39YzCSdaUaNrWGD3iCBxg6lwSO\n\tLKeRhxxfiXCIYEf3vwOsP3YMx2JkD5doseXmWBGW1U0T/oJF+DVfKB6mv5UfsTzpVhJRgee7\n\t4jkjqFq4qsUGxcvF2xtRkfHFpZDbRgRlVmiWkqDkT4qMA+4q1y/dWwshSKi/uwVZNycuLsz+\n\t+OD8xPNCsMTqeUkAKfbD8xW4LCay3r/dD2ckoxRxtMD9eOAyu5wYzo/ydIPTh1QEj9SYyvp8\n\tO0g6CpxEwyHUQtF5oh15O018z3ZLztFJKR3RD42VKVsrnNDKnoY0f4U0z7eJv2NeF8xHMuiU\n\tRCIzqxX1GVYaNkKTnb/Qja8hnYnkUzY1Lc+OtwiGmXTwYsPZjjAaDX35J/RSKAoy5wGo/YFA\n\tJxB1gWThL4kOTbsqqXj9GLcyOImkW0lJGGR3o/fV91Zh63S5TKnf2YGGGzxki+ADdxVQAm+Q\n\tsbsRB8KNNvVXBOVNwko86rQqF9drZuw=","Organization":"Ideas on Board","Message-ID":"","Date":"Wed, 13 Mar 2019 09:32:55 +0000","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101\n\tThunderbird/60.4.0","MIME-Version":"1.0","In-Reply-To":"<20190313010532.28960-1-niklas.soderlund@ragnatech.se>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-GB","Content-Transfer-Encoding":"8bit","Subject":"Re: [libcamera-devel] [PATCH v3 0/4] test: camera: Add basic tests\n\tfor the camera","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Wed, 13 Mar 2019 09:33:00 -0000"}},{"id":1060,"web_url":"https://patchwork.libcamera.org/comment/1060/","msgid":"<20190314150347.GA26015@bigcity.dyn.berto.se>","date":"2019-03-14T15:03:47","subject":"Re: [libcamera-devel] [PATCH v3 0/4] test: camera: Add basic tests\n\tfor the camera","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi,\n\nOn 2019-03-13 09:32:55 +0000, Kieran Bingham wrote:\n> Hi Niklas,\n> \n> On 13/03/2019 01:05, Niklas Söderlund wrote:\n> > Hi,\n> > \n> > This series add basic tests for the camera implementation. The tests\n> > involve reading and setting configurations, access control of the state\n> > machine and capturing.\n> > \n> > All tests uses the vimc pipeline to allow the tests to run on as many\n> > platforms as possible. Down the line this might be expanded to run an\n> > all cameras detected by libcamera.\n> > \n> > All patches in the series are reviewed but I feel that posting it for \n> > one more round is the right thing to do. If no comments come to light \n> > within a day or two I aim to push this series. If you wish to review \n> > this but don't have time ping and I will delay until you have had time \n> > to do so.\n> \n> \n> These look good to me.\n> \n> For the series,\n> \n> Reviewed-by: Kieran Bingham \n\nThanks! I have now pushed this series with your and Laurents tags.\n\n> \n> \n> > \n> > * Changes since v2\n> > - Update all error messages if a test should fail.\n> > \n> > \n> > Niklas Söderlund (4):\n> > test: camera: Add read default configuration test\n> > test: camera: Add setting of configuration test\n> > test: camera: Add capture test\n> > test: camera: Add state machine test\n> > \n> > test/camera/camera_test.cpp | 74 +++++++\n> > test/camera/camera_test.h | 35 ++++\n> > test/camera/capture.cpp | 142 +++++++++++++\n> > test/camera/configuration_default.cpp | 71 +++++++\n> > test/camera/configuration_set.cpp | 91 +++++++++\n> > test/camera/meson.build | 15 ++\n> > test/camera/statemachine.cpp | 275 ++++++++++++++++++++++++++\n> > test/meson.build | 1 +\n> > 8 files changed, 704 insertions(+)\n> > create mode 100644 test/camera/camera_test.cpp\n> > create mode 100644 test/camera/camera_test.h\n> > create mode 100644 test/camera/capture.cpp\n> > create mode 100644 test/camera/configuration_default.cpp\n> > create mode 100644 test/camera/configuration_set.cpp\n> > create mode 100644 test/camera/meson.build\n> > create mode 100644 test/camera/statemachine.cpp\n> > \n> \n> -- \n> Regards\n> --\n> Kieran","headers":{"Return-Path":"","Received":["from mail-lj1-x244.google.com (mail-lj1-x244.google.com\n\t[IPv6:2a00:1450:4864:20::244])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9DC6D600CB\n\tfor ;\n\tThu, 14 Mar 2019 16:03:50 +0100 (CET)","by mail-lj1-x244.google.com with SMTP id z7so5144337lji.0\n\tfor ;\n\tThu, 14 Mar 2019 08:03:50 -0700 (PDT)","from localhost (89-233-230-99.cust.bredband2.com. [89.233.230.99])\n\tby smtp.gmail.com with ESMTPSA id\n\tg68sm2513211ljg.53.2019.03.14.08.03.48\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tThu, 14 Mar 2019 08:03:48 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to\n\t:user-agent; bh=ryqtLqUOFfS5OMcGnbZZbxiXrzMRM6Wno/MOynK6WFo=;\n\tb=Pc1ZLvpv9BZokePtV3LOhFcDed1LkMkR8yVqG6I+6YzFQUY1myrDIXeDa71Eoz66g2\n\tVtcnvjzxcj7OVoMRpPEj3fm1BY0QBa8C7HiKxuBGtzCtGZf/t1vUHAn0fqeYhDdOrAMG\n\tAtXElhAmya/NnA83I+jLLKJpyo2QeMYTJ1B3W+eoHwTQmI6L8IJdf96BxIdjy0hbAmZg\n\twlUXEFBKAbozea9FuaJ8LXGG7ezbRztlfLPqRWt4tmKc1B0rbETmZVk/89jPRLNYCuiK\n\tuBFOF8nrdwsZTQOx3tMVhVp2NiwzbeRgg3a3XgV+DM7f/VCjzt4F+gv88UPYWvB8fn47\n\tW6Bw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to:user-agent;\n\tbh=ryqtLqUOFfS5OMcGnbZZbxiXrzMRM6Wno/MOynK6WFo=;\n\tb=HfXp0hh/CFkd2QTbEU1TCDPnkrvMahMRGJCLd87t6rm2TLKtGNt4zBfW/xegi3Lnqe\n\tG4o15hMqJdS0g1NxoCbQoK3lP0RCu1pt3EPlf8xZnGsUyr5/fn0Bb7FHAWkxEl/3kWwH\n\tCU4D1z7olOmoy2LyGRngtwgerPTpGfSFFBeaXJvVA0rMhyzeTUpmC1olgQpQ5xyLIOIG\n\tR+yrzD/BUQN/QvpTudKIR214FVhgK7Rysg71Z7K2qEIAhf8bmR6EhNWg28HuaJUFx6NY\n\ty+K98A2v97lwMPOCWDhe9MXcmTBEYAAvTLb2J4TiLCOy3kYyBMM7PxE+oOCIuCXbjykG\n\tY3Ww==","X-Gm-Message-State":"APjAAAUlsWJESe6Do0pPFlxMdw+3kmndt/8Aa4I8d9JT605FWbMjd/cE\n\twVrhSoJOGCqUoz4hkTedVp1QAC1MGls=","X-Google-Smtp-Source":"APXvYqy1eQL5WZbn2U3NyrTXeMqkyF3b1CFrZgh5/ZcYcfkLwxns4qQJ3ukVNpyvV4+7x1x1nSMQkw==","X-Received":"by 2002:a2e:9bd5:: with SMTP id w21mr1763269ljj.66.1552575829428;\n\tThu, 14 Mar 2019 08:03:49 -0700 (PDT)","Date":"Thu, 14 Mar 2019 16:03:47 +0100","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Kieran Bingham ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190314150347.GA26015@bigcity.dyn.berto.se>","References":"<20190313010532.28960-1-niklas.soderlund@ragnatech.se>\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"","User-Agent":"Mutt/1.11.3 (2019-02-01)","Subject":"Re: [libcamera-devel] [PATCH v3 0/4] test: camera: Add basic tests\n\tfor the camera","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Thu, 14 Mar 2019 15:03:50 -0000"}}]