[{"id":1048,"web_url":"https://patchwork.libcamera.org/comment/1048/","msgid":"<20190313010626.GA12538@bigcity.dyn.berto.se>","date":"2019-03-13T01:06:26","subject":"Re: [libcamera-devel] [PATCH v2 0/4] test: camera: Add basic tests\n\tfor the camera","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Laurent,\n\nThanks for your feedback on this series.\n\nI have addressed all your comments and posted a v3 to the ML. I will let \nit float for a day or two in case there are more review comments and \nmerge it if noting surface.\n\nOn 2019-03-11 03:22:28 +0100, Niklas Söderlund wrote:\n> Hi,\n> \n> This series add basic tests for the camera implementation. The tests \n> involve reading and setting configurations, access control of the state \n> machine and capturing.\n> \n> All tests uses the vimc pipeline to allow the tests to run on as many\n> platforms as possible. Down the line this might be expanded to run an\n> all cameras detected by libcamera.\n> \n> Niklas Söderlund (4):\n> test: camera: Add read default configuration test\n> test: camera: Add setting of configuration test\n> test: camera: Add capture test\n> test: camera: Add state machine test\n> \n> test/camera/camera_test.cpp | 74 +++++++\n> test/camera/camera_test.h | 35 ++++\n> test/camera/capture.cpp | 136 +++++++++++++\n> test/camera/configuration_default.cpp | 68 +++++++\n> test/camera/configuration_set.cpp | 90 +++++++++\n> test/camera/meson.build | 15 ++\n> test/camera/statemachine.cpp | 275 ++++++++++++++++++++++++++\n> test/meson.build | 1 +\n> 8 files changed, 694 insertions(+)\n> create mode 100644 test/camera/camera_test.cpp\n> create mode 100644 test/camera/camera_test.h\n> create mode 100644 test/camera/capture.cpp\n> create mode 100644 test/camera/configuration_default.cpp\n> create mode 100644 test/camera/configuration_set.cpp\n> create mode 100644 test/camera/meson.build\n> create mode 100644 test/camera/statemachine.cpp\n> \n> -- \n> 2.21.0\n>","headers":{"Return-Path":"","Received":["from mail-lj1-x242.google.com (mail-lj1-x242.google.com\n\t[IPv6:2a00:1450:4864:20::242])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DE2ED610B6\n\tfor ;\n\tWed, 13 Mar 2019 02:06:28 +0100 (CET)","by mail-lj1-x242.google.com with SMTP id w6so48738ljd.7\n\tfor ;\n\tTue, 12 Mar 2019 18:06:28 -0700 (PDT)","from localhost (89-233-230-99.cust.bredband2.com. [89.233.230.99])\n\tby smtp.gmail.com with ESMTPSA id\n\tw11sm447196lfe.62.2019.03.12.18.06.26\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tTue, 12 Mar 2019 18:06:27 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to\n\t:user-agent; bh=iu+vXPhFMHQ3fcTEZwtXnVlNkBp0SwnaqexfHG4c5xQ=;\n\tb=Z+LgMPOVI4VBOXJaWQL/XsHfCtiBw/UTmoa1S2DDcxyb56OM5mDSRwf1Ff02aW2cKl\n\toCKmGmArI5t5PwQfLicnyHgAvPHjKklT82Gy1R8aS2g+VBPUuEmcjZucWOYWsgIbyLnh\n\tTPW+MCJN6+CCsDUpMk/Mb2aZDR8IB2btB7eBr/Xrmn8BWxPwTBNdavbXJXUFzrRwmcTs\n\t0nQm2/VtXaLuMkd0RDV1jLwDtsH55iYg4o2TTf22IX9gYCwFePpiHnZPO4sJa3jMc5+p\n\t9tFGVAuxUJV/3eyY+FMOHjbzMk5i2K4eMvC3hzQmQZMwY8KMQOGxpz7YZohfqPGmPOCu\n\trETg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to:user-agent;\n\tbh=iu+vXPhFMHQ3fcTEZwtXnVlNkBp0SwnaqexfHG4c5xQ=;\n\tb=Be1MRvjnl/6gn8wIkP0FSpDJT24wce+7csho+7r3hN2CCl6cO7elssG3L/Gp3IKSOz\n\tIocUNdcs2LhF5e22GlkzFQpGe0aQ7XtWz9fH/ioWuPQqHZs7kkufeHwF8UbwDSdHlPIR\n\t/HzjueziKZ5qe+kaUeVyx6Hl/qh8joWT/H6Uw3vpXDrB+IFhNMa5YSc38uVSTuwqTiZF\n\t0RqfJbZ3003yERUhbOBeiK3dVaCeNxtoqRAdrUafiZjGSu+1Upspz80dft1hj2cFkvKk\n\tyuO0xKlp0Zeg+wwu9WX8xAkgylICm/IISuHOdzuzZXhPrz5yj+HuhPInXtXjvBBqpyuj\n\t0wiw==","X-Gm-Message-State":"APjAAAX/jXCCKY2TKkZLanBvqZQRNDblfZKmBOSVatCwKyGZ6jpxmKdM\n\tQz6bhrRk5J9JLXqnMEt2ZtJCmydDUoE=","X-Google-Smtp-Source":"APXvYqxDUS/BwDhXDj4VvMigQ4bDF5qSvoc155QSfKFoFSjzOUSv9PzYZ/QSgQn985oAgerclNiwBQ==","X-Received":"by 2002:a2e:4290:: with SMTP id\n\th16mr21575643ljf.52.1552439188053; \n\tTue, 12 Mar 2019 18:06:28 -0700 (PDT)","Date":"Wed, 13 Mar 2019 02:06:26 +0100","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190313010626.GA12538@bigcity.dyn.berto.se>","References":"<20190311022232.4759-1-niklas.soderlund@ragnatech.se>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20190311022232.4759-1-niklas.soderlund@ragnatech.se>","User-Agent":"Mutt/1.11.3 (2019-02-01)","Subject":"Re: [libcamera-devel] [PATCH v2 0/4] test: camera: Add basic tests\n\tfor the camera","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Wed, 13 Mar 2019 01:06:29 -0000"}}]