[{"id":1001,"web_url":"https://patchwork.libcamera.org/comment/1001/","msgid":"<20190301180128.GF32244@pendragon.ideasonboard.com>","date":"2019-03-01T18:01:28","subject":"Re: [libcamera-devel] [PATCH v7 0/5] v4l2_(sub)dev: improvements\n\tand tests","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jacopo,\n\nThank you for the patches.\n\nOn Fri, Mar 01, 2019 at 04:40:58PM +0100, Jacopo Mondi wrote:\n> Hello,\n> few minor changes to address Laurent's comments.\n> \n> 1) propagate error on ENUM_FRAME_SIZE (all errors != from EINVAL and ENOTTY,\n> I wonder if subdevices can implement ENUM_MBUS but not ENUM_FRAME_SIZE\n> 2) remove method reordering in v4l2_device cosmetic patch\n> 3) use std::vector.empty() instead of (std::vector.size() == 0) in list\n> formats test.\n> \n> Hopefully this version might be pushed.\n\nFor the wholes series,\n\nReviewed-by: Laurent Pinchart \n\n> Jacopo Mondi (5):\n> libcamera: v4l2_subdevice: Implement ENUM_FRAME_SIZES\n> test: v4l2_subdevice: Add ListFormat test\n> libcamera: v4l2_subdevice: Cosmetic update\n> libcamera: v4l2_device: Add support for META_CAPTURE devices\n> libcamera: v4l2_device: Cosmetic update\n> \n> src/libcamera/geometry.cpp | 34 ++++++++\n> src/libcamera/include/geometry.h | 12 +++\n> src/libcamera/include/v4l2_device.h | 26 +++++-\n> src/libcamera/include/v4l2_subdevice.h | 11 ++-\n> src/libcamera/v4l2_device.cpp | 92 ++++++++++++++-------\n> src/libcamera/v4l2_subdevice.cpp | 107 ++++++++++++++++++++++---\n> test/v4l2_subdevice/list_formats.cpp | 81 +++++++++++++++++++\n> test/v4l2_subdevice/meson.build | 1 +\n> 8 files changed, 321 insertions(+), 43 deletions(-)\n> create mode 100644 test/v4l2_subdevice/list_formats.cpp","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C33B5610BF\n\tfor ;\n\tFri, 1 Mar 2019 19:01:37 +0100 (CET)","from pendragon.ideasonboard.com\n\t(dfj612yhrgyx302h3jwwy-3.rev.dnainternet.fi\n\t[IPv6:2001:14ba:21f5:5b00:ce28:277f:58d7:3ca4])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 2A0A949;\n\tFri, 1 Mar 2019 19:01:34 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1551463294;\n\tbh=kPMWr1GRb5yxTGG6rUm6pybqjHHGbKmSUqLr/ivAECA=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=BFTDZi41EpA6JXW+72PEUH/ysSa6wZIB7UMmqZpIdATWZti986iulIsETbsDMkYEw\n\t/jQypFPOq6KGqhKowKe9RuGIj2QAxIbFR0LT33DgQ6TVWSPANkyBECsy8Y4YF/E05I\n\tHnj/LuQ5FIHLheXYWgVW7743+U6WgOrEy8Gf8Lp0=","Date":"Fri, 1 Mar 2019 20:01:28 +0200","From":"Laurent Pinchart ","To":"Jacopo Mondi ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190301180128.GF32244@pendragon.ideasonboard.com>","References":"<20190301154103.19588-1-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20190301154103.19588-1-jacopo@jmondi.org>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH v7 0/5] v4l2_(sub)dev: improvements\n\tand tests","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Fri, 01 Mar 2019 18:01:39 -0000"}},{"id":1003,"web_url":"https://patchwork.libcamera.org/comment/1003/","msgid":"<20190302173336.xyquq7wopitqrdd5@uno.localdomain>","date":"2019-03-02T17:33:36","subject":"Re: [libcamera-devel] [PATCH v7 0/5] v4l2_(sub)dev: improvements\n\tand tests","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Laurent,\n\nOn Fri, Mar 01, 2019 at 08:01:28PM +0200, Laurent Pinchart wrote:\n> Hi Jacopo,\n>\n> Thank you for the patches.\n>\n> On Fri, Mar 01, 2019 at 04:40:58PM +0100, Jacopo Mondi wrote:\n> > Hello,\n> > few minor changes to address Laurent's comments.\n> >\n> > 1) propagate error on ENUM_FRAME_SIZE (all errors != from EINVAL and ENOTTY,\n> > I wonder if subdevices can implement ENUM_MBUS but not ENUM_FRAME_SIZE\n> > 2) remove method reordering in v4l2_device cosmetic patch\n> > 3) use std::vector.empty() instead of (std::vector.size() == 0) in list\n> > formats test.\n> >\n> > Hopefully this version might be pushed.\n>\n> For the wholes series,\n>\n> Reviewed-by: Laurent Pinchart \n\nThanks, series now pushed to master\n\n>\n> > Jacopo Mondi (5):\n> > libcamera: v4l2_subdevice: Implement ENUM_FRAME_SIZES\n> > test: v4l2_subdevice: Add ListFormat test\n> > libcamera: v4l2_subdevice: Cosmetic update\n> > libcamera: v4l2_device: Add support for META_CAPTURE devices\n> > libcamera: v4l2_device: Cosmetic update\n> >\n> > src/libcamera/geometry.cpp | 34 ++++++++\n> > src/libcamera/include/geometry.h | 12 +++\n> > src/libcamera/include/v4l2_device.h | 26 +++++-\n> > src/libcamera/include/v4l2_subdevice.h | 11 ++-\n> > src/libcamera/v4l2_device.cpp | 92 ++++++++++++++-------\n> > src/libcamera/v4l2_subdevice.cpp | 107 ++++++++++++++++++++++---\n> > test/v4l2_subdevice/list_formats.cpp | 81 +++++++++++++++++++\n> > test/v4l2_subdevice/meson.build | 1 +\n> > 8 files changed, 321 insertions(+), 43 deletions(-)\n> > create mode 100644 test/v4l2_subdevice/list_formats.cpp\n>\n> --\n> Regards,\n>\n> Laurent Pinchart","headers":{"Return-Path":"","Received":["from relay7-d.mail.gandi.net (relay7-d.mail.gandi.net\n\t[217.70.183.200])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 76018610BF\n\tfor ;\n\tSat, 2 Mar 2019 18:33:06 +0100 (CET)","from uno.localdomain\n\t(host175-152-static.252-95-b.business.telecomitalia.it\n\t[95.252.152.175]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay7-d.mail.gandi.net (Postfix) with ESMTPSA id C09DF20004;\n\tSat, 2 Mar 2019 17:33:05 +0000 (UTC)"],"X-Originating-IP":"95.252.152.175","Date":"Sat, 2 Mar 2019 18:33:36 +0100","From":"Jacopo Mondi ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190302173336.xyquq7wopitqrdd5@uno.localdomain>","References":"<20190301154103.19588-1-jacopo@jmondi.org>\n\t<20190301180128.GF32244@pendragon.ideasonboard.com>","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\"; boundary=\"y7elsabtdkrp7dc2\"","Content-Disposition":"inline","In-Reply-To":"<20190301180128.GF32244@pendragon.ideasonboard.com>","User-Agent":"NeoMutt/20180716","Subject":"Re: [libcamera-devel] [PATCH v7 0/5] v4l2_(sub)dev: improvements\n\tand tests","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Sat, 02 Mar 2019 17:33:06 -0000"}}]