[{"id":879,"web_url":"https://patchwork.libcamera.org/comment/879/","msgid":"<20190225222833.GE899@bigcity.dyn.berto.se>","date":"2019-02-25T22:28:33","subject":"Re: [libcamera-devel] [PATCH v2 0/4] cam: improve error paths","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"On 2019-02-24 18:14:03 +0100, Niklas Söderlund wrote:\n> Hi,\n> \n> This series improves the error paths of the cam tool. The most\n> noteworthy fix is 1/4 where the buffers allocated by the tool is\n> actually freed once they are no longer needed.\n\nSeries pushed to master.\n\n> \n> * Changes since v1\n> - Update patch 4/4 to be more clever per Laurent's suggestion, thanks!\n> \n> Niklas Söderlund (4):\n> cam: free allocated buffers when done capturing\n> cam: improve error checking when capturing\n> cam: fix printing of camera name\n> cam: Improve when usage information is printed\n> \n> src/cam/main.cpp | 33 +++++++++++++++++++++------------\n> 1 file changed, 21 insertions(+), 12 deletions(-)\n> \n> -- \n> 2.20.1\n>","headers":{"Return-Path":"","Received":["from mail-lj1-x241.google.com (mail-lj1-x241.google.com\n\t[IPv6:2a00:1450:4864:20::241])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E675B600FC\n\tfor ;\n\tMon, 25 Feb 2019 23:28:35 +0100 (CET)","by mail-lj1-x241.google.com with SMTP id z7so8746173lji.0\n\tfor ;\n\tMon, 25 Feb 2019 14:28:35 -0800 (PST)","from localhost (89-233-230-99.cust.bredband2.com. [89.233.230.99])\n\tby smtp.gmail.com with ESMTPSA id\n\tg24sm1858442ljj.87.2019.02.25.14.28.33\n\tfor \n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tMon, 25 Feb 2019 14:28:33 -0800 (PST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to\n\t:user-agent; bh=+DeBFx81R0Ex8Bqyki4CT0i29saUmWyfTg/62zTNVfE=;\n\tb=f66FcGEVs/z7mI17PPV9vAeXpG+LSspgLqfveFMGbp38KvHP/5WfKzEgwouUGoEhnz\n\teGUwWhUjeXnU+vuOzAw/Jq+OOLD5mOJulqIoX8jlbEgESejAnpS9NKT9yiPmxz/GGSZv\n\tRfeS6zddWjfzRs0ejSwz+dgA5faAw2xVaBYAyG4DjIkB5Ur/VawbeGtHr9PQ9gpPRIjZ\n\tKyDe+utUVW5kjRr7YNOPBrbh4YcXMOV3/Tgp9jK9HYUyhYoxdMPpG6/A6FCMcWclBkHw\n\tcm2/9QT8tB89fymK9fa1FzGrAtnokvbCOO83op+ZC/xBPPukCzhdhR5AfFZAdDW3+LJq\n\txl0g==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to:user-agent;\n\tbh=+DeBFx81R0Ex8Bqyki4CT0i29saUmWyfTg/62zTNVfE=;\n\tb=c+EF6rGrfiFX9ttUWBf06SLpJOnr3Qin5PMuoP2JIx8vUZcFnNOjVBGPC0//pYI0S+\n\ttVlPz1U6/Sf7kLEgz9u+jzDXh6mBTb+8nDeedZuUWmHbgFv1NEN++ekBw9jMKNwM9dVF\n\tA02PRnAUeScV7kd6pQiLZuO5D1MS3UftAgR2MsnXzds45LZ4CI3LyzAxt9omKkEMTwFZ\n\t5cRcKCz7JqQkZihAx76EYYr6wVvHr/Uh5Eb7snuXS0XELk1nernIqLuZvcsepZc1TslN\n\t3G6PflcSbZVraWqs7sEpWiCxsefUqcJHVRdcrivP0UyfrA9HQ+zKFEp5OcaP1DifzSfJ\n\tVSIQ==","X-Gm-Message-State":"AHQUAubDN7uFw1n2Rt++Xh4ymKYTyxmeE5t+EZn5g31B/43IZxxinrzS\n\tqtQfeAW+wybCq4IUdecSbFMYN4afABQ=","X-Google-Smtp-Source":"AHgI3IbjvVXNcDF79ettJeYWyWCIkHpvSIN+JOJW0Gw/WdP/EWCBf39XuRzKnieAspum34vMLrwzrA==","X-Received":"by 2002:a2e:95c4:: with SMTP id y4mr11284747ljh.98.1551133714606;\n\tMon, 25 Feb 2019 14:28:34 -0800 (PST)","Date":"Mon, 25 Feb 2019 23:28:33 +0100","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190225222833.GE899@bigcity.dyn.berto.se>","References":"<20190224171407.7856-1-niklas.soderlund@ragnatech.se>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20190224171407.7856-1-niklas.soderlund@ragnatech.se>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH v2 0/4] cam: improve error paths","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Mon, 25 Feb 2019 22:28:36 -0000"}}]