[{"id":808,"web_url":"https://patchwork.libcamera.org/comment/808/","msgid":"<20190213153726.GC5332@pendragon.ideasonboard.com>","date":"2019-02-13T15:37:26","subject":"Re: [libcamera-devel] [PATCH 0/3] Fix LOG usage","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nThank you for the patches.\n\nOn Wed, Feb 13, 2019 at 12:20:32PM +0000, Kieran Bingham wrote:\n> The LOG output should always provide a category.\n> \n> Update various locations where this was not provided.\n> \n> Kieran Bingham (3):\n>   libcamera: v4l2_device: Fix LOG usage\n>   libcamera: v4l2_subdevice: Fix LOG usage\n>   libcamera: device_enumerator: Fix LOG usage\n\nFor the whole series,\n\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n\n>  src/libcamera/device_enumerator.cpp | 3 ++-\n>  src/libcamera/v4l2_device.cpp       | 8 ++++----\n>  src/libcamera/v4l2_subdevice.cpp    | 3 ++-\n>  3 files changed, 8 insertions(+), 6 deletions(-)","headers":{"Return-Path":"<laurent.pinchart@ideasonboard.com>","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8703A610AE\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 13 Feb 2019 16:37:30 +0100 (CET)","from pendragon.ideasonboard.com\n\t(dfj612yhrgyx302h3jwwy-3.rev.dnainternet.fi\n\t[IPv6:2001:14ba:21f5:5b00:ce28:277f:58d7:3ca4])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E83E585;\n\tWed, 13 Feb 2019 16:37:29 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1550072250;\n\tbh=Nt1ve7VL1QGhcFrpoFSAUUiTpue1obJi3zaL/k+gMHI=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=EztLcqlCYZRg2w+4NlDED14DC2IOpdWy1eVvlsuMsre1Fa+bzFCeP7XbM8wUrsTN4\n\tn4Fh8zj1yqWRQHWXkRgBM+62PGf2vDOoaBJMg+y3Zw4UZ+fjW7qb3CAK6KJ8GGoTPo\n\t5yEjryOrr0fLQUgOyWYsAO4oQk+LpEPMfHfX9uFc=","Date":"Wed, 13 Feb 2019 17:37:26 +0200","From":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","To":"Kieran Bingham <kieran.bingham@ideasonboard.com>","Cc":"LibCamera Devel <libcamera-devel@lists.libcamera.org>","Message-ID":"<20190213153726.GC5332@pendragon.ideasonboard.com>","References":"<20190213122035.25309-1-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20190213122035.25309-1-kieran.bingham@ideasonboard.com>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH 0/3] Fix LOG usage","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","X-List-Received-Date":"Wed, 13 Feb 2019 15:37:30 -0000"}}]