[{"id":10978,"web_url":"https://patchwork.libcamera.org/comment/10978/","msgid":"<0cafeeb9-54bd-1a1b-3301-47b5b8542ae8@collabora.com>","date":"2020-06-29T17:33:49","subject":"Re: [libcamera-devel] [PATCH 00/25] media: ov5647: Support\n\tRaspberryPi Camera Module v1","submitter":{"id":46,"url":"https://patchwork.libcamera.org/api/people/46/","name":"Dafna Hirschfeld","email":"dafna.hirschfeld@collabora.com"},"content":"Hi,\nThanks for the series,\n\nI tried to apply it on master and found out that the set\nis rebased on top of the patchset\n\"dt-bidings: media: ov5647 bindings\"\nso running 'git am' without the other set fails.\nMaybe better to merge the two sets or mention it in the cover letter.\n\nThanks,\nDafna\n\n\n\nOn 23.06.20 12:07, Jacopo Mondi wrote:\n> -------------------------------------------------------------------------------\n> Second attempt after my ISP blocked the part of the first sending.\n> Also removed Luis Oliveira email from the receiver list as it gets\n> bounced back.\n> 550 5.1.1 ... User unknown\n> -------------------------------------------------------------------------------\n> \n> Hello,\n> this series improves and expand the existing ov5647 sensor driver to\n> the same feature level as found in RaspberryPi BSP.\n> \n> It is based on recent media tree master and the sensor bindings conversion\n> to dt-schema I sent out a few days ago:\n> \"[PATCH 0/2] dt-bidings: media: ov5647 bindings + small fix\"\n> \n> The first patches in the series has been sent by Roman as part of\n> \"[PATCH v2 0/6] ov5647 driver improvement\"\n> I took his patches in, addressed review comments and rebased on top\n> of the new dt-schema bindings. I kept the extensive receiver list he had\n> in his series for this reason.\n> \n> The series continues by polishing and cleaning up the driver and expanding\n> its functionalities to support multiple modes and image formats.\n> \n> The series has been tested with libcamera and the driver functionalities\n> compared with the BSP driver ones, and tested stand-alone by capturing\n> raw frames with yavta.\n> \n> Thanks\n> j\n> \n> Dave Stevenson (8):\n> media: ov5647: Add support for PWDN GPIO.\n> media: ov5647: Add support for non-continuous clock mode\n> media: ov5647: Add set_fmt and get_fmt calls.\n> media: ov5647: Add support for get_selection()\n> media: ov5647: Set V4L2_SUBDEV_FL_HAS_EVENTS flag\n> media: ov5647: Support V4L2_CID_PIXEL_RATE\n> media: ov5647: Support V4L2_CID_VBLANK control\n> media: ov5647: Advertise the correct exposure range\n> \n> David Plowman (1):\n> media: ov5647: Support gain, exposure and AWB controls\n> \n> Jacopo Mondi (16):\n> dt-bindings: media: ov5647: Document pwdn-gpios\n> dt-bindings: media: ov5647: Document clock-noncontinuous\n> media: ov5647: Fix format initialization\n> media: ov5647: Fix style issues\n> media: ov5647: Replace license with SPDX identifier\n> media: ov5647: Fix return value from read/write\n> media: ov5647: Program mode at s_stream(1) time\n> media: ov5647: Implement enum_frame_size()\n> media: ov5647: Protect s_stream() with mutex\n> media: ov5647: Rationalize driver structure name\n> media: ov5647: Break out format handling\n> media: ov5647: Rename SBGGR8 VGA mode\n> media: ov5647: Add SGGBR10_1X10 modes\n> media: ov5647: Implement set_fmt pad operation\n> media: ov5647: Program mode only if it has changed\n> media: ov5647: Support V4L2_CID_HBLANK control\n> \n> .../devicetree/bindings/media/i2c/ov5647.yaml | 11 +\n> drivers/media/i2c/ov5647.c | 1267 +++++++++++++++--\n> 2 files changed, 1126 insertions(+), 152 deletions(-)\n> \n> --\n> 2.27.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 01D5CBFFE2\n\tfor ;\n\tMon, 29 Jun 2020 17:33:55 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 969D3609DF;\n\tMon, 29 Jun 2020 19:33:54 +0200 (CEST)","from bhuna.collabora.co.uk (bhuna.collabora.co.uk [46.235.227.227])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 473AC603B2\n\tfor ;\n\tMon, 29 Jun 2020 19:33:53 +0200 (CEST)","from [IPv6:2003:cb:8737:cf00:84c7:ee07:61e9:a21f]\n\t(p200300cb8737cf0084c7ee0761e9a21f.dip0.t-ipconnect.de\n\t[IPv6:2003:cb:8737:cf00:84c7:ee07:61e9:a21f])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128\n\tbits))\n\t(No client certificate requested) (Authenticated sender: dafna)\n\tby bhuna.collabora.co.uk (Postfix) with ESMTPSA id 3ABD32A0C4E;\n\tMon, 29 Jun 2020 18:33:52 +0100 (BST)"],"To":"Jacopo Mondi , mchehab@kernel.org,\n\tsakari.ailus@linux.intel.com, hverkuil@xs4all.nl,\n\tlaurent.pinchart@ideasonboard.com, roman.kovalivskyi@globallogic.com, \n\tdave.stevenson@raspberrypi.org, naush@raspberrypi.com","References":"<20200623100815.10674-1-jacopo@jmondi.org>","From":"Dafna Hirschfeld ","Message-ID":"<0cafeeb9-54bd-1a1b-3301-47b5b8542ae8@collabora.com>","Date":"Mon, 29 Jun 2020 19:33:49 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.8.0","MIME-Version":"1.0","In-Reply-To":"<20200623100815.10674-1-jacopo@jmondi.org>","Content-Language":"en-US","Subject":"Re: [libcamera-devel] [PATCH 00/25] media: ov5647: Support\n\tRaspberryPi Camera Module v1","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"andrew_gabbasov@mentor.com, mrodin@de.adit-jv.com, mripard@kernel.org,\n\tlibcamera-devel@lists.libcamera.org, sudipi@jp.adit-jv.com,\n\thugues.fruchet@st.com, erosca@de.adit-jv.com, aford173@gmail.com,\n\tlinux-media@vger.kernel.org","Content-Transfer-Encoding":"7bit","Content-Type":"text/plain; charset=\"us-ascii\"; Format=\"flowed\"","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":10980,"web_url":"https://patchwork.libcamera.org/comment/10980/","msgid":"<602feda3-6c4c-4107-f0a5-e19be73c7db6@collabora.com>","date":"2020-06-29T18:08:51","subject":"Re: [libcamera-devel] [PATCH 00/25] media: ov5647: Support\n\tRaspberryPi Camera Module v1","submitter":{"id":46,"url":"https://patchwork.libcamera.org/api/people/46/","name":"Dafna Hirschfeld","email":"dafna.hirschfeld@collabora.com"},"content":"On 29.06.20 19:33, Dafna Hirschfeld wrote:\n> Hi,\n> Thanks for the series,\n> \n> I tried to apply it on master and found out that the set\n> is rebased on top of the patchset\n> \"dt-bidings: media: ov5647 bindings\"\n> so running 'git am' without the other set fails.\n> Maybe better to merge the two sets or mention it in the cover letter.\n> \n> Thanks,\n> Dafna\n> \n> \n> \n> On 23.06.20 12:07, Jacopo Mondi wrote:\n>> -------------------------------------------------------------------------------\n>> Second attempt after my ISP blocked the part of the first sending.\n>> Also removed Luis Oliveira email from the receiver list as it gets\n>> bounced back.\n>> 550 5.1.1 ... User unknown\n>> -------------------------------------------------------------------------------\n>>\n>> Hello,\n>>    this series improves and expand the existing ov5647 sensor driver to\n>> the same feature level as found in RaspberryPi BSP.\n>>\n>> It is based on recent media tree master and the sensor bindings conversion\n>> to dt-schema I sent out a few days ago:\n>> \"[PATCH 0/2] dt-bidings: media: ov5647 bindings + small fix\"\n\noops, maybe I should better read the cover letter first,\nsorry for the noise,\n\nThanks,\nDafna\n\n>>\n>> The first patches in the series has been sent by Roman as part of\n>> \"[PATCH v2 0/6] ov5647 driver improvement\"\n>> I took his patches in, addressed review comments and rebased on top\n>> of the new dt-schema bindings. I kept the extensive receiver list he had\n>> in his series for this reason.\n>>\n>> The series continues by polishing and cleaning up the driver and expanding\n>> its functionalities to support multiple modes and image formats.\n>>\n>> The series has been tested with libcamera and the driver functionalities\n>> compared with the BSP driver ones, and tested stand-alone by capturing\n>> raw frames with yavta.\n>>\n>> Thanks\n>>     j\n>>\n>> Dave Stevenson (8):\n>>    media: ov5647: Add support for PWDN GPIO.\n>>    media: ov5647: Add support for non-continuous clock mode\n>>    media: ov5647: Add set_fmt and get_fmt calls.\n>>    media: ov5647: Add support for get_selection()\n>>    media: ov5647: Set V4L2_SUBDEV_FL_HAS_EVENTS flag\n>>    media: ov5647: Support V4L2_CID_PIXEL_RATE\n>>    media: ov5647: Support V4L2_CID_VBLANK control\n>>    media: ov5647: Advertise the correct exposure range\n>>\n>> David Plowman (1):\n>>    media: ov5647: Support gain, exposure and AWB controls\n>>\n>> Jacopo Mondi (16):\n>>    dt-bindings: media: ov5647: Document pwdn-gpios\n>>    dt-bindings: media: ov5647: Document clock-noncontinuous\n>>    media: ov5647: Fix format initialization\n>>    media: ov5647: Fix style issues\n>>    media: ov5647: Replace license with SPDX identifier\n>>    media: ov5647: Fix return value from read/write\n>>    media: ov5647: Program mode at s_stream(1) time\n>>    media: ov5647: Implement enum_frame_size()\n>>    media: ov5647: Protect s_stream() with mutex\n>>    media: ov5647: Rationalize driver structure name\n>>    media: ov5647: Break out format handling\n>>    media: ov5647: Rename SBGGR8 VGA mode\n>>    media: ov5647: Add SGGBR10_1X10 modes\n>>    media: ov5647: Implement set_fmt pad operation\n>>    media: ov5647: Program mode only if it has changed\n>>    media: ov5647: Support V4L2_CID_HBLANK control\n>>\n>>   .../devicetree/bindings/media/i2c/ov5647.yaml |   11 +\n>>   drivers/media/i2c/ov5647.c                    | 1267 +++++++++++++++--\n>>   2 files changed, 1126 insertions(+), 152 deletions(-)\n>>\n>> -- \n>> 2.27.0\n>>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1047EBFFE2\n\tfor ;\n\tMon, 29 Jun 2020 18:08:57 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9E159609DB;\n\tMon, 29 Jun 2020 20:08:56 +0200 (CEST)","from bhuna.collabora.co.uk (bhuna.collabora.co.uk\n\t[IPv6:2a00:1098:0:82:1000:25:2eeb:e3e3])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 30EBA603B2\n\tfor ;\n\tMon, 29 Jun 2020 20:08:55 +0200 (CEST)","from [IPv6:2003:cb:8737:cf00:84c7:ee07:61e9:a21f]\n\t(p200300cb8737cf0084c7ee0761e9a21f.dip0.t-ipconnect.de\n\t[IPv6:2003:cb:8737:cf00:84c7:ee07:61e9:a21f])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128\n\tbits))\n\t(No client certificate requested) (Authenticated sender: dafna)\n\tby bhuna.collabora.co.uk (Postfix) with ESMTPSA id 2ACAA2A122C;\n\tMon, 29 Jun 2020 19:08:54 +0100 (BST)"],"From":"Dafna Hirschfeld ","To":"Jacopo Mondi , mchehab@kernel.org,\n\tsakari.ailus@linux.intel.com, hverkuil@xs4all.nl,\n\tlaurent.pinchart@ideasonboard.com, roman.kovalivskyi@globallogic.com, \n\tdave.stevenson@raspberrypi.org, naush@raspberrypi.com","References":"<20200623100815.10674-1-jacopo@jmondi.org>\n\t<0cafeeb9-54bd-1a1b-3301-47b5b8542ae8@collabora.com>","Message-ID":"<602feda3-6c4c-4107-f0a5-e19be73c7db6@collabora.com>","Date":"Mon, 29 Jun 2020 20:08:51 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.8.0","MIME-Version":"1.0","In-Reply-To":"<0cafeeb9-54bd-1a1b-3301-47b5b8542ae8@collabora.com>","Content-Language":"en-US","Subject":"Re: [libcamera-devel] [PATCH 00/25] media: ov5647: Support\n\tRaspberryPi Camera Module v1","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"andrew_gabbasov@mentor.com, mrodin@de.adit-jv.com, mripard@kernel.org,\n\tlibcamera-devel@lists.libcamera.org, sudipi@jp.adit-jv.com,\n\thugues.fruchet@st.com, erosca@de.adit-jv.com, aford173@gmail.com,\n\tlinux-media@vger.kernel.org","Content-Transfer-Encoding":"base64","Content-Type":"text/plain; charset=\"utf-8\"; Format=\"flowed\"","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":11341,"web_url":"https://patchwork.libcamera.org/comment/11341/","msgid":"<09d5ae97-3576-0666-20ed-29c00ce28ee2@collabora.com>","date":"2020-07-10T15:59:56","subject":"Re: [libcamera-devel] [PATCH 00/25] media: ov5647: Support\n\tRaspberryPi Camera Module v1","submitter":{"id":46,"url":"https://patchwork.libcamera.org/api/people/46/","name":"Dafna Hirschfeld","email":"dafna.hirschfeld@collabora.com"},"content":"On 23.06.20 12:07, Jacopo Mondi wrote:\n> -------------------------------------------------------------------------------\n> Second attempt after my ISP blocked the part of the first sending.\n> Also removed Luis Oliveira email from the receiver list as it gets\n> bounced back.\n> 550 5.1.1 ... User unknown\n> -------------------------------------------------------------------------------\n> \n> Hello,\n> this series improves and expand the existing ov5647 sensor driver to\n> the same feature level as found in RaspberryPi BSP.\n> \n> It is based on recent media tree master and the sensor bindings conversion\n> to dt-schema I sent out a few days ago:\n> \"[PATCH 0/2] dt-bidings: media: ov5647 bindings + small fix\"\n> \n> The first patches in the series has been sent by Roman as part of\n> \"[PATCH v2 0/6] ov5647 driver improvement\"\n> I took his patches in, addressed review comments and rebased on top\n> of the new dt-schema bindings. I kept the extensive receiver list he had\n> in his series for this reason.\n> \n> The series continues by polishing and cleaning up the driver and expanding\n> its functionalities to support multiple modes and image formats.\n> \n> The series has been tested with libcamera and the driver functionalities\n> compared with the BSP driver ones, and tested stand-alone by capturing\n> raw frames with yavta.\n\nHi,\nTested it on rock-pi 4 board with rkisp1 driver for the isp,\nusing the command 'cam -c 1 -C --file=\"/tmp/libcamframe#.data\" -s width=800,height=600'\nfrom libcamera.\n\nThis the branch: https://gitlab.collabora.com/dafna/linux/-/tree/test-ov5647-10-jul\nThe top commit is the ov5647 dts node:\nhttps://gitlab.collabora.com/dafna/linux/-/commit/6aa58e6c5378dc20fce9fcc0ef68916ae3fa7b22\n\nTested-by: Dafna Hirschfeld \n\n> \n> Thanks\n> j\n> \n> Dave Stevenson (8):\n> media: ov5647: Add support for PWDN GPIO.\n> media: ov5647: Add support for non-continuous clock mode\n> media: ov5647: Add set_fmt and get_fmt calls.\n> media: ov5647: Add support for get_selection()\n> media: ov5647: Set V4L2_SUBDEV_FL_HAS_EVENTS flag\n> media: ov5647: Support V4L2_CID_PIXEL_RATE\n> media: ov5647: Support V4L2_CID_VBLANK control\n> media: ov5647: Advertise the correct exposure range\n> \n> David Plowman (1):\n> media: ov5647: Support gain, exposure and AWB controls\n> \n> Jacopo Mondi (16):\n> dt-bindings: media: ov5647: Document pwdn-gpios\n> dt-bindings: media: ov5647: Document clock-noncontinuous\n> media: ov5647: Fix format initialization\n> media: ov5647: Fix style issues\n> media: ov5647: Replace license with SPDX identifier\n> media: ov5647: Fix return value from read/write\n> media: ov5647: Program mode at s_stream(1) time\n> media: ov5647: Implement enum_frame_size()\n> media: ov5647: Protect s_stream() with mutex\n> media: ov5647: Rationalize driver structure name\n> media: ov5647: Break out format handling\n> media: ov5647: Rename SBGGR8 VGA mode\n> media: ov5647: Add SGGBR10_1X10 modes\n> media: ov5647: Implement set_fmt pad operation\n> media: ov5647: Program mode only if it has changed\n> media: ov5647: Support V4L2_CID_HBLANK control\n> \n> .../devicetree/bindings/media/i2c/ov5647.yaml | 11 +\n> drivers/media/i2c/ov5647.c | 1267 +++++++++++++++--\n> 2 files changed, 1126 insertions(+), 152 deletions(-)\n> \n> --\n> 2.27.0\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9AF81BD792\n\tfor ;\n\tFri, 10 Jul 2020 16:00:02 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id CE3706049D;\n\tFri, 10 Jul 2020 18:00:01 +0200 (CEST)","from bhuna.collabora.co.uk (bhuna.collabora.co.uk [46.235.227.227])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id AC1B760491\n\tfor ;\n\tFri, 10 Jul 2020 18:00:00 +0200 (CEST)","from [IPv6:2003:cb:8737:cf00:b1e0:33ea:13e:2fa7]\n\t(p200300cb8737cf00b1e033ea013e2fa7.dip0.t-ipconnect.de\n\t[IPv6:2003:cb:8737:cf00:b1e0:33ea:13e:2fa7])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128\n\tbits))\n\t(No client certificate requested) (Authenticated sender: dafna)\n\tby bhuna.collabora.co.uk (Postfix) with ESMTPSA id 7A1A82A69E4;\n\tFri, 10 Jul 2020 16:59:59 +0100 (BST)"],"To":"Jacopo Mondi , mchehab@kernel.org,\n\tsakari.ailus@linux.intel.com, hverkuil@xs4all.nl,\n\tlaurent.pinchart@ideasonboard.com, roman.kovalivskyi@globallogic.com, \n\tdave.stevenson@raspberrypi.org, naush@raspberrypi.com","References":"<20200623100815.10674-1-jacopo@jmondi.org>","From":"Dafna Hirschfeld ","Message-ID":"<09d5ae97-3576-0666-20ed-29c00ce28ee2@collabora.com>","Date":"Fri, 10 Jul 2020 17:59:56 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"<20200623100815.10674-1-jacopo@jmondi.org>","Content-Language":"en-US","Subject":"Re: [libcamera-devel] [PATCH 00/25] media: ov5647: Support\n\tRaspberryPi Camera Module v1","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"andrew_gabbasov@mentor.com, mrodin@de.adit-jv.com, mripard@kernel.org,\n\tlibcamera-devel@lists.libcamera.org, sudipi@jp.adit-jv.com,\n\thugues.fruchet@st.com, erosca@de.adit-jv.com, aford173@gmail.com,\n\tlinux-media@vger.kernel.org","Content-Transfer-Encoding":"7bit","Content-Type":"text/plain; charset=\"us-ascii\"; Format=\"flowed\"","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":11382,"web_url":"https://patchwork.libcamera.org/comment/11382/","msgid":"<20200714124820.dcq4eucynyzpqlmi@uno.localdomain>","date":"2020-07-14T12:48:20","subject":"Re: [libcamera-devel] [PATCH 00/25] media: ov5647: Support\n\tRaspberryPi Camera Module v1","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Dafna,\n\nOn Fri, Jul 10, 2020 at 05:59:56PM +0200, Dafna Hirschfeld wrote:\n>\n>\n> On 23.06.20 12:07, Jacopo Mondi wrote:\n> > -------------------------------------------------------------------------------\n> > Second attempt after my ISP blocked the part of the first sending.\n> > Also removed Luis Oliveira email from the receiver list as it gets\n> > bounced back.\n> > 550 5.1.1 ... User unknown\n> > -------------------------------------------------------------------------------\n> >\n> > Hello,\n> > this series improves and expand the existing ov5647 sensor driver to\n> > the same feature level as found in RaspberryPi BSP.\n> >\n> > It is based on recent media tree master and the sensor bindings conversion\n> > to dt-schema I sent out a few days ago:\n> > \"[PATCH 0/2] dt-bidings: media: ov5647 bindings + small fix\"\n> >\n> > The first patches in the series has been sent by Roman as part of\n> > \"[PATCH v2 0/6] ov5647 driver improvement\"\n> > I took his patches in, addressed review comments and rebased on top\n> > of the new dt-schema bindings. I kept the extensive receiver list he had\n> > in his series for this reason.\n> >\n> > The series continues by polishing and cleaning up the driver and expanding\n> > its functionalities to support multiple modes and image formats.\n> >\n> > The series has been tested with libcamera and the driver functionalities\n> > compared with the BSP driver ones, and tested stand-alone by capturing\n> > raw frames with yavta.\n>\n> Hi,\n> Tested it on rock-pi 4 board with rkisp1 driver for the isp,\n> using the command 'cam -c 1 -C --file=\"/tmp/libcamframe#.data\" -s width=800,height=600'\n> from libcamera.\n>\n> This the branch: https://gitlab.collabora.com/dafna/linux/-/tree/test-ov5647-10-jul\n> The top commit is the ov5647 dts node:\n> https://gitlab.collabora.com/dafna/linux/-/commit/6aa58e6c5378dc20fce9fcc0ef68916ae3fa7b22\n>\n> Tested-by: Dafna Hirschfeld \n>\n\nThanks for having validated the driver on a platform different from\nthe one I've tested with.\n\nI'll collect your tag in the next version.\n\nThanks\n j\n\n> >\n> > Thanks\n> > j\n> >\n> > Dave Stevenson (8):\n> > media: ov5647: Add support for PWDN GPIO.\n> > media: ov5647: Add support for non-continuous clock mode\n> > media: ov5647: Add set_fmt and get_fmt calls.\n> > media: ov5647: Add support for get_selection()\n> > media: ov5647: Set V4L2_SUBDEV_FL_HAS_EVENTS flag\n> > media: ov5647: Support V4L2_CID_PIXEL_RATE\n> > media: ov5647: Support V4L2_CID_VBLANK control\n> > media: ov5647: Advertise the correct exposure range\n> >\n> > David Plowman (1):\n> > media: ov5647: Support gain, exposure and AWB controls\n> >\n> > Jacopo Mondi (16):\n> > dt-bindings: media: ov5647: Document pwdn-gpios\n> > dt-bindings: media: ov5647: Document clock-noncontinuous\n> > media: ov5647: Fix format initialization\n> > media: ov5647: Fix style issues\n> > media: ov5647: Replace license with SPDX identifier\n> > media: ov5647: Fix return value from read/write\n> > media: ov5647: Program mode at s_stream(1) time\n> > media: ov5647: Implement enum_frame_size()\n> > media: ov5647: Protect s_stream() with mutex\n> > media: ov5647: Rationalize driver structure name\n> > media: ov5647: Break out format handling\n> > media: ov5647: Rename SBGGR8 VGA mode\n> > media: ov5647: Add SGGBR10_1X10 modes\n> > media: ov5647: Implement set_fmt pad operation\n> > media: ov5647: Program mode only if it has changed\n> > media: ov5647: Support V4L2_CID_HBLANK control\n> >\n> > .../devicetree/bindings/media/i2c/ov5647.yaml | 11 +\n> > drivers/media/i2c/ov5647.c | 1267 +++++++++++++++--\n> > 2 files changed, 1126 insertions(+), 152 deletions(-)\n> >\n> > --\n> > 2.27.0\n> >\n> > _______________________________________________\n> > libcamera-devel mailing list\n> > libcamera-devel@lists.libcamera.org\n> > https://lists.libcamera.org/listinfo/libcamera-devel\n> >","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 11412BD792\n\tfor ;\n\tTue, 14 Jul 2020 12:44:54 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 746A060832;\n\tTue, 14 Jul 2020 14:44:53 +0200 (CEST)","from relay5-d.mail.gandi.net (relay5-d.mail.gandi.net\n\t[217.70.183.197])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C2ACD605B2\n\tfor ;\n\tTue, 14 Jul 2020 14:44:52 +0200 (CEST)","from uno.localdomain (93-34-118-233.ip49.fastwebnet.it\n\t[93.34.118.233]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay5-d.mail.gandi.net (Postfix) with ESMTPSA id C1D7C1C000B;\n\tTue, 14 Jul 2020 12:44:47 +0000 (UTC)"],"X-Originating-IP":"93.34.118.233","Date":"Tue, 14 Jul 2020 14:48:20 +0200","From":"Jacopo Mondi ","To":"Dafna Hirschfeld ","Message-ID":"<20200714124820.dcq4eucynyzpqlmi@uno.localdomain>","References":"<20200623100815.10674-1-jacopo@jmondi.org>\n\t<09d5ae97-3576-0666-20ed-29c00ce28ee2@collabora.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<09d5ae97-3576-0666-20ed-29c00ce28ee2@collabora.com>","Subject":"Re: [libcamera-devel] [PATCH 00/25] media: ov5647: Support\n\tRaspberryPi Camera Module v1","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"andrew_gabbasov@mentor.com, dave.stevenson@raspberrypi.org,\n\tmrodin@de.adit-jv.com, erosca@de.adit-jv.com, mripard@kernel.org,\n\troman.kovalivskyi@globallogic.com, libcamera-devel@lists.libcamera.org,\n\tlinux-media@vger.kernel.org, sakari.ailus@linux.intel.com,\n\thugues.fruchet@st.com, mchehab@kernel.org, aford173@gmail.com,\n\tsudipi@jp.adit-jv.com","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]