[{"id":5393,"web_url":"https://patchwork.libcamera.org/comment/5393/","msgid":"<20200625032803.GD5980@pendragon.ideasonboard.com>","date":"2020-06-25T03:28:03","subject":"Re: [libcamera-devel] [PATCH v3 0/4] libcamera sharpness strength\n\tcontrol","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi David,\n\nOn Tue, Jun 23, 2020 at 10:14:00AM +0100, David Plowman wrote:\n> Hi\n> \n> Version 3 of the sharpness control patch - same as v2 except:\n> \n> * Commit messages tidied a little.\n> \n> * In commit 3 I've made the user_strength_ parameter a regular double\n> too, as everything does get serialised within our pipeline handler.\n\nThank you. I've applied the series with one small fix in patch 3/4. It's\ngoing through compilation tests right now, and I'll push to master right\nafter (or reply to this e-mail if anything goes wrong).\n\nIn the future, when you post new versions of patch series, could you try\nto apply the tags received in previous versions ? I had replied with a\nReviewed-by for 1/4, 2/4 and 4/4 in v2. This would make it easier to\ntrack what patches have been reviewed already.\n\n> David Plowman (4):\n> libcamera: Add a sharpness strength control\n> libcamera: ipa: raspberrypi: Make sharpening mode_factor an ordinary\n> double\n> libcamera: ipa: raspberrypi: Add sharpness strength control\n> libcamera: ipa: raspberrypi: plumb in the libcamera sharpness control\n> \n> include/libcamera/ipa/raspberrypi.h | 1 +\n> .../raspberrypi/controller/rpi/sharpen.cpp | 29 +++++++++++++++----\n> .../raspberrypi/controller/rpi/sharpen.hpp | 8 +++--\n> .../controller/sharpen_algorithm.hpp | 21 ++++++++++++++\n> .../raspberrypi/controller/sharpen_status.h | 2 ++\n> src/ipa/raspberrypi/raspberrypi.cpp | 12 ++++++++\n> src/libcamera/control_ids.yaml | 12 ++++++++\n> 7 files changed, 76 insertions(+), 9 deletions(-)\n> create mode 100644 src/ipa/raspberrypi/controller/sharpen_algorithm.hpp","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 86937C0100\n\tfor ;\n\tThu, 25 Jun 2020 03:28:06 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id F35FA609A5;\n\tThu, 25 Jun 2020 05:28:05 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E69B1603BB\n\tfor ;\n\tThu, 25 Jun 2020 05:28:04 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 604FB521;\n\tThu, 25 Jun 2020 05:28:04 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"LS90XOji\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1593055684;\n\tbh=3N+QsElAAusHurzglNmzGWN8yFunDNjNwtTGKall2K4=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=LS90XOjiyBrs6GNUCwH+VdIgI/WpgBpXFmkpHGDXq+6EtoV3g+QAPGBEcScbxaikJ\n\tApFCaD4ibzZc+ycTcQfIwoOwzyElsikQw/LZFdManAV0TXQ9ZGcJbnY7jgGrah/pSr\n\t68ehrBIBUXPJxgW/4kSjESS8Z2UgRwWufMu+wdJ8=","Date":"Thu, 25 Jun 2020 06:28:03 +0300","From":"Laurent Pinchart ","To":"David Plowman ","Message-ID":"<20200625032803.GD5980@pendragon.ideasonboard.com>","References":"<20200623091404.15155-1-david.plowman@raspberrypi.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200623091404.15155-1-david.plowman@raspberrypi.com>","Subject":"Re: [libcamera-devel] [PATCH v3 0/4] libcamera sharpness strength\n\tcontrol","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":5401,"web_url":"https://patchwork.libcamera.org/comment/5401/","msgid":"","date":"2020-06-25T07:20:13","subject":"Re: [libcamera-devel] [PATCH v3 0/4] libcamera sharpness strength\n\tcontrol","submitter":{"id":42,"url":"https://patchwork.libcamera.org/api/people/42/","name":"David Plowman","email":"david.plowman@raspberrypi.com"},"content":"Hi Laurent\n\nThanks for taking care of this.\n\nOn Thu, 25 Jun 2020 at 04:28, Laurent Pinchart\n wrote:\n>\n> Hi David,\n>\n> On Tue, Jun 23, 2020 at 10:14:00AM +0100, David Plowman wrote:\n> > Hi\n> >\n> > Version 3 of the sharpness control patch - same as v2 except:\n> >\n> > * Commit messages tidied a little.\n> >\n> > * In commit 3 I've made the user_strength_ parameter a regular double\n> > too, as everything does get serialised within our pipeline handler.\n>\n> Thank you. I've applied the series with one small fix in patch 3/4. It's\n> going through compilation tests right now, and I'll push to master right\n> after (or reply to this e-mail if anything goes wrong).\n>\n> In the future, when you post new versions of patch series, could you try\n> to apply the tags received in previous versions ? I had replied with a\n> Reviewed-by for 1/4, 2/4 and 4/4 in v2. This would make it easier to\n> track what patches have been reviewed already.\n\nWill do. I'll also double-check if my checkstyle.py is working, I thought\nI'd done that but it's entirely possible I got it wrong!\n\nBest regards\nDavid\n\n>\n> > David Plowman (4):\n> > libcamera: Add a sharpness strength control\n> > libcamera: ipa: raspberrypi: Make sharpening mode_factor an ordinary\n> > double\n> > libcamera: ipa: raspberrypi: Add sharpness strength control\n> > libcamera: ipa: raspberrypi: plumb in the libcamera sharpness control\n> >\n> > include/libcamera/ipa/raspberrypi.h | 1 +\n> > .../raspberrypi/controller/rpi/sharpen.cpp | 29 +++++++++++++++----\n> > .../raspberrypi/controller/rpi/sharpen.hpp | 8 +++--\n> > .../controller/sharpen_algorithm.hpp | 21 ++++++++++++++\n> > .../raspberrypi/controller/sharpen_status.h | 2 ++\n> > src/ipa/raspberrypi/raspberrypi.cpp | 12 ++++++++\n> > src/libcamera/control_ids.yaml | 12 ++++++++\n> > 7 files changed, 76 insertions(+), 9 deletions(-)\n> > create mode 100644 src/ipa/raspberrypi/controller/sharpen_algorithm.hpp\n>\n> --\n> Regards,\n>\n> Laurent Pinchart","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B6218C0101\n\tfor ;\n\tThu, 25 Jun 2020 07:20:26 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 23618609A9;\n\tThu, 25 Jun 2020 09:20:26 +0200 (CEST)","from mail-ot1-x341.google.com (mail-ot1-x341.google.com\n\t[IPv6:2607:f8b0:4864:20::341])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A7A8E603BE\n\tfor ;\n\tThu, 25 Jun 2020 09:20:24 +0200 (CEST)","by mail-ot1-x341.google.com with SMTP id d4so4372076otk.2\n\tfor ;\n\tThu, 25 Jun 2020 00:20:24 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"KbeiLSQ8\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=GI04CLuoAkivxK+z0GUPCsOf7DTzDnGHqym1smeq6zg=;\n\tb=KbeiLSQ8VWpg3lYbsaz5VGfsZLumIMV3KsMlD1rcWlKNLyNM64Z+aW5wUyoOzT1Kzn\n\tY2+dN7EfFtLkocQIEZSs23V7Oj7c9lJrlUPGDXqeHUTeY62XLcIZH3k4x4h3nAxUq2L2\n\t/KoGbS72ylKZ73L7ZJOZCsTMuySvlg4eamHcp54ck38yZ9fmmOKzjlLuwJ49U8FP/bWG\n\tgBEjPLWtFMDuseL83fCnDnm6yKk9X0aIBS/Hx866Ytu6uAWrJVJj2QZb3vYW8qTj9umq\n\t/lnJrbQ93uo2Y/ydV9/PiPlDc5rVh1VnG+gIbSN7YNNtnMXLkdQn5cJOFxUY5XFNhRXf\n\tVj0Q==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=GI04CLuoAkivxK+z0GUPCsOf7DTzDnGHqym1smeq6zg=;\n\tb=pR1TD/gh9EIE0L4osV9IDtioxH6NFeneiIHjioeYYGOVcqcMeLkP/9+P/LWLRtsI24\n\t2mFhkOuBu1yeywGW+rbdziNZ5XO5/Ldbs6BX+hexCSxuy2KWxPsRvtlggXceLptNPKzZ\n\tHsIJXRuSpE790jkjVAtdkXO2cxG13V0Fj/Ccjg4eiRJi8glJ1R0/bPhd3bG5ucHCdPoz\n\t1IZ+qYdg5PVmlIyxxEBrbNaQw0GrGJpNI3wfErKsOmh2/wCRYGSmci9pXVQf7l+nqrQP\n\t/0cxZUzD47fi4sf3wL6/XA/u03OO1PJNTMPT/nMCbx53f09geF5m++oJv0kTVAAQEbj2\n\tzExw==","X-Gm-Message-State":"AOAM5312J2CHQHxyaRiLXErL0o73J/lHojGoTEuZFumZ9HlnD9PPO7Ry\n\tGWUzDBjxym5CV1ij85rqkkvhfYKBFDJXE3mOn9T81i8h","X-Google-Smtp-Source":"ABdhPJxhtJCniR/yTalvHetwYnwAUXxrie/tC/5opuZIQrE0Cx0U0RwC/2Tqh5Q4sNceu3bOsezj1tNPGzmcfwIUdNc=","X-Received":"by 2002:a9d:5604:: with SMTP id\n\te4mr25546106oti.166.1593069623242; \n\tThu, 25 Jun 2020 00:20:23 -0700 (PDT)","MIME-Version":"1.0","References":"<20200623091404.15155-1-david.plowman@raspberrypi.com>\n\t<20200625032803.GD5980@pendragon.ideasonboard.com>","In-Reply-To":"<20200625032803.GD5980@pendragon.ideasonboard.com>","From":"David Plowman ","Date":"Thu, 25 Jun 2020 08:20:13 +0100","Message-ID":"","To":"Laurent Pinchart ","Subject":"Re: [libcamera-devel] [PATCH v3 0/4] libcamera sharpness strength\n\tcontrol","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]