{"id":4127,"url":"https://patchwork.libcamera.org/api/covers/4127/?format=json","web_url":"https://patchwork.libcamera.org/cover/4127/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200623020930.1781469-1-niklas.soderlund@ragnatech.se>","date":"2020-06-23T02:09:20","name":"[libcamera-devel,v3,00/10] libcamera: ipu3: Allow zero-copy RAW stream","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/?format=json","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"mbox":"https://patchwork.libcamera.org/cover/4127/mbox/","series":[{"id":1027,"url":"https://patchwork.libcamera.org/api/series/1027/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1027","date":"2020-06-23T02:09:20","name":"libcamera: ipu3: Allow zero-copy RAW stream","version":3,"mbox":"https://patchwork.libcamera.org/series/1027/mbox/"}],"comments":"https://patchwork.libcamera.org/api/covers/4127/comments/","headers":{"Return-Path":"","Received":["from vsp-unauthed02.binero.net (vsp-unauthed02.binero.net\n\t[195.74.38.227])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8DF21603BD\n\tfor ;\n\tTue, 23 Jun 2020 04:09:43 +0200 (CEST)","from bismarck.berto.se (p4fca2eca.dip0.t-ipconnect.de\n\t[79.202.46.202]) by bin-vsp-out-01.atm.binero.net (Halon) with ESMTPA\n\tid 96de0ddc-b4f6-11ea-933e-005056917a89;\n\tTue, 23 Jun 2020 04:09:42 +0200 (CEST)"],"X-Halon-ID":"96de0ddc-b4f6-11ea-933e-005056917a89","Authorized-sender":"niklas@soderlund.pp.se","From":"=?utf-8?q?Niklas_S=C3=B6derlund?= ","To":"libcamera-devel@lists.libcamera.org","Date":"Tue, 23 Jun 2020 04:09:20 +0200","Message-Id":"<20200623020930.1781469-1-niklas.soderlund@ragnatech.se>","X-Mailer":"git-send-email 2.27.0","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v3 00/10] libcamera: ipu3: Allow zero-copy\n\tRAW stream","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Tue, 23 Jun 2020 02:09:44 -0000"},"content":"Hi,\n\nThis series removes the need to copy the buffer when capturing RAW\nbuffers from the IPU3 pipeline. This is made possible by allocating an\ninternal queue of buffers in the pipeline handler which is used when the\napplication does not provide an buffer for the RAW stream.\n\nThere is on issue with this series. If the camera is configured to\nsupply the application with more then one stream and one of them is a\nRAW stream. Then the sequence number of the RAW buffers in all requests\nare set to 0 before the request completes. This is due to that if two or\nmore streams are used the RAW buffer is always queued to the ImgU input\nto serve as input to the vf and/or output buffers. When the RAW buffers\nis dequeued from the ImgU input device the kernel sets the sequence\nnumber to zero. This should either be solved in the kernel or by \nreworking how sequence numbers handled going out of libcamera, does it \nmake sens to have seq numbers on the buffer level ?\n\nAs the RPi pipeline handler already started using the copy approach we\ncan not yet rename to role nor remove the copyFrom() helper. I aim to\nwork on that once the approach taken in this series is agreed upon.\n\nNiklas Söderlund (10):\n libcamera: camera_sensor: Make mbusCodes() return a set\n libcamera: ipu3: Fold mediaBusToFormat() into only caller\n libcamera: ipu3: Breakout stream assignment to new function\n libcamera: ipu3: Calculate number of buffers for ImgU\n libcamera: ipu3: cio2: Move the CIO2Device class to separate files\n libcamera: ipu3: cio2: Consolidate information about formats\n libcamera: ipu3: cio2: Add function to generate configuration\n libcamera: ipu3: cio2: Make the V4L2 devices private\n libcamera: ipu3: cio2: Hide buffer allocation and freeing from users\n libcamera: ipu3: Allow zero-copy RAW stream capture\n\n include/libcamera/internal/camera_sensor.h | 4 +-\n include/libcamera/internal/formats.h | 2 +-\n src/libcamera/camera_sensor.cpp | 1 -\n src/libcamera/formats.cpp | 7 +-\n src/libcamera/pipeline/ipu3/cio2.cpp | 298 ++++++++++++\n src/libcamera/pipeline/ipu3/cio2.h | 66 +++\n src/libcamera/pipeline/ipu3/ipu3.cpp | 497 +++++----------------\n src/libcamera/pipeline/ipu3/meson.build | 1 +\n test/camera-sensor.cpp | 2 +-\n 9 files changed, 475 insertions(+), 403 deletions(-)\n create mode 100644 src/libcamera/pipeline/ipu3/cio2.cpp\n create mode 100644 src/libcamera/pipeline/ipu3/cio2.h"}