[{"id":627,"web_url":"https://patchwork.libcamera.org/comment/627/","msgid":"<20190126164111.GA4542@pendragon.ideasonboard.com>","date":"2019-01-26T16:41:11","subject":"Re: [libcamera-devel] [PATCH 0/2] libcamera: ipu3: more review fixes","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jacopo,\n\nThanks you for the patches.\n\nOn Sat, Jan 26, 2019 at 05:28:57PM +0100, Jacopo Mondi wrote:\n> Address review comments on the IPU3 pipeline handler CameraData usage.\n\nYou may want to expland the commit message of 2/2 to explain why the\nreworked version is an improvement. In any way,\n\nReviewed-by: Laurent Pinchart \n\n> Jacopo Mondi (2):\n> libcamera: ipu3: Add method to retrieve camera data\n> libcamera: ipu3: Re-work camera data registration\n> \n> src/libcamera/pipeline/ipu3/ipu3.cpp | 16 ++++++++++------\n> 1 file changed, 10 insertions(+), 6 deletions(-)\n>","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C47FE60B2D\n\tfor ;\n\tSat, 26 Jan 2019 17:41:20 +0100 (CET)","from pendragon.ideasonboard.com (85-76-144-239-nat.elisa-mobile.fi\n\t[85.76.144.239])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 5EBEE23A;\n\tSat, 26 Jan 2019 17:41:18 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1548520880;\n\tbh=LL9e0YOfzSmI9QAl9eMYgFmcs9VPxKeD2yllwmCvcz0=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=Dy7lbxn0ohTkeEw1EWyhVtO1EEQpWUdqMlVQtDMbRSg//SOghxCCPKh/gByPt6xo0\n\txGvYmSejRmt2zF1nkPdCCBcPp4ZtNFLCwayCrOJXBm5C7wDRfgvZXvhAdvwyyC3HBB\n\tlVWy+6z82san4Ac8HgBR8aXiu0AmFjOfUHXxsBDs=","Date":"Sat, 26 Jan 2019 18:41:11 +0200","From":"Laurent Pinchart ","To":"Jacopo Mondi ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190126164111.GA4542@pendragon.ideasonboard.com>","References":"<20190126162859.32031-1-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20190126162859.32031-1-jacopo@jmondi.org>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH 0/2] libcamera: ipu3: more review fixes","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Sat, 26 Jan 2019 16:41:20 -0000"}},{"id":690,"web_url":"https://patchwork.libcamera.org/comment/690/","msgid":"<20190129145532.kq4qb6ovp2opkwyo@uno.localdomain>","date":"2019-01-29T14:55:32","subject":"Re: [libcamera-devel] [PATCH 0/2] libcamera: ipu3: more review fixes","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Laurent,\n\nOn Sat, Jan 26, 2019 at 06:41:11PM +0200, Laurent Pinchart wrote:\n> Hi Jacopo,\n>\n> Thanks you for the patches.\n>\n> On Sat, Jan 26, 2019 at 05:28:57PM +0100, Jacopo Mondi wrote:\n> > Address review comments on the IPU3 pipeline handler CameraData usage.\n>\n> You may want to expland the commit message of 2/2 to explain why the\n> reworked version is an improvement. In any way,\n>\n> Reviewed-by: Laurent Pinchart \n\nThanks, comment expanded and pushed\n\nThanks\n j\n\n>\n> > Jacopo Mondi (2):\n> > libcamera: ipu3: Add method to retrieve camera data\n> > libcamera: ipu3: Re-work camera data registration\n> >\n> > src/libcamera/pipeline/ipu3/ipu3.cpp | 16 ++++++++++------\n> > 1 file changed, 10 insertions(+), 6 deletions(-)\n> >\n>\n> --\n> Regards,\n>\n> Laurent Pinchart","headers":{"Return-Path":"","Received":["from relay11.mail.gandi.net (relay11.mail.gandi.net\n\t[217.70.178.231])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E478E60DB8\n\tfor ;\n\tTue, 29 Jan 2019 15:55:24 +0100 (CET)","from uno.localdomain (2-224-242-101.ip172.fastwebnet.it\n\t[2.224.242.101]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay11.mail.gandi.net (Postfix) with ESMTPSA id 6903610000E;\n\tTue, 29 Jan 2019 14:55:24 +0000 (UTC)"],"Date":"Tue, 29 Jan 2019 15:55:32 +0100","From":"Jacopo Mondi ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190129145532.kq4qb6ovp2opkwyo@uno.localdomain>","References":"<20190126162859.32031-1-jacopo@jmondi.org>\n\t<20190126164111.GA4542@pendragon.ideasonboard.com>","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\"; boundary=\"ikaa6ha6bf2rwu3h\"","Content-Disposition":"inline","In-Reply-To":"<20190126164111.GA4542@pendragon.ideasonboard.com>","User-Agent":"NeoMutt/20180716","Subject":"Re: [libcamera-devel] [PATCH 0/2] libcamera: ipu3: more review fixes","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Tue, 29 Jan 2019 14:55:25 -0000"}}]