[{"id":5125,"web_url":"https://patchwork.libcamera.org/comment/5125/","msgid":"<20200608092907.7ubcugpvwswlq4p6@uno.localdomain>","date":"2020-06-08T09:29:07","subject":"Re: [libcamera-devel] [PATCH v3 0/8] android: Build stream\n\tconfiguration map","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hello,\n\nOn Fri, Jun 05, 2020 at 04:09:54PM +0200, Jacopo Mondi wrote:\n> Hello,\n> this series contains v2 of \"android: Implement format translation\" where I\n> have addressed Kieran's suggestions in patch 1.\n> Patches 2, 3 and 4 are the same as v2.\n\nI'm now pushing patches 1 to 4.\n\nThe part on FrameDurationLimits it's useful for discussion purposes on\nthe property definition but I'll try to rework it to provide\nper-configuration duration limits.\n\nThanks\n j\n\n>\n> Patch 5 introduces a new property a camera can use to report it frame duration\n> limits. Patch 6 and 7 fill those limits by inspecting in the camera sensor\n> class, and patch 8 reports that duration in the android static metadata buffers.\n>\n> As noted in the comments in patch 8, this is a sub-optimal approach, as the\n> minimum frame duration should be reported per-configuration.\n>\n> Patch 5 could potentially conflict with Naush's work on frame duration. Sending\n> it out anyway for discussion purposed.\n>\n> Tested with RPi and imx219, IPU3 with ov5670, currently failing to report\n> correct frame durations for ov13858. I'll investigate and fix, but I'm sending\n> this out earlier anyway to reduce possible conflicts.\n>\n> Thanks\n> j\n>\n> Jacopo Mondi (8):\n> android: camera_device: Initialize stream configuration\n> android: camera_device: Calculate metadata size\n> android: camera_device: Replace hardcoded stream configuration\n> android: camera_device: Translate Android format\n> libcamera: properties: Add FrameDurationLimits\n> libcamera: camera_sensor: Break out properties initialization\n> libcamera: camera_sensor: Initialize frame durations\n> android: camera_device: Report frame durations\n>\n> include/libcamera/internal/camera_sensor.h | 2 +\n> src/android/camera_device.cpp | 349 +++++++++++++++++++--\n> src/android/camera_device.h | 15 +\n> src/libcamera/camera_sensor.cpp | 139 ++++++--\n> src/libcamera/property_ids.yaml | 47 +++\n> 5 files changed, 492 insertions(+), 60 deletions(-)\n>\n> --\n> 2.27.0\n>","headers":{"Return-Path":"","Received":["from relay7-d.mail.gandi.net (relay7-d.mail.gandi.net\n\t[217.70.183.200])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1B2696002E\n\tfor ;\n\tMon, 8 Jun 2020 11:25:44 +0200 (CEST)","from uno.localdomain (2-224-242-101.ip172.fastwebnet.it\n\t[2.224.242.101]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay7-d.mail.gandi.net (Postfix) with ESMTPSA id 47CD620006\n\tfor ;\n\tMon, 8 Jun 2020 09:25:42 +0000 (UTC)"],"X-Originating-IP":"2.224.242.101","Date":"Mon, 8 Jun 2020 11:29:07 +0200","From":"Jacopo Mondi ","To":"libcamera-devel@lists.libcamera.org","Message-ID":"<20200608092907.7ubcugpvwswlq4p6@uno.localdomain>","References":"<20200605141002.49119-1-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20200605141002.49119-1-jacopo@jmondi.org>","Subject":"Re: [libcamera-devel] [PATCH v3 0/8] android: Build stream\n\tconfiguration map","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Mon, 08 Jun 2020 09:25:44 -0000"}}]