[{"id":5029,"web_url":"https://patchwork.libcamera.org/comment/5029/","msgid":"<20200605065045.GA5852@pendragon.ideasonboard.com>","date":"2020-06-05T06:50:45","subject":"Re: [libcamera-devel] [PATCH 0/6] Random documentation fixes","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Marvin,\n\nThank you for the patches.\n\nOn Thu, Jun 04, 2020 at 03:42:54PM +0200, Marvin Schmidt wrote:\n> Just a couple of fixes for minor documentation problems I stumpled upon while\n> getting familiar with tne codebase.\n> \n> Marvin Schmidt (6):\n> docs: Remove stray HTML tags\n> docs: Remove trailing whitespace\n> docs: coding-style: Change full stop to colon\n> docs: Markup LD_PRELOAD as code\n> libcamera: ipa_module: Fix typo in function description\n> libcamera: camera: Order parameter documentation correctly\n\nFor the whole series,\n\nReviewed-by: Laurent Pinchart \n\n> Documentation/coding-style.rst | 2 +-\n> Documentation/docs.rst | 10 +++++-----\n> src/libcamera/camera.cpp | 2 +-\n> src/libcamera/ipa_module.cpp | 2 +-\n> 4 files changed, 8 insertions(+), 8 deletions(-)\n>","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A1880603C5\n\tfor ;\n\tFri, 5 Jun 2020 08:51:03 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 0851B253;\n\tFri, 5 Jun 2020 08:51:02 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"SzmDvpaS\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1591339863;\n\tbh=RwJIMrtAo2EL/U5xptyIYVGNlVoFLvEOjCP3Ccu4rLs=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=SzmDvpaSVWGh7TG0hYv+ExulsxxltzoHzBfBApDgZXqpA7j4u3EYyxY1YpAcaIHI3\n\t87rpHcr4wItMUJ6CL06u7b6YjM9+eGd3PH4vKLxLcoZAYyNA79iC7WRXAk4oGm2Ouy\n\ts2VIaV0wFBTdO5Z4Mdtqsxh9mk0iXuQ0XnPY2s60=","Date":"Fri, 5 Jun 2020 09:50:45 +0300","From":"Laurent Pinchart ","To":"Marvin Schmidt ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20200605065045.GA5852@pendragon.ideasonboard.com>","References":"<20200604134300.2986113-1-marvin.schmidt1987@gmail.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20200604134300.2986113-1-marvin.schmidt1987@gmail.com>","Subject":"Re: [libcamera-devel] [PATCH 0/6] Random documentation fixes","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Fri, 05 Jun 2020 06:51:04 -0000"}},{"id":5033,"web_url":"https://patchwork.libcamera.org/comment/5033/","msgid":"","date":"2020-06-05T08:21:06","subject":"Re: [libcamera-devel] [PATCH 0/6] Random documentation fixes","submitter":{"id":51,"url":"https://patchwork.libcamera.org/api/people/51/","name":"Marvin Schmidt","email":"marvin.schmidt1987@gmail.com"},"content":"Am Fr., 5. Juni 2020 um 08:51 Uhr schrieb Laurent Pinchart\n:\n>\n> Hi Marvin,\n>\n> Thank you for the patches.\n>\n> On Thu, Jun 04, 2020 at 03:42:54PM +0200, Marvin Schmidt wrote:\n> > Just a couple of fixes for minor documentation problems I stumpled upon while\n> > getting familiar with tne codebase.\n> >\n> > Marvin Schmidt (6):\n> > docs: Remove stray HTML tags\n> > docs: Remove trailing whitespace\n> > docs: coding-style: Change full stop to colon\n> > docs: Markup LD_PRELOAD as code\n> > libcamera: ipa_module: Fix typo in function description\n> > libcamera: camera: Order parameter documentation correctly\n>\n> For the whole series,\n>\n> Reviewed-by: Laurent Pinchart \n>\n\nHey Laurent,\n\nthanks for reviewing, I'll send v2 with your and Kieran's R-b tags.\n\n> > Documentation/coding-style.rst | 2 +-\n> > Documentation/docs.rst | 10 +++++-----\n> > src/libcamera/camera.cpp | 2 +-\n> > src/libcamera/ipa_module.cpp | 2 +-\n> > 4 files changed, 8 insertions(+), 8 deletions(-)\n> >\n>\n> --\n> Regards,\n>\n> Laurent Pinchart","headers":{"Return-Path":"","Received":["from mail-wr1-x444.google.com (mail-wr1-x444.google.com\n\t[IPv6:2a00:1450:4864:20::444])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B1098603C7\n\tfor ;\n\tFri, 5 Jun 2020 10:21:17 +0200 (CEST)","by mail-wr1-x444.google.com with SMTP id l11so8819633wru.0\n\tfor ;\n\tFri, 05 Jun 2020 01:21:17 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"Z2S3lgrg\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=Fdc2foUE4IDsB3nhI+QTkORn6SYKNRWSS904mK6NNIc=;\n\tb=Z2S3lgrgbKiRzmqLyAN2NPpUQlPtwGMcQSSpDLBoQc59O1IZlsbxUK6ps3O9KzcJgX\n\tfxokcLSl1b/NhgYX1FvQNSzcW5NV4VqDOPhyOsCxqZsU92nDf+Ji0MBkoAQWi5AkzuCS\n\tFLYW/skSQsDEr4x/F8taLkUpRKwsQvcNeK1WZ7dwBhHitan5PlR+xZpIp3SLlxiIqPQ7\n\tMEX9HG8icag9jqoAqMZB3pGnOEwZ3lUGkbhol3Aif4Xuvu2nGHRqE2mgTQ8CyTQWokCx\n\tIWPh2EuMkJQe+5HWLFY40uWgFlBCQgN9YZBYjZX0r7+KAohPCAquvceS5c7HwHe+rCxL\n\tI38Q==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=Fdc2foUE4IDsB3nhI+QTkORn6SYKNRWSS904mK6NNIc=;\n\tb=G1DRadpCvsnnEHYeW2T38vO1nELJZ8Ym329mcDAm12jS1TjsJdZ22vxbBWgHk2AvnX\n\tXKMNJWRBIzy6mRzs2vYmkbZQgYGrsK63619ciYdBGAt4oSuPIg+7Bxs2BV6Hy1xADyHf\n\tieo57vEBc2mamr/Uf8Ejmv4Tl32vW1PcqXAAJqOjXRop07fA1wekXSk7+t0buIkfjnmj\n\t4SniAqbayBPc1trPtKYWHort001f/26vSEW49ioWIW7m8auBY8iEeoN4kXqyDWj7udfM\n\t3Y5BfE7lAU6Sz4xdNWnCvBJhKnrD7BfqkQN4wC58GBe8MDDWisyPL7GMH+DXyM/dDrJN\n\tAtrw==","X-Gm-Message-State":"AOAM530roB0Se/t0FfueR2AKHDOb0tuouCPbOkXkew96XBKq1ADN13ax\n\te8IH6A1sui0NcKUWSa5uK0ADhpucnZty6NHJ404=","X-Google-Smtp-Source":"ABdhPJyyRqGL6xjwiYKyBp2Pc/T0eEkK1phVTKRAPS+5rLd5lW7zn7P7NFgNcpGsIuI4X/PIygWE8Y4iJdy4c6ieayY=","X-Received":"by 2002:a5d:4b47:: with SMTP id w7mr8039578wrs.234.1591345277414;\n\tFri, 05 Jun 2020 01:21:17 -0700 (PDT)","MIME-Version":"1.0","References":"<20200604134300.2986113-1-marvin.schmidt1987@gmail.com>\n\t<20200605065045.GA5852@pendragon.ideasonboard.com>","In-Reply-To":"<20200605065045.GA5852@pendragon.ideasonboard.com>","From":"Marvin Schmidt ","Date":"Fri, 5 Jun 2020 10:21:06 +0200","Message-ID":"","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"UTF-8\"","Subject":"Re: [libcamera-devel] [PATCH 0/6] Random documentation fixes","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Fri, 05 Jun 2020 08:21:17 -0000"}}]